Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/810218/?format=api
{ "id": 810218, "url": "http://patchwork.ozlabs.org/api/1.2/patches/810218/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905160027.15081-2-groug@kaod.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170905160027.15081-2-groug@kaod.org>", "list_archive_url": null, "date": "2017-09-05T16:00:24", "name": "[PULL,v2,1/4] 9pfs: avoid sign conversion error simplifying the code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cfad7fa2620d37a06bed7e0302c8a67ccfffb68d", "submitter": { "id": 69178, "url": "http://patchwork.ozlabs.org/api/1.2/people/69178/?format=api", "name": "Greg Kurz", "email": "groug@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905160027.15081-2-groug@kaod.org/mbox/", "series": [ { "id": 1604, "url": "http://patchwork.ozlabs.org/api/1.2/series/1604/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1604", "date": "2017-09-05T16:00:25", "name": "[PULL,v2,1/4] 9pfs: avoid sign conversion error simplifying the code", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1604/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810218/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xms7K73LSz9ryk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Sep 2017 02:07:41 +1000 (AEST)", "from localhost ([::1]:59987 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpGO2-0002it-7z\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 12:07:38 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:34585)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1dpGHP-0006Nx-4m\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 12:00:56 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1dpGHF-0000N4-Tr\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 12:00:47 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37417)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <groug@kaod.org>) id 1dpGHF-0000LM-0v\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 12:00:37 -0400", "from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv85Fwa2M097149\n\tfor <qemu-devel@nongnu.org>; Tue, 5 Sep 2017 12:00:35 -0400", "from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2csvwnya7y-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Tue, 05 Sep 2017 12:00:35 -0400", "from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <groug@kaod.org>;\n\tTue, 5 Sep 2017 17:00:32 +0100", "from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 17:00:30 +0100", "from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v85G0Uat11403500; Tue, 5 Sep 2017 16:00:30 GMT", "from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id AE881AE045;\n\tTue, 5 Sep 2017 16:55:46 +0100 (BST)", "from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9C403AE053;\n\tTue, 5 Sep 2017 16:55:46 +0100 (BST)", "from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 5 Sep 2017 16:55:46 +0100 (BST)", "from bahia.lab.toulouse-stg.fr.ibm.com\n\t(bahia.lab.toulouse-stg.fr.ibm.com [9.101.4.41])\n\tby smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id\n\tAAA4522023E; Tue, 5 Sep 2017 18:00:29 +0200 (CEST)" ], "From": "Greg Kurz <groug@kaod.org>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 5 Sep 2017 18:00:24 +0200", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170905160027.15081-1-groug@kaod.org>", "References": "<20170905160027.15081-1-groug@kaod.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-TM-AS-GCONF": "00", "x-cbid": "17090516-0040-0000-0000-000003F5C4BE", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17090516-0041-0000-0000-000020963C57", "Message-Id": "<20170905160027.15081-2-groug@kaod.org>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=3\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050229", "Content-Transfer-Encoding": "quoted-printable", "X-MIME-Autoconverted": "from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v85Fwa2M097149", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.156.1", "Subject": "[Qemu-devel] [PULL v2 1/4] 9pfs: avoid sign conversion error\n\tsimplifying the code", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Peter Maydell <peter.maydell@linaro.org>, Greg Kurz <groug@kaod.org>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Philippe Mathieu-Daudé <f4bug@amsat.org>\n\n(note this is how other functions also handle the errors).\n\nhw/9pfs/9p.c:948:18: warning: Loss of sign in implicit conversion\n offset = err;\n ^~~\n\nReported-by: Clang Static Analyzer\nSigned-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nSigned-off-by: Greg Kurz <groug@kaod.org>\n---\n hw/9pfs/9p.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c\nindex 333dbb6f8ee2..0a37c8bd1361 100644\n--- a/hw/9pfs/9p.c\n+++ b/hw/9pfs/9p.c\n@@ -945,7 +945,6 @@ static void coroutine_fn v9fs_version(void *opaque)\n v9fs_string_init(&version);\n err = pdu_unmarshal(pdu, offset, \"ds\", &s->msize, &version);\n if (err < 0) {\n- offset = err;\n goto out;\n }\n trace_v9fs_version(pdu->tag, pdu->id, s->msize, version.data);\n@@ -962,13 +961,12 @@ static void coroutine_fn v9fs_version(void *opaque)\n \n err = pdu_marshal(pdu, offset, \"ds\", s->msize, &version);\n if (err < 0) {\n- offset = err;\n goto out;\n }\n- offset += err;\n+ err += offset;\n trace_v9fs_version_return(pdu->tag, pdu->id, s->msize, version.data);\n out:\n- pdu_complete(pdu, offset);\n+ pdu_complete(pdu, err);\n v9fs_string_free(&version);\n }\n \n", "prefixes": [ "PULL", "v2", "1/4" ] }