Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/809972/?format=api
{ "id": 809972, "url": "http://patchwork.ozlabs.org/api/1.2/patches/809972/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20170905072004.3959082-2-arnd@arndb.de/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.2/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170905072004.3959082-2-arnd@arndb.de>", "list_archive_url": null, "date": "2017-09-05T07:19:45", "name": "[2/2] PCI: iproc: fix Stingray CRS defect handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2f1345bce221124d69adc99a08657cb522c132c8", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/1.2/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20170905072004.3959082-2-arnd@arndb.de/mbox/", "series": [ { "id": 1499, "url": "http://patchwork.ozlabs.org/api/1.2/series/1499/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=1499", "date": "2017-09-05T07:19:44", "name": "[1/2] PCI: iproc: export iproc_pcie_shutdown symbol", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1499/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809972/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809972/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmdSM716Pz9sP3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 17:21:39 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751761AbdIEHVE (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 5 Sep 2017 03:21:04 -0400", "from mout.kundenserver.de ([217.72.192.75]:49793 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752066AbdIEHU7 (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Tue, 5 Sep 2017 03:20:59 -0400", "from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0MMnK3-1dpxEU3eIx-008XyS; Tue, 05 Sep 2017 09:20:26 +0200" ], "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Arnd Bergmann <arnd@arndb.de>, Ray Jui <rjui@broadcom.com>,\n\tScott Branden <sbranden@broadcom.com>, Jon Mason <jonmason@broadcom.com>,\n\tbcm-kernel-feedback-list@broadcom.com,\n\tOza Pawandeep <oza.oza@broadcom.com>,\n\tLorenzo Pieralisi <lorenzo.pieralisi@arm.com>,\n\tlinux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH 2/2] PCI: iproc: fix Stingray CRS defect handling", "Date": "Tue, 5 Sep 2017 09:19:45 +0200", "Message-Id": "<20170905072004.3959082-2-arnd@arndb.de>", "X-Mailer": "git-send-email 2.9.0", "In-Reply-To": "<20170905072004.3959082-1-arnd@arndb.de>", "References": "<20170905072004.3959082-1-arnd@arndb.de>", "X-Provags-ID": "V03:K0:zGuc58DaM0+i44U9+dkIo41sMp9w09Ky0WMpJqy3ODz+4vJjdQf\n\t1XbTOFQfk5TMSmqGpHetO9v3qJJobyKPnHq9HbXQFNJ62AP8R8jCdaqZ5SCrv9V0MGp7FQ8\n\tPCmr6ZWtRb/HgM61EOxszlIRLdI/6u2a+b+CetD9MPfSq70EA281Acpw4qPU4h35CGmXeXn\n\tqWEbBmA/vrFuJuja4ohGw==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:6OJuOIHgeAU=:xC3VRt+GdAopps/52wjtF2\n\tc5MEUOjeWg7OOxWZF7dI4ol4TuSM/ZcraG4E0ucqOP2+0OahiqbEsgm6lYU45VPTqxfya9X3K\n\tSdYbPRZ2dxRujoFI2MSEqwuXf6azCOcWW/H0yWJJjvd+B+BJIpyKfLbKN2hMjp9JfQjxEe8HQ\n\tVRtGzF3btyJxkeIzNcDKTVPdh+Ei7mnIAMQk0O3unTKHiPadPcSIAs0HKB8Kd921Y2W2m+fh/\n\tr+YM7joz6fdcfb79n1jSKvefzbX4v1pO+bYgLlIiN6z0/7+BC3Ngei9JSX5mXiM4zwPaI83DC\n\trwXlZ8pnDD9M9HvJT2JX93XaBh5eKyGYyQ+Yhb9eUcVnj8o8USOSSKpl3KdgVJHLyU3M0XM8i\n\tbTYKmo/lY7w5kcOATScrPmKISEkIc072uIVBVVvLtgJdV3QKtliZp9KunJZ05AU8JfQwF5JX9\n\tFaMZtt9CEnL4yDF2H9IZVJNInakP74MMdqYwt7V+86+nN0YvC6bfMagoZq31ah39M2Mgscl3B\n\tVK8bscWLb9AULjkgU2ep3XRnvYnNlwEtqTwjBtrLzjH8tCBbWChNqqP9ZYgJHeboIppOw7cLv\n\tpJu/DCRM6dNgey/MDU3lslzrbjV+/qb2QG0KnMzBrLoeXfSyHStkKRDJgUJYc3+mD/ZxUowp6\n\tLoaSH6OiEL+5UuOPBBr/vXEPnZziAs2Q8dXJLScd2MaYOruZ0qxu49POZp9r5S7iPUxU8f7TH\n\tx7Fd32o42ZP8LF9jqG5tNibMfkdjF6L8sLEwzA==", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" }, "content": "The condition that was used to detect the PCI_EXP_RTCAP\nflag access is wrong, as pointed out by gcc-8:\n\ndrivers/pci/host/pcie-iproc.c: In function 'iproc_pcie_config_read':\ndrivers/pci/host/pcie-iproc.c:531:22: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]\n if ((where & ~0x3) == PCI_EXP_CAP + PCI_EXP_RTCAP)\n\nThis adds the same bit mask to the other end as well, so the\ncondition is evaluated correctly for any access.\n\nFixes: ac8d3e852f75 (\"PCI: iproc: Work around Stingray CRS defects\")\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\n---\n drivers/pci/host/pcie-iproc.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c\nindex d7f4c29aed96..f2df9c2266b9 100644\n--- a/drivers/pci/host/pcie-iproc.c\n+++ b/drivers/pci/host/pcie-iproc.c\n@@ -528,7 +528,7 @@ static int iproc_pcie_config_read(struct pci_bus *bus, unsigned int devfn,\n \t\t\treturn ret;\n \n \t\t/* Don't advertise CRS SV support */\n-\t\tif ((where & ~0x3) == PCI_EXP_CAP + PCI_EXP_RTCAP)\n+\t\tif ((where & ~0x3) == ((PCI_EXP_CAP + PCI_EXP_RTCAP) & ~0x03))\n \t\t\t*val &= ~(PCI_EXP_RTCAP_CRSVIS << 16);\n \t\treturn PCIBIOS_SUCCESSFUL;\n \t}\n", "prefixes": [ "2/2" ] }