Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/807419/?format=api
{ "id": 807419, "url": "http://patchwork.ozlabs.org/api/1.2/patches/807419/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/1504073010-14243-1-git-send-email-alan@tkos.co.il/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/1.2/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504073010-14243-1-git-send-email-alan@tkos.co.il>", "list_archive_url": null, "date": "2017-08-30T06:03:30", "name": "[RFC] qt5tools: Install QDesignerExportWidget include", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a76e550c0c20a47b38ea19666c75fe62ca4070fa", "submitter": { "id": 64816, "url": "http://patchwork.ozlabs.org/api/1.2/people/64816/?format=api", "name": "Alan Yaniger", "email": "alan@tkos.co.il" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/1504073010-14243-1-git-send-email-alan@tkos.co.il/mbox/", "series": [ { "id": 528, "url": "http://patchwork.ozlabs.org/api/1.2/series/528/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=528", "date": "2017-08-30T06:03:30", "name": "[RFC] qt5tools: Install QDesignerExportWidget include", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/528/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807419/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807419/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhw1L5XW1z9t0M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 16:03:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3E21E87835;\n\tWed, 30 Aug 2017 06:03:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id POtQ6pui7Acw; Wed, 30 Aug 2017 06:03:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 906DB87A2F;\n\tWed, 30 Aug 2017 06:03:47 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E3D351C3F86\n\tfor <buildroot@lists.busybox.net>;\n\tWed, 30 Aug 2017 06:03:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DD56D87A2F\n\tfor <buildroot@lists.busybox.net>;\n\tWed, 30 Aug 2017 06:03:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dCdZ0lyrUVgD for <buildroot@lists.busybox.net>;\n\tWed, 30 Aug 2017 06:03:43 +0000 (UTC)", "from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id ACE8187835\n\tfor <buildroot@buildroot.org>; Wed, 30 Aug 2017 06:03:43 +0000 (UTC)", "from alan-tkos-lenovo.brainsway.co.il\n\t(80.178.168.47.adsl.012.net.il [80.178.168.47])\n\tby mx.tkos.co.il (Postfix) with ESMTPA id DB06444025F;\n\tWed, 30 Aug 2017 09:03:39 +0300 (IDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Alan Yaniger <alan@tkos.co.il>", "To": "buildroot@buildroot.org", "Date": "Wed, 30 Aug 2017 09:03:30 +0300", "Message-Id": "<1504073010-14243-1-git-send-email-alan@tkos.co.il>", "X-Mailer": "git-send-email 2.7.4", "Cc": "ps.report@gmx.net", "Subject": "[Buildroot] [RFC PATCH] qt5tools: Install QDesignerExportWidget\n\tinclude", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "To build a custom widget exposed to QtDesigner, the widget should \ninclude the file QtUiPlugin/QDesignerExportWidget. Without this patch,\nthe include file is not installed in ${STAGING_DIR}/usr/include/qt5. \n\nThe file QDesignerExportWidget in the qt5tools tarball is just an \ninclude of the file qdesignerexportwidget.h, which itself includes the\nfile qdesignerexportwidget.h, identified by a relative path \n\"../../src/designer/src/uiplugin/qdesignerexportwidget.h\". That \nrelative path will not work in the staging dir, so just copy \nqdesignerexportwidget.h into staging, and give it the name \nQtUiPlugin/QDesignerExportWidget.\n\nIf anyone has a better way to install this file, using the Qt build \nsystem instead of \"cp\", I would be happy to revise the patch.\n\nSigned-off-by: Alan Yaniger <alan@tkos.co.il>\n---\n package/qt5/qt5tools/qt5tools.mk | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)", "diff": "diff --git a/package/qt5/qt5tools/qt5tools.mk b/package/qt5/qt5tools/qt5tools.mk\nindex 3638b74..96a3c65 100644\n--- a/package/qt5/qt5tools/qt5tools.mk\n+++ b/package/qt5/qt5tools/qt5tools.mk\n@@ -31,7 +31,7 @@ QT5TOOLS_BUILD_DIRS_$(BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS) += \\\n \tlinguist/lconvert linguist/lrelease linguist/lupdate\n ifeq ($(BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS),y)\n # use install target to copy cmake module files\n-define QT5TOOLS_INSTALL_STAGING_CMDS\n+define QT5TOOLS_LINGUIST_TOOLS_INSTALL_STAGING_CMDS\n \t$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/src/linguist install\n endef\n endif\n@@ -58,6 +58,19 @@ define QT5TOOLS_BUILD_CMDS\n \t\t$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/src/$(p)$(sep))\n endef\n \n+ifeq ($(BR2_PACKAGE_QT5TOOLS_QTPLUGININFO),y)\n+define QT5TOOLS_QTPLUGININFO_INSTALL_STAGING_CMDS\n+\t$(INSTALL) -D -m0644 \\\n+\t\t$(@D)/src/designer/src/uiplugin/qdesignerexportwidget.h \\\n+\t\t$(STAGING_DIR)/usr/include/qt5/QtUiPlugin/QDesignerExportWidget\n+endef\n+endif\n+\n+define QT5TOOLS_INSTALL_STAGING_CMDS\n+\t$(QT5TOOLS_LINGUIST_TOOLS_INSTALL_STAGING_CMDS)\n+\t$(QT5TOOLS_QTPLUGININFO_INSTALL_STAGING_CMDS)\n+endef\n+\n define QT5TOOLS_INSTALL_TARGET_CMDS\n \t$(foreach p,$(QT5TOOLS_INSTALL_TARGET_y), \\\n \t\t$(INSTALL) -D -m0755 $(@D)/bin/$(p) $(TARGET_DIR)/usr/bin/$(p)$(sep))\n", "prefixes": [ "RFC" ] }