Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/804291/?format=api
{ "id": 804291, "url": "http://patchwork.ozlabs.org/api/1.2/patches/804291/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20170822064927.15200-1-hegdevasant@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/1.2/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170822064927.15200-1-hegdevasant@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-22T06:49:23", "name": "[1/5] hdata: Fix vpd parse", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "66b8bb575f608a5bfa11d37e3444385429f9f856", "submitter": { "id": 22361, "url": "http://patchwork.ozlabs.org/api/1.2/people/22361/?format=api", "name": "Vasant Hegde", "email": "hegdevasant@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20170822064927.15200-1-hegdevasant@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/804291/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/804291/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xc1RB3Nz8z9t2c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 22 Aug 2017 16:50:46 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xc1RB23XBzDrJ3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 22 Aug 2017 16:50:46 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xc1R41vGXzDqjm\n\tfor <skiboot@lists.ozlabs.org>; Tue, 22 Aug 2017 16:50:39 +1000 (AEST)", "from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7M6nECP028900\n\tfor <skiboot@lists.ozlabs.org>; Tue, 22 Aug 2017 02:50:38 -0400", "from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cgeyh32md-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Tue, 22 Aug 2017 02:50:37 -0400", "from localhost\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <hegdevasant@linux.vnet.ibm.com>; \n\tTue, 22 Aug 2017 16:50:35 +1000", "from d23relay09.au.ibm.com (202.81.31.228)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 22 Aug 2017 16:50:34 +1000", "from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7M6oQ2730539796\n\tfor <skiboot@lists.ozlabs.org>; Tue, 22 Aug 2017 16:50:34 +1000", "from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7M6o17f026696\n\tfor <skiboot@lists.ozlabs.org>; Tue, 22 Aug 2017 16:50:01 +1000", "from hegdevasant.in.ibm.com (hegdevasant.in.ibm.com [9.122.211.32]\n\t(may be forged))\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7M6o05o025980; Tue, 22 Aug 2017 16:50:00 +1000" ], "From": "Vasant Hegde <hegdevasant@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Tue, 22 Aug 2017 12:19:23 +0530", "X-Mailer": "git-send-email 2.9.3", "X-TM-AS-MML": "disable", "x-cbid": "17082206-0004-0000-0000-0000022B3B24", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082206-0005-0000-0000-00005E121F33", "Message-Id": "<20170822064927.15200-1-hegdevasant@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-22_03:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708220107", "Subject": "[Skiboot] [PATCH 1/5] hdata: Fix vpd parse", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "We detect vpd data format in vpd_parse() and set \"op_platform\" variable.\ndt_add_vpd_node() depends on op_platform to select parser type.\n\nThere are places where we call dt_add_vpd_node() even before calling\nvpd_parse(). And in such cases it will not parse vpd data properly.\n\nThis patch fixes above issue.\n\nFixes: 694546c1 (hdata/vpd: Parse the OpenPOWER OPFR record)\nCC: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>\nSigned-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>\n---\n hdata/vpd.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/hdata/vpd.c b/hdata/vpd.c\nindex d7d57cd..0e23e29 100644\n--- a/hdata/vpd.c\n+++ b/hdata/vpd.c\n@@ -23,8 +23,6 @@\n #include \"hdata.h\"\n #include <inttypes.h>\n \n-static bool op_platform;\n-\n struct card_info {\n \tconst char *ccin; \t/* Customer card identification number */\n \tconst char *description;\n@@ -492,7 +490,7 @@ struct dt_node *dt_add_vpd_node(const struct HDIF_common_hdr *hdr,\n \t && !dt_find_property(node, \"ibm,vpd\")) {\n \t\tdt_add_property(node, \"ibm,vpd\", fruvpd, fruvpd_sz);\n \n-\t\tif (op_platform)\n+\t\tif (vpd_find_record(fruvpd, fruvpd_sz, \"OPFR\", NULL))\n \t\t\tvpd_opfr_parse(node, fruvpd, fruvpd_sz);\n \t\telse\n \t\t\tvpd_vini_parse(node, fruvpd, fruvpd_sz);\n@@ -607,10 +605,9 @@ static void sysvpd_parse(void)\n \t}\n \n \t/* Look for the new OpenPower \"OSYS\" first */\n-\tif (vpd_find_record(sysvpd, sysvpd_sz, \"OSYS\", NULL)) {\n-\t\top_platform = true;\n+\tif (vpd_find_record(sysvpd, sysvpd_sz, \"OSYS\", NULL))\n \t\tsysvpd_parse_opp(sysvpd, sysvpd_sz);\n-\t} else\n+\telse\n \t\tsysvpd_parse_legacy(sysvpd, sysvpd_sz);\n \n \tdt_add_model_name();\n", "prefixes": [ "1/5" ] }