Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/798894/?format=api
{ "id": 798894, "url": "http://patchwork.ozlabs.org/api/1.2/patches/798894/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/patch/1502140260-13789-2-git-send-email-stephend@adiengineering.com/", "project": { "id": 35, "url": "http://patchwork.ozlabs.org/api/1.2/projects/35/?format=api", "name": "Linux I2C development", "link_name": "linux-i2c", "list_id": "linux-i2c.vger.kernel.org", "list_email": "linux-i2c@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1502140260-13789-2-git-send-email-stephend@adiengineering.com>", "list_archive_url": null, "date": "2017-08-07T21:10:59", "name": "[1/2] i2c: ismt: Don't duplicate the receive length for block reads", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "34d0820a7f9ae801e3e766b221000a0e4b9bf599", "submitter": { "id": 72123, "url": "http://patchwork.ozlabs.org/api/1.2/people/72123/?format=api", "name": "Stephen Douthit", "email": "stephend@adiengineering.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-i2c/patch/1502140260-13789-2-git-send-email-stephend@adiengineering.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/798894/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/798894/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-i2c-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=SILICOMLTD.onmicrosoft.com\n\theader.i=@SILICOMLTD.onmicrosoft.com header.b=\"hIA1sOQh\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=stephend@adiengineering.com; " ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xR9FV6qxnz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 8 Aug 2017 07:11:42 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751799AbdHGVLj (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tMon, 7 Aug 2017 17:11:39 -0400", "from mail-he1eur01on0102.outbound.protection.outlook.com\n\t([104.47.0.102]:13680\n\t\"EHLO EUR01-HE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751826AbdHGVLg (ORCPT <rfc822;linux-i2c@vger.kernel.org>);\n\tMon, 7 Aug 2017 17:11:36 -0400", "from localhost.localdomain (96.82.2.57) by\n\tVI1PR04MB1360.eurprd04.prod.outlook.com (2a01:111:e400:5348::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22;\n\tMon, 7 Aug 2017 21:11:29 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=SILICOMLTD.onmicrosoft.com; s=selector1-adiengineering-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=JGZK2z/TclPvMJAzvS/VB9gLLEBPa+y0gIKdqJn8bq4=;\n\tb=hIA1sOQhuI7qDhX46q5crZYxwTReSmzqyXkvGyer1ihRsrlggtIFd+73LY4F4ZsWCqu1HW/AiU4zj3aUHERE3MXCKJFhAZDylAEW3nYEKF7Z6nUtX392Xaz//t4bdENVbgN5l6vYqEIxiqu5jmOjRCltEZtJH6RCvkT6+uTxt4Y=", "From": "Stephen Douthit <stephend@adiengineering.com>", "To": "seth.heasley@intel.com, nhorman@tuxdriver.com", "Cc": "wsa@the-dreams.de, danp@adiengineering.com,\n\tstephend@adiengineering.com, linux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH 1/2] i2c: ismt: Don't duplicate the receive length for block\n\treads", "Date": "Mon, 7 Aug 2017 17:10:59 -0400", "Message-Id": "<1502140260-13789-2-git-send-email-stephend@adiengineering.com>", "X-Mailer": "git-send-email 2.7.5", "In-Reply-To": "<1502140260-13789-1-git-send-email-stephend@adiengineering.com>", "References": "<1502140260-13789-1-git-send-email-stephend@adiengineering.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[96.82.2.57]", "X-ClientProxiedBy": "DM5PR06CA0048.namprd06.prod.outlook.com\n\t(2603:10b6:3:5d::34) To VI1PR04MB1360.eurprd04.prod.outlook.com\n\t(2a01:111:e400:5348::15)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "48440d83-6d97-4b34-f38d-08d4ddd8e097", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB1360; ", "X-Microsoft-Exchange-Diagnostics": [ "1; VI1PR04MB1360;\n\t3:9yTjxVbN3ARhs8VIzP1OVDXBgltu0pLfX/upQFWwOD9kx2yqtyen4Gz9Sc9zmgEtr6G003kIFl08iaQ48G3QH/NeEYoYPgUvh/4LM40Bn8Bt5H9JN3Gb7Ex6QijeORCJcSrSI+hmxJ+BkYfMJZEq0sa7UcrLdnOI7i4qSilP9AeCiXpKAZWQXIiZKQBYRd+94vB/IM0MQxBTIqSSEHuvzwhfVHOaKZVJvhKIfIwoFXRzAJ5/pFJikO3TNP6Pb+Sb;\n\t25:d+wavcGgh+Bwbv5Z7uFKrKomTqAWC0+PBWOapkV0brRTkFxkQmPFj5zaBBPC5vjnaaOasV5nb7k8jPUERurclyuAqP+toFEFkvHMBx+/HTTZ9quimWMvRf/Jrd60oHvfVTkBqKti10DRHzFCByzImD1XB/BkJmMcqiIv98KVjEEcqfdZ3MzDC8XZuc6O1/oq8W/EZW1aIG0JF6L/JJayPiQ+9WTcMdvbfJVnU5C9koPeNPcW1oKS9ky80qpTjESRBGennwI54MtD1Ov+uF+/pp1tYF+uSkBu306oMV7I760P2+8dFBzWOtGEfEH1jBF99L2X1wVW+Z8/1nChWn3gnw==;\n\t31:PY3VhlGSc6TAl+SP6K7xW3Pk+WbkrK2TNkqHTGYDdeAMq63KGqSdYm98TB1iQFxCOuFvrU+hdG/pJh4i0ItMeJlriI9jPoHPEV779RaqTFHXoQQpCbpsDr8vVYNG7eZ6Lv4zvmBQPyOVM6hBQk4GkvfhE1a9TFe7em85U0nc2p8h0qS+LJEKqkahB+cZcDmexG9yBGFY1pKtq8Ft+EF2z9/bd3l98fvaGiYarm7MDB8=", "1; VI1PR04MB1360;\n\t20:+P3H4g3MaN4Nb9cHw4kZx3BAe4JaVysc2sPSoAxPVw5csx85H0ohTQyEqBY3sXjNh7yCGSko215wDRZTKJWporbGGBOPhNFovKqrBaLXfRyVGHV5Ih14I5G1ppMp0H6twxNKYjiwOC79e9Pb4KUkg2P53DzknisRCiETV0TPtJHJr+/e3ez72pEHhLcedcT2VziQnEGv0BjDjT8GIo9EaLl61bt8ZTlnraJaR4FcpFRghvlBJfIemjoEQ0edhEgJFgzNCPRU0F6egImhL0UNYkhs128/HleOd0gjmK6QsUt+784pAyUQaDF/ecDSmF1EazYDi3L5Mr4PrueA3ehMhkUwyWcpIcx0hGHtqjiH0AzSdiY3JBARsBuwH6fssP+cZOtkpB1pjLcYhMw+NNbnZ6E4Hr5JN5Iz3rqu1XKCAqE=;\n\t4:1EwhcQIGstM5Sl+r/r2jMbwCBOHohxxelrhXHujZ2HF+wXMl/0TL1BrxJVBt5tz5UaXp0w0QNAdffkiwbb3gHt331v0MeeC70P+kGC7PHCb8fTlqc7dnjTqoNngoEqp6d+iSXD8ZiTU6gDXehdlWhCB57cNHJ6DrKi2/aPvsZhAmTNmU0KZtPNdQQrvfaNXcPbBLWYYu5hzofJoWBaSrdOdKYD0kUGp4DmTuMxptMaiXzX36k7QrCtmdcuknwAH+Hu6DHkfQWl5ppWDJBItcKCd0qBJczlpS0r0R24stHCA=", "=?us-ascii?Q?1; VI1PR04MB1360;\n\t23:ufo0b70E7FKm2AoJ9SnPX4xl1RGrhMXmLErrhxaba?=\n\t=?us-ascii?Q?J19vPPc9GxlcmHLAXfgnXBo9+YmbK6c73uZnEfE2ZJk51d7UDVyOIzURPeI4?=\n\t=?us-ascii?Q?jCwASvIOfnfxKksYHSK5216BTheyfDv09EdAQY56kCHkso5NaXuQgGBFbFN9?=\n\t=?us-ascii?Q?zr61HHIcNIsfpgrPiTJjM0KLZxZQjjpsPmvB6OTfIUgvEklILvmzy7FNIGo0?=\n\t=?us-ascii?Q?8Ynkq9NsFaFeV6mbsc10wW53ILp2tZUiJ9r1paGQ0BrCnWtFF7gyBg1DZa8h?=\n\t=?us-ascii?Q?GNCECo57kUoId+QLcq62JESiiszRAfMyi1Tt38EKP7yYfOhs1ev3K6jSPkqd?=\n\t=?us-ascii?Q?tSkirfasD9y5QQszTNOZcA/p8V3MJMXh9KoxPeyo5tGz0NUuWL8KTuWD9Yco?=\n\t=?us-ascii?Q?kEiGW6mlRlobQmeYEkdko7E1w3aZ/vCQRkQ43pnQe1Qb/0e4zYPmVQRTq96V?=\n\t=?us-ascii?Q?cbfEM+n7+E9unImVvIx3HzuYdl66/4vOAYVvWpvn+lQkL6JfDFGrRqr5Tlhd?=\n\t=?us-ascii?Q?lRfkqY7letGVh95IzbaqGCS1AF/myi50zxOv/ajaElQDJ1kuJRHEW2p4k8sP?=\n\t=?us-ascii?Q?weJklJ+4tn6RJVmxjGs85qB3WRxbOKTfXhNBUmE/bACEYoCFn8cCdjEn2nvF?=\n\t=?us-ascii?Q?3k0+mBBTFaQok7KMIK1eFNmk0h6RZGrhIkt/IahNn+agfPKggQ0ufwTpRq2r?=\n\t=?us-ascii?Q?k6bSGkVvgiIJz6Aah+9RVz30kWuN8gOaj+/z3DE6sw/HLEby6Qbx7LKZrk9e?=\n\t=?us-ascii?Q?2xaz0v8XbnjgZzEX1oeKBZMG0SAFpLSPVsnxwN7L6X8S0ECIau5YiVeGB4v5?=\n\t=?us-ascii?Q?a0TjKn8CdCTZGF6Ao6fIH9FDhSwPKBH14uIbHiUoxC1O3H+jTsIblyOYYC/z?=\n\t=?us-ascii?Q?ERgE20rpZN7QIQL+jLCuvjJCTy4nURP699GU022w02z+UI+Fsq8Gba+yc+cK?=\n\t=?us-ascii?Q?2eYjBPHu7DZCxUUz32umD1EUZIXCCY9neCtlBp/dM0RGrLIp9QRlLiRaLS7/?=\n\t=?us-ascii?Q?aVFItqtYw48G/fADdOWEQYIcrzm1MbKcQlGha05Sp6+FlT1gchu6F0jH6fNk?=\n\t=?us-ascii?Q?Ss5W3ZIIiys4dt0qdEtTO226LXEvR9h6zfUxl0kKAR/U05c/JobgpILvBCrR?=\n\t=?us-ascii?Q?CFVereCBOQN8Y4BOahgFP50hcNTBpV+WJ5q0b4ByePBDg8CwS91oWGEHm3VK?=\n\t=?us-ascii?Q?9JWQM/zZ3O1vMOABYaKEouKvZTwOwoPF1AI?=", "1; VI1PR04MB1360;\n\t6:plgHLKNherk6avaCPw7crjzj4DIni83OiqBjclPXAg4AhgFIJfLOccvtfaZIIs1t0zlzm2j9GGHcLjKvSrY5IY/5BYgj3ERplJCzB4YdVfCyGWuruNjL1lntgQ6DId02bWKqNLVI6Kyxu2yK4oE01wlNETr1NSzZgC4Wn5h/JBbiyJrjKwAWq3QHM3GxWqZBPjqZRyfmyUnoB+FzmjC2bv4EuDrFe9UcRzk2DUjZD9Yuk63qwh4r5fly/jRAzOa83UemTSyJnLocxetZl1jDYs8IA2xe+bzx/+ZPMzExcbG8rXWsL/376fIfKIjWdZ6/7GdYig39A61IbL6DVxh8rQ==;\n\t5:6xhohf8ps2EyXn7SMjpgl2cc6083xgvwj1v2qx2smBdRS4d4AszbHzmbBq1U6wa//q0AaJHA3TZ2hfLQXNrKwJnZ70weVthnc75bFPZ8X9eWZv3C60wvQ8hAzresEj6dWWqLumfFVe14l92ZO90B/w==;\n\t24:UxrIpMnuY+R/kkrsVCLJLwspBQQqipLAF/BA4k9Gccnv84eIg6TrvyGwzapsCeu6avL0/ANyiLuA0SnSzEuOVtdkzyH8Qgo8vWK0dj7/5So=;\n\t7:83u3LunYWlieuRY/9yycostRZObJz66CaqMZuJ2N7RVPFwuuvuwL9Cb9FAJHipca191tXU0UstyApt8YWngt7hsk6KYWafKWWoBZQv8gsPXjAZRZc27+vYjL9dpXkQOMfDoTzQlFwiUkLIy+17dcj5MC+9vmfqEcMJVILs2/7nvnXrSeto6GXe1tAAuAL3gx7L58kKJ/Ch6f9beQYavIOkEERUGOkgHidQQQYQY+WeI=" ], "X-MS-TrafficTypeDiagnostic": "VI1PR04MB1360:", "X-Exchange-Antispam-Report-Test": "UriScan:(20558992708506);", "X-Microsoft-Antispam-PRVS": "<VI1PR04MB13605498D11CB17BE0EFCCC0B5B50@VI1PR04MB1360.eurprd04.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB1360; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB1360; ", "X-Forefront-PRVS": "0392679D18", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10019020)(7370300001)(4630300001)(6069001)(6009001)(39400400002)(39410400002)(39450400003)(39830400002)(199003)(189002)(6116002)(25786009)(6512007)(53936002)(68736007)(110136004)(38730400002)(478600001)(4326008)(305945005)(5660300001)(6506006)(6486002)(7736002)(50226002)(48376002)(8676002)(2950100002)(81166006)(5003940100001)(81156014)(50466002)(7350300001)(86362001)(189998001)(105586002)(2906002)(106356001)(66066001)(76176999)(6666003)(50986999)(47776003)(97736004)(3846002)(101416001)(42186005)(33646002)(36756003);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR04MB1360;\n\tH:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords;\n\tA:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: adiengineering.com does not\n\tdesignate permitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "adiengineering.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Aug 2017 21:11:29.8529\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB1360", "Sender": "linux-i2c-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-i2c.vger.kernel.org>", "X-Mailing-List": "linux-i2c@vger.kernel.org" }, "content": "According to Table 15-14 of the C2000 EDS (Intel doc #510524) the\nrx data pointed to by the descriptor dptr contains the byte count.\n\ndesc->rxbytes reports all bytes read on the wire, including the\n\"byte count\" byte. So if a device sends 4 bytes in response to a\nblock read, on the wire and in the DMA buffer we see:\n\ncount data1 data2 data3 data4\n 0x04 0xde 0xad 0xbe 0xef\n\nThat's what we want to return in data->block to the next level.\n\nInstead we were actually prefixing that with desc->rxbytes:\n\nbad\ncount count data1 data2 data3 data4\n 0x05 0x04 0xde 0xad 0xbe 0xef\n\nThis was discovered while developing a BMC solution relying on the\nipmi_ssif.c driver which was trying to interpret the bogus length\nfield as part of the IPMI response.\n\nSigned-off-by: Stephen Douthit <stephend@adiengineering.com>\nTested-by: Dan Priamo <danp@adiengineering.com>\n---\n drivers/i2c/busses/i2c-ismt.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c\nindex e98e44e..9af2337 100644\n--- a/drivers/i2c/busses/i2c-ismt.c\n+++ b/drivers/i2c/busses/i2c-ismt.c\n@@ -341,8 +341,8 @@ static int ismt_process_desc(const struct ismt_desc *desc,\n \t\t\tbreak;\n \t\tcase I2C_SMBUS_BLOCK_DATA:\n \t\tcase I2C_SMBUS_I2C_BLOCK_DATA:\n-\t\t\tmemcpy(&data->block[1], dma_buffer, desc->rxbytes);\n-\t\t\tdata->block[0] = desc->rxbytes;\n+\t\t\tmemcpy(data->block, dma_buffer, desc->rxbytes);\n+\t\t\tdata->block[0] = desc->rxbytes - 1;\n \t\t\tbreak;\n \t\t}\n \t\treturn 0;\n", "prefixes": [ "1/2" ] }