Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/784516/?format=api
{ "id": 784516, "url": "http://patchwork.ozlabs.org/api/1.2/patches/784516/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1499251121-19678-6-git-send-email-akshay.adiga@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/1.2/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1499251121-19678-6-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-07-05T10:38:40", "name": "[PATCHv2,5/6] SLW: Allow deep states if homer address is known", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "911b08c9717f530d7d0d9021e332f17568dfd398", "submitter": { "id": 68766, "url": "http://patchwork.ozlabs.org/api/1.2/people/68766/?format=api", "name": "Akshay Adiga", "email": "akshay.adiga@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1499251121-19678-6-git-send-email-akshay.adiga@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/784516/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/784516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x2cnJ4R4Fz9s2s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 5 Jul 2017 20:39:32 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3x2cnJ3b5rzDr4w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 5 Jul 2017 20:39:32 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3x2cms0jykzDqhn\n\tfor <skiboot@lists.ozlabs.org>; Wed, 5 Jul 2017 20:39:08 +1000 (AEST)", "from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv65AcxoM049390\n\tfor <skiboot@lists.ozlabs.org>; Wed, 5 Jul 2017 06:39:06 -0400", "from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2bgvxbm07h-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Wed, 05 Jul 2017 06:39:06 -0400", "from localhost\n\tby e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <akshay.adiga@linux.vnet.ibm.com>;\n\tWed, 5 Jul 2017 20:39:03 +1000", "from d23relay07.au.ibm.com (202.81.31.226)\n\tby e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 5 Jul 2017 20:39:01 +1000", "from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])\n\tby d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv65Ad10h6357344\n\tfor <skiboot@lists.ozlabs.org>; Wed, 5 Jul 2017 20:39:01 +1000", "from d23av04.au.ibm.com (localhost [127.0.0.1])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv65AcxUI024207\n\tfor <skiboot@lists.ozlabs.org>; Wed, 5 Jul 2017 20:38:59 +1000", "from aksadiga.in.ibm.com (aksadiga.in.ibm.com [9.124.35.223])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv65Aclu6023862; Wed, 5 Jul 2017 20:38:57 +1000" ], "From": "Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Wed, 5 Jul 2017 16:08:40 +0530", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1499251121-19678-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "References": "<1499251121-19678-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "x-cbid": "17070510-0048-0000-0000-000002507CEC", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17070510-0049-0000-0000-00004801AE38", "Message-Id": "<1499251121-19678-6-git-send-email-akshay.adiga@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-07-05_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000\n\tdefinitions=main-1707050178", "Subject": "[Skiboot] [PATCHv2 5/6] SLW: Allow deep states if homer address is\n\tknown", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Use a common variable has_wakeup_engine instead of has_slw to tell if\nthe\na) SLW image is populated in case of power8\nb) CME image is populated in case of power9\n\nCurrently we expect CME to be loaded if homer address is known ( except\nfor simulators)\n\nSigned-off-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>\n---\n hw/slw.c | 23 +++++++++++++++++------\n 1 file changed, 17 insertions(+), 6 deletions(-)", "diff": "diff --git a/hw/slw.c b/hw/slw.c\nindex c943d80..288295a 100644\n--- a/hw/slw.c\n+++ b/hw/slw.c\n@@ -707,7 +707,7 @@ void add_cpu_idle_state_properties(void)\n \tint nr_states;\n \n \tbool can_sleep = true;\n-\tbool has_slw = true;\n+\tbool has_wakeup_engine = true;\n \tbool has_stop_inst = false;\n \tu8 i;\n \n@@ -797,9 +797,20 @@ void add_cpu_idle_state_properties(void)\n \t\tnr_states = ARRAY_SIZE(power7_cpu_idle_states);\n \t}\n \n-\t/* Enable deep idle states only if slw image is intact */\n-\thas_slw = (chip->slw_base && chip->slw_bar_size &&\n-\t\t\tchip->slw_image_size);\n+\t/*\n+\t * Enable deep idle states only if :\n+\t * P8 : slw image is intact\n+\t * P9 : homer_base is set\n+\t */\n+\tif (!(proc_chip_quirks & QUIRK_MAMBO_CALLOUTS)) {\n+\t\tif (proc_gen == proc_gen_p9)\n+\t\t\thas_wakeup_engine = !!(chip->homer_base);\n+\t\telse /* (proc_gen == proc_gen_p8) */\n+\t\t\thas_wakeup_engine = (chip->slw_base && chip->slw_bar_size &&\n+\t\t\t\t\tchip->slw_image_size);\n+\t} else {\n+\t\thas_wakeup_engine = false;\n+\t}\n \n \t/*\n \t * Currently we can't append strings and cells to dt properties.\n@@ -827,7 +838,7 @@ void add_cpu_idle_state_properties(void)\n \tif (has_stop_inst) {\n \t\t/* Power 9 / POWER ISA 3.0 */\n \t\tsupported_states_mask = OPAL_PM_STOP_INST_FAST;\n-\t\tif (has_slw)\n+\t\tif (has_wakeup_engine)\n \t\t\tsupported_states_mask |= OPAL_PM_STOP_INST_DEEP;\n \t} else {\n \t\t/* Power 7 and Power 8 */\n@@ -835,7 +846,7 @@ void add_cpu_idle_state_properties(void)\n \t\tif (can_sleep)\n \t\t\tsupported_states_mask |= OPAL_PM_SLEEP_ENABLED |\n \t\t\t\t\t\tOPAL_PM_SLEEP_ENABLED_ER1;\n-\t\tif (has_slw)\n+\t\tif (has_wakeup_engine)\n \t\t\tsupported_states_mask |= OPAL_PM_WINKLE_ENABLED;\n \t}\n \tfor (i = 0; i < nr_states; i++) {\n", "prefixes": [ "PATCHv2", "5/6" ] }