Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/717625/?format=api
{ "id": 717625, "url": "http://patchwork.ozlabs.org/api/1.2/patches/717625/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/patch/20170120123644.118612-2-sean.nyekjaer@prevas.dk/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/1.2/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170120123644.118612-2-sean.nyekjaer@prevas.dk>", "list_archive_url": null, "date": "2017-01-20T12:36:44", "name": "[2/2] rtc: pcf2127: add support for pcf2127 tamper functionality", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "df0d39cbfa4d2731a134fc3441786b2a6f2cb4fc", "submitter": { "id": 64902, "url": "http://patchwork.ozlabs.org/api/1.2/people/64902/?format=api", "name": "Sean Nyekjær", "email": "sean.nyekjaer@prevas.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/patch/20170120123644.118612-2-sean.nyekjaer@prevas.dk/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/717625/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/717625/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<rtc-linux+bncBAABBIUJRDCAKGQE65IFQSI@googlegroups.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from mail-wm0-x23c.google.com (mail-wm0-x23c.google.com\n\t[IPv6:2a00:1450:400c:c09::23c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3v4gGn0xbHz9sDF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Jan 2017 23:38:08 +1100 (AEDT)", "by mail-wm0-x23c.google.com with SMTP id f73sf10450699wmf.1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Jan 2017 04:38:08 -0800 (PST)", "by 10.46.75.18 with SMTP id y18ls510046lja.12.gmail; Fri, 20 Jan\n\t2017 04:37:53 -0800 (PST)", "from mail02.prevas.se (mail02.prevas.se. [62.95.78.10])\n\tby gmr-mx.google.com with ESMTPS id\n\th62si105086wme.2.2017.01.20.04.37.53\n\tfor <rtc-linux@googlegroups.com>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 20 Jan 2017 04:37:53 -0800 (PST)", "from unknown (HELO skn.kamstrup.dk) ([95.138.208.137])\n\tby mail02.prevas.se with ESMTP/TLS/AES128-SHA256;\n\t20 Jan 2017 13:37:52 +0100" ], "Authentication-Results": "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"R4pfgGMP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=DfvpWSfpPzTFvMSKP+wQw0YlvQ2RbTCe+Oq5H5zD9k4=;\n\tb=R4pfgGMPHRfCwU+jjfAjo5Zg8qrexrF9L0A5NpSbTPn1YWCmZn8EcxnyHN0bvsuGsk\n\tyg8YZhcEss4fr1SRtSJ0hFHTNTqfUXtW2zMLDGVdVmWjC/7CynxLUA12ldfpAI9OGO+D\n\tk7ZKZyfO0JWoHLj3T9gxTxcG9j1nTK3iaJmg80FYq4S/Xq2ilRyWGooJi/YtUnNZHfrI\n\tCusEi3x8uhpw8vpI0Hclu0q5HFfYAXCO4MJz6jxjmnKHVvBE+P3k2CfO/4+669xCackM\n\tUfjKNEsgD4Xjr4xKyRNOo/3fjAWANI6MhbpdPT97RtCTeOhpVj/1vbLEnZnjCdtxEdVU\n\tXPyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:in-reply-to:references:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=DfvpWSfpPzTFvMSKP+wQw0YlvQ2RbTCe+Oq5H5zD9k4=;\n\tb=WEqjgkPLZXZRz3Y73kPtSvlJR2vpaIwS3LcBSReU+xp06rLOsdWEMgVHMJHvnjeuZ6\n\t9x286yX3HqnXROX3+0X3YX02AqcPe3iIX0zwXOgHx6T1HmwWJHcETAq73ul6u+EsFiwM\n\tgNI0C5NKbnChsKrMWbm2N2JFgxoLUdB5+ExUBIk7VP5x1j7JVSaeaHBSfsjpThyEH2x8\n\t6V8E136NhQVig2kesYaNu/6N4tT5l6EOGOMUMdn4/kx2EXWFC8WeTB2x6Pfsg9pe8xax\n\t617qBDu7jlM5Iu7QUMlMDlmkCXt51VWgqcI5bY/GwPlip9rzml1TqOWQptjEoMxCop1j\n\tNVMQ==", "Sender": "rtc-linux@googlegroups.com", "X-Gm-Message-State": "AIkVDXLh3bjEtG8O7MvGWKGSP+ZH21B7mS9tEgLWIYYORl+QQWRIgvgevC7wTLeGxnM/hg==", "X-Received": [ "by 10.46.74.2 with SMTP id x2mr16244lja.15.1484915874229;\n\tFri, 20 Jan 2017 04:37:54 -0800 (PST)", "by 10.25.40.17 with SMTP id o17mr1090749lfo.25.1484915873782;\n\tFri, 20 Jan 2017 04:37:53 -0800 (PST)" ], "MIME-Version": "1.0", "X-BeenThere": "rtc-linux@googlegroups.com", "Received-SPF": "pass (google.com: domain of\n\tprvs=186a45687=sean.nyekjaer@prevas.dk designates 62.95.78.10\n\tas permitted sender) client-ip=62.95.78.10; ", "X-IronPort-Anti-Spam-Filtered": "true", "X-IronPort-Anti-Spam-Result": "=?us-ascii?q?A2HcAwCQA4JY/4nQil9eHQEFAQsBgz0BA?=\n\t=?us-ascii?q?QEBAR+BaYMFhVaFAKUigg+CDBqGCAIMggE/FAECAQEBAQEBAQNgKIRqBidSEBg?=\n\t=?us-ascii?q?nElcZiQixDTomAooeAQEBByiGS4wFDIMMBY8rjB2BfI9eDYpHhieSdB85gSiFJ?=\n\t=?us-ascii?q?RyBYT01iRQBAQE?=", "X-IPAS-Result": "=?us-ascii?q?A2HcAwCQA4JY/4nQil9eHQEFAQsBgz0BAQEBAR+BaYMFhVa?=\n\t=?us-ascii?q?FAKUigg+CDBqGCAIMggE/FAECAQEBAQEBAQNgKIRqBidSEBgnElcZiQixDTomA?=\n\t=?us-ascii?q?ooeAQEBByiGS4wFDIMMBY8rjB2BfI9eDYpHhieSdB85gSiFJRyBYT01iRQBAQE?=", "X-IronPort-AV": "E=Sophos;i=\"5.33,258,1477954800\"; d=\"scan'208\";a=\"1666495\"", "From": "Sean Nyekjaer <sean.nyekjaer@prevas.dk>", "To": "rtc-linux@googlegroups.com", "Cc": "Sean Nyekjaer <sean.nyekjaer@prevas.dk>", "Subject": "[rtc-linux] [PATCH 2/2] rtc: pcf2127: add support for pcf2127\n\ttamper functionality", "Date": "Fri, 20 Jan 2017 13:36:44 +0100", "Message-Id": "<20170120123644.118612-2-sean.nyekjaer@prevas.dk>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170120123644.118612-1-sean.nyekjaer@prevas.dk>", "References": "<20170120123644.118612-1-sean.nyekjaer@prevas.dk>", "X-Original-Sender": "sean.nyekjaer@prevas.dk", "X-Original-Authentication-Results": "gmr-mx.google.com; dkim=pass\n\theader.i=@prevas.dk; spf=pass (google.com: domain of\n\tprvs=186a45687=sean.nyekjaer@prevas.dk designates 62.95.78.10 as\n\tpermitted\n\tsender) smtp.mailfrom=prvs=186a45687=sean.nyekjaer@prevas.dk", "Reply-To": "rtc-linux@googlegroups.com", "Content-Type": "text/plain; charset=UTF-8", "Precedence": "list", "Mailing-list": "list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com", "List-ID": "<rtc-linux.googlegroups.com>", "X-Spam-Checked-In-Group": "rtc-linux@googlegroups.com", "X-Google-Group-Id": "712029733259", "List-Post": "<https://groups.google.com/group/rtc-linux/post>,\n\t<mailto:rtc-linux@googlegroups.com>", "List-Help": "<https://groups.google.com/support/>,\n\t<mailto:rtc-linux+help@googlegroups.com>", "List-Archive": "<https://groups.google.com/group/rtc-linux", "List-Subscribe": "<https://groups.google.com/group/rtc-linux/subscribe>,\n\t<mailto:rtc-linux+subscribe@googlegroups.com>", "List-Unsubscribe": "<mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>,\n\t<https://groups.google.com/group/rtc-linux/subscribe>" }, "content": "Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>\n---\n drivers/rtc/Kconfig | 7 +++\n drivers/rtc/rtc-pcf2127.c | 128 +++++++++++++++++++++++++++++++++++++++++++---\n 2 files changed, 129 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig\nindex c8985be81d83..e8d7944a4018 100644\n--- a/drivers/rtc/Kconfig\n+++ b/drivers/rtc/Kconfig\n@@ -806,6 +806,13 @@ config RTC_DRV_PCF2127_WDT\n \t If you say Y here you will get support for the\n \t watchdog timer in the NXP PCF2127 chip real-time clock chips.\n \n+config RTC_DRV_PCF2127_TAMPER\n+\tbool \"NXP PCF2127 tamper\"\n+\tdepends on RTC_DRV_PCF2127\n+\thelp\n+\t If you say Y here you will get support for the\n+\t tamper device in the NXP PCF2127 chip real-time clock chips.\n+\n config RTC_DRV_RV3029C2\n \ttristate \"Micro Crystal RV3029/3049\"\n \tdepends on RTC_I2C_AND_SPI\ndiff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c\nindex 31627c59c44d..5f96cff9ebd5 100644\n--- a/drivers/rtc/rtc-pcf2127.c\n+++ b/drivers/rtc/rtc-pcf2127.c\n@@ -30,7 +30,10 @@\n #endif\n \n #define PCF2127_REG_CTRL1 (0x00) /* Control Register 1 */\n+#define PCF2127_TSF1\t\tBIT(4)\n #define PCF2127_REG_CTRL2 (0x01) /* Control Register 2 */\n+#define PCF2127_TSIE\t\tBIT(2)\n+#define PCF2127_TSF2\t\tBIT(5)\n \n #define PCF2127_REG_CTRL3 (0x02) /* Control Register 3 */\n #define PCF2127_REG_CTRL3_BLF\t\tBIT(2)\n@@ -42,6 +45,17 @@\n #define PCF2127_REG_WDG_T_TF_1HZ\tBIT(1)\t/* Timer clock source */\n #define PCF2127_REG_WDG_TIMVAL\t\t(0x11)\n \n+#define PCF2127_REG_TIMSTP_CTL\t\t(0x12)\n+#define PCF2127_TSM\t\t\tBIT(7)\n+#define PCF2127_TSOFF\t\t\tBIT(6)\n+\n+#define PCF2127_REG_TIMSTP_SC\t\t(0x01)\n+#define PCF2127_REG_TIMSTP_MN\t\t(0x02)\n+#define PCF2127_REG_TIMSTP_HR\t\t(0x03)\n+#define PCF2127_REG_TIMSTP_DM\t\t(0x04)\n+#define PCF2127_REG_TIMSTP_MO\t\t(0x05)\n+#define PCF2127_REG_TIMSTP_YR\t\t(0x06)\n+\n #define PCF2127_REG_SC (0x03) /* datetime */\n #define PCF2127_REG_MN (0x04)\n #define PCF2127_REG_HR (0x05)\n@@ -55,10 +69,84 @@\n struct pcf2127 {\n \tstruct rtc_device *rtc;\n \tstruct regmap *regmap;\n+\tstruct rtc_time tamper_event;\n+\tbool tamper_enabled;\n+\tint irq;\n };\n \n-#ifdef CONFIG_RTC_DRV_PCF2127_WDT\n+#if defined(CONFIG_RTC_DRV_PCF2127_TAMPER) || defined(CONFIG_RTC_DRV_PCF2127_WDT)\n static struct pcf2127 *save_pcf2127;\n+#endif\n+\n+#ifdef CONFIG_RTC_DRV_PCF2127_TAMPER\n+static int pcf2127_tamper_event_print(struct device *dev)\n+{\n+\tint err;\n+\tunsigned char buf[7];\n+\tstruct rtc_time *tm;\n+\n+\terr = regmap_bulk_read(save_pcf2127->regmap, PCF2127_REG_TIMSTP_CTL,\n+\t\t\t buf, sizeof(buf));\n+\tif (err)\n+\t\treturn err;\n+\n+\ttm = &save_pcf2127->tamper_event;\n+\n+\ttm->tm_sec = bcd2bin(buf[PCF2127_REG_TIMSTP_SC] & 0x7F);\n+\ttm->tm_min = bcd2bin(buf[PCF2127_REG_TIMSTP_MN] & 0x7F);\n+\ttm->tm_hour = bcd2bin(buf[PCF2127_REG_TIMSTP_HR] & 0x3F);\n+\ttm->tm_mday = bcd2bin(buf[PCF2127_REG_TIMSTP_DM] & 0x3F);\n+\ttm->tm_mon = bcd2bin(buf[PCF2127_REG_TIMSTP_MO] & 0x1F) - 1;\n+\ttm->tm_year = bcd2bin(buf[PCF2127_REG_TIMSTP_YR]);\n+\n+\tdev_emerg(dev, \"%s: Tamper detected at secs=%d, mins=%d, hours=%d, \"\n+\t\t \"mday=%d, mon=%d, year=%d\\n\",\n+\t\t __func__,\n+\t\t tm->tm_sec, tm->tm_min, tm->tm_hour,\n+\t\t tm->tm_mday, tm->tm_mon, tm->tm_year);\n+\n+\treturn 0;\n+}\n+\n+static int pcf2127_tamper_enable(void)\n+{\n+\tint err;\n+\n+\t/* Enable interrupt on tamper event */\n+\terr = regmap_write_bits(save_pcf2127->regmap, PCF2127_REG_CTRL2,\n+\t\t\t\tPCF2127_TSIE, PCF2127_TSIE);\n+\tif (err)\n+\t\treturn err;\n+\n+\t/* Enable timestamp function */\n+\terr = regmap_write_bits(save_pcf2127->regmap, PCF2127_REG_TIMSTP_CTL,\n+\t\t\t\tPCF2127_TSM | PCF2127_TSOFF, PCF2127_TSM);\n+\tif (err)\n+\t\treturn err;\n+\n+\tsave_pcf2127->tamper_enabled = true;\n+\n+\treturn 0;\n+}\n+\n+static irqreturn_t pcf2127_tamper_event_irq(int irq, void *data)\n+{\n+\tstruct device *dev = data;\n+\tstruct pcf2127 *pcf2127 = dev_get_drvdata(dev);\n+\n+\tpcf2127_tamper_event_print(dev);\n+\n+\t/* Clear interrupt pin */\n+\tregmap_write_bits(pcf2127->regmap, PCF2127_REG_CTRL1,\n+\t\t\tPCF2127_TSF1, 0);\n+\tregmap_write_bits(pcf2127->regmap, PCF2127_REG_CTRL2,\n+\t\t\tPCF2127_TSF2, 0);\n+\n+\treturn IRQ_HANDLED;\n+}\n+#endif\n+\n+#ifdef CONFIG_RTC_DRV_PCF2127_WDT\n \n /* default 32 sec timeout */\n #define WD_TIMO 32\n@@ -219,6 +307,11 @@ static int pcf2127_rtc_read_time(struct device *dev, struct rtc_time *tm)\n \t\t\t \"oscillator stop detected, date/time is not reliable\\n\");\n \t\treturn -EINVAL;\n \t}\n+#ifdef CONFIG_RTC_DRV_PCF2127_TAMPER\n+\tif (buf[PCF2127_REG_CTRL1] & PCF2127_TSF1) {\n+\t\tpcf2127_tamper_event_print(dev);\n+\t}\n+#endif\n \n \tdev_dbg(dev,\n \t\t\"%s: raw data is cr1=%02x, cr2=%02x, cr3=%02x, \"\n@@ -319,9 +412,9 @@ static const struct rtc_class_ops pcf2127_rtc_ops = {\n };\n \n static int pcf2127_probe(struct device *dev, struct regmap *regmap,\n-\t\t\tconst char *name)\n+\t\t\t const char *name, int irq)\n {\n-#ifdef CONFIG_RTC_DRV_PCF2127_WDT\n+#if defined(CONFIG_RTC_DRV_PCF2127_TAMPER) || defined(CONFIG_RTC_DRV_PCF2127_WDT)\n \tint ret;\n #endif\n \tstruct pcf2127 *pcf2127;\n@@ -332,7 +425,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,\n \tif (!pcf2127)\n \t\treturn -ENOMEM;\n \n-#ifdef CONFIG_RTC_DRV_PCF2127_WDT\n+#if defined(CONFIG_RTC_DRV_PCF2127_TAMPER) || defined(CONFIG_RTC_DRV_PCF2127_WDT)\n \tsave_pcf2127 = pcf2127;\n #endif\n \n@@ -358,6 +451,28 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,\n \tpcf2127_wdt_settimeout(32);\n #endif\n \n+#ifdef CONFIG_RTC_DRV_PCF2127_TAMPER\n+\tpcf2127->tamper_enabled = false;\n+\n+\tif (!of_device_is_compatible(dev->of_node, \"nxp,pcf2127\"))\n+\t\treturn 0;\n+\n+\tif (of_property_read_bool(dev->of_node, \"tamper\")) {\n+\t\tpcf2127_tamper_enable();\n+\n+\t\tret = devm_request_threaded_irq(dev, irq, NULL,\n+\t\t\t\t\t\tpcf2127_tamper_event_irq,\n+\t\t\t\t\t\tIRQF_ONESHOT | IRQF_TRIGGER_FALLING, dev_name(dev),\n+\t\t\t\t\t\tdev);\n+\t\tif (ret < 0) {\n+\t\t\tdev_err(dev, \"IRQ is not free.\\n\");\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\tpcf2127->irq = irq;\n+\t}\n+#endif\n+\n \treturn 0;\n }\n \n@@ -466,7 +581,7 @@ static int pcf2127_i2c_probe(struct i2c_client *client,\n \t}\n \n \treturn pcf2127_probe(&client->dev, regmap,\n-\t\t\t\tpcf2127_i2c_driver.driver.name);\n+\t\t\t\tpcf2127_i2c_driver.driver.name, client->irq);\n }\n \n static const struct i2c_device_id pcf2127_i2c_id[] = {\n@@ -529,7 +644,8 @@ static int pcf2127_spi_probe(struct spi_device *spi)\n \t\treturn PTR_ERR(regmap);\n \t}\n \n-\treturn pcf2127_probe(&spi->dev, regmap, pcf2127_spi_driver.driver.name);\n+\treturn pcf2127_probe(&spi->dev, regmap, pcf2127_spi_driver.driver.name,\n+\t\t\t spi->irq);\n }\n \n static const struct spi_device_id pcf2127_spi_id[] = {\n", "prefixes": [ "2/2" ] }