Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2235287/?format=api
{ "id": 2235287, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2235287/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260509024539.90998-2-guobin@linux.alibaba.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260509024539.90998-2-guobin@linux.alibaba.com>", "list_archive_url": null, "date": "2026-05-09T02:45:38", "name": "[1/2] kvm: remove redundant check in kvm_close", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7d5c92e7514ec1da40ccbec89fee11e514f0630d", "submitter": { "id": 91693, "url": "http://patchwork.ozlabs.org/api/1.2/people/91693/?format=api", "name": "Bin Guo", "email": "guobin@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260509024539.90998-2-guobin@linux.alibaba.com/mbox/", "series": [ { "id": 503478, "url": "http://patchwork.ozlabs.org/api/1.2/series/503478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503478", "date": "2026-05-09T02:45:38", "name": "kvm: minor cleanups in kvm_close and kvm_irqchip_release_virq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/503478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2235287/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2235287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=ca/Dp5Aa;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC9PP5dd2z1yMp\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 12:47:04 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wLXi0-0007tF-Dg; Fri, 08 May 2026 22:46:28 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <guobin@linux.alibaba.com>)\n id 1wLXhj-0007sT-8O\n for qemu-devel@nongnu.org; Fri, 08 May 2026 22:46:16 -0400", "from out30-112.freemail.mail.aliyun.com ([115.124.30.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <guobin@linux.alibaba.com>)\n id 1wLXhg-0003BE-LX\n for qemu-devel@nongnu.org; Fri, 08 May 2026 22:46:10 -0400", "from localhost(mailfrom:guobin@linux.alibaba.com\n fp:SMTPD_---0X2ZCFg-_1778294749 cluster:ay36) by smtp.aliyun-inc.com;\n Sat, 09 May 2026 10:45:54 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linux.alibaba.com; s=default;\n t=1778294755; h=From:To:Subject:Date:Message-ID:MIME-Version;\n bh=6sbYWlJN+z4hkTQrsoN7IxSNEeSI4CJC1PosPUP5cnY=;\n b=ca/Dp5AaFaqk+Hhadttqx0NBoSLBGzJXAoCUOC76sSZTOE0R7JItXoZJq+0rDecG4zVpLxVvRoECV189BxUQLieUDt11AvIwnswd3/2i8xaaGCt8HI/YPgjn3ENhXUoqIGlUdRGDiEVkNk/RASVVjYTNCsRLyfMD8bSWsZ0+2Rc=", "X-Alimail-AntiSpam": "AC=PASS; BC=-1|-1; BR=01201311R161e4; CH=green;\n DM=||false|;\n DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037026112;\n MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=3; SR=0;\n TI=SMTPD_---0X2ZCFg-_1778294749;", "From": "Bin Guo <guobin@linux.alibaba.com>", "To": "qemu-devel@nongnu.org", "Cc": "pbonzini@redhat.com,\n\tkvm@vger.kernel.org", "Subject": "[PATCH 1/2] kvm: remove redundant check in kvm_close", "Date": "Sat, 9 May 2026 10:45:38 +0800", "Message-ID": "<20260509024539.90998-2-guobin@linux.alibaba.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260509024539.90998-1-guobin@linux.alibaba.com>", "References": "<20260509024539.90998-1-guobin@linux.alibaba.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=115.124.30.112;\n envelope-from=guobin@linux.alibaba.com;\n helo=out30-112.freemail.mail.aliyun.com", "X-Spam_score_int": "-174", "X-Spam_score": "-17.5", "X-Spam_bar": "-----------------", "X-Spam_report": "(-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5,\n USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In kvm_close(), the condition `!kvm_state || kvm_state->fd == -1` is\nchecked at the function entry, causing an early return if either is\ntrue. Later in the function, the same condition is redundantly checked\nagain before closing vmfd and fd.\n\nRemove the redundant second check since it can never be true at that\npoint.\n\nSigned-off-by: Bin Guo <guobin@linux.alibaba.com>\n---\n accel/kvm/kvm-all.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\nindex 92af42503b..70bc2c86a2 100644\n--- a/accel/kvm/kvm-all.c\n+++ b/accel/kvm/kvm-all.c\n@@ -769,12 +769,11 @@ void kvm_close(void)\n cpu->kvm_vcpu_stats_fd = -1;\n }\n \n- if (kvm_state && kvm_state->fd != -1) {\n- close(kvm_state->vmfd);\n- kvm_state->vmfd = -1;\n- close(kvm_state->fd);\n- kvm_state->fd = -1;\n- }\n+ close(kvm_state->vmfd);\n+ kvm_state->vmfd = -1;\n+ close(kvm_state->fd);\n+ kvm_state->fd = -1;\n+\n kvm_state = NULL;\n }\n \n", "prefixes": [ "1/2" ] }