Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2235256/?format=api
{ "id": 2235256, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2235256/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260508213217.3807786-3-aristo.chen@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508213217.3807786-3-aristo.chen@canonical.com>", "list_archive_url": null, "date": "2026-05-08T21:32:00", "name": "[v1,2/3] test: fit: regression test for default-config print with reversed node order", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f43b8074d1a3e8a24db9521c6603debb7b140de4", "submitter": { "id": 92721, "url": "http://patchwork.ozlabs.org/api/1.2/people/92721/?format=api", "name": "Aristo Chen", "email": "aristo.chen@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260508213217.3807786-3-aristo.chen@canonical.com/mbox/", "series": [ { "id": 503465, "url": "http://patchwork.ozlabs.org/api/1.2/series/503465/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=503465", "date": "2026-05-08T21:31:58", "name": "boot/fit: use fdt_for_each_subnode() in image-fit.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/503465/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2235256/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2235256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=pH1Ew3M/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"pH1Ew3M/\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=aristo.chen@canonical.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC6f24MDJz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 10:42:50 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 40AA784E58;\n\tSat, 9 May 2026 02:40:21 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 9D36884CE5; Fri, 8 May 2026 23:32:41 +0200 (CEST)", "from smtp-relay-internal-0.canonical.com\n (smtp-relay-internal-0.canonical.com [185.125.188.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B6A5484CFD\n for <u-boot@lists.denx.de>; Fri, 8 May 2026 23:32:39 +0200 (CEST)", "from mail-pf1-f197.google.com (mail-pf1-f197.google.com\n [209.85.210.197])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 7B9243FEC7\n for <u-boot@lists.denx.de>; Fri, 8 May 2026 21:32:39 +0000 (UTC)", "by mail-pf1-f197.google.com with SMTP id\n d2e1a72fcca58-82f9429f49cso2841521b3a.3\n for <u-boot@lists.denx.de>; Fri, 08 May 2026 14:32:39 -0700 (PDT)", "from noble-uboot.tail872496.ts.net\n (124-218-37-86.cm.dynamic.apol.com.tw. [124.218.37.86])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-83962e7e3fcsm16196751b3a.0.2026.05.08.14.32.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 14:32:36 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1778275959;\n bh=yiddp9x9S6gdCPetEGdIOtFmgLoQQUErMs3L72I6tIM=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=pH1Ew3M/wj6SrApYWslkF+dvTBCOIJevZFoTvXomkvQLaWVA4FJOiod4fIOLn+4Py\n 9pBX/sqSd4vzCzttX7Ke09zxWvPEIH2LVPSqsmGepdHEB5mHPnVkGO5JGgDy7swBA1\n qHvAyjv3CczS1POKwWTSdLYVqNJZenkDpCTlCqCWk3h8xp3rs2CPRQePbf9GIHlF/r\n wdbnluZOWSHuizVT9tCgTEj8uNXkWnseA+WsLyzz+BKgFMETWu9qF0ccPXyuPWx/tj\n GyQ4eYOsl61vjKMBAMkPYKImJU4YVAqxKDQ6duQhOwxDngWzvuf93m4dZqW3CsdRnE\n U8fxqWGKYVWaH3HiSMQAHjWPPql8eVjCNjulbGNacg3dzAGTzzF6A7daso818JHRT4\n 2/KYD10XCFSKxzFB9eSAC4qmZhev/xKDPsKFgsa74XWfLzup2Y14rrHzr8aRyWu+BG\n YDL/p8DFdAW1SrjuoDcZT+ETMH5rliNh30LLK+s5WwZSrUCksu1LdiNrrV3ha5qFSt\n I1NOI9Mr/bPnB+DFhOkRn6lphHli/FLDQF0Lbb4b54kF+wgpD4aQjM7algDLgTrh/K\n t+ygCDySO3ek197WZVLimCYDOFGm1+SD0Rswxw9y5YQr+3Be9WOk49iw+9GKkcPcGY\n R9SKw1xvMxFPyCHBQpzs7Jj0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778275958; x=1778880758;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yiddp9x9S6gdCPetEGdIOtFmgLoQQUErMs3L72I6tIM=;\n b=rwLmjmnq/Dl9sImUFc0l6fiZHJ8HlC0moowq0OevSpkzb5gygyrZgftu234myUf0w2\n txYPBeSpoDG2f4PgdklzPS2Mt+oMxopmIRRqyohKqcxn3yjHxFnSBthPg+N6o1LtfxP0\n rAhvkEsgYD7Y0lQ13AdH5RepVePMVL2fOmnGfQp3wacimc9cr1ookzfJPUzhua372eBi\n cuLElLsBRAnkZK4f+ne+wKXhDCBI56fjN8z1/l0nJelaFgWRoWvVf/Zo6qnDPXDhaIj3\n XfeZ5ysVV+yAUaYAfg5Rdz7aQPI4u4o9omgx/l2qQ8OzlDuR7wyYE4bHgzUooaxSdY/I\n x2Hg==", "X-Gm-Message-State": "AOJu0YyP+AO7HNw83lkV2XCjTzIfP7IWMh/e5r5iOVMDvhrsm24/8H8O\n xJ6hjWEpg2uikLUpwtOpmpX/i7XrlxIlmv/1iXIvy3JDWSBXz+VYf55So47+gUfy43SViY03NNN\n 1IXqZkEhBCeWwDOq5OneP3eJrlie+0ooLMuVYCo04hloYlj6MUHTn8lupvvpzBZ5sB+tlmtipBI\n Mrz5gLTVWR", "X-Gm-Gg": "Acq92OFHqf9sdQV/tTm0twrwqeNe1FYiwz/f8q/5K4RAyiYhObP9o2nRjX3mY7ob+TM\n csR/PE1ckNelwymNd4sK91C/PXI3msZ+8JreOAjKu5+QX+fsT8eO4jJky30YERM6dpXH9Rwzgz5\n ba5LSYmf+1qzKjJ+8uro4DDILGQMQbbjVq3LLmoNNrMvmfEgnMFPomrkgfFU7An6wsGA+fJfUsw\n utVwR9LCX+4hRwBmd29eToPd88ZRvtWDr07kbLUuQn9pUksINgwH1DWk+gripgvm3QUOUq0c2eM\n dKwn2zLOBHnO/eYhAkzGIzVXYpirM3hstluJA/SGJ97OxWs0EAPEUIYheP4p1zfSMFvpSanM4jR\n 9wkeDBw/+cdMsVuDW/pW8oqZZZzLOxkaXJdZp4Zzb0v1JDMzVkgjU2yjiOXuabU8GNhz/gyS9Nw\n J9zzXazmEUCCopjWk=", "X-Received": [ "by 2002:a05:6a00:190e:b0:82c:9e00:f958 with SMTP id\n d2e1a72fcca58-83e36e51082mr34645b3a.0.1778275957675;\n Fri, 08 May 2026 14:32:37 -0700 (PDT)", "by 2002:a05:6a00:190e:b0:82c:9e00:f958 with SMTP id\n d2e1a72fcca58-83e36e51082mr34613b3a.0.1778275957237;\n Fri, 08 May 2026 14:32:37 -0700 (PDT)" ], "From": "Aristo Chen <aristo.chen@canonical.com>", "To": "u-boot@lists.denx.de", "Cc": "Aristo Chen <aristo.chen@canonical.com>, Tom Rini <trini@konsulko.com>,\n Simon Glass <sjg@chromium.org>", "Subject": "[PATCH v1 2/3] test: fit: regression test for default-config print\n with reversed node order", "Date": "Fri, 8 May 2026 21:32:00 +0000", "Message-ID": "<20260508213217.3807786-3-aristo.chen@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260508213217.3807786-1-aristo.chen@canonical.com>", "References": "<20260508213217.3807786-1-aristo.chen@canonical.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Sat, 09 May 2026 02:40:19 +0200", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Add a test that builds a FIT whose /configurations node is defined\nbefore /images in the source, runs iminfo, and asserts that the\n\"Default Configuration: '<name>'\" line appears in the output.\n\nBefore the fix in the preceding commit (\"boot/fit: read default-config\nproperty from the configurations node\"), fit_print_contents() read the\ndefault-config property using the loop variable left over from iterating\n/images children. With /images defined first that variable accidentally\npointed at /configurations and the line printed correctly; with\n/configurations defined first the read returned NULL and the line was\nsilently omitted. The new test exercises the latter layout, which had\nno coverage.\n\niminfo and the fit_print_contents() path had no test coverage at all\nbefore this commit.\n\nSigned-off-by: Aristo Chen <aristo.chen@canonical.com>\n---\n test/py/tests/test_fit.py | 53 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 53 insertions(+)", "diff": "diff --git a/test/py/tests/test_fit.py b/test/py/tests/test_fit.py\nindex bcaaa6a5fc4..a526307ea7a 100755\n--- a/test/py/tests/test_fit.py\n+++ b/test/py/tests/test_fit.py\n@@ -438,3 +438,56 @@ class TestFitImage:\n \n output = ubman.run_command_list(cmds)\n assert \"can't get kernel image!\" in '\\n'.join(output)\n+\n+ def test_fit_iminfo_configs_first(self, ubman, fsetup):\n+ \"\"\"Regression: iminfo prints \"Default Configuration\" even when\n+ /configurations is defined before /images in the source.\n+\n+ fit_print_contents() in boot/image-fit.c used to read the default\n+ configuration name from whatever offset libfdt happened to return\n+ after iterating /images children. With /images defined first that\n+ offset accidentally landed on /configurations; with /configurations\n+ defined first the read returned NULL and the line silently went\n+ missing. Fixed in commit \"boot/fit: read default-config property\n+ from the configurations node\".\n+ \"\"\"\n+ configs_first_its = '''\n+/dts-v1/;\n+\n+/ {\n+ description = \"FIT with /configurations before /images\";\n+ #address-cells = <1>;\n+\n+ configurations {\n+ default = \"conf-1\";\n+ conf-1 {\n+ description = \"first config\";\n+ kernel = \"kernel-1\";\n+ };\n+ };\n+\n+ images {\n+ kernel-1 {\n+ description = \"first image\";\n+ data = /incbin/(\"%(kernel)s\");\n+ type = \"kernel\";\n+ arch = \"sandbox\";\n+ os = \"linux\";\n+ compression = \"none\";\n+ load = <0x40000>;\n+ entry = <0x40000>;\n+ };\n+ };\n+};\n+'''\n+ fit = fit_util.make_fit(ubman, fsetup['mkimage'], configs_first_its,\n+ fsetup, basename='configs-first.fit')\n+ cmds = [\n+ 'host load hostfs 0 %#x %s' % (fsetup['fit_addr'], fit),\n+ 'iminfo %#x' % fsetup['fit_addr'],\n+ ]\n+ output = '\\n'.join(ubman.run_command_list(cmds))\n+ assert \"Default Configuration: 'conf-1'\" in output, (\n+ 'iminfo output is missing the \"Default Configuration\" line for a '\n+ 'FIT whose /configurations node precedes /images. Output was:\\n'\n+ + output)\n", "prefixes": [ "v1", "2/3" ] }