Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2235255/?format=api
{ "id": 2235255, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2235255/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260508213217.3807786-2-aristo.chen@canonical.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508213217.3807786-2-aristo.chen@canonical.com>", "list_archive_url": null, "date": "2026-05-08T21:31:59", "name": "[v1,1/3] boot/fit: read default-config property from the configurations node", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6f3be6b1bd273897851011accf6309818494d5fa", "submitter": { "id": 92721, "url": "http://patchwork.ozlabs.org/api/1.2/people/92721/?format=api", "name": "Aristo Chen", "email": "aristo.chen@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260508213217.3807786-2-aristo.chen@canonical.com/mbox/", "series": [ { "id": 503465, "url": "http://patchwork.ozlabs.org/api/1.2/series/503465/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=503465", "date": "2026-05-08T21:31:58", "name": "boot/fit: use fdt_for_each_subnode() in image-fit.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/503465/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2235255/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2235255/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=bMmr/m2b;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"bMmr/m2b\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=aristo.chen@canonical.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC6dt1HF9z1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 10:42:42 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0344B84E3D;\n\tSat, 9 May 2026 02:40:21 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id CD2E284CF1; Fri, 8 May 2026 23:32:39 +0200 (CEST)", "from smtp-relay-internal-1.canonical.com\n (smtp-relay-internal-1.canonical.com [185.125.188.123])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E115184CE5\n for <u-boot@lists.denx.de>; Fri, 8 May 2026 23:32:37 +0200 (CEST)", "from mail-pg1-f199.google.com (mail-pg1-f199.google.com\n [209.85.215.199])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 92C233F9C1\n for <u-boot@lists.denx.de>; Fri, 8 May 2026 21:32:37 +0000 (UTC)", "by mail-pg1-f199.google.com with SMTP id\n 41be03b00d2f7-c70f19f0f37so1403745a12.0\n for <u-boot@lists.denx.de>; Fri, 08 May 2026 14:32:37 -0700 (PDT)", "from noble-uboot.tail872496.ts.net\n (124-218-37-86.cm.dynamic.apol.com.tw. [124.218.37.86])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-83962e7e3fcsm16196751b3a.0.2026.05.08.14.32.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 14:32:34 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1778275957;\n bh=P9bxS7ZvW/jWs2zPFQZl6n2TtP559v11PvIFdtyhLAk=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=bMmr/m2bPTLLlzLtf5Gja6RTNEeIizBsm32hvP9oICmJAYs4pOyUBI/LxaL6l78Jq\n X4WFGvdnxjni3n+qZXXfhqEA4mcQ57QPajWTUZKlQKx8/Ic0I4xafCc4GfIOAoQpvw\n Lc0HtyFltdT1fAtaFRfLmbO1+5q/PBFaycIf4RB4GOzL1cVfmiwbUU8AlhQj3lBcSw\n 3clC04yPqUi1AAN7xYphHPlzk1eXngeJI3sCK3IDysaE8Mn/InVcEVQyPAzo0xEsXZ\n OdUNFOlbkK+0Iy0tfJm1Z6TVLFUertgB41Y4pZ5KoMpIF/9thMJcolp9wVDd+lD2He\n 9bGaibovyDbO7KyXVAsEXvuGHA5qYeJC94fRvMANeVAKYtl9XiZ86oYYOqmYjI0bjk\n TRnHKmVdgyO1zbh3EFKbq1hfJogIQRUcV4CJwqAZxrg3O5CRyotpRsjqOklvK8WB2a\n En6+GlmLrhZfOltEQTUywhs/kKsmsifxh8np4q4xh8yubGz9rvp3B3BC40nf9Byh8h\n 17Gm20msDXEP4CdK7KpVUFio18Z+4uYhkPJLQxzeV7mMGw4z28ES9/tKalJtOhDcqJ\n voryTC5lzoU0XNnsSHV5tS3g1V2MmL/+3rAIQpVMnrxIafejA6+qwb3ZmGPlHiriTk\n +x2YzyiEdWoX474MjQY6ePOU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778275956; x=1778880756;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=P9bxS7ZvW/jWs2zPFQZl6n2TtP559v11PvIFdtyhLAk=;\n b=k9ZyohByhqwyJDmPq/RRQbEQu7MsMAlas1q8QOBTFkbWIQKt0iivrs3v2WPJ066cYG\n a9ne9H8x84huG4p88dwr9Uy14oUdO2UUH8JYe9UxWnAkc4TKAdwatEnDZai1n8cLQRwj\n sGcs2IprIMkbZaDSFcBeSXwBUkTIwGnyRJtJphdWRwTbTB3Nvjvz+h13ooKQWPpZpDmO\n poZn2NGDNETQLUdFJasWgeb9cYSpAEE2wLQTkzx2lgt48VaIl2THGJS1olfq0ZhJlSV1\n plemTCG6jpfyAEhEMjkYwS4UQaszYxMUFqyyjOkyNH7O6IkTa2PuesBEUhjAAj+PCwml\n FNVw==", "X-Gm-Message-State": "AOJu0YxWlXVHLd2aoARKHfwNag4HTEhaaWRtqUkyUXCXfd+Zj00iki8o\n AI4RaH3QOq7a7Zvpc9RecupwKxq/UsJRjVAI9zO9WyfoUdRK51m5x28M9Q++MnJHOotlU9GqGsb\n m2ersYmi1VyjqHVz5Rg191j4C/aNw4x8yu2vgf8t5XvVi3eox8DmiHJKx5TNDH0vN/SHkXPoRs4\n vPU35x67Pf5ak=", "X-Gm-Gg": "AeBDievVvP3OA/V2akIyxlhALas9lSEbyBiX7AWTkuOEvQdUWvdKxDX1vHjsTwtUrMV\n +a0/KJ9Z6alXN7UWvpUVLuzFrg+b3iIqqfQdmmR0ux3UPNgQZ0m8yAmh0hwUFIrK3hmer6v7q0l\n XeW7YR2nunC3phw4+pboZg4DfSFMpwq0MLV9gq05vXvLMdVfEQbWcd6GT/OauIQJQbiZcWV6NX1\n sIw45YNnQ39tOT1nglJmdR+8cPNs3+la+IoaiIMb6XhXvUQ4tMN0NtqU73woR067F+A9F05jfyt\n dVWhRa23XLKbkPBgVaInF2yZlrY9E2HNphJYT8yrgLVYlnzSToIKALCZberRqAKoSpWefXoxlfY\n dEVZ9r1WHanK53DlemuQX8KslwMo639RDWDV5NS9c/DUJ3PKeQwFHw3KVEVAixE7QL+thplfziw\n Q1F6TZWdYEYeSKVTY=", "X-Received": [ "by 2002:a05:6a20:3d1f:b0:35d:cc9a:8bc1 with SMTP id\n adf61e73a8af0-3aa8c1edb8fmr8476538637.27.1778275955689;\n Fri, 08 May 2026 14:32:35 -0700 (PDT)", "by 2002:a05:6a20:3d1f:b0:35d:cc9a:8bc1 with SMTP id\n adf61e73a8af0-3aa8c1edb8fmr8476518637.27.1778275955271;\n Fri, 08 May 2026 14:32:35 -0700 (PDT)" ], "From": "Aristo Chen <aristo.chen@canonical.com>", "To": "u-boot@lists.denx.de", "Cc": "Aristo Chen <aristo.chen@canonical.com>, Tom Rini <trini@konsulko.com>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>", "Subject": "[PATCH v1 1/3] boot/fit: read default-config property from the\n configurations node", "Date": "Fri, 8 May 2026 21:31:59 +0000", "Message-ID": "<20260508213217.3807786-2-aristo.chen@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260508213217.3807786-1-aristo.chen@canonical.com>", "References": "<20260508213217.3807786-1-aristo.chen@canonical.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Sat, 09 May 2026 02:40:19 +0200", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In fit_print_contents() the default configuration's unit name is read by\ncalling fdt_getprop() with noffset rather than confs_noffset. Today this\nhappens to work by coincidence: the preceding loop walks /images using\nfdt_next_node(), and when iteration leaves the subtree libfdt returns\nthe offset of the next sibling in DFS order, which by FIT layout\nconvention is /configurations. The depth counter then drops below zero\nand the loop exits with noffset still pointing at /configurations.\n\nThis relies on /images and /configurations being adjacent siblings and\non the implementation detail of fdt_next_node()'s post-exhaustion\nreturn value. It also blocks a follow-up conversion to\nfdt_for_each_subnode(), whose post-loop loop variable is a negative\nerror code rather than a valid offset.\n\nUse confs_noffset directly, which the comment immediately above the\ncall already names as the source.\n\nSigned-off-by: Aristo Chen <aristo.chen@canonical.com>\n---\n boot/image-fit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/boot/image-fit.c b/boot/image-fit.c\nindex 2d2709aa5b1..5a502e93106 100644\n--- a/boot/image-fit.c\n+++ b/boot/image-fit.c\n@@ -449,7 +449,7 @@ void fit_print_contents(const void *fit)\n \t}\n \n \t/* get default configuration unit name from default property */\n-\tuname = (char *)fdt_getprop(fit, noffset, FIT_DEFAULT_PROP, NULL);\n+\tuname = (char *)fdt_getprop(fit, confs_noffset, FIT_DEFAULT_PROP, NULL);\n \tif (uname)\n \t\tprintf(\"%s Default Configuration: '%s'\\n\", p, uname);\n \n", "prefixes": [ "v1", "1/3" ] }