Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2235024/?format=api
{ "id": 2235024, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2235024/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508124208.11622-5-przemyslaw.kitszel@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.2/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508124208.11622-5-przemyslaw.kitszel@intel.com>", "list_archive_url": null, "date": "2026-05-08T12:41:57", "name": "[iwl-next,v1,04/15] ice: add VF queue ena/dis helper functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "25c0b94b776e45f0ea629967572daf33e1fab6aa", "submitter": { "id": 85252, "url": "http://patchwork.ozlabs.org/api/1.2/people/85252/?format=api", "name": "Przemek Kitszel", "email": "przemyslaw.kitszel@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508124208.11622-5-przemyslaw.kitszel@intel.com/mbox/", "series": [ { "id": 503388, "url": "http://patchwork.ozlabs.org/api/1.2/series/503388/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503388", "date": "2026-05-08T12:41:53", "name": "devlink, mlx5, iavf, ice: XLVF for iavf", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/503388/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2235024/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2235024/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5GTzgsSR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBq305qmtz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 22:59:56 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6B87040F2F;\n\tFri, 8 May 2026 12:59:53 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xBl9LKuo5Vwv; Fri, 8 May 2026 12:59:51 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id ADFBC40FA3;\n\tFri, 8 May 2026 12:59:51 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 3A9BF358\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2026 12:59:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 2CAAA40FBC\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2026 12:59:50 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pKSGR5dPGaM0 for <intel-wired-lan@lists.osuosl.org>;\n Fri, 8 May 2026 12:59:49 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 1413140F74\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2026 12:59:48 +0000 (UTC)", "from fmviesa005.fm.intel.com ([10.60.135.145])\n by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 May 2026 05:59:49 -0700", "from irvmail002.ir.intel.com ([10.43.11.120])\n by fmviesa005.fm.intel.com with ESMTP; 08 May 2026 05:59:43 -0700", "from vecna.igk.intel.com (vecna.igk.intel.com [10.123.220.17])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id DBA4E2FC40;\n Fri, 8 May 2026 13:59:40 +0100 (IST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org ADFBC40FA3", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1413140F74" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778245191;\n\tbh=ytdItwycy+SOrdJ5g69fcSGWr0cGLimgtIav0EtLbVQ=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=5GTzgsSR8ox8wWAjWZGljUFq9hk0ZDl7EgVb28Tn7HDzKvweUaoZ9O53D78Jq539q\n\t WNEojgEM40QywFtYqcJOguLO0ivEsrA3EqE+xo24LViX16Cb5oJ8Vpjm37lDO0ewgu\n\t 8jOZo9axmfRNpIbjn48NL8YtnNjRfV0l74g2MmBKB/mlvaqX4lYomhxAzavreIRJ6Q\n\t KjOL8jSKTpDpJeJbJLrCMmryYb4/xzp68pC/kQ5hPUhm/SEQ8B8kk3YqsdpqoDRjnE\n\t aZ8/4Pbus62/7zHoP17Z9Sig2Lido8CFJYHpQYn6sA1zDKUbisjrW/KzieLytuXbZA\n\t fHUbJ6Vv1idaA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.17;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 1413140F74", "X-CSE-ConnectionGUID": [ "sGplEGn1TFy/jatA1GcRXQ==", "QdjmrR3XRauMd4Hx955Iaw==" ], "X-CSE-MsgGUID": [ "zObYMSykT/uboxxWZbcrZA==", "Q/BjC+khSZ6c8iMpu/HHsQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11779\"; a=\"79199889\"", "E=Sophos;i=\"6.23,223,1770624000\"; d=\"scan'208\";a=\"79199889\"", "E=Sophos;i=\"6.23,223,1770624000\"; d=\"scan'208\";a=\"241730112\"" ], "X-ExtLoop1": "1", "From": "Przemek Kitszel <przemyslaw.kitszel@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, Michal Schmidt <mschmidt@redhat.com>,\n Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>", "Cc": "netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n bruce.richardson@intel.com,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n padraig.j.connolly@intel.com, ananth.s@intel.com,\n timothy.miskell@intel.com, Jacob Keller <jacob.e.keller@intel.com>,\n Lukasz Czapnik <lukasz.czapnik@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,\n Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>,\n Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Wojciech Drewek <wojciech.drewek@intel.com>,\n Jedrzej Jagielski <jedrzej.jagielski@intel.com>", "Date": "Fri, 8 May 2026 14:41:57 +0200", "Message-Id": "<20260508124208.11622-5-przemyslaw.kitszel@intel.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20260508124208.11622-1-przemyslaw.kitszel@intel.com>", "References": "<20260508124208.11622-1-przemyslaw.kitszel@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778245190; x=1809781190;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=748h7Xx8q52MKpfWxfAmxkATQ+6j/9UMHqUMByZ1RCg=;\n b=Di+Hb8uEAtO2L2d+7ldT56+AFi2jaJ2pg/9ukVVsRNjNZAUsJAJuV1pi\n /3mzGGWLrdUNtaPmB0NLQYdNquKdLuvuZ+1kVsdzHzHFvBMNinBukOopd\n KMeW+nk8kVkA219qef0hYg6wdUXChGUcJMPE+7eLP82R1d53ojSzCjbFC\n EnWxnUxAUfRv5QWpX1JaxzGHuO5KkBkBx+2iuUFM0AwpBogS8W0Y0unjD\n cNxzq7HTTP2sVjLlvmraJigFR4ZJjWzzXYy6Bny3RPx84LZ2QBpT/Tzra\n /wDyM5WKbciTHO2Na9VF813SO41W5ZJ/X4aUkcY6aDgi3T4llAzVnkadi\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Di+Hb8uE" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v1 04/15] ice: add VF queue\n ena/dis helper functions", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nAdd three new functions:\n- ice_vf_vsi_dis_single_rxq()\n- ice_vf_vsi_ena_single_rxq()\n- ice_vf_vsi_ena_single_txq()\n (ice_vf_vsi_dis_single_txq() was introduced earlier.\n\nThose functions wrap operations needed in the processes of enabling\nand disabling single Tx/Rx VF queue, which are:\n- check if the queue is not already in desired state\n- perform the dis/ena operations\n- bookkeeping of the queue's state.\n\nFuture commit will use them from another callsite.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\nSigned-off-by: Wojciech Drewek <wojciech.drewek@intel.com>\nReviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>\nSigned-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\n---\n drivers/net/ethernet/intel/ice/virt/queues.c | 111 ++++++++++++++-----\n 1 file changed, 84 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/virt/queues.c b/drivers/net/ethernet/intel/ice/virt/queues.c\nindex 6e4ec681fd07..28adc24197b8 100644\n--- a/drivers/net/ethernet/intel/ice/virt/queues.c\n+++ b/drivers/net/ethernet/intel/ice/virt/queues.c\n@@ -224,6 +224,57 @@ void ice_vf_ena_rxq_interrupt(struct ice_vsi *vsi, u32 q_idx)\n \twr32(hw, QINT_RQCTL(pfq), reg | QINT_RQCTL_CAUSE_ENA_M);\n }\n \n+/**\n+ * ice_vf_vsi_ena_single_rxq - enable single Rx queue based on relative q_id\n+ * @vf: VF to enable queue for\n+ * @vsi: VSI for the VF\n+ * @q_id: VSI relative (0-based) queue ID\n+ *\n+ * Enable the Rx queue passed in.\n+ *\n+ * Return: 0 on success or negative on error.\n+ */\n+static int ice_vf_vsi_ena_single_rxq(struct ice_vf *vf, struct ice_vsi *vsi,\n+\t\t\t\t u16 q_id)\n+{\n+\tint err;\n+\n+\tif (test_bit(q_id, vf->rxq_ena))\n+\t\treturn 0;\n+\n+\terr = ice_vsi_ctrl_one_rx_ring(vsi, true, q_id, true);\n+\tif (err) {\n+\t\tdev_err(ice_pf_to_dev(vsi->back), \"Failed to enable Rx ring %d on VSI %d\\n\",\n+\t\t\tq_id, vsi->vsi_num);\n+\t\treturn err;\n+\t}\n+\n+\tice_vf_ena_rxq_interrupt(vsi, q_id);\n+\tset_bit(q_id, vf->rxq_ena);\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * ice_vf_vsi_ena_single_txq - enable single Tx queue based on relative q_id\n+ * @vf: VF to enable queue for\n+ * @vsi: VSI for the VF\n+ * @q_id: VSI relative (0-based) queue ID\n+ *\n+ * Enable the Tx queue's interrupt. Note that the Tx queue(s) should have\n+ * already been configurated/enabled in VIRTCHNL_OP_CONFIG_QUEUES so this\n+ * function only enables the interrupt associated with the q_id.\n+ */\n+static void ice_vf_vsi_ena_single_txq(struct ice_vf *vf, struct ice_vsi *vsi,\n+\t\t\t\t u16 q_id)\n+{\n+\tif (test_bit(q_id, vf->txq_ena))\n+\t\treturn;\n+\n+\tice_vf_ena_txq_interrupt(vsi, q_id);\n+\tset_bit(q_id, vf->txq_ena);\n+}\n+\n /**\n * ice_vc_ena_qs_msg\n * @vf: pointer to the VF info\n@@ -272,34 +323,20 @@ int ice_vc_ena_qs_msg(struct ice_vf *vf, u8 *msg)\n \t\t\tgoto error_param;\n \t\t}\n \n-\t\t/* Skip queue if enabled */\n-\t\tif (test_bit(vf_q_id, vf->rxq_ena))\n-\t\t\tcontinue;\n-\n-\t\tif (ice_vsi_ctrl_one_rx_ring(vsi, true, vf_q_id, true)) {\n-\t\t\tdev_err(ice_pf_to_dev(vsi->back), \"Failed to enable Rx ring %d on VSI %d\\n\",\n-\t\t\t\tvf_q_id, vsi->vsi_num);\n+\t\tif (ice_vf_vsi_ena_single_rxq(vf, vsi, vf_q_id)) {\n \t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\tgoto error_param;\n \t\t}\n-\n-\t\tice_vf_ena_rxq_interrupt(vsi, vf_q_id);\n-\t\tset_bit(vf_q_id, vf->rxq_ena);\n \t}\n \n \tq_map = vqs->tx_queues;\n \tfor_each_set_bit(vf_q_id, &q_map, ICE_MAX_RSS_QS_PER_VF) {\n \t\tif (!ice_vc_isvalid_q_id(vsi, vf_q_id)) {\n \t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\tgoto error_param;\n \t\t}\n \n-\t\t/* Skip queue if enabled */\n-\t\tif (test_bit(vf_q_id, vf->txq_ena))\n-\t\t\tcontinue;\n-\n-\t\tice_vf_ena_txq_interrupt(vsi, vf_q_id);\n-\t\tset_bit(vf_q_id, vf->txq_ena);\n+\t\tice_vf_vsi_ena_single_txq(vf, vsi, vf_q_id);\n \t}\n \n \t/* Set flag to indicate that queues are enabled */\n@@ -351,6 +388,36 @@ int ice_vf_vsi_dis_single_txq(struct ice_vf *vf, struct ice_vsi *vsi, u16 q_id)\n \treturn 0;\n }\n \n+/*\n+ * ice_vf_vsi_dis_single_rxq - disable a Rx queue for VF on relative queue ID\n+ * @vf: VF to disable queue for\n+ * @vsi: VSI for the VF\n+ * @q_id: VSI relative (0-based) queue ID\n+ *\n+ * Attempt to disable the Rx queue passed in. If the Rx queue was successfully\n+ * disabled then clear q_id bit in the enabled queues bitmap.\n+ */\n+static int ice_vf_vsi_dis_single_rxq(struct ice_vf *vf, struct ice_vsi *vsi,\n+\t\t\t\t u16 q_id)\n+{\n+\tint err;\n+\n+\tif (!test_bit(q_id, vf->rxq_ena))\n+\t\treturn 0;\n+\n+\terr = ice_vsi_ctrl_one_rx_ring(vsi, false, q_id, true);\n+\tif (err) {\n+\t\tdev_err(ice_pf_to_dev(vsi->back), \"Failed to stop Rx ring %d on VSI %d\\n\",\n+\t\t\tq_id, vsi->vsi_num);\n+\t\treturn err;\n+\t}\n+\n+\t/* Clear enabled queues flag */\n+\tclear_bit(q_id, vf->rxq_ena);\n+\n+\treturn 0;\n+}\n+\n /**\n * ice_vc_dis_qs_msg\n * @vf: pointer to the VF info\n@@ -415,20 +482,10 @@ int ice_vc_dis_qs_msg(struct ice_vf *vf, u8 *msg)\n \t\t\t\tgoto error_param;\n \t\t\t}\n \n-\t\t\t/* Skip queue if not enabled */\n-\t\t\tif (!test_bit(vf_q_id, vf->rxq_ena))\n-\t\t\t\tcontinue;\n-\n-\t\t\tif (ice_vsi_ctrl_one_rx_ring(vsi, false, vf_q_id,\n-\t\t\t\t\t\t true)) {\n-\t\t\t\tdev_err(ice_pf_to_dev(vsi->back), \"Failed to stop Rx ring %d on VSI %d\\n\",\n-\t\t\t\t\tvf_q_id, vsi->vsi_num);\n+\t\t\tif (ice_vf_vsi_dis_single_rxq(vf, vsi, vf_q_id)) {\n \t\t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\t\tgoto error_param;\n \t\t\t}\n-\n-\t\t\t/* Clear enabled queues flag */\n-\t\t\tclear_bit(vf_q_id, vf->rxq_ena);\n \t\t}\n \t}\n \n", "prefixes": [ "iwl-next", "v1", "04/15" ] }