Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234804/?format=api
{ "id": 2234804, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234804/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-9-kwilczynski@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.2/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260508043543.217179-9-kwilczynski@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260508043543.217179-9-kwilczynski@kernel.org/", "date": "2026-05-08T04:35:27", "name": "[v7,08/24] PCI/sysfs: Warn about BAR resize failure in __resource_resize_store()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "59dc2111873ebb11231ed7590e5f6a1bc6db8075", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.2/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-9-kwilczynski@kernel.org/mbox/", "series": [ { "id": 503322, "url": "http://patchwork.ozlabs.org/api/1.2/series/503322/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=503322", "date": "2026-05-08T04:35:20", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/503322/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234804/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234804/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-20592-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=NAOVaKZS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20592-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=NAOVaKZS;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbtd164Nz1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 14:36:57 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBbsw6ptzz3bhY;\n\tFri, 08 May 2026 14:36:20 +1000 (AEST)", "from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBbsw0RQnz2xPb\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 08 May 2026 14:36:20 +1000 (AEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 3580260181;\n\tFri, 8 May 2026 04:36:18 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 9BD14C2BCB4;\n\tFri, 8 May 2026 04:36:14 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778214980;\n\tcv=none;\n b=Z/oOpchvLVhSk1TLPGUJPnrXtituJVrakLS5FQK1tLQhGKDKopQEEqSzS1TfQbRZIr7mAe06gfnGmO2ixhy0cEYN+3mJeIygG+ZtdbU/0IlbTa2wxPdCPJcVLwPE/awvAlvESxwJUp7+MIgvfHpQxagpDyM2PtrcLOIzhAEasK7E1s6E21aU3WYutYiZzXtPLemjXHn/qNqFs5QfavNL6h1JdteRE3OjQbYR4gmKCmsu9WsyqTqvN3ad1IwXaWN0qAiPV5prTENyuh2jVlq0j7adQQJMJydEKsl3QobwWmtbqgedzobfuFeSLJJTKNKfW3O5MTmB/1701HKCGtM1OQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778214980; c=relaxed/relaxed;\n\tbh=5FO94nBRtGaqJOfD9g8mGYnlUBduBtpebOTsKzSu/NY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=hxQZW0yYd2NgXWzUYCQK8vvPoaC6IdrTDmt/gWpzuFUyZDi9Gwqra3wDvqVyPD0q6rmf1+u0vsEKm5gGwZ5D5MFbGwRB8l9jyYsJM3/ABWWmoa3JG/Ha+w2WNL/RW4XfuPH5pYlVzFeUgJocBPRqytrq8s2j3Y2JCaREPgta+CmnKZi+y3JrTuK6kAMiuhaKuyZHrCOLSi+J/pH8Q2Zs01LMIETJEH7vps9MclXGU+QYvMVG+rUQ2kJcMHyCQTy92jkky6yN0BAZhaQBYcMDAK+kkvdbe726BTe56IInZFrtiofU444irG9dWTuC6h15/z8cgWop43QrIioANQi/ng==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=NAOVaKZS; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778214977;\n\tbh=npFjt2eFuO2uVckDmBE/VjWzSztOJLV6MfwijXvEL7M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NAOVaKZSgv2JC8kYDcMYr1zfF/BGWGk29hLtLyOrUeg8gi/M4FBPWTP2DTqY8U0kL\n\t OAnpX7rAzXkuisaJu0w4BgQT7QdsdJyl8OifmwkmOGmW+2QET8CxzeJ1yL7GhtDaw7\n\t ZCBLnOnzfkEOau9IOeVLnWqxP37EdoKqckL55iCjfDknDHWHJQwXkAXt82crrhzqay\n\t KBq9hS8BDOas3hPbCvUYSSSN5JrcBWN++vRoX5EVzilPjLteTkI7I80XbftbQ6Mvwt\n\t xgEONVRMWMXalytUEVfgLhDHExjS7vPZtQ95P0MpkaACcMgyrCMXMFYlw5KUw/B8iS\n\t +qEnUACT6QfRg==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Alex Williamson <alex@shazbot.org>, Magnus Lindholm <linmag7@gmail.com>,\n Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v7 08/24] PCI/sysfs: Warn about BAR resize failure in\n __resource_resize_store()", "Date": "Fri, 8 May 2026 04:35:27 +0000", "Message-ID": "<20260508043543.217179-9-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260508043543.217179-1-kwilczynski@kernel.org>", "References": "<20260508043543.217179-1-kwilczynski@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Add a pci_warn() to __resource_resize_store(), so that BAR resize\nfailures are visible to the user, which can help troubleshoot any\npotential resource resize issues.\n\nWhile at it, rename the resource_resize_is_visible() to\nresource_resize_attr_is_visible() along with the corresponding\ngroup variable to align with the naming convention used by the\nresource attribute groups.\n\nAlso, change the order of pci_dev_groups[] such that the resize\ngroup is now located alongside the other resource groups.\n\nTested-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/pci-sysfs.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 0fa126d46e35..f34415a401ec 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1679,6 +1679,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tsysfs_remove_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups);\n \n \tret = pci_resize_resource(pdev, n, size, 0);\n+\tif (ret)\n+\t\tpci_warn(pdev, \"Failed to resize BAR %d: %pe\\n\",\n+\t\t\t n, ERR_PTR(ret));\n \n \tpci_assign_unassigned_bus_resources(bus);\n \n@@ -1726,7 +1729,7 @@ static struct attribute *resource_resize_attrs[] = {\n \tNULL,\n };\n \n-static umode_t resource_resize_is_visible(struct kobject *kobj,\n+static umode_t resource_resize_attr_is_visible(struct kobject *kobj,\n \t\t\t\t\t struct attribute *a, int n)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n@@ -1734,9 +1737,9 @@ static umode_t resource_resize_is_visible(struct kobject *kobj,\n \treturn pci_rebar_get_current_size(pdev, n) < 0 ? 0 : a->mode;\n }\n \n-static const struct attribute_group pci_dev_resource_resize_group = {\n+static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n-\t.is_visible = resource_resize_is_visible,\n+\t.is_visible = resource_resize_attr_is_visible,\n };\n \n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n@@ -1857,6 +1860,7 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n #endif\n+\t&pci_dev_resource_resize_attr_group,\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n@@ -1868,7 +1872,6 @@ const struct attribute_group *pci_dev_groups[] = {\n #ifdef CONFIG_ACPI\n \t&pci_dev_acpi_attr_group,\n #endif\n-\t&pci_dev_resource_resize_group,\n \tARCH_PCI_DEV_GROUPS\n \tNULL,\n };\n", "prefixes": [ "v7", "08/24" ] }