Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234802/?format=api
{ "id": 2234802, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234802/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-16-kwilczynski@kernel.org/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.2/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508043543.217179-16-kwilczynski@kernel.org>", "list_archive_url": null, "date": "2026-05-08T04:35:34", "name": "[v7,15/24] alpha/PCI: Remove WARN from __pci_mmap_fits() and __legacy_mmap_fits()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "594f657a1e00a74d1e7ed287c9bce30ed5002b25", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.2/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-16-kwilczynski@kernel.org/mbox/", "series": [ { "id": 503321, "url": "http://patchwork.ozlabs.org/api/1.2/series/503321/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=503321", "date": "2026-05-08T04:35:19", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/503321/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234802/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-54208-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R6HBL0pi;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54208-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"R6HBL0pi\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbtW1LYpz1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 14:36:51 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5D3FB3023509\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 8 May 2026 04:36:44 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D6ECA17A2FC;\n\tFri, 8 May 2026 04:36:43 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B435B15539A;\n\tFri, 8 May 2026 04:36:43 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 1BDF0C2BCB4;\n\tFri, 8 May 2026 04:36:39 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778215003; cv=none;\n b=rXcteunWh+uCes1QLQg1CM1ft04WXA9/Xcbq+i8wzQ39wM8uoIATUycSPhuUyNS+sN6EehBZ9+VtpJMldoQXeLQyMDz5pslzg4DCrDkz68RT6RzLGRrPlNJXSIv65VMcil8ujHWQvgfd9vTq0EJeQdkkdg9UP1I4A51FcwDtIZk=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778215003; c=relaxed/simple;\n\tbh=RvhmeHPggHFvnpvKsNMm4x+OKY6vAIZNY1FNS7XUoxg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=Odq4qUvYP5zo52tXbqE2UYDtt2V+whTSVHNoISi5Yr6z2JOqO5TXGTj3i98HgXIoHFY/fccHHcDLwPe5HHvAyejtnAyQ3n2ZdnL/DXrtXn28ZDSaeU1Ey1Mvu7VSxfgyUAX6gL+YhYBeptbeRLyFXFkRxSmmkpfZQQJwHV+8kdE=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=R6HBL0pi; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778215003;\n\tbh=RvhmeHPggHFvnpvKsNMm4x+OKY6vAIZNY1FNS7XUoxg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R6HBL0pinAWktnoLCLexrXMErdJxfRI3rqc0tRU23vmwpMZG2iZWBFQiawvwdama7\n\t invyEx99A5op8QyhD40MMD/JRw1YfS5fMjapZ3HM3cThGZ00Xf9h4l4VV57lK4Vi78\n\t IS83/FicH4dpT7UBDUCjWXj2F+ANaJ82RldQ1UUqAzJq25dtHOv7RqTfeABdNoZ+cb\n\t 0UFEA5Irs8HN0SSZO3odQp/QJ1wtZZCG0QaqnigEJFbnjrs+AhxM7LLVw2av/xWfJu\n\t YDIflHsAtCCxTMFzyXtuNCKBsL6scKYhv8VYhRgR4rj/2L50xgbv1v8Tn3jBvOuCzr\n\t W4DsRyW/AmuzA==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Alex Williamson <alex@shazbot.org>, Magnus Lindholm <linmag7@gmail.com>,\n Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v7 15/24] alpha/PCI: Remove WARN from __pci_mmap_fits() and\n __legacy_mmap_fits()", "Date": "Fri, 8 May 2026 04:35:34 +0000", "Message-ID": "<20260508043543.217179-16-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260508043543.217179-1-kwilczynski@kernel.org>", "References": "<20260508043543.217179-1-kwilczynski@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit" }, "content": "Remove the WARN() that fires when userspace attempts to mmap beyond\nthe BAR bounds. The check still returns 0 to reject the mapping,\nbut the warning is excessive for normal operation.\n\nA similar warning was removed from the PCI core in the commit\n3b519e4ea618 (\"PCI: fix size checks for mmap() on /proc/bus/pci files\").\n\nTested-by: Magnus Lindholm <linmag7@gmail.com>\nTested-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>\nReviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\nAcked-by: Magnus Lindholm <linmag7@gmail.com>\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n arch/alpha/kernel/pci-sysfs.c | 20 ++++----------------\n 1 file changed, 4 insertions(+), 16 deletions(-)", "diff": "diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 8802f955256e..a8dade7d084b 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -48,13 +48,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,\n \tstart = vma->vm_pgoff;\n \tsize = ((len - 1) >> (PAGE_SHIFT - shift)) + 1;\n \n-\tif (start < size && size - start >= nr)\n-\t\treturn 1;\n-\tWARN(1, \"process \\\"%s\\\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d \"\n-\t\t\"(size 0x%08lx)\\n\",\n-\t\tcurrent->comm, sparse ? \" sparse\" : \"\", start, start + nr,\n-\t\tpci_name(pdev), num, size);\n-\treturn 0;\n+\treturn start < size && size - start >= nr;\n }\n \n /**\n@@ -259,7 +253,7 @@ int pci_create_resource_files(struct pci_dev *pdev)\n \n static int __legacy_mmap_fits(struct pci_controller *hose,\n \t\t\t struct vm_area_struct *vma,\n-\t\t\t unsigned long res_size, int sparse)\n+\t\t\t unsigned long res_size)\n {\n \tunsigned long nr, start, size;\n \n@@ -267,13 +261,7 @@ static int __legacy_mmap_fits(struct pci_controller *hose,\n \tstart = vma->vm_pgoff;\n \tsize = ((res_size - 1) >> PAGE_SHIFT) + 1;\n \n-\tif (start < size && size - start >= nr)\n-\t\treturn 1;\n-\tWARN(1, \"process \\\"%s\\\" tried to map%s 0x%08lx-0x%08lx on hose %d \"\n-\t\t\"(size 0x%08lx)\\n\",\n-\t\tcurrent->comm, sparse ? \" sparse\" : \"\", start, start + nr,\n-\t\those->index, size);\n-\treturn 0;\n+\treturn start < size && size - start >= nr;\n }\n \n static inline int has_sparse(struct pci_controller *hose,\n@@ -296,7 +284,7 @@ int pci_mmap_legacy_page_range(struct pci_bus *bus, struct vm_area_struct *vma,\n \n \tres_size = (mmap_type == pci_mmap_mem) ? bus->legacy_mem->size :\n \t\t\t\t\t\t bus->legacy_io->size;\n-\tif (!__legacy_mmap_fits(hose, vma, res_size, sparse))\n+\tif (!__legacy_mmap_fits(hose, vma, res_size))\n \t\treturn -EINVAL;\n \n \treturn hose_mmap_page_range(hose, vma, mmap_type, sparse);\n", "prefixes": [ "v7", "15/24" ] }