Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234727/?format=api
{ "id": 2234727, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234727/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508031226.3601800-3-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.2/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260508031226.3601800-3-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-05-08T03:12:20", "name": "[iwl-next,2/8] ixgbe: use int instead of u32 for error code variables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1098b98d0931c2297ab784fffb3627f86f1ff301", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.2/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508031226.3601800-3-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 503311, "url": "http://patchwork.ozlabs.org/api/1.2/series/503311/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503311", "date": "2026-05-08T03:12:18", "name": "ixgbe: small cleanups and improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/503311/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234727/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234727/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=e49O2iX+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBZ1K69dWz1yKm\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 13:12:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id F196061236;\n\tFri, 8 May 2026 03:12:35 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iCE__vqMdiPd; Fri, 8 May 2026 03:12:34 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8EF8C6122A;\n\tFri, 8 May 2026 03:12:34 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 7DD31317\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2026 03:12:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 7836C4030E\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2026 03:12:33 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id e_YvLzItheta for <intel-wired-lan@lists.osuosl.org>;\n Fri, 8 May 2026 03:12:32 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 492DB409B3\n for <intel-wired-lan@lists.osuosl.org>; Fri, 8 May 2026 03:12:32 +0000 (UTC)", "from fmviesa005.fm.intel.com ([10.60.135.145])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2026 20:12:32 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa005.fm.intel.com with ESMTP; 07 May 2026 20:12:30 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8EF8C6122A", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 492DB409B3" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778209954;\n\tbh=eyakVV3nLMre4SsKhAYSvPE3ucfYucdhjx44Uwls0CM=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=e49O2iX+MXfbcXusBrwYuuSAmcV+bYs64otbRFbGcFPVaSnoABehiLn9Exkwxm73q\n\t 0F3LMFzd5ZKSG1dPsZtm2pTQ19KwYqNKeO4EU3Pt0ZC6yhgEmkAPzbHm10Wziwn9x8\n\t DKiC1iRvnPZZ6pFsyG/4gscMbkPwAh/fWo2sOVBaIWXChtj0peJ3sNwsqxSRQB71o3\n\t wDJ8XlSmMsxoXGJdpl5pYUJR0QRYOANng33DCZ3pAZXfNIbnqj/dGmImo/BxhVI+WQ\n\t PNnEDi6rQERfCUq3FVu3dUUCQLHVlt5tFyCmfbB70rMnujXSyiqS8Up8NUpoBTyaxb\n\t T2jEBbOT8LyMw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.17;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 492DB409B3", "X-CSE-ConnectionGUID": [ "dDgo3/TMTSSqT0Q/EdUY9Q==", "MChumWXESnuwnG0zcO/pWw==" ], "X-CSE-MsgGUID": [ "Qpo+YIyZTR6+FKbJgbVvcg==", "i7GdhBqkRKWzsz+joIaEFg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11779\"; a=\"79027489\"", "E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"79027489\"", "E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"241623182\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tSimon Horman <horms@kernel.org>", "Date": "Fri, 8 May 2026 05:12:20 +0200", "Message-ID": "<20260508031226.3601800-3-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260508031226.3601800-1-aleksandr.loktionov@intel.com>", "References": "<20260508031226.3601800-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778209952; x=1809745952;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=NDXYRNxohjaR9SlsX7zQsn4ljQYIO2z6Y5cD8SIerPU=;\n b=f9BG9yfd75PiKbCKMnDQrPqt1pqdrMf93D9T3wDhRiQ6KGjw7Bc+kREl\n c+CrzdFxivN0zNnXgS30vWIDLxn/bB+lr2hWT/Q+kdhv3+v6Ipn27u/re\n Cefs+zEnS0X+1zQ5IZ0fz1bqG3zC27AIrHToiGZCAdnS9+M2FNGkipi/p\n QjaUxZddh5Kja7GnzwXKx2KQ9zDiVM7dtwprvPoHlNd5OLxqREYy71lvA\n hkxyoqiUlegNhv234RSR8iLgK7DAyMI+oPS5EEawpSshngAWVIn5ZpYjO\n Y2OweeTMNbnjHr59SMpHjIEkpDzEVHZqxrOCJuP0qnR2+qfxmxWCvEZEP\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=f9BG9yfd" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next 2/8] ixgbe: use int instead of\n u32 for error code variables", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The variables used to store return values of kernel and driver functions\nthroughout the ixgbe driver are declared as u32 in several places. Such\nfunctions return negative errno values on error (e.g. -EIO, -EFAULT),\nwhich are sign-extended negative integers. Storing them in an unsigned\nu32 silently wraps the value: -EIO (0xFFFFFFF7) stored in u32 becomes a\nlarge positive number, so any \"if (status)\" truthiness check still works\nby accident, but comparisons against specific negative error codes or\npropagation up the call stack produce wrong results.\n\nIn the Linux kernel, u32 is reserved for fixed-width quantities used in\nhardware interfaces or protocol structures. Using it for generic error\ncodes misleads reviewers into thinking the value is hardware-constrained.\n\nChange all such local variables from u32 to int driver-wide: one in\nixgbe_main.c (ixgbe_resume), three in ixgbe_phy.c\n(ixgbe_identify_phy_generic, ixgbe_tn_check_overtemp,\nixgbe_set_copper_phy_power), and six in ixgbe_x550.c\n(ixgbe_check_link_t_X550em, ixgbe_get_lasi_ext_t_x550em,\nixgbe_enable_lasi_ext_t_x550em, ixgbe_handle_lasi_ext_t_x550em,\nixgbe_ext_phy_t_x550em_get_link, ixgbe_setup_internal_phy_t_x550em).\n\nNo functional change.\n\nReviewed-by: Simon Horman <horms@kernel.org>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 6 +++---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 12 ++++++------\n 3 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 65426a1..b6308c1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7528,7 +7528,7 @@ static int ixgbe_resume(struct device *dev_d)\n \tstruct pci_dev *pdev = to_pci_dev(dev_d);\n \tstruct ixgbe_adapter *adapter = pci_get_drvdata(pdev);\n \tstruct net_device *netdev = adapter->netdev;\n-\tu32 err;\n+\tint err;\n \n \tadapter->hw.hw_addr = adapter->io_addr;\n \ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex ab733e7..de8f6c6 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -262,7 +262,7 @@ static bool ixgbe_probe_phy(struct ixgbe_hw *hw, u16 phy_addr)\n **/\n int ixgbe_identify_phy_generic(struct ixgbe_hw *hw)\n {\n-\tu32 status = -EFAULT;\n+\tint status = -EFAULT;\n \tu32 phy_addr;\n \n \tif (!hw->phy.phy_semaphore_mask) {\n@@ -2811,7 +2811,7 @@ static void ixgbe_i2c_bus_clear(struct ixgbe_hw *hw)\n bool ixgbe_tn_check_overtemp(struct ixgbe_hw *hw)\n {\n \tu16 phy_data = 0;\n-\tu32 status;\n+\tint status;\n \n \tif (hw->device_id != IXGBE_DEV_ID_82599_T3_LOM)\n \t\treturn false;\n@@ -2831,7 +2831,7 @@ bool ixgbe_tn_check_overtemp(struct ixgbe_hw *hw)\n **/\n int ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on)\n {\n-\tu32 status;\n+\tint status;\n \tu16 reg;\n \n \t/* Bail if we don't have copper phy */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 76d2fa3..9b14f3b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1911,7 +1911,7 @@ static int ixgbe_check_link_t_X550em(struct ixgbe_hw *hw,\n \t\t\t\t bool *link_up,\n \t\t\t\t bool link_up_wait_to_complete)\n {\n-\tu32 status;\n+\tint status;\n \tu16 i, autoneg_status;\n \n \tif (hw->mac.ops.get_media_type(hw) != ixgbe_media_type_copper)\n@@ -2330,7 +2330,7 @@ static int ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,\n static int ixgbe_get_lasi_ext_t_x550em(struct ixgbe_hw *hw, bool *lsc,\n \t\t\t\t bool *is_overtemp)\n {\n-\tu32 status;\n+\tint status;\n \tu16 reg;\n \n \t*is_overtemp = false;\n@@ -2418,7 +2418,7 @@ static int ixgbe_get_lasi_ext_t_x550em(struct ixgbe_hw *hw, bool *lsc,\n static int ixgbe_enable_lasi_ext_t_x550em(struct ixgbe_hw *hw)\n {\n \tbool lsc, overtemp;\n-\tu32 status;\n+\tint status;\n \tu16 reg;\n \n \t/* Clear interrupt flags */\n@@ -2512,7 +2512,7 @@ static int ixgbe_handle_lasi_ext_t_x550em(struct ixgbe_hw *hw,\n {\n \tstruct ixgbe_phy_info *phy = &hw->phy;\n \tbool lsc;\n-\tu32 status;\n+\tint status;\n \n \tstatus = ixgbe_get_lasi_ext_t_x550em(hw, &lsc, is_overtemp);\n \tif (status)\n@@ -2606,7 +2606,7 @@ static int ixgbe_setup_kr_x550em(struct ixgbe_hw *hw)\n **/\n static int ixgbe_ext_phy_t_x550em_get_link(struct ixgbe_hw *hw, bool *link_up)\n {\n-\tu32 ret;\n+\tint ret;\n \tu16 autoneg_status;\n \n \t*link_up = false;\n@@ -2642,7 +2642,7 @@ static int ixgbe_setup_internal_phy_t_x550em(struct ixgbe_hw *hw)\n {\n \tixgbe_link_speed force_speed;\n \tbool link_up;\n-\tu32 status;\n+\tint status;\n \tu16 speed;\n \n \tif (hw->mac.ops.get_media_type(hw) != ixgbe_media_type_copper)\n", "prefixes": [ "iwl-next", "2/8" ] }