Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234673/?format=api
{ "id": 2234673, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234673/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260507234413.643512-4-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507234413.643512-4-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2026-05-07T23:43:16", "name": "[v4,03/60] target/arm: Implement FEAT_FAMINMAX for SME", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dc4651444e17753b9c5784a75664a7ff567bf5cd", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/1.2/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260507234413.643512-4-richard.henderson@linaro.org/mbox/", "series": [ { "id": 503296, "url": "http://patchwork.ozlabs.org/api/1.2/series/503296/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503296", "date": "2026-05-07T23:43:14", "name": "target/arm: Implement FEAT_FP8", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/503296/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234673/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=RoZdHPNZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBTVp28Xsz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 09:49:22 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wL8OH-0000Bd-5G; Thu, 07 May 2026 19:44:25 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wL8OD-00008g-BN\n for qemu-devel@nongnu.org; Thu, 07 May 2026 19:44:21 -0400", "from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wL8OB-0000ys-Ow\n for qemu-devel@nongnu.org; Thu, 07 May 2026 19:44:21 -0400", "by mail-ot1-x32b.google.com with SMTP id\n 46e09a7af769-7dea1272943so885848a34.0\n for <qemu-devel@nongnu.org>; Thu, 07 May 2026 16:44:19 -0700 (PDT)", "from stoup.attlocal.net ([2600:381:c938:6375:9641:bbb2:a93a:bb4c])\n by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7e367d8feb1sm84320a34.23.2026.05.07.16.44.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 16:44:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778197458; x=1778802258; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=f9icdZxYx+oMiDyU4sbRQtkDtk863yHoHjjLPL4BYJo=;\n b=RoZdHPNZ/M6101hp3ZMVYPM62R/UOJDlv+Twt23pWX8p1QDUF4+ZwxwDc/jndoWqI1\n /szGC9B1W2G9a+bVh/gs2stwp1Vz/tAj7PshMruEpZJTfDV99CFrr+vVH0VEeWmi8Bjy\n AjjfFw27hU6M0anCCGE0Fx4lzF69xPPFczWgZyUYjJbgDYyaqC/GJ9mqjVF1JFPFyDS8\n pFn6NwhuBajwWAgTAoiNWULCCrUlsQtErPR8H79zUsOSjKf7V694Znfm6l6D5PJRvhR3\n +4ieXYGsrQ2DOtGr5NYv07DNlV49Ui+f14A94VsehHx2+AqTWnfkgiMVe1T/bstIFC3k\n d/Rw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778197458; x=1778802258;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=f9icdZxYx+oMiDyU4sbRQtkDtk863yHoHjjLPL4BYJo=;\n b=pCS+nJvW6OLPauF5FblcYbxPxw2pXIkPHUM3+V4A3s3wJHhKju8rLpXXU48icTrDOe\n CGgKy5ieDCe/3GFOM/CsvhXS8XuLLUfKaPT+co0XrSifzJEO9liyQSzxAaBJfrDF+A2L\n kelRzKgfeRMW+09odxgFjF7Q2x3xmYjKegZtOg7cW0eu6gQsTEXUQWa3EIxGhI8RXlbp\n nIOmrmibSo7JZ7HGMIYZRtYoc2YW/7GOrkSwWh9+ZGCtDW2JRCylDNwPTLn+bpy3gAYh\n GrbexbRUmTyjogj7NYw8P8VW8O3NNb9MwAgf86CpkqXYR2uZP1RRiMsyK/IlwFIEkUjf\n Dnrg==", "X-Gm-Message-State": "AOJu0YxX7/m084zRbbyWN5EkUiKDoP0X5NTdsHrnf6IbVyyztPON5AHD\n ++5jjH3X0POcy5g+OYSoJ7HacmX9MZLK6teGplcY4o4D7n7bvfDh4vc+7G4KRi/LsE4df8lT9Mt\n OcGDC", "X-Gm-Gg": "AeBDieuO0R9CxdjShjOOXTD09O9qGs1yxhk5pgk+JqX8ewaJ7SV6twvDY1qd9JNsptn\n btrkA9fm+N0+Ad26TA8nPGZ57O9IZTVzG/BemDrjxst+Q/I93lZSpCosyYcgJbhFrssUBjhOnhl\n ZGwFBFXXB63bbnDJ3vy11OGu6Zr+bcUNEfP0B2dCSNTgbCijNZhl/Prsd3khMekEzrkk9K9GmBP\n AVFZDBii6ZTV3Qg+9cxVki1hYBUFvUmk1nWqHe1yN/w+xMIGYoFJubngduxx1+OdVenBfxeIuDV\n /6SuysYro5g3CVvMf+YuSuCd8//oQjWsoChQ3XNa5aZdjKygB0MAbpwwn0pETHTnOOexyh2W9k3\n U3zRxb6WTdK5/wQjUTwot9CHAsK2vNflK6AscF+5JMkllf+qmUE8TJ7j4XS+J+/zg4lqjBJ5oEc\n cqMwmlsGqVoUstHL659dAXkchq1nKk27Xl/v15WzN4Re1Naw==", "X-Received": "by 2002:a05:6830:d8d:b0:7d7:c96c:c5d6 with SMTP id\n 46e09a7af769-7e1dee2eb3bmr6459062a34.1.1778197458590;\n Thu, 07 May 2026 16:44:18 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org", "Subject": "[PATCH v4 03/60] target/arm: Implement FEAT_FAMINMAX for SME", "Date": "Thu, 7 May 2026 18:43:16 -0500", "Message-ID": "<20260507234413.643512-4-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260507234413.643512-1-richard.henderson@linaro.org>", "References": "<20260507234413.643512-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::32b;\n envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32b.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Since there is no bfloat16 variant of FAMINMAX,\ncheck for missing function pointer in do_z2z_nn_fpst.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n target/arm/cpu-features.h | 5 +++++\n target/arm/tcg/translate-sme.c | 23 +++++++++++++++++++++--\n target/arm/tcg/sme.decode | 5 +++++\n 3 files changed, 31 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h\nindex 21d0be73cd..fe5d3a1635 100644\n--- a/target/arm/cpu-features.h\n+++ b/target/arm/cpu-features.h\n@@ -1587,6 +1587,11 @@ static inline bool isar_feature_aa64_sme2_f64f64(const ARMISARegisters *id)\n return isar_feature_aa64_sme2(id) && isar_feature_aa64_sme_f64f64(id);\n }\n \n+static inline bool isar_feature_aa64_sme2_faminmax(const ARMISARegisters *id)\n+{\n+ return isar_feature_aa64_sme2(id) && isar_feature_aa64_faminmax(id);\n+}\n+\n static inline bool isar_feature_aa64_sve_i8mm(const ARMISARegisters *id)\n {\n return isar_feature_aa64_sve(id) && isar_feature_aa64_sme_sve_i8mm(id);\ndiff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c\nindex 08254b088e..a67501226f 100644\n--- a/target/arm/tcg/translate-sme.c\n+++ b/target/arm/tcg/translate-sme.c\n@@ -19,6 +19,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"cpu.h\"\n+#include \"helper-a64.h\"\n #include \"helper-sme.h\"\n #include \"helper-sve.h\"\n #include \"translate.h\"\n@@ -742,9 +743,12 @@ static bool do_z2z_nn_fpst(DisasContext *s, arg_z2z_en *a,\n gen_helper_gvec_3_ptr * const fns[4])\n {\n int esz = a->esz, n, dn, dm, vsz;\n- gen_helper_gvec_3_ptr *fn;\n+ gen_helper_gvec_3_ptr *fn = fns[esz];\n TCGv_ptr fpst;\n \n+ if (fn == NULL) {\n+ return false;\n+ }\n if (esz == MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) {\n return false;\n }\n@@ -753,7 +757,6 @@ static bool do_z2z_nn_fpst(DisasContext *s, arg_z2z_en *a,\n }\n \n fpst = fpstatus_ptr(esz == MO_16 ? FPST_A64_F16 : FPST_A64);\n- fn = fns[esz];\n n = a->n;\n dn = a->zdn;\n dm = a->zm;\n@@ -812,6 +815,22 @@ static gen_helper_gvec_3_ptr * const f_vector_fminnm[4] = {\n TRANS_FEAT(FMINNM_n1, aa64_sme2, do_z2z_n1_fpst, a, f_vector_fminnm)\n TRANS_FEAT(FMINNM_nn, aa64_sme2, do_z2z_nn_fpst, a, f_vector_fminnm)\n \n+static gen_helper_gvec_3_ptr * const f_vector_famax[4] = {\n+ NULL,\n+ gen_helper_gvec_famax_h,\n+ gen_helper_gvec_famax_s,\n+ gen_helper_gvec_famax_d,\n+};\n+TRANS_FEAT(FAMAX_nn, aa64_sme2_faminmax, do_z2z_nn_fpst, a, f_vector_famax)\n+\n+static gen_helper_gvec_3_ptr * const f_vector_famin[4] = {\n+ NULL,\n+ gen_helper_gvec_famin_h,\n+ gen_helper_gvec_famin_s,\n+ gen_helper_gvec_famin_d,\n+};\n+TRANS_FEAT(FAMIN_nn, aa64_sme2_faminmax, do_z2z_nn_fpst, a, f_vector_famin)\n+\n /* Add/Sub vector Z[m] to each Z[n*N] with result in ZA[d*N]. */\n static bool do_azz_n1(DisasContext *s, arg_azz_n *a, int esz,\n GVecGen3FnVar *fn)\ndiff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode\nindex 6bb9aa2a90..9dec7318a4 100644\n--- a/target/arm/tcg/sme.decode\n+++ b/target/arm/tcg/sme.decode\n@@ -286,6 +286,11 @@ URSHL_nn 1100000 1 .. 1 ..... 1011.0 10001 .... 1 @z2z_4x4\n SQDMULH_nn 1100000 1 .. 1 ..... 1011.1 00000 .... 0 @z2z_2x2\n SQDMULH_nn 1100000 1 .. 1 ..... 1011.1 00000 .... 0 @z2z_4x4\n \n+FAMAX_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 0 @z2z_2x2\n+FAMAX_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 0 @z2z_4x4\n+FAMIN_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 1 @z2z_2x2\n+FAMIN_nn 1100000 1 .. 1 ..... 1011.0 01010 .... 1 @z2z_4x4\n+\n ### SME2 Multi-vector Multiple and Single Array Vectors\n \n &azz_n n off rv zn zm\n", "prefixes": [ "v4", "03/60" ] }