Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234476/?format=api
{ "id": 2234476, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-25-93453e1a9597@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507-winbond-v6-18-rc1-spi-nor-swp-v5-25-93453e1a9597@bootlin.com>", "list_archive_url": null, "date": "2026-05-07T16:47:06", "name": "[v5,25/28] mtd: spi-nor: winbond: Add W25H02NWxxAM CMP locking support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8594bb6b2c7cf7e6d95c32fd30004e7748108c22", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-25-93453e1a9597@bootlin.com/mbox/", "series": [ { "id": 503226, "url": "http://patchwork.ozlabs.org/api/1.2/series/503226/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=503226", "date": "2026-05-07T16:46:51", "name": "mtd: spi-nor: Enhance software protection", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/503226/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234476/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zmlfPsDh;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=bMjqEd60;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=vKwYPBrS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBJ8S5Gykz1yMj\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 02:47:52 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1t5-00000004Nrk-22LG;\n\tThu, 07 May 2026 16:47:47 +0000", "from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1t3-00000004NnN-0blw\n\tfor linux-mtd@bombadil.infradead.org;\n\tThu, 07 May 2026 16:47:45 +0000", "from smtpout-04.galae.net ([185.171.202.116])\n\tby desiato.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1sz-000000046M7-2PLA\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 07 May 2026 16:47:44 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-04.galae.net (Postfix) with ESMTPS id 1110EC5DC60;\n\tThu, 7 May 2026 16:48:29 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 45842605CF;\n\tThu, 7 May 2026 16:47:41 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 993E7108194ED;\n\tThu, 7 May 2026 18:47:38 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=8VhNmEUCc7vRDykUGZGBxZ/QiPuNxYX7DpeWiNtvgq4=; b=zmlfPsDhHsFJWX\n\t3v22cOd0uzA2Ec6gKQZDWI/RBp+e5v9nUdhesrA2piiOScAFC6BkKsST8KYVNXPDYxpLKcq8fPfyy\n\tv/3l3QeNt8KWjIRSMTF2oDBXgDIXTdc4lsxjcQV71fkb9i27cauzpU8D0cfWq43X9JLaU0ymP1bdP\n\tpjcA1mu/isIlMKx31pxaJIlVBd8rBkxXSjySjPNUYca49GquJGSi7zib3MxgHYV5HDrHtgqb9KX2Y\n\tOHgTMtRF59wpvHEdlHcDolAP/7YbInc5qJZzvG7vh8yIm00eIfxmsAP95YQeSudqlORjudQS7CaoI\n\tPGe17E6EjbvKQYsjh88A==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References:\n\tMessage-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:\n\tFrom:Sender:Reply-To:Content-ID:Content-Description;\n\tbh=edSYQazxhakuu8k26vId3X0/S/a6bSHMtg1O+5hvsoM=; b=bMjqEd60f1oAJevXRWmilHHe2Z\n\tdlHe/DDRRTnxlwuOn2WoaDpik1o+G7CMwJD3yx6uP8EbMOM04AjvijBz8Z1ecHyY1Jru8R3VotgxK\n\th41G8XKRNTdGmMfMKMsCwmEImkN7zXZrywS0G12bvToTTn0qEelneGDBWIU0vTi/tq+qbK2Y+Qxza\n\tnmIdWiAZX4Avpi7Ldm1XUQEXA+k5DLPnFYcR9eZX/zGukDUp4Q43n62j9PvS2kZ3tnmKWJdJhoves\n\tXysYBkU4SLnQQFKszn5ztPdocw3Nz0ZuTEn7c02pJzZkk/xUPtYsfot/t9vUjcZCIX+tFFVgIesmd\n\tL8FMcV7g==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1778172460; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=edSYQazxhakuu8k26vId3X0/S/a6bSHMtg1O+5hvsoM=;\n\tb=vKwYPBrS4YjVoVEO4GxXcjYXKV+h72br8aWoMtv0FhCJ5KuSeBmfu3DIDU4ECsReg6P0ca\n\tEfguaW25dJKf3N5wm4kQ3tCe6HS4cg1fUNfZfXBOvTxqU70TOC5Oh6z+PtrhlIoBhmPiDD\n\thdBgu664mNRAffAJHuC26Q5IOImFvrftq9xCYsK4d/hMlENhGT+3e6QBCqyKkEs5zICihR\n\tTHTxfOZIrdeFRZg4g7lchfeulBO6+SFiq8+UA6TtQDcoar3BIjrQOrgLU4wNdZmfxFHWBu\n\tihb7sENefFdmMfUuEw8a6WyHMzZSeTzNF7zg9KfZzYu+En1sxhmtpDiAFb3bow==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Thu, 07 May 2026 18:47:06 +0200", "Subject": "[PATCH v5 25/28] mtd: spi-nor: winbond: Add W25H02NWxxAM CMP\n locking support", "MIME-Version": "1.0", "Message-Id": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-25-93453e1a9597@bootlin.com>", "References": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "In-Reply-To": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>, Tudor Ambarus <tudor.ambarus@linaro.org>,\n Shuah Khan <skhan@linuxfoundation.org>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260507_174742_002919_D9BC6F4F ", "X-CRM114-Status": "GOOD ( 14.80 )", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: This chip has support for the locking complement (CMP)\n feature.\n Add the relevant bit to enable it. Unfortunately,\n this chip also comes with\n an incorrect BFPT table,\n indicating the Control Register cannot be read back.\n This is wrong, reading back the register works and has no (observed) side\n effect. [...]\n Content analysis details: (-0.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.0 DMARC_PASS DMARC pass policy", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "This chip has support for the locking complement (CMP) feature. Add\nthe relevant bit to enable it.\n\nUnfortunately, this chip also comes with an incorrect BFPT table,\nindicating the Control Register cannot be read back. This is wrong,\nreading back the register works and has no (observed) side effect. The\ndatasheet clearly indicates supporting the 35h command and all bits from\nthe CR are marked readable. QE and CMP bits are inside, and can be\nproperly read back.\n\nAdd a fixup for this, otherwise it would defeat the use of the CMP\nfeature.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\nTest run with W25H02NWxxAM:\n$ flash_lock -u /dev/mtd0\n$ flash_lock -l /dev/mtd0 $bs $all_but_one # all but the first\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0000ffff | unlocked | 1\n 00010000-0fffffff | locked | 4095\n$ flash_lock -u /dev/mtd0 $bs 1 # all but the two first\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0001ffff | unlocked | 2\n 00020000-0fffffff | locked | 4094\n$ flash_lock -u /dev/mtd0\n$ flash_lock -l /dev/mtd0 0 $all_but_one # same from the other side\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0ffeffff | locked | 4095\n 0fff0000-0fffffff | unlocked | 1\n$ flash_lock -u /dev/mtd0 $(($size - (2 * $bs))) 1 # all but two\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0ffdffff | locked | 4094\n 0ffe0000-0fffffff | unlocked | 2\n---\n drivers/mtd/spi-nor/winbond.c | 24 +++++++++++++++++++++++-\n 1 file changed, 23 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c\nindex 7628fa7fb64f..2c48d6c4a0aa 100644\n--- a/drivers/mtd/spi-nor/winbond.c\n+++ b/drivers/mtd/spi-nor/winbond.c\n@@ -73,6 +73,26 @@ static const struct spi_nor_fixups w25q256_fixups = {\n \t.post_bfpt = w25q256_post_bfpt_fixups,\n };\n \n+static int\n+winbond_rdcr_post_bfpt_fixup(struct spi_nor *nor,\n+\t\t\t const struct sfdp_parameter_header *bfpt_header,\n+\t\t\t const struct sfdp_bfpt *bfpt)\n+{\n+\t/*\n+\t * W25H02NW, unlike its W25H512NW nor W25H01NW cousins, improperly sets\n+\t * the QE BFPT configuration bits, indicating a non readable CR. This is\n+\t * both incorrect and impractical, as the chip features a CMP bit for its\n+\t * locking scheme that lays in the Control Register, and needs to be read.\n+\t */\n+\tnor->flags &= ~SNOR_F_NO_READ_CR;\n+\n+\treturn 0;\n+}\n+\n+static const struct spi_nor_fixups winbond_rdcr_fixup = {\n+\t.post_bfpt = winbond_rdcr_post_bfpt_fixup,\n+};\n+\n /**\n * winbond_nor_select_die() - Set active die.\n * @nor:\tpointer to 'struct spi_nor'.\n@@ -370,7 +390,9 @@ static const struct flash_info winbond_nor_parts[] = {\n \t}, {\n \t\t/* W25H02NWxxAM */\n \t\t.id = SNOR_ID(0xef, 0xa0, 0x22),\n-\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_NOR_4BIT_BP,\n+\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 |\n+\t\t\t SPI_NOR_4BIT_BP | SPI_NOR_HAS_CMP,\n+\t\t.fixups = &winbond_rdcr_fixup,\n \t},\n };\n \n", "prefixes": [ "v5", "25/28" ] }