Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234470/?format=api
{ "id": 2234470, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234470/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-17-93453e1a9597@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507-winbond-v6-18-rc1-spi-nor-swp-v5-17-93453e1a9597@bootlin.com>", "list_archive_url": null, "date": "2026-05-07T16:46:58", "name": "[v5,17/28] mtd: spi-nor: Create a local SR cache", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "67b387f107fa02f0d052b711eacf4396efda90bb", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-17-93453e1a9597@bootlin.com/mbox/", "series": [ { "id": 503226, "url": "http://patchwork.ozlabs.org/api/1.2/series/503226/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=503226", "date": "2026-05-07T16:46:51", "name": "mtd: spi-nor: Enhance software protection", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/503226/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234470/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0FscYMKQ;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=VLTOP8FN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBJ870Tmrz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 02:47:35 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1so-00000004NRa-3ght;\n\tThu, 07 May 2026 16:47:30 +0000", "from smtpout-02.galae.net ([185.246.84.56])\n\tby bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1sm-00000004NLY-0iFT\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 07 May 2026 16:47:29 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-02.galae.net (Postfix) with ESMTPS id B4E9D1A355C;\n\tThu, 7 May 2026 16:47:26 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 830E0605CF;\n\tThu, 7 May 2026 16:47:26 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 580A3108194E4;\n\tThu, 7 May 2026 18:47:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=vGb2kzhElyS6nC2pvXa95nOZG5aVxL6xdnLN0h/HHcE=; b=0FscYMKQel+E6V\n\tOo5lQSTpW0HpbTj47zXdNjE7SzOLGyW8FluTrz/TrU3a0NfwCaWUOd8W8DTWar+vlDS23I+5At1nZ\n\tuBkcNVRfXhZtYcQSOFIr94Gx4XHBPr+GKsDvAInc818EA+XF50VZm+eKjrsF0qdX1tf3EerM5MhiT\n\tqa4+VGa3IiKYced/8zQMXgz4uUlt2xt/9pPbbPQfScYe6Sn8DVldb7fKtPC3mO7h5R+UK3vEA1JwV\n\tHpu28d+xDa4efTKGf+f/rteCWL0ifc+V7RufGAPvod/1d2tdyVyuJ119VzZWMGHnFjWdzowrlnDlC\n\t9KbHaIoCVq5htw/2eMAA==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1778172444; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=tyk4eiCefGG1PtqLnRTT3btja7/h8QBKgIFeSq5ePuk=;\n\tb=VLTOP8FNVo6lLMxRzSz8X0EcPKhzT0LxEj/GsssLOcevgWVrekxFgzMUbT1BBwQ35aG4CZ\n\tKaLk2Tc/KPaXYtWmALW4xAreUbbUjKLAEt2n9jllWR1xIZsx+pk84frweRHTcQeEfbjsNu\n\tRI/aWUTEFQp9ZXNUMrB3llQXOOPs89QlkJ6btlHmwMs6I0tqG0aLncWEX7w1rJr/4WwPhG\n\tOOveUcL+MrQjK334bJnDpAILMxEjT8BgFIrL1VdG3Go+fltDp4fnPDrYmvCWwhynj4Ocho\n\tMbtdYhG2CuWRbjIobdQc+ytn3LMKGjH/oVjXihHt2M9DgdCw8VAT8eTtRp/hCw==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Thu, 07 May 2026 18:46:58 +0200", "Subject": "[PATCH v5 17/28] mtd: spi-nor: Create a local SR cache", "MIME-Version": "1.0", "Message-Id": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-17-93453e1a9597@bootlin.com>", "References": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "In-Reply-To": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>, Tudor Ambarus <tudor.ambarus@linaro.org>,\n Shuah Khan <skhan@linuxfoundation.org>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260507_094728_351470_1810A12A ", "X-CRM114-Status": "GOOD ( 18.54 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: In order to be able to generate debugfs output without\n having\n to actually reach the flash,\n create a SPI NOR local cache of the status registers.\n What matters in our case are all the bits related to se [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DMARC_PASS DMARC pass policy", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "In order to be able to generate debugfs output without having to\nactually reach the flash, create a SPI NOR local cache of the status\nregisters. What matters in our case are all the bits related to sector\nlocking. As such, in order to make it clear that this cache is not\nintended to be used anywhere else, we zero the irrelevant bits.\n\nThe cache is initialized once during the early init, and then maintained\nevery time the write protection scheme is updated.\n\nSuggested-by: Michael Walle <mwalle@kernel.org>\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/spi-nor/core.c | 6 +++++-\n drivers/mtd/spi-nor/core.h | 1 +\n drivers/mtd/spi-nor/swp.c | 35 +++++++++++++++++++++++++++++++++--\n include/linux/mtd/spi-nor.h | 2 ++\n 4 files changed, 41 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c\nindex 2799c21d0b67..cdca0fd881a3 100644\n--- a/drivers/mtd/spi-nor/core.c\n+++ b/drivers/mtd/spi-nor/core.c\n@@ -3328,8 +3328,12 @@ static int spi_nor_init(struct spi_nor *nor)\n \t */\n \tif (IS_ENABLED(CONFIG_MTD_SPI_NOR_SWP_DISABLE) ||\n \t (IS_ENABLED(CONFIG_MTD_SPI_NOR_SWP_DISABLE_ON_VOLATILE) &&\n-\t nor->flags & SNOR_F_SWP_IS_VOLATILE))\n+\t nor->flags & SNOR_F_SWP_IS_VOLATILE)) {\n \t\tspi_nor_try_unlock_all(nor);\n+\t} else {\n+\t\t/* In the other cases, make sure the debugfs SR cache is up to date */\n+\t\tspi_nor_cache_sr_lock_bits(nor, NULL);\n+\t}\n \n \tif (nor->addr_nbytes == 4 &&\n \t nor->read_proto != SNOR_PROTO_8_8_8_DTR &&\ndiff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h\nindex 7f92586b326b..16bf6190e55a 100644\n--- a/drivers/mtd/spi-nor/core.h\n+++ b/drivers/mtd/spi-nor/core.h\n@@ -679,6 +679,7 @@ int spi_nor_post_bfpt_fixups(struct spi_nor *nor,\n \n void spi_nor_init_default_locking_ops(struct spi_nor *nor);\n void spi_nor_try_unlock_all(struct spi_nor *nor);\n+void spi_nor_cache_sr_lock_bits(struct spi_nor *nor, u8 *sr);\n void spi_nor_set_mtd_locking_ops(struct spi_nor *nor);\n void spi_nor_set_mtd_otp_ops(struct spi_nor *nor);\n \ndiff --git a/drivers/mtd/spi-nor/swp.c b/drivers/mtd/spi-nor/swp.c\nindex c22cb094b66a..2455f1f6fdf1 100644\n--- a/drivers/mtd/spi-nor/swp.c\n+++ b/drivers/mtd/spi-nor/swp.c\n@@ -162,6 +162,25 @@ static int spi_nor_build_sr(struct spi_nor *nor, const u8 *old_sr, u8 *new_sr,\n \treturn 0;\n }\n \n+/*\n+ * Keep a local cache containing all lock-related bits for debugfs use only.\n+ * This way, debugfs never needs to access the flash directly.\n+ */\n+void spi_nor_cache_sr_lock_bits(struct spi_nor *nor, u8 *sr)\n+{\n+\tu8 bp_mask = spi_nor_get_sr_bp_mask(nor);\n+\tu8 tb_mask = spi_nor_get_sr_tb_mask(nor);\n+\n+\tif (!sr) {\n+\t\tif (spi_nor_read_sr(nor, nor->bouncebuf))\n+\t\t\treturn;\n+\n+\t\tsr = nor->bouncebuf;\n+\t}\n+\n+\tnor->dfs_sr_cache[0] = sr[0] & (bp_mask | tb_mask | SR_SRWD);\n+}\n+\n /*\n * Lock a region of the flash. Compatible with ST Micro and similar flash.\n * Supports the block protection bits BP{0,1,2}/BP{0,1,2,3} in the status\n@@ -271,7 +290,13 @@ static int spi_nor_sr_lock(struct spi_nor *nor, loff_t ofs, u64 len)\n \t (ofs_old < ofs_new || (ofs_new + len_new) < (ofs_old + len_old)))\n \t\treturn -EINVAL;\n \n-\treturn spi_nor_write_sr_and_check(nor, status_new[0]);\n+\tret = spi_nor_write_sr_and_check(nor, status_new[0]);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tspi_nor_cache_sr_lock_bits(nor, status_new);\n+\n+\treturn 0;\n }\n \n /*\n@@ -353,7 +378,13 @@ static int spi_nor_sr_unlock(struct spi_nor *nor, loff_t ofs, u64 len)\n \t (ofs_new < ofs_old || (ofs_old + len_old) < (ofs_new + len_new)))\n \t\treturn -EINVAL;\n \n-\treturn spi_nor_write_sr_and_check(nor, status_new[0]);\n+\tret = spi_nor_write_sr_and_check(nor, status_new[0]);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tspi_nor_cache_sr_lock_bits(nor, status_new);\n+\n+\treturn 0;\n }\n \n /*\ndiff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h\nindex 90a0cf583512..9ad77f9e76c2 100644\n--- a/include/linux/mtd/spi-nor.h\n+++ b/include/linux/mtd/spi-nor.h\n@@ -371,6 +371,7 @@ struct spi_nor_flash_parameter;\n * @reg_proto:\t\tthe SPI protocol for read_reg/write_reg/erase operations\n * @sfdp:\t\tthe SFDP data of the flash\n * @debugfs_root:\tpointer to the debugfs directory\n+ * @dfs_sr_cache:\tStatus Register cached value for debugfs use only\n * @controller_ops:\tSPI NOR controller driver specific operations.\n * @params:\t\t[FLASH-SPECIFIC] SPI NOR flash parameters and settings.\n * The structure includes legacy flash parameters and\n@@ -409,6 +410,7 @@ struct spi_nor {\n \tenum spi_nor_cmd_ext\tcmd_ext_type;\n \tstruct sfdp\t\t*sfdp;\n \tstruct dentry\t\t*debugfs_root;\n+\tu8\t\t\tdfs_sr_cache[2];\n \n \tconst struct spi_nor_controller_ops *controller_ops;\n \n", "prefixes": [ "v5", "17/28" ] }