Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234469/?format=api
{ "id": 2234469, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234469/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-16-93453e1a9597@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507-winbond-v6-18-rc1-spi-nor-swp-v5-16-93453e1a9597@bootlin.com>", "list_archive_url": null, "date": "2026-05-07T16:46:57", "name": "[v5,16/28] mtd: spi-nor: swp: Cosmetic changes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ff8ac70f965aa7669ad88678e0f4d7c30495edf5", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-16-93453e1a9597@bootlin.com/mbox/", "series": [ { "id": 503226, "url": "http://patchwork.ozlabs.org/api/1.2/series/503226/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=503226", "date": "2026-05-07T16:46:51", "name": "mtd: spi-nor: Enhance software protection", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/503226/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234469/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TM6u7x6x;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=zy6DB3nV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBJ842ftTz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 02:47:32 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1sl-00000004NMP-2vjN;\n\tThu, 07 May 2026 16:47:27 +0000", "from smtpout-03.galae.net ([185.246.85.4])\n\tby bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1sj-00000004NHU-1vNO\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 07 May 2026 16:47:26 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 0BB1C4E42C13;\n\tThu, 7 May 2026 16:47:24 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id D224A605CF;\n\tThu, 7 May 2026 16:47:23 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id C142410819513;\n\tThu, 7 May 2026 18:47:20 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=h1wDxzm74mtDpylsXGoci33f1E1RYolMLBR8suXJJPs=; b=TM6u7x6x+ZSiT6\n\ti/gx0tcYEm7UWmecbiCq7f+YHP6+F6ETNUt09ajQ9xiJKBq0q8XBinMN+NksqB4GmD3XPkJgPCtfz\n\tSVGtXa22Ytnc1TsmA11+pEv59xEJQTsGpokgbTih8suTKH5k016pEhosvMlgfyD5hEiDMPZ6H8l0f\n\t7ziOFUFpiYvEXEWpi7/fp5fJ29tPw2oYI2n0aFNLVwDy9u0cI90UfyWHEKB+OIPhVhfIZ4rCXWHBq\n\tBxnqEKaP20xF8tNm3EimTR7+vR8kcT9Mrxt7sa0GRh0CNRjqbu2pkeYwyq065bKGc2FvsKkBoQXVP\n\tN5Ek9ELLx1o1R8wD6J4w==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1778172442; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=VwHLR/6FdLe2ctHkVMRBIz8NPLwLgjKVBhP9hMYrXR0=;\n\tb=zy6DB3nV6oAE3PJCl5cdzL8PtXv0m6T95+5EHUpdg5IS9ykrueUm4idF9usvfxTrowWle8\n\tgMasWrMLSBzjqiiaeZ+AVNuDNRN/ZcymD61CT/nB5vfoGz4U4LiHpo92dCCo5C+Wa7jJ3n\n\tsrCjDBfu0mAPNAg1ej/JelEkB9Ij+X8iWB7LdSUYh6mhOqF/uIIhv4DiG67UiiG1ZhCl2a\n\t7SKTXGTiY0GIO7JCma03J/aeqIHrnwoVV305N5TPc/J7KcYbJ2Uce5mT88aw4YIeoHPnlq\n\t/8dhAYTtU2hlQ7HCI459GD2eu3kkbbRkR8njGXUCWomUHFwruo8+AqUNAS2q5Q==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Thu, 07 May 2026 18:46:57 +0200", "Subject": "[PATCH v5 16/28] mtd: spi-nor: swp: Cosmetic changes", "MIME-Version": "1.0", "Message-Id": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-16-93453e1a9597@bootlin.com>", "References": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "In-Reply-To": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>, Tudor Ambarus <tudor.ambarus@linaro.org>,\n Shuah Khan <skhan@linuxfoundation.org>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260507_094725_653518_362E3DD3 ", "X-CRM114-Status": "GOOD ( 10.81 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: As a final preparation step for the introduction of CMP\n support,\n make a few more cosmetic changes to simplify the reading of the diff when\n adding the CMP feature. In particular, define \"min_prot_len\" [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DMARC_PASS DMARC pass policy", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "As a final preparation step for the introduction of CMP support, make\na few more cosmetic changes to simplify the reading of the diff when\nadding the CMP feature. In particular, define \"min_prot_len\" earlier as\nit will be reused and move the definition of the \"ret\" variable at the\nend of the stack just because it looks better.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/spi-nor/swp.c | 19 +++++++------------\n 1 file changed, 7 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/mtd/spi-nor/swp.c b/drivers/mtd/spi-nor/swp.c\nindex a45627380363..c22cb094b66a 100644\n--- a/drivers/mtd/spi-nor/swp.c\n+++ b/drivers/mtd/spi-nor/swp.c\n@@ -197,14 +197,14 @@ static int spi_nor_build_sr(struct spi_nor *nor, const u8 *old_sr, u8 *new_sr,\n */\n static int spi_nor_sr_lock(struct spi_nor *nor, loff_t ofs, u64 len)\n {\n-\tu64 min_prot_len;\n-\tint ret;\n+\tu64 min_prot_len = spi_nor_get_min_prot_length_sr(nor);\n \tu8 status_old[1] = {}, status_new[1] = {};\n \tloff_t ofs_old, ofs_new;\n \tu64 len_old, len_new;\n \tloff_t lock_len;\n \tbool can_be_top = true, can_be_bottom = nor->flags & SNOR_F_HAS_SR_TB;\n \tbool use_top;\n+\tint ret;\n \tu8 pow;\n \n \tret = spi_nor_read_sr(nor, nor->bouncebuf);\n@@ -238,12 +238,10 @@ static int spi_nor_sr_lock(struct spi_nor *nor, loff_t ofs, u64 len)\n \telse\n \t\tlock_len = ofs + len;\n \n-\tif (lock_len == nor->params->size) {\n+\tif (lock_len == nor->params->size)\n \t\tpow = (nor->flags & SNOR_F_HAS_4BIT_BP) ? GENMASK(3, 0) : GENMASK(2, 0);\n-\t} else {\n-\t\tmin_prot_len = spi_nor_get_min_prot_length_sr(nor);\n+\telse\n \t\tpow = ilog2(lock_len) - ilog2(min_prot_len) + 1;\n-\t}\n \n \tret = spi_nor_build_sr(nor, status_old, status_new, pow, use_top);\n \tif (ret)\n@@ -283,7 +281,7 @@ static int spi_nor_sr_lock(struct spi_nor *nor, loff_t ofs, u64 len)\n */\n static int spi_nor_sr_unlock(struct spi_nor *nor, loff_t ofs, u64 len)\n {\n-\tu64 min_prot_len;\n+\tu64 min_prot_len = spi_nor_get_min_prot_length_sr(nor);\n \tint ret;\n \tu8 status_old[1], status_new[1];\n \tloff_t ofs_old, ofs_new;\n@@ -331,14 +329,11 @@ static int spi_nor_sr_unlock(struct spi_nor *nor, loff_t ofs, u64 len)\n \telse\n \t\tlock_len = ofs;\n \n-\tif (lock_len == 0) {\n+\tif (lock_len == 0)\n \t\tpow = 0; /* fully unlocked */\n-\t} else {\n-\t\tmin_prot_len = spi_nor_get_min_prot_length_sr(nor);\n+\telse\n \t\tpow = ilog2(lock_len) - ilog2(min_prot_len) + 1;\n \n-\t}\n-\n \tret = spi_nor_build_sr(nor, status_old, status_new, pow, use_top);\n \tif (ret)\n \t\treturn ret;\n", "prefixes": [ "v5", "16/28" ] }