Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234458/?format=api
{ "id": 2234458, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234458/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-3-93453e1a9597@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/1.2/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507-winbond-v6-18-rc1-spi-nor-swp-v5-3-93453e1a9597@bootlin.com>", "list_archive_url": null, "date": "2026-05-07T16:46:44", "name": "[v5,03/28] mtd: spi-nor: Make sure the QE bit is kept enabled if useful", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4ce388755b77732ad014c2b521a46adeb30e6129", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/1.2/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260507-winbond-v6-18-rc1-spi-nor-swp-v5-3-93453e1a9597@bootlin.com/mbox/", "series": [ { "id": 503226, "url": "http://patchwork.ozlabs.org/api/1.2/series/503226/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=503226", "date": "2026-05-07T16:46:51", "name": "mtd: spi-nor: Enhance software protection", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/503226/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234458/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EwvOz5L9;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=dcXqUxO2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBJ7y5Qjrz23mJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 02:47:24 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1sR-00000004Mwp-1bSA;\n\tThu, 07 May 2026 16:47:07 +0000", "from smtpout-02.galae.net ([185.246.84.56])\n\tby bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux))\n\tid 1wL1sM-00000004MuS-40CP\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 07 May 2026 16:47:04 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-02.galae.net (Postfix) with ESMTPS id 8B0501A356B;\n\tThu, 7 May 2026 16:47:01 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 59213605CF;\n\tThu, 7 May 2026 16:47:01 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 4514F108194A8;\n\tThu, 7 May 2026 18:46:59 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=EKfkOVmKsrXA/5ApQUBgODZKMghL/1VPNmIhu7/GKIA=; b=EwvOz5L9HVeP1Y\n\tzS0m31Yylg7tgiXc4opYGxOQReQG0VEE01uiE5z/K5XObMZ1lRGo+P3QYsnYBJRgXLoU8mtfzw+Qk\n\tVX9e9FAS6hqdhS6OIthrn1r24057la4J4UWwcjnGLZIVaOzv8jqwB27bA6+q81axK+xuMWBQ3EGgq\n\tvAhc8Cs8KaeZ8UJlNXkrMHlBmq1K6fU7jUBwhFu1dsP7Wiur2Wvsw16HvNjsZVoezxE0STuCsMlvE\n\tGl6Wr9VfFxACpeWF3lDD8kKqYefP6nfjk/yWFdLGOy+XjzAlH47S+zakNBzEKLRCPrzBw9dhYQyX8\n\taa9ECCO76+lNzZgroz0w==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1778172420; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=r/I8HpmdlgiZEDA4JzntxIQZil5h8OVsqG1FV3N20+g=;\n\tb=dcXqUxO2tgoi2qQeatUweuEc3whB+18tPx9IUiJ/OnXR7WUd12k/11SZ2tHzoW6Waq9lqo\n\tqn/+d6PfFZnHekXaAqy2nl2SC+9Snr6iOHT0EV1Hoho+L1i0OndrLaf136lD6y22VB+AGM\n\tN9+m2za0qwGZSgAFAx3Et6nYfMLZ1dm9g0cDFqOjLYqVOciCCg8WIt1wWBucVyCQTfA3Ct\n\tymk7iysyd6aHVle/0N+5Z7zRdUsMW0iCF+dnqzWr5bs/CD5qJQnJyvhhi9bJbfNMXf00L/\n\tVNpOvJKPHtIkiCV46EeBds4b/iSHkJ42kO8uZX++PfGbOcwWaUY9JXz55aHQaA==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Thu, 07 May 2026 18:46:44 +0200", "Subject": "[PATCH v5 03/28] mtd: spi-nor: Make sure the QE bit is kept\n enabled if useful", "MIME-Version": "1.0", "Message-Id": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-3-93453e1a9597@bootlin.com>", "References": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "In-Reply-To": "\n <20260507-winbond-v6-18-rc1-spi-nor-swp-v5-0-93453e1a9597@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>, Tudor Ambarus <tudor.ambarus@linaro.org>,\n Shuah Khan <skhan@linuxfoundation.org>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260507_094703_133152_F2D2A7C9 ", "X-CRM114-Status": "GOOD ( 12.71 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Not all chips implement the 4BAIT table which typically\n indicates\n the program capability, while many of them do implement the relevant SFDP\n parts indicating the read capabilities. In such a situation, [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DMARC_PASS DMARC pass policy", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Not all chips implement the 4BAIT table which typically indicates the\nprogram capability, while many of them do implement the relevant SFDP\nparts indicating the read capabilities. In such a situation, programs\ncan happen in single mode (1-1-1) and reads in quad mode (1-1-4 or\n1-4-4). For the reads to work in such condition, the QE bit must be set.\nIn case we later use the spi_nor_write_16bit_sr_and_check() helper with\na chip with such configuration, the QE bit would get incorrectly\ncleared.\n\nMake sure this doesn't happen by keeping the QE bit under a simpler\ncondition:\n- the quad enable hook is there (no change)\n- and at least one of the two protocols is based on quad I/O cycles\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/spi-nor/core.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c\nindex 5dd0b3cb5250..394c27de02d6 100644\n--- a/drivers/mtd/spi-nor/core.c\n+++ b/drivers/mtd/spi-nor/core.c\n@@ -869,8 +869,8 @@ static int spi_nor_write_16bit_sr_and_check(struct spi_nor *nor, u8 sr1)\n \t\tret = spi_nor_read_cr(nor, &sr_cr[1]);\n \t\tif (ret)\n \t\t\treturn ret;\n-\t} else if (spi_nor_get_protocol_width(nor->read_proto) == 4 &&\n-\t\t spi_nor_get_protocol_width(nor->write_proto) == 4 &&\n+\t} else if ((spi_nor_get_protocol_width(nor->read_proto) == 4 ||\n+\t\t spi_nor_get_protocol_width(nor->write_proto) == 4) &&\n \t\t nor->params->quad_enable) {\n \t\t/*\n \t\t * If the Status Register 2 Read command (35h) is not\n", "prefixes": [ "v5", "03/28" ] }