Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234411/?format=api
{ "id": 2234411, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234411/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260507160959.449170-4-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507160959.449170-4-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2026-05-07T16:09:51", "name": "[v3,03/11] fpu: Hoist nan check in partsN_addsub", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6746c3b9fc95ef86bcae5fb8f5f5cc7501bda282", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/1.2/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260507160959.449170-4-richard.henderson@linaro.org/mbox/", "series": [ { "id": 503213, "url": "http://patchwork.ozlabs.org/api/1.2/series/503213/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503213", "date": "2026-05-07T16:09:49", "name": "fpu: Export some internals for targets", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/503213/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234411/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234411/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Q/zcIfj4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBHLf4Ztbz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 02:11:38 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wL1JO-0002lJ-2j; Thu, 07 May 2026 12:10:54 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wL1Ie-0001gR-7Q\n for qemu-devel@nongnu.org; Thu, 07 May 2026 12:10:11 -0400", "from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wL1Ib-00085e-K4\n for qemu-devel@nongnu.org; Thu, 07 May 2026 12:10:07 -0400", "by mail-ot1-x331.google.com with SMTP id\n 46e09a7af769-7dbe07d3ec3so530858a34.0\n for <qemu-devel@nongnu.org>; Thu, 07 May 2026 09:10:05 -0700 (PDT)", "from stoup.attlocal.net ([2600:381:c938:6375:9641:bbb2:a93a:bb4c])\n by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7e302462fb1sm16415a34.11.2026.05.07.09.10.03\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 09:10:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778170204; x=1778775004; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=2PfrqBtIf7vrbh2G9kIH/7coVyeCHu2A8Sgg5/INWz4=;\n b=Q/zcIfj4gVp9No/9ryuJ7+UsPqxaEvV0cY8esTO4lSAmKN7Nl9CH/014WcHVCy536+\n avyWuImv5Cz/kLe5muwleQ2l/xnAecopEyMtLq9Sfta5JZmVWD8Jx1omwn2rMmIiGCwc\n g+xJcK21PO/U8g8lYvCQ9G5x237GMYjc2O54/+x4RxDGOCcgrREc8bhBriLkUcKAgG6u\n mj25xDDWslrBj8UPMPPhHW/7jLOr5eRnpyBkYMpRfi6uShzebER2OV+P5GwD3vF5yuyo\n 6goyR2w5KTCcc6TpokdS93dG8Bq6egSpTPoSXWyekse0h/IMMFmhP8ji6kOXiPyd0DsT\n bw1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778170204; x=1778775004;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=2PfrqBtIf7vrbh2G9kIH/7coVyeCHu2A8Sgg5/INWz4=;\n b=MXkEEveGY5Zj2WuKfVFdB+/OHBsr6xQwe/sB5DxuNYXTp5/BbevZ33lFKc354KekuQ\n 6mvuM/80RjsetGmWR7OmbXtDilW55LEmYnArVPM3L4Nm14pCqzoYg/BVb60v+Bb7cu9c\n kTSmyylB6ioKALs6DKS16rshCK9/X0qRj4a/wESh3rh//GVC396qMy3Ld4xwrreOnZs7\n ywsGESQXf4TQTgWMp99EcmBSpHMybDVi6Puo2oWic2nnMWzESAhvrpyiGVIRfEaVF3Gt\n NdXZ35Ca1NPo1+liMcyWW6T0+pHv1loj8pOmKQPHoOmXQVWxmCQfnnATcvEMI1wGTRmM\n 9kbQ==", "X-Gm-Message-State": "AOJu0Yxp5g+MM54XOhqRYMp0QRhpDLH2jG+E8TvF1EDmskxnXKCdv2l9\n tLXyGconlQmjzpH88465pS5rnJABY6mRtdsI5X6h6w8XqiRVsJ52bAeMNn3OSr9tpKgO7VAab9p\n ruCB2", "X-Gm-Gg": "AeBDieu1zI5sUTXP3CDvsGfhSBbKkw3nurafYPpzl++w0pLcUCrVoFa9UjPY4FiYXmh\n 5RkVaw0ONqlCXdiBPLjuljwqRZheSQi6SxzJUlXhg2pHZ5UZtfQwyxWVzeS9UYEgTYQ3eV2z8NX\n rz6qKd6p60gDtIXUJPmdmtJK0O/SXFtVboFeexHDMLNGrTm96PuQsoUKMRdqXpmdtASRR9EoTlA\n ra02VgBckFTLR1PWusPkxxBsNnWtK9yUQXDTdqqxAr7+pyWGxIhNY63ZXy9fdPWtqDlSiL/rGIk\n 7Bf7+Hzodd3d250jvtt5O2NfLZaO6VxJdj17bPzRFEI0whVgHBahDnipkZMP5c6l7fUl0Srq3JN\n DYGXr6Nk/WnUdp1YdsGP1mfOqvXcWTDwrHdHVrH9pWhj2/yE+ER3chm2L1zEtcLDuii+PlgE8mZ\n Ja0pVc8BNJN8JYm1vzBP+cOtlM9Ico6FOjCjmv6Q3hmjJigg==", "X-Received": "by 2002:a05:6830:83b1:b0:7d7:f623:680a with SMTP id\n 46e09a7af769-7e1ded2af14mr4988566a34.2.1778170204330;\n Thu, 07 May 2026 09:10:04 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH v3 03/11] fpu: Hoist nan check in partsN_addsub", "Date": "Thu, 7 May 2026 11:09:51 -0500", "Message-ID": "<20260507160959.449170-4-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260507160959.449170-1-richard.henderson@linaro.org>", "References": "<20260507160959.449170-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::331;\n envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The nan test had been down below because it was unlikely.\nBut if we have to have one anyway because of denormals,\nwe might as well take care of them right away.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat-parts.c.inc | 19 +++++--------------\n 1 file changed, 5 insertions(+), 14 deletions(-)", "diff": "diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 87525fb4b6..20cb739c75 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -530,13 +530,15 @@ FloatPartsN partsN(addsub)(const FloatPartsN *a_orig,\n {\n int ab_mask = float_cmask(a_orig->cls) | float_cmask(b_orig->cls);\n \n+ if (unlikely(ab_mask & float_cmask_anynan)) {\n+ return partsN(pick_nan)(a_orig, b_orig, s);\n+ }\n+\n /*\n * For addition and subtraction, we will consume an\n * input denormal unless the other input is a NaN.\n */\n- if (!(ab_mask & float_cmask_anynan)) {\n- record_denormals_used(ab_mask, s);\n- }\n+ record_denormals_used(ab_mask, s);\n \n FloatPartsN a = *a_orig;\n FloatPartsN b = *b_orig;\n@@ -558,10 +560,6 @@ FloatPartsN partsN(addsub)(const FloatPartsN *a_orig,\n return a;\n }\n \n- if (unlikely(ab_mask & float_cmask_anynan)) {\n- goto p_nan;\n- }\n-\n if (ab_mask & float_cmask_inf) {\n if (a.cls != float_class_inf) {\n /* N - Inf */\n@@ -586,10 +584,6 @@ FloatPartsN partsN(addsub)(const FloatPartsN *a_orig,\n return a;\n }\n \n- if (unlikely(ab_mask & float_cmask_anynan)) {\n- goto p_nan;\n- }\n-\n if (ab_mask & float_cmask_inf) {\n a.cls = float_class_inf;\n return a;\n@@ -604,9 +598,6 @@ FloatPartsN partsN(addsub)(const FloatPartsN *a_orig,\n g_assert(a.cls == float_class_zero);\n g_assert(is_anynorm(b.cls));\n return b;\n-\n- p_nan:\n- return partsN(pick_nan)(a_orig, b_orig, s);\n }\n \n /*\n", "prefixes": [ "v3", "03/11" ] }