Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234246/?format=api
{ "id": 2234246, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234246/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260507140423.3734545-2-lixiasong1@huawei.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.2/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507140423.3734545-2-lixiasong1@huawei.com>", "list_archive_url": null, "date": "2026-05-07T14:04:22", "name": "[nft,v2,1/2] netfilter: nf_conntrack_sip: get helper before allocating expectation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "83d2c590d35f8b585ed6668b287c738f06fb42ad", "submitter": { "id": 93343, "url": "http://patchwork.ozlabs.org/api/1.2/people/93343/?format=api", "name": "Li Xiasong", "email": "lixiasong1@huawei.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260507140423.3734545-2-lixiasong1@huawei.com/mbox/", "series": [ { "id": 503182, "url": "http://patchwork.ozlabs.org/api/1.2/series/503182/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=503182", "date": "2026-05-07T14:04:23", "name": "netfilter: fix expectation reference leaks", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/503182/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234246/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-12481-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=h+eSMKlW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12481-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com\n header.b=\"h+eSMKlW\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=113.46.200.227", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huawei.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCyq3VMgz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 23:39:15 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 582533011A74\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 7 May 2026 13:39:05 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 75A1B3F7A99;\n\tThu, 7 May 2026 13:39:00 +0000 (UTC)", "from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com\n [113.46.200.227])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F05E23B893A;\n\tThu, 7 May 2026 13:38:57 +0000 (UTC)", "from mail.maildlp.com (unknown [172.19.163.127])\n\tby canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4gBCpD4SDDznTXS;\n\tThu, 7 May 2026 21:31:48 +0800 (CST)", "from kwepemj500018.china.huawei.com (unknown [7.202.194.48])\n\tby mail.maildlp.com (Postfix) with ESMTPS id BA328402AB;\n\tThu, 7 May 2026 21:38:54 +0800 (CST)", "from huawei.com (10.50.85.128) by kwepemj500018.china.huawei.com\n (7.202.194.48) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 7 May\n 2026 21:38:54 +0800" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778161140; cv=none;\n b=fQItjFDkHgHs4ZljjUoEDSzjXdJHkluwnf604ce48q9FuDeuL4ikxERfoeajuNZZrt1q1fJg33ulEuKFN3SIt9svh3fdATc1egYGMXH9fngmdz+7uDQdHoglahW4xVmu7dOPjD140fn8OQ/UxMbOX0JjF9chmfgxOG8vLOCgzAU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778161140; c=relaxed/simple;\n\tbh=kUgJmL/GAPlg8Lm7wTNxGGcekfOVXdbOcH3b88ZNNV0=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=kLrBQdeyonn7XdOMjykYuawSH17A2IQqZseuRq2a03JFqP/mpVLVLjM6iSMjgwhOpeEduwcGhWfaPMkRGzNsQqjPPkg8AVogOEZglEzp3x8nKbw+heRsgKe5WpaE+yxHNVRnHbS4WatL5lcYaFIUSn6q2yzomWP/+lXx39DNQUE=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com;\n spf=pass smtp.mailfrom=huawei.com;\n dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com\n header.b=h+eSMKlW; arc=none smtp.client-ip=113.46.200.227", "dkim-signature": "v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=x6aYXSkDMxsfxRvjT+JWwxZLyvgj/tSbFyzDgWDtwqg=;\n\tb=h+eSMKlWt3zvKVmHKnPYNe98y/hii2BmLlYP3voXPA49G8hOdq9h8mmmpSZKIna1RGhCf81lo\n\t8Td2RZi5UQy3nvQlKe78OJ67dHRCtGqQ2NzmEee9uRnp0T/r/AnkmWCSnG74xrR376Xsh1Wcntc\n\tbi2XM84CIcjA1YXWAj0fusM=", "From": "Li Xiasong <lixiasong1@huawei.com>", "To": "<netfilter-devel@vger.kernel.org>", "CC": "<stable@vger.kernel.org>, Pablo Neira Ayuso <pablo@netfilter.org>, Florian\n Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>, <coreteam@netfilter.org>,\n\t<yuehaibing@huawei.com>, <zhangchangzhong@huawei.com>,\n\t<weiyongjun1@huawei.com>", "Subject": "[PATCH nft v2 1/2] netfilter: nf_conntrack_sip: get helper before\n allocating expectation", "Date": "Thu, 7 May 2026 22:04:22 +0800", "Message-ID": "<20260507140423.3734545-2-lixiasong1@huawei.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260507140423.3734545-1-lixiasong1@huawei.com>", "References": "<20260507140423.3734545-1-lixiasong1@huawei.com>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "kwepems200002.china.huawei.com (7.221.188.68) To\n kwepemj500018.china.huawei.com (7.202.194.48)" }, "content": "process_register_request() allocates an expectation and then checks\nwhether a conntrack helper is available. If helper lookup fails, the\nfunction returns early and the allocated expectation is left behind.\n\nReorder the code to fetch and validate helper before calling\nnf_ct_expect_alloc(). This keeps the logic simpler and removes the leak\npath while preserving existing behavior.\n\nFixes: e14575fa7529 (\"netfilter: nf_conntrack: use rcu accessors where needed\")\nCc: stable@vger.kernel.org\nSigned-off-by: Li Xiasong <lixiasong1@huawei.com>\n---\n net/netfilter/nf_conntrack_sip.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c\nindex 1eb55907d470..58fce6242f89 100644\n--- a/net/netfilter/nf_conntrack_sip.c\n+++ b/net/netfilter/nf_conntrack_sip.c\n@@ -1366,6 +1366,10 @@ static int process_register_request(struct sk_buff *skb, unsigned int protoff,\n \t\tgoto store_cseq;\n \t}\n \n+\thelper = rcu_dereference(nfct_help(ct)->helper);\n+\tif (!helper)\n+\t\treturn NF_DROP;\n+\n \texp = nf_ct_expect_alloc(ct);\n \tif (!exp) {\n \t\tnf_ct_helper_log(skb, ct, \"cannot alloc expectation\");\n@@ -1376,10 +1380,6 @@ static int process_register_request(struct sk_buff *skb, unsigned int protoff,\n \tif (sip_direct_signalling)\n \t\tsaddr = &ct->tuplehash[!dir].tuple.src.u3;\n \n-\thelper = rcu_dereference(nfct_help(ct)->helper);\n-\tif (!helper)\n-\t\treturn NF_DROP;\n-\n \tnf_ct_expect_init(exp, SIP_EXPECT_SIGNALLING, nf_ct_l3num(ct),\n \t\t\t saddr, &daddr, proto, NULL, &port);\n \texp->timeout.expires = sip_timeout * HZ;\n", "prefixes": [ "nft", "v2", "1/2" ] }