Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2234239/?format=api
{ "id": 2234239, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2234239/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20260507131541.2331771-3-houminxi@gmail.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/1.2/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260507131541.2331771-3-houminxi@gmail.com>", "list_archive_url": null, "date": "2026-05-07T13:15:41", "name": "[ovs-dev,net-next,v7,2/2] selftests: openvswitch: add pop_vlan test", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5a092637853dc5dd9ca0c44742ac804a0be8f054", "submitter": { "id": 93141, "url": "http://patchwork.ozlabs.org/api/1.2/people/93141/?format=api", "name": "Minxi Hou", "email": "houminxi@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20260507131541.2331771-3-houminxi@gmail.com/mbox/", "series": [ { "id": 503180, "url": "http://patchwork.ozlabs.org/api/1.2/series/503180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=503180", "date": "2026-05-07T13:15:39", "name": "selftests: openvswitch: add pop_vlan test", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/503180/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2234239/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2234239/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=fpRenenu;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=fpRenenu", "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=fpRenenu" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBCSP3gy7z1y04\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 07 May 2026 23:16:21 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 764A883BE3;\n\tThu, 7 May 2026 13:16:19 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FCrEMDj54-6I; Thu, 7 May 2026 13:16:18 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 7F69083BE2;\n\tThu, 7 May 2026 13:16:18 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 546F7C04EB;\n\tThu, 7 May 2026 13:16:18 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 101CFC04E7\n for <dev@openvswitch.org>; Thu, 7 May 2026 13:16:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id F05E74114F\n for <dev@openvswitch.org>; Thu, 7 May 2026 13:16:12 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id rsLkrcgDk12G for <dev@openvswitch.org>;\n Thu, 7 May 2026 13:16:12 +0000 (UTC)", "from mail-ot1-x332.google.com (mail-ot1-x332.google.com\n [IPv6:2607:f8b0:4864:20::332])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 1DE8C4112C\n for <dev@openvswitch.org>; Thu, 7 May 2026 13:16:11 +0000 (UTC)", "by mail-ot1-x332.google.com with SMTP id\n 46e09a7af769-7dbd23bc684so504056a34.2\n for <dev@openvswitch.org>; Thu, 07 May 2026 06:16:11 -0700 (PDT)", "from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7deca826dbesm14047117a34.12.2026.05.07.06.16.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 06:16:09 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7F69083BE2", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1DE8C4112C" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::332; helo=mail-ot1-x332.google.com;\n envelope-from=houminxi@gmail.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 1DE8C4112C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778159771; x=1778764571; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nCencyebNV6RkeBeV6Zcfzu1ZdE6veaso03Op6l41qE=;\n b=fpRenenuLzqx3OlUsB58sBJ3RdYXKPaOuaSlUX6svk3SifjaPoR2ZHyUSivLVq2Rpa\n CLEdBCKFkFOkWVYD9FN6wYtqy06I3vtk0IFkxqW8boXY8YE3Rt1/oy/hEzTvORd+HJGj\n QLXABoFJ4uRS+JLYrquqinLVRPB0dcFhVil3wT6+vw+wPwEOgdXYcAhcMqVz/tBmOhiw\n +fqw/uBvtQT1epxj9fhEHwVhEjjpWKb41zX1W4LHRjuOWb54YNXXSk38XE0LpxPllxj/\n Pq9B8sXMT/sgqv4UR+EOHdpnd+V87rymlS84uhDPNwbcvZH7Rk9gOh2u5y7HQS2JKCsi\n soHA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778159771; x=1778764571;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=nCencyebNV6RkeBeV6Zcfzu1ZdE6veaso03Op6l41qE=;\n b=Ne9fGZ4qwqdqbC4WIDhQyO3DZy2MXvHr/gexsCCCTtfc5mybF/m/uuZrLqqSVSnc0H\n uQ8vliAQUj4dO5rWNn838mv8n93GFrEHhv7v8GBGyVir6VelLDSEJYFJekRPQE65AS0a\n rOkDqrLJiYdXxGLKHf7i48IC5GqcPXfsI8PWVriU4V+dXHAPiN6TjmhEj2gJhwWKwx0w\n u3pKHem0ztkvU241srvnA1VVfIa/L3gyZnzsWodrRvR/FHHwGeYWOCy72mJ2rmI0Y7t8\n Q2etXhuQ5fZS1bqvnzPwQvKMs3obrp+4JtqM/mmvm9wCuijiPSHevlOcPrj7fUxphopU\n UKtg==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ9jLehem9Tu0a1PqHhCMMLERjo7RmezY/+v5z6mEhH5ZGyAqQKEbvBsBxgfFQAQzvnolCA=@openvswitch.org", "X-Gm-Message-State": "AOJu0YyU0DKjnu3Yc3Ng8SUbVygovy6oarh03cENKFkUDeFFLwzY6Bbu\n I75OCHN/qBpIm2ynkVqW6RA8iOmG0TszI4Bh0IzPpdY1a64CH0GdEGor", "X-Gm-Gg": "AeBDiesvcLYlyJIRXreEl7O1KChRD0s4i5Ll5/VvPobZHnVC/0wmdAy5RGBhPOVC+85\n bhKzdwhxWh1SUJrVYlSFplkQe7KleDf2G3q3aLlB/V8IWSCGC8ZAwpIcRXuhdtjXQuckCcQ1RAF\n 0dpE+zrrqRrDI4b/OQkIdJdXwTyNiR9VLlY96+jN16D+Zeec1ALmffdb1A+nlI7D/fLP1algx7A\n MCG9Vkjj9pKlyLmUngWwh+SFaFdV4rLN4V02Oae5KQCk6Jvwqg3w7wpqh+sVo6sJv5RZD+LXJcq\n 5rNwQM0FchyRz8A1jhIA76ft1WpTe/qkdGactce5OLiOEXmJB4pA+tAB1b2xj0z9o5uLi/x+svX\n cyJ8fyHb4Hs1mxbQGxjzv1BHp69XtW8UATe4klxZfbAoyFtMyaKUSuo0HZuQLu1xUS9yUS2EY9s\n Vv09f7gBk9YeFfyFt52zbOuE98Cg==", "X-Received": "by 2002:a05:6830:3592:b0:7db:b5c9:2d87 with SMTP id\n 46e09a7af769-7e1def36698mr4757801a34.11.1778159770507;\n Thu, 07 May 2026 06:16:10 -0700 (PDT)", "From": "Minxi Hou <houminxi@gmail.com>", "To": "netdev@vger.kernel.org", "Date": "Thu, 7 May 2026 21:15:41 +0800", "Message-ID": "<20260507131541.2331771-3-houminxi@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260507131541.2331771-1-houminxi@gmail.com>", "References": "<20260507131541.2331771-1-houminxi@gmail.com>", "MIME-Version": "1.0", "Subject": "[ovs-dev] [PATCH net-next v7 2/2] selftests: openvswitch: add\n pop_vlan test", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Cc": "dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n Minxi Hou <houminxi@gmail.com>, linux-kernel@vger.kernel.org,\n i.maximets@ovn.org, edumazet@google.com, horms@kernel.org, kuba@kernel.org,\n pabeni@redhat.com, shuah@kernel.org, davem@davemloft.net", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action\ncorrectly strips 802.1Q VLAN tags from frames.\n\nTest structure:\n- Baseline: untagged forwarding validates basic connectivity.\n- Negative: forward without pop_vlan, tagged frame is invisible\n to ns2 (no VLAN sub-interface), ping fails.\n- Positive: pop_vlan strips tag on forward path, push_vlan\n restores tag on return path, ping succeeds.\n\nUse static ARP entries to avoid VLAN-tagged ARP complexity.\nRely on ping success/failure for verification -- no tcpdump or\npcap files needed.\n\nSigned-off-by: Minxi Hou <houminxi@gmail.com>\n---\n .../selftests/net/openvswitch/openvswitch.sh | 73 +++++++++++++++++++\n 1 file changed, 73 insertions(+)", "diff": "diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh\nindex b327d3061ed5..6d13ee8c2baf 100755\n--- a/tools/testing/selftests/net/openvswitch/openvswitch.sh\n+++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh\n@@ -27,6 +27,7 @@ tests=\"\n \tupcall_interfaces\t\t\tovs: test the upcall interfaces\n \ttunnel_metadata\t\t\t\tovs: test extraction of tunnel metadata\n \tdrop_reason\t\t\t\tdrop: test drop reasons are emitted\n+\tpop_vlan\t\t\t\tvlan: POP_VLAN action strips tag\n \tpsample\t\t\t\t\tpsample: Sampling packets with psample\"\n \n info() {\n@@ -830,6 +831,78 @@ test_tunnel_metadata() {\n \treturn 0\n }\n \n+test_pop_vlan() {\n+\tlocal sbx=\"test_pop_vlan\"\n+\tsbx_add \"$sbx\" || return $?\n+\tovs_add_dp \"$sbx\" vlandp || return 1\n+\n+\tovs_add_netns_and_veths \"$sbx\" vlandp \\\n+\t\tns1 veth1 ns1veth 192.0.2.1/24 || return 1\n+\tovs_add_netns_and_veths \"$sbx\" vlandp \\\n+\t\tns2 veth2 ns2veth 192.0.2.2/24 || return 1\n+\n+\t# Baseline: untagged bidirectional forwarding\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0806),arp()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0806),arp()' '1' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0800),ipv4()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' '1' || return 1\n+\tovs_sbx \"$sbx\" ip netns exec ns1 ping -c 3 -W 2 \\\n+\t\t192.0.2.2 || return 1\n+\n+\t# VLAN topology: ns1 uses VLAN sub-interface, ns2 is plain\n+\tip -n ns1 link add link ns1veth name ns1veth.10 \\\n+\t\ttype vlan id 10 || return 1\n+\ton_exit \"ip -n ns1 link del ns1veth.10 2>/dev/null\"\n+\tip -n ns1 addr add 198.51.100.1/24 dev ns1veth.10 || return 1\n+\tip -n ns1 link set ns1veth.10 up || return 1\n+\tip -n ns2 addr add 198.51.100.2/24 dev ns2veth || return 1\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# Static ARP: avoids VLAN-tagged ARP complexity\n+\tlocal ns1veth10mac ns2mac\n+\tns1veth10mac=$(ip -n ns1 link show ns1veth.10 \\\n+\t\t| awk '/link\\/ether/ {print $2}')\n+\tns2mac=$(ip -n ns2 link show ns2veth \\\n+\t\t| awk '/link\\/ether/ {print $2}')\n+\tip -n ns1 neigh replace 198.51.100.2 lladdr \"$ns2mac\" \\\n+\t\tdev ns1veth.10 nud permanent || return 1\n+\tip -n ns2 neigh replace 198.51.100.1 \\\n+\t\tlladdr \"$ns1veth10mac\" \\\n+\t\tdev ns2veth nud permanent || return 1\n+\n+\tlocal vlan_match='in_port(1),eth(),eth_type(0x8100),'\n+\tvlan_match+='vlan(vid=10),'\n+\tvlan_match+='encap(eth_type(0x0800),'\n+\tvlan_match+='ipv4(src=198.51.100.1,proto=1),icmp())'\n+\n+\t# Negative: forward without pop_vlan -- tagged frame\n+\t# is invisible to ns2 (no VLAN sub-interface), ping fails\n+\tovs_add_flow \"$sbx\" vlandp \"$vlan_match\" '2' || return 1\n+\tovs_sbx \"$sbx\" ip netns exec ns1 ping -I ns1veth.10 \\\n+\t\t-c 3 -W 1 198.51.100.2 >/dev/null 2>&1 \\\n+\t\t&& { info \"FAIL: ping should fail without pop_vlan\"\n+\t\t return 1; }\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# Positive: pop_vlan strips tag on forward path,\n+\t# push_vlan restores tag on return path -- ping succeeds\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t\"$vlan_match\" 'pop_vlan,2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' \\\n+\t\t'push_vlan(vid=10,pcp=0,tpid=0x8100),1' || return 1\n+\tovs_sbx \"$sbx\" ip netns exec ns1 ping -I ns1veth.10 \\\n+\t\t-c 3 -W 2 198.51.100.2 || return 1\n+\n+\treturn 0\n+}\n+\n run_test() {\n \t(\n \ttname=\"$1\"\n", "prefixes": [ "ovs-dev", "net-next", "v7", "2/2" ] }