Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2233309/?format=api
{ "id": 2233309, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2233309/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-2-armenon@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260506075813.120781-2-armenon@redhat.com>", "list_archive_url": null, "date": "2026-05-06T07:58:08", "name": "[v7,1/6] hw/tpm: Add TPM CRB chunking fields", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b2f6e6cf8022bf8e7c83be13153920159eb273b5", "submitter": { "id": 91136, "url": "http://patchwork.ozlabs.org/api/1.2/people/91136/?format=api", "name": "Arun Menon", "email": "armenon@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-2-armenon@redhat.com/mbox/", "series": [ { "id": 502931, "url": "http://patchwork.ozlabs.org/api/1.2/series/502931/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502931", "date": "2026-05-06T07:58:09", "name": "hw/tpm: CRB chunking capability to handle PQC", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/502931/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233309/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233309/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ody11UV4;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=cWCx8Ib3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9SSv66W4z1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 17:59:11 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKX9Q-0004uP-7E; Wed, 06 May 2026 03:58:36 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wKX9O-0004tZ-Ae\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:34 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wKX9L-0000bY-Q5\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:33 -0400", "from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-472-BwQ-UbfnMIeR9p6vBbanhA-1; Wed, 06 May 2026 03:58:29 -0400", "by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b2e8bba2e6so72796675ad.1\n for <qemu-devel@nongnu.org>; Wed, 06 May 2026 00:58:29 -0700 (PDT)", "from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ba7ca29f9dsm15439865ad.78.2026.05.06.00.58.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 May 2026 00:58:26 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778054310;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v4pF4l9L+XhDbGXCnZWjvEQGjfAJPVkKy76gDH2nELI=;\n b=Ody11UV4TXXAmYCRh6hWUEZlRM4+eYY1vWBEzReotrajOotdIErCGgZvDmHDUqKh778UuX\n 7yskV/MbKYHW5ydXRqrOCC3S70tBco77+dHqOc7o/0YBzu9WqEnAiz3xvv+XLQIYQr0I4l\n KLJMbljI43+32LryU+3IrmsXy0Drmd0=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1778054308; x=1778659108; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=v4pF4l9L+XhDbGXCnZWjvEQGjfAJPVkKy76gDH2nELI=;\n b=cWCx8Ib3OjxnFm+zJhuQqYnCrKzrrh3JdzIgQnJYDc7MZ+vIVt3aOXICOpXZqj2v7B\n 04119ufEyrttG5/owjT0aT54y+RygcflWmHxueX8nUhguIGbLnDb6vSeEvnCdHdSBRnx\n Yi/pH2BR6CqNrDoW+DwWx/MK9R6G/8RsbuJf6syj1cKs53WOG3bR1fH/T7iPimj1Z+6K\n weLzOmTFZRHTcr1Yrp1Ve99z/UJN+DzxR1wHZF5BkxuTAJOewJa0MVeyjcx4CnGb7H0l\n hP8kAEnmw+jBwjHrqbRe3K4WX3crVRYjofEC8Axgx+sjHOjvC4XHozPGzzqYeyCp+xrW\n BrDA==" ], "X-MC-Unique": "BwQ-UbfnMIeR9p6vBbanhA-1", "X-Mimecast-MFC-AGG-ID": "BwQ-UbfnMIeR9p6vBbanhA_1778054308", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778054308; x=1778659108;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=v4pF4l9L+XhDbGXCnZWjvEQGjfAJPVkKy76gDH2nELI=;\n b=Ky85RPXChjE6+C1YX5/asVEGs4Eqcm4UVx7oZuA0DbcLKFqvJ8x5kNzL1FyrcDDQJf\n RNgT2aczuoKBaGnwwsfYJkFl5G2vzi6VFlkWUkllpJmcBklBDS0ynnna5Yhc9FOcaAF4\n W4wTnB6boXi9W8K09ONWpxmItvrSnpoG2zzl3Zn+A6N2QzBSU8UoXldz1tHSFbgv91Cc\n JbNUIY7ZisM2To4IdPZS+z5qOZIV5shy8mlLZ2+PL4nimBqYpVmMppQjvgJmFqV98QiQ\n 6xdMs/rw7P+zc3cnwhnZQsqcDGMV2kDZTKgklSR6W/6yjw6fgD/PKb7Kw1HjWagdiogv\n Ff9w==", "X-Gm-Message-State": "AOJu0Ywi88t37UDTfUWOJvi01irZW7K13TvKsLZCkHPy5flc7f/pyk+K\n gpLPMwy8HB349O7CRx91L72tqM31DBfe43t1KWau0a/UXch7PpKktdyP0eFZM71iTVfLBS/ZBXY\n 8Uino8RANQky/hO782funb9/Gi4MJ0H+BuT6WsD8vtg3SOam3rMRegghR0Gtp2yb+l+HqDGqVFt\n BWIXgaEd+oSqZMs13JuG/G13UF5+TZyck23Zotr6k=", "X-Gm-Gg": "AeBDievwhLpZu/ZwYLxD0jJYD+fvr6LZMADrzIF/g+lVTFhcwIgyrNGNkaw2VqL5SC6\n RHZedfwGD3EwAnHPmUuxh6LeRygEEsu4NbuUCia6u8Wi718tuqqCukxG9Dds6nlmi1DLPhkeJ8g\n Y6SlcEcVNo45gqYmvaxSWVX+LKETaLrglUyLxQT0oVDCIUEkmXMbTbIqqXyrEVFZaWcDxEfWxfG\n hOHX+FWfEDXUTOeitlVn/02B9wmPsaLlNZDuPETi21D/1gtls89lqz10BM8YeE3M+w8D3dcNz3Q\n zv6B9Q+QEUKnGVJQqrPk964e2EoodEdbTRFKpuErd9w41fZy1HODQvV0T0Gx6I7uKdhwvH06rq2\n odpXfP9o3h9hzpf1erNx5AAvtHr6pJaBLIBPh/vJpfDQlxG9wTLOcG5gGex/Em5W07WIKrDrw", "X-Received": [ "by 2002:a17:903:1a4c:b0:2ba:9587:25c2 with SMTP id\n d9443c01a7336-2ba958726f3mr4407315ad.3.1778054308012;\n Wed, 06 May 2026 00:58:28 -0700 (PDT)", "by 2002:a17:903:1a4c:b0:2ba:9587:25c2 with SMTP id\n d9443c01a7336-2ba958726f3mr4406945ad.3.1778054307452;\n Wed, 06 May 2026 00:58:27 -0700 (PDT)" ], "From": "Arun Menon <armenon@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Zhao Liu <zhao1.liu@intel.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Ani Sinha <anisinha@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n marcandre.lureau@redhat.com, Stefan Berger <stefanb@linux.vnet.ibm.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Yanan Wang <wangyanan55@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Laurent Vivier <lvivier@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n Igor Mammedov <imammedo@redhat.com>, Arun Menon <armenon@redhat.com>,\n Stefan Berger <stefanb@linux.ibm.com>", "Subject": "[PATCH v7 1/6] hw/tpm: Add TPM CRB chunking fields", "Date": "Wed, 6 May 2026 13:28:08 +0530", "Message-ID": "<20260506075813.120781-2-armenon@redhat.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260506075813.120781-1-armenon@redhat.com>", "References": "<20260506075813.120781-1-armenon@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Arun Menon <armenon@redhat.com>\n\n- Add new fields to the CRB Interface Identifier and the CRB\n Control Start registers.\n- CRB_CTRL_START now has 2 new settings, that can be toggled using the\n nextChunk and crbRspRetry bits.\n- CapCRBChunk bit (10) was Reserved1 previously. The field is reused in\n this revision of the specification. Refer to section 6.4.2.2 of [1]\n- Add hw_compat global property called cap-chunk because the chunking\n feature is only supported for machine type 11.1 and higher.\n\n[1] https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_Pub.pdf\n\nSigned-off-by: Arun Menon <armenon@redhat.com>\nReviewed-by: Stefan Berger <stefanb@linux.ibm.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/core/machine.c | 4 +++-\n hw/tpm/tpm_crb.c | 6 ++++++\n include/hw/acpi/tpm.h | 5 ++++-\n 3 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/core/machine.c b/hw/core/machine.c\nindex 1b661fd36a..4e0a93e231 100644\n--- a/hw/core/machine.c\n+++ b/hw/core/machine.c\n@@ -39,7 +39,9 @@\n #include \"hw/acpi/generic_event_device.h\"\n #include \"qemu/audio.h\"\n \n-GlobalProperty hw_compat_11_0[] = {};\n+GlobalProperty hw_compat_11_0[] = {\n+ { \"tpm-crb\", \"cap-chunk\", \"off\" },\n+};\n const size_t hw_compat_11_0_len = G_N_ELEMENTS(hw_compat_11_0);\n \n GlobalProperty hw_compat_10_2[] = {\ndiff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex 02701ab948..bfa09c04cf 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -44,6 +44,8 @@ struct CRBState {\n size_t be_buffer_size;\n \n TPMPPI ppi;\n+\n+ bool cap_chunk;\n };\n typedef struct CRBState CRBState;\n \n@@ -58,6 +60,7 @@ DECLARE_INSTANCE_CHECKER(CRBState, CRB,\n #define CRB_INTF_CAP_FIFO_NOT_SUPPORTED 0b0\n #define CRB_INTF_CAP_CRB_SUPPORTED 0b1\n #define CRB_INTF_IF_SELECTOR_CRB 0b1\n+#define CRB_INTF_CAP_CRB_CHUNK 0b1\n \n #define CRB_CTRL_CMD_SIZE (TPM_CRB_ADDR_SIZE - A_CRB_DATA_BUFFER)\n \n@@ -227,6 +230,7 @@ static const VMStateDescription vmstate_tpm_crb = {\n \n static const Property tpm_crb_properties[] = {\n DEFINE_PROP_TPMBE(\"tpmdev\", CRBState, tpmbe),\n+ DEFINE_PROP_BOOL(\"cap-chunk\", CRBState, cap_chunk, true),\n };\n \n static void tpm_crb_reset(void *dev)\n@@ -258,6 +262,8 @@ static void tpm_crb_reset(void *dev)\n CapCRB, CRB_INTF_CAP_CRB_SUPPORTED);\n ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n InterfaceSelector, CRB_INTF_IF_SELECTOR_CRB);\n+ ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n+ CapCRBChunk, s->cap_chunk ? CRB_INTF_CAP_CRB_CHUNK : 0);\n ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n RID, 0b0000);\n ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID2,\ndiff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h\nindex 2ab186a745..782dc8212c 100644\n--- a/include/hw/acpi/tpm.h\n+++ b/include/hw/acpi/tpm.h\n@@ -150,7 +150,7 @@ REG32(CRB_INTF_ID, 0x30)\n FIELD(CRB_INTF_ID, InterfaceVersion, 4, 4)\n FIELD(CRB_INTF_ID, CapLocality, 8, 1)\n FIELD(CRB_INTF_ID, CapCRBIdleBypass, 9, 1)\n- FIELD(CRB_INTF_ID, Reserved1, 10, 1)\n+ FIELD(CRB_INTF_ID, CapCRBChunk, 10, 1)\n FIELD(CRB_INTF_ID, CapDataXferSizeSupport, 11, 2)\n FIELD(CRB_INTF_ID, CapFIFO, 13, 1)\n FIELD(CRB_INTF_ID, CapCRB, 14, 1)\n@@ -169,6 +169,9 @@ REG32(CRB_CTRL_STS, 0x44)\n FIELD(CRB_CTRL_STS, tpmIdle, 1, 1)\n REG32(CRB_CTRL_CANCEL, 0x48)\n REG32(CRB_CTRL_START, 0x4C)\n+ FIELD(CRB_CTRL_START, Start, 0, 1)\n+ FIELD(CRB_CTRL_START, crbRspRetry, 1, 1)\n+ FIELD(CRB_CTRL_START, nextChunk, 2, 1)\n REG32(CRB_INT_ENABLED, 0x50)\n REG32(CRB_INT_STS, 0x54)\n REG32(CRB_CTRL_CMD_SIZE, 0x58)\n", "prefixes": [ "v7", "1/6" ] }