Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2233092/?format=api
{ "id": 2233092, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2233092/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-10-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260505160915.25558-10-farosas@suse.de>", "list_archive_url": null, "date": "2026-05-05T16:09:08", "name": "[v1,09/15] tests/qtest/migration: Remove multifd compression hook", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b043fdc69e1d074631cfdbf6834573673a92fcc9", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/1.2/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-10-farosas@suse.de/mbox/", "series": [ { "id": 502864, "url": "http://patchwork.ozlabs.org/api/1.2/series/502864/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502864", "date": "2026-05-05T16:09:07", "name": "tests/qtest/migration: Always defer", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502864/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233092/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233092/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=s8Pa5jju;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=grnONh+c;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=s8Pa5jju;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=grnONh+c;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out1.suse.de;\n\tnone" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93SL4SVmz1yJx\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 02:12:18 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKIMH-00006K-Eq; Tue, 05 May 2026 12:10:53 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKIM7-0008UG-Po\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:10:45 -0400", "from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKIM4-0000p5-JG\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:10:42 -0400", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 86ED76B785;\n Tue, 5 May 2026 16:09:37 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5DC59593A3;\n Tue, 5 May 2026 16:09:36 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id iIS6C0AW+mmNcgAAD6G6ig\n (envelope-from <farosas@suse.de>); Tue, 05 May 2026 16:09:36 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997377;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8gLu8fyUzyQP1940vUaN/flGN80brylBhmoAkEaPaCE=;\n b=s8Pa5jjuHqS1aFVTYrcs2NnXiH8u4l+Wdm9FpDE1EGszi0Aasf3zn/w0V9uyqvIC37MsWx\n KM6aULGLY5dRVUhYm31J5ZyJ5epsLN/G82GA5IFrzc4PsU82h5UtQxzbu426YErDbFHkaE\n yWJPCRT9CDkNj+aUNcS8XUS7t/DuCQ8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997377;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8gLu8fyUzyQP1940vUaN/flGN80brylBhmoAkEaPaCE=;\n b=grnONh+cy7lzuYX9cfoFxwzcuLsYuk4h1DWkKz0k4qZSy/lCyuYk/b5QjZ52IXhS6fhtW4\n WPt88c3eRdFuDQDg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997377;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8gLu8fyUzyQP1940vUaN/flGN80brylBhmoAkEaPaCE=;\n b=s8Pa5jjuHqS1aFVTYrcs2NnXiH8u4l+Wdm9FpDE1EGszi0Aasf3zn/w0V9uyqvIC37MsWx\n KM6aULGLY5dRVUhYm31J5ZyJ5epsLN/G82GA5IFrzc4PsU82h5UtQxzbu426YErDbFHkaE\n yWJPCRT9CDkNj+aUNcS8XUS7t/DuCQ8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997377;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8gLu8fyUzyQP1940vUaN/flGN80brylBhmoAkEaPaCE=;\n b=grnONh+cy7lzuYX9cfoFxwzcuLsYuk4h1DWkKz0k4qZSy/lCyuYk/b5QjZ52IXhS6fhtW4\n WPt88c3eRdFuDQDg==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v1 09/15] tests/qtest/migration: Remove multifd compression\n hook", "Date": "Tue, 5 May 2026 13:09:08 -0300", "Message-ID": "<20260505160915.25558-10-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260505160915.25558-1-farosas@suse.de>", "References": "<20260505160915.25558-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]", "X-Spam-Score": "-2.80", "Received-SPF": "pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Take advantage of the default compression method for multifd being\n\"none\" and remove the common compression hook.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n tests/qtest/migration/framework.c | 9 ----\n tests/qtest/migration/framework.h | 3 --\n tests/qtest/migration/precopy-tests.c | 11 ----\n tests/qtest/migration/tls-tests.c | 74 +++------------------------\n 4 files changed, 8 insertions(+), 89 deletions(-)", "diff": "diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c\nindex f9f16faee4..9df33f8809 100644\n--- a/tests/qtest/migration/framework.c\n+++ b/tests/qtest/migration/framework.c\n@@ -1063,15 +1063,6 @@ finish:\n migrate_end(from, to, args->result == MIG_TEST_SUCCEED);\n }\n \n-void *migrate_hook_start_precopy_tcp_multifd_common(QTestState *from,\n- QTestState *to,\n- const char *method)\n-{\n- migrate_set_parameter_str(from, \"multifd-compression\", method);\n- migrate_set_parameter_str(to, \"multifd-compression\", method);\n- return NULL;\n-}\n-\n QTestMigrationState *get_src(void)\n {\n return &src_state;\ndiff --git a/tests/qtest/migration/framework.h b/tests/qtest/migration/framework.h\nindex 613839dec8..7635e9fac1 100644\n--- a/tests/qtest/migration/framework.h\n+++ b/tests/qtest/migration/framework.h\n@@ -241,9 +241,6 @@ void test_postcopy_recovery_common(MigrateCommon *args,\n int test_precopy_common(MigrateCommon *args);\n void test_precopy_unix_common(MigrateCommon *args);\n void test_file_common(MigrateCommon *args, bool stop_src);\n-void *migrate_hook_start_precopy_tcp_multifd_common(QTestState *from,\n- QTestState *to,\n- const char *method);\n \n typedef struct QTestMigrationState QTestMigrationState;\n QTestMigrationState *get_src(void);\ndiff --git a/tests/qtest/migration/precopy-tests.c b/tests/qtest/migration/precopy-tests.c\nindex 05e5bee48d..45a8f6d76c 100644\n--- a/tests/qtest/migration/precopy-tests.c\n+++ b/tests/qtest/migration/precopy-tests.c\n@@ -378,18 +378,10 @@ static void test_auto_converge(char *name, MigrateCommon *args)\n migrate_end(from, to, true);\n }\n \n-static void *\n-migrate_hook_start_precopy_tcp_multifd(QTestState *from,\n- QTestState *to)\n-{\n- return migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n-}\n-\n static void *\n migrate_hook_start_precopy_tcp_multifd_zero_page_legacy(QTestState *from,\n QTestState *to)\n {\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n migrate_set_parameter_str(from, \"zero-page-detection\", \"legacy\");\n return NULL;\n }\n@@ -398,14 +390,12 @@ static void *\n migrate_hook_start_precopy_tcp_multifd_no_zero_page(QTestState *from,\n QTestState *to)\n {\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n migrate_set_parameter_str(from, \"zero-page-detection\", \"none\");\n return NULL;\n }\n \n static void test_multifd_tcp_uri_none(char *name, MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_precopy_tcp_multifd;\n /*\n * Multifd is more complicated than most of the features, it\n * directly takes guest page buffers when sending, make sure\n@@ -450,7 +440,6 @@ static void test_multifd_tcp_no_zero_page(char *name, MigrateCommon *args)\n \n static void test_multifd_tcp_channels_none(char *name, MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_precopy_tcp_multifd;\n args->live = true;\n args->connect_channels = (\"[ { 'channel-type': 'main',\"\n \" 'addr': { 'transport': 'socket',\"\ndiff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-tests.c\nindex 275d0b84d4..f45f4c4b0c 100644\n--- a/tests/qtest/migration/tls-tests.c\n+++ b/tests/qtest/migration/tls-tests.c\n@@ -593,67 +593,9 @@ static void test_precopy_tcp_tls_x509_reject_anon_client(char *name,\n }\n #endif /* CONFIG_TASN1 */\n \n-static void *\n-migrate_hook_start_multifd_tcp_tls_psk_match(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_psk_match(from, to);\n-}\n-\n-static void *\n-migrate_hook_start_multifd_tcp_tls_psk_mismatch(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_psk_mismatch(from, to);\n-}\n-\n-#ifdef CONFIG_TASN1\n-static void *\n-migrate_hook_start_multifd_tls_x509_default_host(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_x509_default_host(from, to);\n-}\n-\n-static void *\n-migrate_hook_start_multifd_tls_x509_override_host(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_x509_override_host(from, to);\n-}\n-\n-static void *\n-migrate_hook_start_multifd_tls_x509_mismatch_host(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_x509_mismatch_host(from, to);\n-}\n-\n-static void *\n-migrate_hook_start_multifd_tls_x509_allow_anon_client(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_x509_allow_anon_client(from, to);\n-}\n-\n-static void *\n-migrate_hook_start_multifd_tls_x509_reject_anon_client(QTestState *from,\n- QTestState *to)\n-{\n- migrate_hook_start_precopy_tcp_multifd_common(from, to, \"none\");\n- return migrate_hook_start_tls_x509_reject_anon_client(from, to);\n-}\n-#endif /* CONFIG_TASN1 */\n-\n static void test_multifd_tcp_tls_psk_match(char *name, MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tcp_tls_psk_match;\n+ args->start_hook = migrate_hook_start_tls_psk_match;\n args->end_hook = migrate_hook_end_tls_psk;\n \n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n@@ -663,7 +605,7 @@ static void test_multifd_tcp_tls_psk_match(char *name, MigrateCommon *args)\n \n static void test_multifd_tcp_tls_psk_mismatch(char *name, MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tcp_tls_psk_mismatch;\n+ args->start_hook = migrate_hook_start_tls_psk_mismatch;\n args->end_hook = migrate_hook_end_tls_psk;\n args->result = MIG_TEST_FAIL;\n \n@@ -676,7 +618,7 @@ static void test_multifd_tcp_tls_psk_mismatch(char *name, MigrateCommon *args)\n static void test_multifd_postcopy_tcp_tls_psk_match(char *name,\n MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tcp_tls_psk_match;\n+ args->start_hook = migrate_hook_start_tls_psk_match;\n args->end_hook = migrate_hook_end_tls_psk;\n \n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n@@ -689,7 +631,7 @@ static void test_multifd_postcopy_tcp_tls_psk_match(char *name,\n static void test_multifd_tcp_tls_x509_default_host(char *name,\n MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tls_x509_default_host;\n+ args->start_hook = migrate_hook_start_tls_x509_default_host;\n args->end_hook = migrate_hook_end_tls_x509;\n \n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n@@ -700,7 +642,7 @@ static void test_multifd_tcp_tls_x509_default_host(char *name,\n static void test_multifd_tcp_tls_x509_override_host(char *name,\n MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tls_x509_override_host;\n+ args->start_hook = migrate_hook_start_tls_x509_override_host;\n args->end_hook = migrate_hook_end_tls_x509;\n \n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n@@ -724,7 +666,7 @@ static void test_multifd_tcp_tls_x509_mismatch_host(char *name,\n * to load migration state, and thus just aborts the migration\n * without exiting.\n */\n- args->start_hook = migrate_hook_start_multifd_tls_x509_mismatch_host;\n+ args->start_hook = migrate_hook_start_tls_x509_mismatch_host;\n args->end_hook = migrate_hook_end_tls_x509;\n args->result = MIG_TEST_FAIL;\n \n@@ -737,7 +679,7 @@ static void test_multifd_tcp_tls_x509_mismatch_host(char *name,\n static void test_multifd_tcp_tls_x509_allow_anon_client(char *name,\n MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tls_x509_allow_anon_client;\n+ args->start_hook = migrate_hook_start_tls_x509_allow_anon_client;\n args->end_hook = migrate_hook_end_tls_x509;\n \n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n@@ -748,7 +690,7 @@ static void test_multifd_tcp_tls_x509_allow_anon_client(char *name,\n static void test_multifd_tcp_tls_x509_reject_anon_client(char *name,\n MigrateCommon *args)\n {\n- args->start_hook = migrate_hook_start_multifd_tls_x509_reject_anon_client;\n+ args->start_hook = migrate_hook_start_tls_x509_reject_anon_client;\n args->end_hook = migrate_hook_end_tls_x509;\n args->result = MIG_TEST_FAIL;\n \n", "prefixes": [ "v1", "09/15" ] }