Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2233091/?format=api
{ "id": 2233091, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2233091/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-4-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260505160915.25558-4-farosas@suse.de>", "list_archive_url": null, "date": "2026-05-05T16:09:02", "name": "[v1,03/15] tests/qtest/migration: Set file URI by default", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7fbcb89da81e118d0fa61e100bb00c74392b9299", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/1.2/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-4-farosas@suse.de/mbox/", "series": [ { "id": 502864, "url": "http://patchwork.ozlabs.org/api/1.2/series/502864/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502864", "date": "2026-05-05T16:09:07", "name": "tests/qtest/migration: Always defer", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502864/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233091/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233091/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=DjSRJyc1;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=J2tyBysP;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=DjSRJyc1;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=J2tyBysP;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out1.suse.de;\n\tnone" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93SL4fcCz1yK2\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 02:12:18 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKIM3-0008Pt-V3; Tue, 05 May 2026 12:10:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKILI-00080E-R2\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:09:53 -0400", "from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKILG-00086L-I9\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:09:51 -0400", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 059276B763;\n Tue, 5 May 2026 16:09:28 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D6F49593A3;\n Tue, 5 May 2026 16:09:26 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id iGJfKTYW+mmNcgAAD6G6ig\n (envelope-from <farosas@suse.de>); Tue, 05 May 2026 16:09:26 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997368;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ih7EP1hGcdM62oFC55Hb51YORj/ldUEDXIPDlWObwhA=;\n b=DjSRJyc11thmgaRCfBShXIXbYY52q9XxP56zUX8ocUfOWD+mA4Mcv/CEokCuCouyeOrz0P\n yiHwOpD4psDztGDjarCO0kK5MjOIjAVZ/uwDIFh8bk4dLBiuyYRUbMrPVpZX8BY9VF/Jxn\n 2ev84Bqu/rhPnAZDKIbr+XDzvCn/Er8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997368;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ih7EP1hGcdM62oFC55Hb51YORj/ldUEDXIPDlWObwhA=;\n b=J2tyBysP5BP5xsqKOjN1SXlvYbwVbcK5bxIeyeG+hrgbIpdMu9mJC5QqWT6ElL8tjETuaV\n +7em3ixod9ram5DA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997368;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ih7EP1hGcdM62oFC55Hb51YORj/ldUEDXIPDlWObwhA=;\n b=DjSRJyc11thmgaRCfBShXIXbYY52q9XxP56zUX8ocUfOWD+mA4Mcv/CEokCuCouyeOrz0P\n yiHwOpD4psDztGDjarCO0kK5MjOIjAVZ/uwDIFh8bk4dLBiuyYRUbMrPVpZX8BY9VF/Jxn\n 2ev84Bqu/rhPnAZDKIbr+XDzvCn/Er8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997368;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ih7EP1hGcdM62oFC55Hb51YORj/ldUEDXIPDlWObwhA=;\n b=J2tyBysP5BP5xsqKOjN1SXlvYbwVbcK5bxIeyeG+hrgbIpdMu9mJC5QqWT6ElL8tjETuaV\n +7em3ixod9ram5DA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v1 03/15] tests/qtest/migration: Set file URI by default", "Date": "Tue, 5 May 2026 13:09:02 -0300", "Message-ID": "<20260505160915.25558-4-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260505160915.25558-1-farosas@suse.de>", "References": "<20260505160915.25558-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]", "X-Spam-Score": "-2.80", "Received-SPF": "pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Most file: tests use the same URI. Make it a default in the common\nfunction.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n tests/qtest/migration/file-tests.c | 29 -----------------------------\n tests/qtest/migration/framework.c | 6 ++++++\n 2 files changed, 6 insertions(+), 29 deletions(-)", "diff": "diff --git a/tests/qtest/migration/file-tests.c b/tests/qtest/migration/file-tests.c\nindex 75135447f8..4b6a2eeb7b 100644\n--- a/tests/qtest/migration/file-tests.c\n+++ b/tests/qtest/migration/file-tests.c\n@@ -67,9 +67,6 @@ static void test_file_connect_outgoing_fd_leak(char *name, MigrateCommon *args)\n \n static void test_precopy_file(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n- args->connect_uri = uri;\n test_file_common(args, true);\n }\n \n@@ -142,11 +139,6 @@ static void test_precopy_file_offset_bad(char *name, MigrateCommon *args)\n \n static void test_precopy_file_mapped_ram_live(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n-\n- args->connect_uri = uri;\n-\n args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n \n test_file_common(args, false);\n@@ -154,11 +146,6 @@ static void test_precopy_file_mapped_ram_live(char *name, MigrateCommon *args)\n \n static void test_precopy_file_mapped_ram(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n-\n- args->connect_uri = uri;\n-\n args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n \n test_file_common(args, true);\n@@ -166,10 +153,6 @@ static void test_precopy_file_mapped_ram(char *name, MigrateCommon *args)\n \n static void test_multifd_file_mapped_ram_live(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n- args->connect_uri = uri;\n-\n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n \n@@ -178,11 +161,6 @@ static void test_multifd_file_mapped_ram_live(char *name, MigrateCommon *args)\n \n static void test_multifd_file_mapped_ram(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n-\n- args->connect_uri = uri;\n-\n args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n \n@@ -200,9 +178,6 @@ static void *migrate_hook_start_multifd_mapped_ram_dio(QTestState *from,\n \n static void test_multifd_file_mapped_ram_dio(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n- args->connect_uri = uri;\n args->start_hook = migrate_hook_start_multifd_mapped_ram_dio;\n \n args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n@@ -316,10 +291,6 @@ static void migration_test_add_file_smoke(MigrationTestEnv *env)\n static void\n test_precopy_file_mapped_ram_ignore_shared(char *name, MigrateCommon *args)\n {\n- g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n- FILE_TEST_FILENAME);\n- args->connect_uri = uri;\n-\n args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n args->start.caps[MIGRATION_CAPABILITY_X_IGNORE_SHARED] = true;\n \ndiff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c\nindex edd3d0b165..42f565af7b 100644\n--- a/tests/qtest/migration/framework.c\n+++ b/tests/qtest/migration/framework.c\n@@ -971,11 +971,17 @@ void test_file_common(MigrateCommon *args, bool stop_src)\n QTestState *from, *to;\n void *data_hook = NULL;\n bool check_offset = false;\n+ g_autofree char *uri = NULL;\n \n if (migrate_start(&from, &to, \"defer\", &args->start)) {\n return;\n }\n \n+ if (!args->connect_uri) {\n+ uri = g_strdup_printf(\"file:%s/%s\", tmpfs, FILE_TEST_FILENAME);\n+ args->connect_uri = uri;\n+ }\n+\n /*\n * File migration is never live. We can keep the source VM running\n * during migration, but the destination will not be running\n", "prefixes": [ "v1", "03/15" ] }