Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2233023/?format=api
{ "id": 2233023, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2233023/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20260505142547.795054-3-johan@kernel.org/", "project": { "id": 35, "url": "http://patchwork.ozlabs.org/api/1.2/projects/35/?format=api", "name": "Linux I2C development", "link_name": "linux-i2c", "list_id": "linux-i2c.vger.kernel.org", "list_email": "linux-i2c@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260505142547.795054-3-johan@kernel.org>", "list_archive_url": null, "date": "2026-05-05T14:25:41", "name": "[2/8] i2c: core: fix adapter probe deferral loop", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ddfe2a2583af3b2f6a67fdd7b0e549754b2be6d6", "submitter": { "id": 64666, "url": "http://patchwork.ozlabs.org/api/1.2/people/64666/?format=api", "name": "Johan Hovold", "email": "johan@kernel.org" }, "delegate": { "id": 9049, "url": "http://patchwork.ozlabs.org/api/1.2/users/9049/?format=api", "username": "wsa", "first_name": "Wolfram", "last_name": "Sang", "email": "wolfram@the-dreams.de" }, "mbox": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20260505142547.795054-3-johan@kernel.org/mbox/", "series": [ { "id": 502847, "url": "http://patchwork.ozlabs.org/api/1.2/series/502847/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/list/?series=502847", "date": "2026-05-05T14:25:43", "name": "i2c: core: adapter registration fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502847/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233023/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-i2c+bounces-17256-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-i2c@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=scsN70i/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17256-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"scsN70i/\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g91Hw25p6z1yJx\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 00:34:52 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id EF85F309371F\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 May 2026 14:28:46 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 62875480976;\n\tTue, 5 May 2026 14:28:35 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id ABE01480331;\n\tTue, 5 May 2026 14:28:34 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 6A07AC2BCFA;\n\tTue, 5 May 2026 14:28:34 +0000 (UTC)", "from johan by xi.lan with local (Exim 4.98.2)\n\t(envelope-from <johan@kernel.org>)\n\tid 1wKGlE-00000003Ksu-0SGM;\n\tTue, 05 May 2026 16:28:32 +0200" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777991314; cv=none;\n b=TIcyUrb43AKvXXoER5iHji6T7qz5aTmghOb+YHu+AD0JBGxxfmO1tNRnY+2wjpsBuoN+bX9c5qdxRhrr2RKe7+cQEvKObLmh8bkLbH6Wwh00YNktKcZsuGRNFmPjWXdicdOS7Kt+aa8IqNIJlkU3lz0DX+NegEJ41YCPpCatHAI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777991314; c=relaxed/simple;\n\tbh=JIUw3NRme++76CpTBzA3sK9Ldz5NlkeSMePNeiX4fp0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=R7fl2nt1kO2qfP1nWPcXWFpBCZ6oRZjKXzxFTdNufJsGvJmAQi7wp/fRvN3tI8VKKgeAQlGtn7+d3SHxgPfSyLWNw/5vpMOIW/E9wdXRZMmObXisQOE0qKCvW9d9J79osV4ji1s6yLxhKkQpMdjlXXnGgaWFCTiSFpyd1nmeBVk=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=scsN70i/; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777991314;\n\tbh=JIUw3NRme++76CpTBzA3sK9Ldz5NlkeSMePNeiX4fp0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=scsN70i/yNeeY8COd38hlOlKRMGgCWqnqo08L3yIp/6JkltOasEKsdP0RZhu9ndkM\n\t gyuE3jEps2KOQav2YZRjeY1qYMH1XUOBwrpJzH5QlSFSoPFruapY0/R0L2BZDUpKC9\n\t Lx3rSiNZCQTTMzEqY8++zAqSc3O6AWrnr/dhOqhlOYNXzzZok7Vi64+CRooqmKO+PV\n\t NRDjwyWa/TP0Y4zdUhA3pfpikPpC8wFPBUXLp27h+Jz+L7MrsDykC7vvJEklXP5mn7\n\t MshypMnADhPHAUBOYxlkGUVuNAgo67eX6Al+aOWux0jbagG1jpiml8fNro+iarjziY\n\t wAqlqhq8RaOOA==", "From": "Johan Hovold <johan@kernel.org>", "To": "Wolfram Sang <wsa+renesas@sang-engineering.com>", "Cc": "Andi Shyti <andi.shyti@kernel.org>,\n\tlinux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tJohan Hovold <johan@kernel.org>,\n\tstable@vger.kernel.org,\n\tCodrin Ciubotariu <codrin.ciubotariu@microchip.com>", "Subject": "[PATCH 2/8] i2c: core: fix adapter probe deferral loop", "Date": "Tue, 5 May 2026 16:25:41 +0200", "Message-ID": "<20260505142547.795054-3-johan@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260505142547.795054-1-johan@kernel.org>", "References": "<20260505142547.795054-1-johan@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-i2c@vger.kernel.org", "List-Id": "<linux-i2c.vger.kernel.org>", "List-Subscribe": "<mailto:linux-i2c+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-i2c+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Drivers must not probe defer after having registered devices as that\nwill trigger a probe loop if the devices bind to a driver (cf. commit\nfbc35b45f9f6 (\"Add documentation on meaning of -EPROBE_DEFER\")).\n\nMove the recovery initialisation, where the GPIO lookup may fail, before\nregistering the adapter to prevent this.\n\nFixes: 75820314de26 (\"i2c: core: add generic I2C GPIO recovery\")\nCc: stable@vger.kernel.org\t# 5.9\nCc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>\nSigned-off-by: Johan Hovold <johan@kernel.org>\n---\n drivers/i2c/i2c-core-base.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c\nindex 7cec3f276e13..2832e1aa0ca3 100644\n--- a/drivers/i2c/i2c-core-base.c\n+++ b/drivers/i2c/i2c-core-base.c\n@@ -1562,6 +1562,10 @@ static int i2c_register_adapter(struct i2c_adapter *adap)\n \tadap->dev.type = &i2c_adapter_type;\n \tdevice_initialize(&adap->dev);\n \n+\tres = i2c_init_recovery(adap);\n+\tif (res == -EPROBE_DEFER)\n+\t\tgoto err_put_adap;\n+\n \t/*\n \t * This adapter can be used as a parent immediately after device_add(),\n \t * setup runtime-pm (especially ignore-children) before hand.\n@@ -1574,8 +1578,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)\n \tres = device_add(&adap->dev);\n \tif (res) {\n \t\tpr_err(\"adapter '%s': can't register device (%d)\\n\", adap->name, res);\n-\t\tput_device(&adap->dev);\n-\t\tgoto out_list;\n+\t\tgoto err_put_adap;\n \t}\n \n \tadap->debugfs = debugfs_create_dir(dev_name(&adap->dev), i2c_debugfs_root);\n@@ -1584,10 +1587,6 @@ static int i2c_register_adapter(struct i2c_adapter *adap)\n \tif (res)\n \t\tgoto out_reg;\n \n-\tres = i2c_init_recovery(adap);\n-\tif (res == -EPROBE_DEFER)\n-\t\tgoto out_reg;\n-\n \tdev_dbg(&adap->dev, \"adapter [%s] registered\\n\", adap->name);\n \n \t/* create pre-declared device nodes */\n@@ -1608,8 +1607,10 @@ static int i2c_register_adapter(struct i2c_adapter *adap)\n out_reg:\n \ti2c_deregister_clients(adap);\n \tdebugfs_remove_recursive(adap->debugfs);\n+\tdevice_del(&adap->dev);\n+err_put_adap:\n \tinit_completion(&adap->dev_released);\n-\tdevice_unregister(&adap->dev);\n+\tput_device(&adap->dev);\n \twait_for_completion(&adap->dev_released);\n out_list:\n \tmutex_lock(&core_lock);\n", "prefixes": [ "2/8" ] }