Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2233010/?format=api
{ "id": 2233010, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2233010/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260505134929.3522938-5-aarsenovic@baylibre.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.2/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260505134929.3522938-5-aarsenovic@baylibre.com>", "list_archive_url": null, "date": "2026-05-05T13:15:00", "name": "[4/4] libgomp/oacc-mem: add missing assert to goacc_enter_datum", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1e68733e771095106bfd2f7eca64e51bd97d8247", "submitter": { "id": 92125, "url": "http://patchwork.ozlabs.org/api/1.2/people/92125/?format=api", "name": "Arsen Arsenović", "email": "aarsenovic@baylibre.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260505134929.3522938-5-aarsenovic@baylibre.com/mbox/", "series": [ { "id": 502845, "url": "http://patchwork.ozlabs.org/api/1.2/series/502845/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=502845", "date": "2026-05-05T13:14:59", "name": "GCN: Target offload overhead improvements, batch 2", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502845/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2233010/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2233010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=RvpmPEG4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=RvpmPEG4", "sourceware.org;\n dmarc=none (p=none dis=none) header.from=baylibre.com", "sourceware.org; spf=pass smtp.mailfrom=baylibre.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=2a00:1450:4864:20::630" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g90K34Nyvz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 05 May 2026 23:50:47 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 95C214BA9031\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 May 2026 13:50:45 +0000 (GMT)", "from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n [IPv6:2a00:1450:4864:20::630])\n by sourceware.org (Postfix) with ESMTPS id 9FBB54BA9001\n for <gcc-patches@gcc.gnu.org>; Tue, 5 May 2026 13:50:14 +0000 (GMT)", "by mail-ej1-x630.google.com with SMTP id\n a640c23a62f3a-b79f8f7ea43so835142066b.2\n for <gcc-patches@gcc.gnu.org>; Tue, 05 May 2026 06:50:14 -0700 (PDT)", "from localhost ([146.70.193.12])\n by smtp.googlemail.com with ESMTPSA id\n a640c23a62f3a-bbe6d977b7esm518839166b.48.2026.05.05.06.50.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 06:50:12 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 95C214BA9031", "OpenDKIM Filter v2.11.0 sourceware.org 9FBB54BA9001" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 9FBB54BA9001", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 9FBB54BA9001", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777989014; cv=none;\n b=t19eDtt6xtpSDuJGrtIVeXTXKdNE1BYGUx1zJRdtYVJNpZL1UjCf0cyEqJkElNUdgDDBcsloAjFyWMtHNkWDeCsOzRiyNfll5aEj8oXDtVUvnj0v9CYMaxPsYQtO5b8xB07czTEElmjcjlb8m8hOP0+U/xDlSHwyLD3FpYYHAPU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777989014; c=relaxed/simple;\n bh=bUkfS+B1yPjtjxI8fSMEqjeZ3aKhh788KGnqsEx/PCw=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=fxGzkwOdoWPDnOLq3W1ghhXL0I3fPF14t1PqiBjfcKUEdHMCVrymH8p+ghKMkfeOBWr0DM6VA1n2B7doxBB7n+avmj8nj6XeOfcjfaTpd12yvNhMl38/+9pRSfMeY9QX2VRdVyFkW66N3URggj++JatvI98C5wbEmlWxp5oBVRo=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777989013;\n x=1778593813;\n darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=phgIGJPQ18QVTkr74U51guvdcGCaRQDdbklhL0rPaxE=;\n b=RvpmPEG47608QRf7R6RyE+ou3dhYW8PYSqyIgpcGF8mhclb1Ix+ailNjaJZ9px2pab\n Az+aiw8ISHzq4dshFeEjVIcfYQWmF/9lLPOFkbkTu0v6SiKu+g2fe1fyJUeqYXRKg+rC\n lAwdtbwYlSXS1h8k5Ie31JYPkUTwDMRV4E/77EzzIDurD/QvK2VCI9UvL9fQRItjNgct\n AkoVmnc9/Jsp/MknF2z6l6jIeDmciMtL4WDPUX02PNR7l2PH5Ojv6fssjvYkTSd7K306\n HmNO60p/bdH0itEOMf5WdCYMamrv2Zqs1eaiIx2qVxKxFTlL7OzhRHs6iU21chaLol0h\n xfRQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777989013; x=1778593813;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=phgIGJPQ18QVTkr74U51guvdcGCaRQDdbklhL0rPaxE=;\n b=BWULSbjFOH478ITQzWxoCbvO+egwah2ID2R0LVpkoISLasV6aKkzVaKivvmWwDS+8B\n 4ogU7Gz8hOIqClDeCkXcQsla/EYcehHVrje7hKRjrc4HdXO0Q7rHKvrTyP4qN8RpKxLP\n 1uxxN/goZoY0tOpc+KGqT7jYscY4+6TGzQGUvrhvO1TuiKaCSXZjXJP+yEGpoZ0CZwGH\n YBkchjsVYZdlWaaquuc+9qbyF5PzOLatwbMyzWIhorkjeS7NjnhJy5VXfdyRgEDtk8se\n sDjTtXTazaxJY288rP+H32mEvpbQ4YFdCfg/dKOFxC4mRAEkr0dK/jfAdm3iRhs5aShl\n mGdw==", "X-Gm-Message-State": "AOJu0YzOq23XflKiTSRcFzbH7IROshSWpU51PqCsELso9LZwLv5zIRhg\n crJCPY2+QFB77sJqk6UDAHT3Wp6MB56BVnhekvIVtEmZRi3jzWqse7JQjB9ESVBF5D+nIfQnwwj\n a2hbxGlU=", "X-Gm-Gg": "AeBDietCWnFZeps57lyH9c27fUzox1m0x7BhdwRwOWF7cp9MPMuJdAcdNhD7SwJHvYW\n k0h+zQEeINPLkDb71FZ9TL/SYMGDJH2RCyAEreY5XcLHZeIZ5qJKN/Qaue/+k/a+Pt4RLl3bJgQ\n YqfgkRS5YI54LYiCLWoWgM8ZeSFnz6SuQJ1gUolHtAiFndm+ISutXo9Z9RHJmps5nNSCenyD55u\n 9uNBacKsz7//u9avhrMWLHcW3YMgVKRTGSQkay9pgwVToYhYqTZQg4p8UWsrAQh4tmr50pmRJOu\n LqLCE9xCBRtgymJj792WRvdkGCB+UeiZBU/cOWrfVVm8pEm2iYn6oFaIZkbG8KviMY6zXMrWDQn\n /rr8FNjP9X+efLpwKfiANCTZuaBuqBU2Ycu77kJN9kf2Z37NYXFT3knu+M99FiMV3cZPfgwUU1H\n VXrHhAWIFmLX/VeUpuAae7xttGlITaoB7fdp0=", "X-Received": "by 2002:a17:907:da1:b0:bc2:774c:5a3f with SMTP id\n a640c23a62f3a-bc2774c62e3mr498432766b.6.1777989012710;\n Tue, 05 May 2026 06:50:12 -0700 (PDT)", "From": "=?utf-8?q?Arsen_Arsenovi=C4=87?= <aarsenovic@baylibre.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "=?utf-8?q?Arsen_Arsenovi=C4=87?= <aarsenovic@baylibre.com>", "Subject": "[PATCH 4/4] libgomp/oacc-mem: add missing assert to goacc_enter_datum", "Date": "Tue, 5 May 2026 15:15:00 +0200", "Message-ID": "<20260505134929.3522938-5-aarsenovic@baylibre.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260505134929.3522938-1-aarsenovic@baylibre.com>", "References": "<20260505134929.3522938-1-aarsenovic@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "A bug I accidentally introduced made it so that new variables are\nallocated with some room to spare before them, and ergo, that tgt_offset\n!= 0, leading to tests failing in what looked like a strange way. Turns\nout, goacc_enter_datum was failing to validate its assumption that\ntgt_offset == 0. This patch adds that assert.\n\nlibgomp/ChangeLog:\n\n\t* oacc-mem.c (goacc_enter_datum): Assert that tgt_offset of the\n\tnewly-mapped variable is zero.\n---\n libgomp/oacc-mem.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/libgomp/oacc-mem.c b/libgomp/oacc-mem.c\nindex 5601daf13957..f9ceb094d156 100644\n--- a/libgomp/oacc-mem.c\n+++ b/libgomp/oacc-mem.c\n@@ -593,6 +593,9 @@ goacc_enter_datum (void **hostaddrs, size_t *sizes, void *kinds, int async)\n assert (n);\n assert (n->refcount == 1);\n assert (n->dynamic_refcount == 0);\n+ assert (/* This is only reached if we're mapping a new, singular\n+\t\t variable, and so, its offset ought to be zero. */\n+\t n->tgt_offset == 0);\n n->dynamic_refcount++;\n \n d = (void *) tgt->tgt_start;\n", "prefixes": [ "4/4" ] }