Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2232210/?format=api
{ "id": 2232210, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2232210/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260503204936.3151124-6-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260503204936.3151124-6-sjg@chromium.org>", "list_archive_url": null, "date": "2026-05-03T20:49:23", "name": "[5/6] mccmon6: Quote recovery_status in bootcmd test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8f788353ef01e0b1d72cd5f500e83ae371f537ee", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/1.2/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260503204936.3151124-6-sjg@chromium.org/mbox/", "series": [ { "id": 502588, "url": "http://patchwork.ozlabs.org/api/1.2/series/502588/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502588", "date": "2026-05-03T20:49:18", "name": "test: Quote variables in 'test -n' expressions across boards", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502588/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232210/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=SPzuK+jd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"SPzuK+jd\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7xkb34zmz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 06:50:47 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 61F4D8465C;\n\tSun, 3 May 2026 22:50:27 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 187558464D; Sun, 3 May 2026 22:50:26 +0200 (CEST)", "from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com\n [IPv6:2607:f8b0:4864:20::32e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A7E248465C\n for <u-boot@lists.denx.de>; Sun, 3 May 2026 22:50:23 +0200 (CEST)", "by mail-ot1-x32e.google.com with SMTP id\n 46e09a7af769-7df05fc49e5so197985a34.3\n for <u-boot@lists.denx.de>; Sun, 03 May 2026 13:50:23 -0700 (PDT)", "from chromium.org ([174.51.25.52]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-696aacbb5bbsm1142940eaf.15.2026.05.03.13.50.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 03 May 2026 13:50:19 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777841422; x=1778446222; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5y0MMJ+PALVDpqV2fL5w3ouH0TD4nReMRMutIunEU3E=;\n b=SPzuK+jdDVKWU/VChpnzL4nCWl2Q9zSOxgUkZagv/nEcB+xPyRgjdm+dUbFNx4aXB1\n FUhmrPKWlaYEns6Jl7hS1ucHu2YTjrV6kdVGgiPuqwmp7/MY0mACMpvlXu8le30BJzR9\n fQzfPfaC9gay4sqNpcpwS7eq99iSLusURB1Q4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777841422; x=1778446222;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5y0MMJ+PALVDpqV2fL5w3ouH0TD4nReMRMutIunEU3E=;\n b=Bb2Mysar9f4Eut+/jGR/mLzpdq5qzidfu+BGFlsKf2CxomzcgvM2dG66klZwi9fHjg\n dg2/7DRD1Z4XZ7/gJ4cdN0RsSgcge7thPpJE2DSfu6lTQ7fVmJ7ClmrgGbS42tpM6FDi\n Lbxo8E9oe7ZFVNinXn0m//1Tb6PjoCxxF0Mi2jkhTmJ8zu31p7eChGRQgXeutjFZ+PN4\n gVu73GvNHBX9Ph3VjyVs4ECYmQQAvew/sgwz2yDqY/bGlHk1ei5LyGf7oJG+MWJ2wSQI\n 3YArabD6m/I/3PRbgt1VHRKEgMBQbq7lp45WCFiD2mvesfRrvkbIRdguE5NszOjQr0vN\n /gSA==", "X-Gm-Message-State": "AOJu0YxYWHUjgC1qojs2Bo1tsMuyxgBwGCOygvDdY+xJW9Kwk4pvY6jF\n YtcA1/BVwZ0wMoUTeixNflqGLNFhZ7hhgvuWOA1k3wWaSK/OUQuk/jIg9xuWBj7PxBxcEaSzP3P\n 4g/s58Q==", "X-Gm-Gg": "AeBDieuAGQ4VPFGmWRU7aHzZPQM7ZHLqE0X4Rfw3pshhXeW0M+DfeA3ah9vTPAfXQQ8\n qcXkEo3TIiOhMWqjYk3rA7JyYtpP8edqY3YKklaOWzKHekP/AwDRR9Q0dozhf3HOWiqvIdBBcTo\n mvQDiP2DSXquUVZKl5tfOpYuFQ+zlGo//GVq1RUwlOIj1/bDIDdCU3OWF0LPqIfcq0Xibg5TfFw\n f6JfSRM6TUCJ9YsWYsRANZyQw574I+yVwrmiTBItY2YWhH3hOh2GYk3c2XbzDZznycHIbcb37pc\n BO5jczysMwrQBWq2QzWN6KB/mQVpYQHLS7HMeoJuGjM3uzDsxlOXm7uJTNmbbAu8qh9FogTuCHh\n r+8EIU1TExjlB08HfjKDmcLPgY5hcsXCNSDgWFc6TTD9kq8tk9WitwdKh9WuIX55Vb9eTILrY/c\n iTf1/TMSGsvkkSaC5H09B34Qnz08jD", "X-Received": "by 2002:a05:6820:1789:b0:694:8428:dfd8 with SMTP id\n 006d021491bc7-69697c60c77mr3188435eaf.34.1777841421835;\n Sun, 03 May 2026 13:50:21 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Simon Glass <sjg@chromium.org>, Lukasz Majewski <lukma@denx.de>,\n Rasmus Villemoes <ravi@prevas.dk>, Tom Rini <trini@konsulko.com>,\n\t=?utf-8?q?=C5=81ukasz_Majewski?= <lukma@nabladev.com>", "Subject": "[PATCH 5/6] mccmon6: Quote recovery_status in bootcmd test", "Date": "Sun, 3 May 2026 14:49:23 -0600", "Message-ID": "<20260503204936.3151124-6-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260503204936.3151124-1-sjg@chromium.org>", "References": "<20260503204936.3151124-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The mccmon6 bootcmd starts with:\n\n if test -n ${recovery_status}; then run boot_recovery; ...\n\nThe default state is \"no recovery requested\", i.e. recovery_status\nunset. The expression then expands to 'test -n' with no operand and\nrelies on a U-Boot 'test' quirk that treats a missing operand as\nfalse to skip recovery.\n\nQuote the variable so an unset recovery_status expands to 'test -n \"\"'\nand the emptiness check is explicit.\n\nFixes: 8b0619579b22 (\"cmd: test: fix handling of single-argument form of test\")\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n include/configs/mccmon6.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/configs/mccmon6.h b/include/configs/mccmon6.h\nindex 9f401718bfb..0cf62d6bda8 100644\n--- a/include/configs/mccmon6.h\n+++ b/include/configs/mccmon6.h\n@@ -88,7 +88,7 @@\n \t\t \"bootm $loadaddr};reset;\" \\\n \t\t\"fi\\0\" \\\n \t\"bootcmd=\" \\\n-\t\t\"if test -n ${recovery_status}; then \" \\\n+\t\t\"if test -n \\\"${recovery_status}\\\"; then \" \\\n \t\t \"run boot_recovery;\" \\\n \t\t\"else \" \\\n \t\t \"if test ! -n ${boot_medium}; then \" \\\n", "prefixes": [ "5/6" ] }