Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2232174/?format=api
{ "id": 2232174, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2232174/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260503083220.630655-4-rc@rexion.ai/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.2/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260503083220.630655-4-rc@rexion.ai>", "list_archive_url": null, "date": "2026-05-03T08:32:19", "name": "[net-next,v3,3/4] netfilter: nf_conntrack_amanda: use nf_ct_helper_parse_port()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c79d0dad55a39883526c8c61b77d1d300c92a70c", "submitter": { "id": 93293, "url": "http://patchwork.ozlabs.org/api/1.2/people/93293/?format=api", "name": "HACKE-RC", "email": "rc@rexion.ai" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260503083220.630655-4-rc@rexion.ai/mbox/", "series": [ { "id": 502571, "url": "http://patchwork.ozlabs.org/api/1.2/series/502571/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502571", "date": "2026-05-03T08:32:16", "name": "netfilter: conntrack: shared port parser for helpers", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/502571/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232174/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232174/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-12398-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=rexion.ai\n header.i=@rexion.ai header.a=rsa-sha256 header.s=spacemail header.b=l7ARc+xT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12398-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key) header.d=rexion.ai\n header.i=@rexion.ai header.b=\"l7ARc+xT\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=63.250.43.96", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=rexion.ai", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=rexion.ai" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7dND0VTKz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 03 May 2026 18:33:48 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 6BC9E300531A\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 3 May 2026 08:33:08 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 305E03B19A5;\n\tSun, 3 May 2026 08:32:53 +0000 (UTC)", "from out-13.smtp.spacemail.com (out-13.smtp.spacemail.com\n [63.250.43.96])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B2F13AD508;\n\tSun, 3 May 2026 08:32:51 +0000 (UTC)", "from Kyren (unknown [49.207.224.37])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mail.spacemail.com (Postfix) with ESMTPSA id 4g7dLx28Lnz8sc7;\n\tSun, 03 May 2026 08:32:41 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777797172; cv=none;\n b=JWP3uDH4/79wInQYYCtprl8JbWf3wyqed1mPEg6SKT7vmRrKjt3B48Chw7atiTzlKy14mPiFtOYykkXcD//G1xwC1uNZIhfWTWJkWFXhtKXDoYbVCAr7MA6IeruF5ZZtjbJ9WqJ3YaYEUM0zHHPRsjmUSJ7QMgPqf+q3rZOCQek=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777797172; c=relaxed/simple;\n\tbh=7+OtTcSi3j2IBmO1D9XL1RlcOQN0GcUfX//8dJ3E1DY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=XIEZBpPccaUHKRj2EZNQkHIvm7o6vj7EnivyoWpmz/1s7gz0qmLhk0tIDrTYEVZ1CIeYG8SI6JTesicFzSTUhzhiVU1ODAF3Ef+gMOsr2MV4T3+30EdXVj/WbFI10sWv5qXaeAEM4SJrMoAw49TvdX4/jqVDMedcsawQVqElsMc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=rexion.ai;\n spf=pass smtp.mailfrom=rexion.ai;\n dkim=fail (0-bit key) header.d=rexion.ai header.i=@rexion.ai\n header.b=l7ARc+xT reason=\"key not found in DNS\";\n arc=none smtp.client-ip=63.250.43.96", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=rexion.ai;\n\ts=spacemail; t=1777797165;\n\tbh=HI0hFyyueMYp+zi669wZ/Jih9kqfRtZ1thk4taphQEU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l7ARc+xTuE4J90MzxV8cV16qV4uIwZ1IOersSJL8SqoAPXE5I6ow72khsZXPsnFo5\n\t qx6kiU+X1vYdwPjVdoI6689rjHbOesplnbp+KG6d4zBlQiJ+klBHI9mHdm3XfGyWVq\n\t y5J6U9fBSCiBZE/CTPOxrfxtUdLyEhKVp/YMZDDVXx9uwS8NeAj5uDSQS4dX2dQFGQ\n\t BTYZMg6HOWP3gWz/+RiCsVO749HYJWcemQkOidTByByY4f+jNpKqQzTsUFLNmJo2jx\n\t MK6WGKhAVfnOtlT784p/puO1PGIzr+3LrdTUE/EWKVvd32bsOnxzsdrO+BLrnQD8m8\n\t KLoalh02xQG9A==", "From": "HACKE-RC <rc@rexion.ai>", "To": "Pablo Neira Ayuso <pablo@netfilter.org>,\n\tFlorian Westphal <fw@strlen.de>", "Cc": "Phil Sutter <phil@nwl.cc>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tSimon Horman <horms@kernel.org>,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHACKE-RC <rc@rexion.ai>", "Subject": "[PATCH net-next v3 3/4] netfilter: nf_conntrack_amanda: use\n nf_ct_helper_parse_port()", "Date": "Sun, 3 May 2026 14:02:19 +0530", "Message-ID": "<20260503083220.630655-4-rc@rexion.ai>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260503083220.630655-1-rc@rexion.ai>", "References": "<afSBzDE-caw3Dsr1@orbyte.nwl.cc>\n <20260503083220.630655-1-rc@rexion.ai>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Envelope-From": "rc@rexion.ai" }, "content": "Replace simple_strtoul() with the new nf_ct_helper_parse_port() helper.\nThis removes the dependency on NUL-terminated strings and adds an\nexplicit port range check, rejecting port 0 and values above 65535.\n\nFixes: 16958900578b (\"netfilter: nf_conntrack_amanda: the match is called 'amanda', not 'AMANDA'\")\nSigned-off-by: HACKE-RC <rc@rexion.ai>\n---\n net/netfilter/nf_conntrack_amanda.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/net/netfilter/nf_conntrack_amanda.c b/net/netfilter/nf_conntrack_amanda.c\nindex d2c09e8dd..30b5c4b84 100644\n--- a/net/netfilter/nf_conntrack_amanda.c\n+++ b/net/netfilter/nf_conntrack_amanda.c\n@@ -88,11 +88,12 @@ static int amanda_help(struct sk_buff *skb,\n \tstruct nf_conntrack_expect *exp;\n \tstruct nf_conntrack_tuple *tuple;\n \tunsigned int dataoff, start, stop, off, i;\n+\tnf_nat_amanda_hook_fn *nf_nat_amanda;\n \tchar pbuf[sizeof(\"65535\")], *tmp;\n+\tint ret = NF_ACCEPT;\n \tu_int16_t len;\n+\tu16 parsed_port;\n \t__be16 port;\n-\tint ret = NF_ACCEPT;\n-\tnf_nat_amanda_hook_fn *nf_nat_amanda;\n \n \t/* Only look at packets from the Amanda server */\n \tif (CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL)\n@@ -132,10 +133,10 @@ static int amanda_help(struct sk_buff *skb,\n \t\t\tbreak;\n \t\tpbuf[len] = '\\0';\n \n-\t\tport = htons(simple_strtoul(pbuf, &tmp, 10));\n-\t\tlen = tmp - pbuf;\n-\t\tif (port == 0 || len > 5)\n+\t\tif (nf_ct_helper_parse_port(pbuf, len, &parsed_port, &tmp))\n \t\t\tbreak;\n+\t\tport = htons(parsed_port);\n+\t\tlen = tmp - pbuf;\n \n \t\texp = nf_ct_expect_alloc(ct);\n \t\tif (exp == NULL) {\n", "prefixes": [ "net-next", "v3", "3/4" ] }