Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2227970/?format=api
{ "id": 2227970, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2227970/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-8-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260424154205.364268-8-berrange@redhat.com>", "list_archive_url": null, "date": "2026-04-24T15:41:55", "name": "[07/16] scripts/mtest2make: support optional tests grouping", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b2f8a942e7c172a894f9492fd66027e2f994f679", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/1.2/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-8-berrange@redhat.com/mbox/", "series": [ { "id": 501385, "url": "http://patchwork.ozlabs.org/api/1.2/series/501385/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501385", "date": "2026-04-24T15:41:48", "name": "tests: do more testing of block drivers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501385/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227970/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=O7aCDEd+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2HN46PSqz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 01:45:08 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGIgl-0003Rm-U5; Fri, 24 Apr 2026 11:43:32 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wGIg3-0002ra-8f\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:42:54 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wGIfy-0007QH-Vx\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:42:45 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-zdvh2O1TMR6G8WiFxiZe3w-1; Fri,\n 24 Apr 2026 11:42:39 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D1A1D195608E; Fri, 24 Apr 2026 15:42:37 +0000 (UTC)", "from thinkbook.redhat.com (unknown [10.44.32.213])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id BB00A180047F; Fri, 24 Apr 2026 15:42:34 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777045362;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=VnI1RDbgdvo404hxXw3xEguMYroCOb9KqKhMBQ7BDM8=;\n b=O7aCDEd+UcFZgbWXl8EW5nuEozsV8ULNJAPt57oa32l1yrQQ45QYdnaR/u5CbfRy8CMn2t\n vfIgrk9PASUTy0J4dbrjmwvXBGnT/iqBHHF2UQKMy3QjdY4ZmBP/fbuUtREnO41pM2crjr\n L2ZORNKUrrb7tra4cUm8pyoFCw+x9iY=", "X-MC-Unique": "zdvh2O1TMR6G8WiFxiZe3w-1", "X-Mimecast-MFC-AGG-ID": "zdvh2O1TMR6G8WiFxiZe3w_1777045357", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Hanna Reitz <hreitz@redhat.com>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= <alex.bennee@linaro.org>, qemu-block@nongnu.org,\n Cleber Rosa <crosa@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n John Snow <jsnow@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH 07/16] scripts/mtest2make: support optional tests grouping", "Date": "Fri, 24 Apr 2026 16:41:55 +0100", "Message-ID": "<20260424154205.364268-8-berrange@redhat.com>", "In-Reply-To": "<20260424154205.364268-1-berrange@redhat.com>", "References": "<20260424154205.364268-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "12", "X-Spam_score": "1.2", "X-Spam_bar": "+", "X-Spam_report": "(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Currently tests can be classified into three speed groups depending on\nwhether the meson suite name ends in '-slow' or '-thorough' or neither.\n\nThis gets turned into make targets that match the name of the meson\nsuite, with the speed suffix stripped. e.g.\n\n * suite=block -> 'make check-block'\n * suite=block-slow -> 'make check-block SPEED=slow'\n * suite=block-thorough -> 'make check-block SPEED=thorough'\n\nThe set of tests under the \"thorough\" speed, however, can get rather\nlarge and it would be useful to have a way to expose further make\ntargets for directly running a particular subset of tests.\n\nThis needs a way to run a target without requiring the SPEED variable,\nwhile also not having them enabled by default as if they were 'quick'\ntests.\n\nThis modifies mtest2make.py to support this idea by allowing for a new\nsuffix '-optional' on a suite. When this is present, a correspondingly\nnamed make target will be created without the '-optional' suffix which\nwill never be run automatically.\n\nThis is intended to be combined with use of other suites. For example,\na single NBD test might be added to two suites, 'block-thorough' and\n'block-nbd-optional'.\n\nThis would allow running it as part of all the block tests with\n'make check-block SPEED=thorough', and as part of a standalone target\n'make check-block-nbd'.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n scripts/mtest2make.py | 22 +++++++++++++++-------\n 1 file changed, 15 insertions(+), 7 deletions(-)", "diff": "diff --git a/scripts/mtest2make.py b/scripts/mtest2make.py\nindex 915f02d600..383ea68b16 100644\n--- a/scripts/mtest2make.py\n+++ b/scripts/mtest2make.py\n@@ -22,7 +22,7 @@ def names(self, base):\n print(r'''\n SPEED = quick\n \n-.speed.quick = $(sort $(filter-out %-slow %-thorough, $1))\n+.speed.quick = $(sort $(filter-out %-slow %-thorough %-optional, $1))\n .speed.slow = $(sort $(filter-out %-thorough, $1))\n .speed.thorough = $(sort $1)\n \n@@ -66,10 +66,15 @@ def process_tests(test, targets, suites):\n s = s[:-9]\n suites[s].speeds.add('thorough')\n \n+def target_name(suite):\n+ if suite.endswith('-optional'):\n+ return suite[0:-9]\n+ return suite\n+\n def emit_prolog(suites, prefix):\n- all_targets = ' '.join((f'{prefix}-{k}'\n+ all_targets = ' '.join((f'{prefix}-{target_name(k)}'\n for k in sorted(suites.keys())))\n- all_xml = ' '.join((f'{prefix}-report-{k}.junit.xml'\n+ all_xml = ' '.join((f'{prefix}-report-{target_name(k)}.junit.xml'\n for k in sorted(suites.keys())))\n print()\n print(f'all-{prefix}-targets = {all_targets}')\n@@ -83,14 +88,17 @@ def emit_prolog(suites, prefix):\n print(f'\\t$(MAKE) {prefix}$* MTESTARGS=\"$(MTESTARGS) --logbase {prefix}-report$*\" && ln -f meson-logs/$@ .')\n \n def emit_suite(name, suite, prefix):\n+ tgtname = target_name(name)\n deps = ' '.join(sorted(suite.deps))\n print()\n- print(f'.{prefix}-{name}.deps = {deps}')\n- print(f'.ninja-goals.check-build += $(.{prefix}-{name}.deps)')\n+ print(f'.{prefix}-{tgtname}.deps = {deps}')\n+ print(f'.ninja-goals.check-build += $(.{prefix}-{tgtname}.deps)')\n \n names = ' '.join(sorted(suite.names(name)))\n- targets = f'{prefix}-{name} {prefix}-report-{name}.junit.xml'\n- if not name.endswith('-slow') and not name.endswith('-thorough'):\n+ targets = f'{prefix}-{tgtname} {prefix}-report-{tgtname}.junit.xml'\n+ if not name.endswith('-slow') and \\\n+ not name.endswith('-thorough') and \\\n+ not name.endswith('-optional'):\n targets += f' {prefix} {prefix}-report.junit.xml'\n print(f'ifneq ($(filter {targets}, $(MAKECMDGOALS)),)')\n # for the \"base\" suite possibly add FOO-slow and FOO-thorough\n", "prefixes": [ "07/16" ] }