Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2227462/?format=api
{ "id": 2227462, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2227462/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-38-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423191958.1440-38-farosas@suse.de>", "list_archive_url": null, "date": "2026-04-23T19:19:51", "name": "[PULL,37/43] io/channel: introduce qio_channel_pwrite{v,}_all()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d545118e3c435cf5dd4f0b34cf2564c9eaabc914", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/1.2/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-38-farosas@suse.de/mbox/", "series": [ { "id": 501236, "url": "http://patchwork.ozlabs.org/api/1.2/series/501236/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236", "date": "2026-04-23T19:19:14", "name": "[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501236/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227462/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227462/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=aBbgE4Jh;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=HljIdD+8;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=aBbgE4Jh;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=HljIdD+8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mFb1q4Nz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 05:22:43 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFzdB-0005Nf-Rd; Thu, 23 Apr 2026 15:22:34 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wFzcX-00041k-FQ\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:53 -0400", "from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wFzcV-0002AG-Kj\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:53 -0400", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 6E0195BD73;\n Thu, 23 Apr 2026 19:20:58 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 62023593A3;\n Thu, 23 Apr 2026 19:20:57 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id AHikCxlx6mlJCwAAD6G6ig\n (envelope-from <farosas@suse.de>); Thu, 23 Apr 2026 19:20:57 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972058;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GmWBn+PWgun7VfH09Qi3uCBSo1bZ1EKgN6Mqu3svIfM=;\n b=aBbgE4Jhbsi6YZCrr8QAsh6x2yMG1B66DSugVDU+Z/26Ck6XVMBoEdskh6LsPtj+UuvltE\n SQfQkJqDpjzNo9jQgT4jZQbwTwfTTFQZO7HYDZBlqDGD2PecjwwhqkMD68GGpwQo0T64Z+\n P3YcnJILHCJzIwZOba2vYpPVvQto9YI=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972058;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GmWBn+PWgun7VfH09Qi3uCBSo1bZ1EKgN6Mqu3svIfM=;\n b=HljIdD+8BWd9YXy5rQoBDFyMrP6dxncEfy4HvO2KnW3yz9ZMCRvI74fpOzTdayxHPGsUSQ\n 9gpApERDUz6h4sCA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972058;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GmWBn+PWgun7VfH09Qi3uCBSo1bZ1EKgN6Mqu3svIfM=;\n b=aBbgE4Jhbsi6YZCrr8QAsh6x2yMG1B66DSugVDU+Z/26Ck6XVMBoEdskh6LsPtj+UuvltE\n SQfQkJqDpjzNo9jQgT4jZQbwTwfTTFQZO7HYDZBlqDGD2PecjwwhqkMD68GGpwQo0T64Z+\n P3YcnJILHCJzIwZOba2vYpPVvQto9YI=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972058;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GmWBn+PWgun7VfH09Qi3uCBSo1bZ1EKgN6Mqu3svIfM=;\n b=HljIdD+8BWd9YXy5rQoBDFyMrP6dxncEfy4HvO2KnW3yz9ZMCRvI74fpOzTdayxHPGsUSQ\n 9gpApERDUz6h4sCA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>,\n\tJunjie Cao <junjie.cao@intel.com>", "Subject": "[PULL 37/43] io/channel: introduce qio_channel_pwrite{v,}_all()", "Date": "Thu, 23 Apr 2026 16:19:51 -0300", "Message-ID": "<20260423191958.1440-38-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260423191958.1440-1-farosas@suse.de>", "References": "<20260423191958.1440-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-2.80", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,intel.com:email,suse.de:mid,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[]", "Received-SPF": "pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Junjie Cao <junjie.cao@intel.com>\n\nAdd positioned write helpers that retry on short writes, matching\nthe pread_all family from the previous patch.\n\n qio_channel_pwritev_all() -- retry loop; returns 0 on success,\n -1 on error.\n qio_channel_pwrite_all() -- single-buffer convenience wrapper.\n\nSigned-off-by: Junjie Cao <junjie.cao@intel.com>\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nLink: https://lore.kernel.org/qemu-devel/20260413214549.926435-3-junjie.cao@intel.com\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n include/io/channel.h | 41 +++++++++++++++++++++++++++++++++++++\n io/channel.c | 48 ++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 89 insertions(+)", "diff": "diff --git a/include/io/channel.h b/include/io/channel.h\nindex 47af409ede..287d10cd6f 100644\n--- a/include/io/channel.h\n+++ b/include/io/channel.h\n@@ -598,6 +598,47 @@ ssize_t qio_channel_pwritev(QIOChannel *ioc, const struct iovec *iov,\n ssize_t qio_channel_pwrite(QIOChannel *ioc, void *buf, size_t buflen,\n off_t offset, Error **errp);\n \n+/**\n+ * qio_channel_pwritev_all:\n+ * @ioc: the channel object\n+ * @iov: the array of memory regions to write data from\n+ * @niov: the length of the @iov array\n+ * @offset: the starting offset in the channel to write to\n+ * @errp: pointer to a NULL-initialized error object\n+ *\n+ * Writes @iov, possibly blocking or (if the channel is non-blocking)\n+ * yielding from the current coroutine multiple times until the entire\n+ * content is written. Otherwise behaves as qio_channel_pwritev().\n+ *\n+ * Returns: 0 if all bytes were written, or -1 on error\n+ */\n+int coroutine_mixed_fn qio_channel_pwritev_all(QIOChannel *ioc,\n+ const struct iovec *iov,\n+ size_t niov,\n+ off_t offset,\n+ Error **errp);\n+\n+/**\n+ * qio_channel_pwrite_all:\n+ * @ioc: the channel object\n+ * @buf: the memory region to write data from\n+ * @buflen: the number of bytes to write from @buf\n+ * @offset: the starting offset in the channel to write to\n+ * @errp: pointer to a NULL-initialized error object\n+ *\n+ * Writes @buflen bytes from @buf, possibly blocking or (if the\n+ * channel is non-blocking) yielding from the current coroutine\n+ * multiple times until the entire content is written. Otherwise\n+ * behaves as qio_channel_pwrite().\n+ *\n+ * Returns: 0 if all bytes were written, or -1 on error\n+ */\n+int coroutine_mixed_fn qio_channel_pwrite_all(QIOChannel *ioc,\n+ const void *buf,\n+ size_t buflen,\n+ off_t offset,\n+ Error **errp);\n+\n /**\n * qio_channel_preadv\n * @ioc: the channel object\ndiff --git a/io/channel.c b/io/channel.c\nindex 52c1abfcbc..2853dadb68 100644\n--- a/io/channel.c\n+++ b/io/channel.c\n@@ -478,6 +478,54 @@ ssize_t qio_channel_pwrite(QIOChannel *ioc, void *buf, size_t buflen,\n return qio_channel_pwritev(ioc, &iov, 1, offset, errp);\n }\n \n+int coroutine_mixed_fn qio_channel_pwritev_all(QIOChannel *ioc,\n+ const struct iovec *iov,\n+ size_t niov,\n+ off_t offset,\n+ Error **errp)\n+{\n+ int ret = -1;\n+ struct iovec *local_iov = g_new(struct iovec, niov);\n+ struct iovec *local_iov_head = local_iov;\n+ unsigned int nlocal_iov = niov;\n+\n+ nlocal_iov = iov_copy(local_iov, nlocal_iov,\n+ iov, niov,\n+ 0, iov_size(iov, niov));\n+\n+ while (nlocal_iov > 0) {\n+ ssize_t len;\n+\n+ len = qio_channel_pwritev(ioc, local_iov, nlocal_iov, offset, errp);\n+\n+ if (len == QIO_CHANNEL_ERR_BLOCK) {\n+ qio_channel_wait_cond(ioc, G_IO_OUT);\n+ continue;\n+ }\n+ if (len < 0) {\n+ goto cleanup;\n+ }\n+\n+ offset += len;\n+ iov_discard_front(&local_iov, &nlocal_iov, len);\n+ }\n+\n+ ret = 0;\n+ cleanup:\n+ g_free(local_iov_head);\n+ return ret;\n+}\n+\n+int coroutine_mixed_fn qio_channel_pwrite_all(QIOChannel *ioc,\n+ const void *buf,\n+ size_t buflen,\n+ off_t offset,\n+ Error **errp)\n+{\n+ struct iovec iov = { .iov_base = (char *)buf, .iov_len = buflen };\n+ return qio_channel_pwritev_all(ioc, &iov, 1, offset, errp);\n+}\n+\n ssize_t qio_channel_preadv(QIOChannel *ioc, const struct iovec *iov,\n size_t niov, off_t offset, Error **errp)\n {\n", "prefixes": [ "PULL", "37/43" ] }