Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2226423/?format=api
{ "id": 2226423, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2226423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/patch/20260422122424.43776-79-andrei.otcheretianski@intel.com/", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.2/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422122424.43776-79-andrei.otcheretianski@intel.com>", "list_archive_url": null, "date": "2026-04-22T12:24:09", "name": "[78/92] NAN: Correctly configure SAE groups on responder", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a6e319dc0ff24ed8c9178eff165788ba6e632e47", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.2/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260422122424.43776-79-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 501001, "url": "http://patchwork.ozlabs.org/api/1.2/series/501001/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/list/?series=501001", "date": "2026-04-22T12:23:05", "name": "Add NAN PASN pairing support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501001/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226423/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=AvaOZLes;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=JomcwCv6;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=P547MxlR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0z9F5RnNz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 22:31:13 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWj1-0000000AANk-2jmn;\n\tWed, 22 Apr 2026 12:30:39 +0000", "from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWfm-0000000A5qf-3gHi\n\tfor hostap@bombadil.infradead.org;\n\tWed, 22 Apr 2026 12:27:19 +0000", "from mgamail.intel.com ([192.198.163.17])\n\tby desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWfi-0000000BKjs-3Hh6\n\tfor hostap@lists.infradead.org;\n\tWed, 22 Apr 2026 12:27:17 +0000", "from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 05:26:41 -0700", "from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 05:26:40 -0700" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=MDjXPBdH3zrH0tuBZEEJU1seAbeMIFoLe08xn1M26wk=; b=AvaOZLes4GCxyi\n\tILm1sE3Vnv+N7LaFhRnn/AJb41PCaTuu3pM/otE/jFTk5Kkq9rD4OX+0DNMsIfi0KQXddFCYfs2TU\n\tkPXqtL3Vl9zGZQtiNSnE5ExqZHclrr6ZMagsPiyKZmoeShaBKzFekYU/Jbaer5h/MXmmjOYvlJSkq\n\t9+MjBodnNy0m4un+sFl403WP+rKaR6d2OZdUi3S9hOp8wo6bMgfZSmyQIfNFd1WgQM5pv43GwbkC/\n\tnR0sxgppkOZwJcrRbADlT9Z1eUtjcizqo7YIh+Quv7a+p8IzYLlMGqOaEsKh2+ABEVlmVCAqIrbou\n\t8vPN3jj3vNv0E/p+WLIg==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version\n\t:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:\n\tContent-Type:Content-ID:Content-Description;\n\tbh=2R0e5tBd2R2wDSo11DFhiUGQhBePMmRmDmg13b8yhCI=; b=JomcwCv62H+5jWukxPYsgyNGJW\n\tMv7E2BU5tVMJ5ZrrImi3egi8YOBnQxxz3ZaZIYnUx+CyjrryOVlf0iZMFQofy64aWz125yYWwdeHD\n\t3i0+dgA79RJVY4uwp8RhE3CUDIqkMfmJaBewCRyVF6RaEP2RcnEzjBUAM+LOy6mj5nZykqkjTEMsZ\n\trKKM3fryuekQtcgE8iHaG/oPoS+SfPFySNTa3nWMAlKfIE9yRcYDBt4q1Q71+gAYPEsQktKsHxFdA\n\tt3NLXJv/21rs9lv2EiEJwW67NSWBH6MvgW19v0pquJwK02tJrsr+O7fAUd7ulXZC7S2nnN6mUDkZn\n\tbjvsqXsA==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776860834; x=1808396834;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=/cWzibHQD/9Cjc+PLO0Oru9dJpTIuaSOmL6w1pFhL0M=;\n b=P547MxlRJCu8yPNQpBagKIdQuBsgycMykExr4XxTPmG9ZNFmwbvC3T06\n zY42NjXAuzSRVtdMeA2Z8XdAIjxLj4p2pRI/gUPUdCP4+B8rI1FWsLuGN\n imqZ7067bJrQE3EvUzXFGU/agIhJeFxku0pO3Ysjeel+/4DcfFMrRlW2K\n HRmZYe5+kJbMmzLZNyvNSIBYEO8Rsi8ZTA0hvc8ziIH2yVdd6MKFiAXZ4\n ZpphYKafw9jZ0qL4zj67Jih4hvct0CTB53fjy7PuDcPvg1fZisIDcexn6\n CTPWWI68FCEmXBTjuWcMMfaScsC5veL+Q5riwIGCoitvxA3WMSubeE69y\n Q==;" ], "X-CSE-ConnectionGUID": [ "Aauu0/BtRVyv9R8xzIdNog==", "YqGSXUE5QRqLBNcLdXniEA==" ], "X-CSE-MsgGUID": [ "aBXaNrfmRCWXJ+OXIKsg/g==", "o5jnsqLrQnWinJJCnGcPFg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11764\"; a=\"77687563\"", "E=Sophos;i=\"6.23,192,1770624000\";\n d=\"scan'208\";a=\"77687563\"", "E=Sophos;i=\"6.23,192,1770624000\";\n d=\"scan'208\";a=\"231445285\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org", "Cc": "vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAndrei Otcheretianski <andrei.otcheretianski@intel.com>", "Subject": "[PATCH 78/92] NAN: Correctly configure SAE groups on responder", "Date": "Wed, 22 Apr 2026 15:24:09 +0300", "Message-ID": "<20260422122424.43776-79-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422122424.43776-1-andrei.otcheretianski@intel.com>", "References": "<20260422122424.43776-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260422_132715_176125_B625CEC6 ", "X-CRM114-Status": "GOOD ( 11.23 )", "X-Spam-Score": "-2.5 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: SAE groups were not configured for opportunistic pairing.\n Since it is needed for all modes, move the PASN group setting to before the\n mode specific handling. Signed-off-by: Andrei Otcheretianski\n <andrei.otcheretianski@intel.com>\n --- src/nan/nan_pairing.c | 40 ++++++++++ 1 file changed,\n 10 insertions(+),\n 30 deletions(-)\n Content analysis details: (-2.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [192.198.163.17 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "SAE groups were not configured for opportunistic pairing. Since\nit is needed for all modes, move the PASN group setting to before\nthe mode specific handling.\n\nSigned-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>\n---\n src/nan/nan_pairing.c | 40 ++++++++++------------------------------\n 1 file changed, 10 insertions(+), 30 deletions(-)", "diff": "diff --git a/src/nan/nan_pairing.c b/src/nan/nan_pairing.c\nindex 8cdef0d727..05a40b9cd4 100644\n--- a/src/nan/nan_pairing.c\n+++ b/src/nan/nan_pairing.c\n@@ -141,15 +141,6 @@ static int nan_pairing_set_password(struct pasn_data *pasn,\n #ifdef CONFIG_SAE\n \tstruct sae_pt *pt;\n \n-\tpasn->pasn_groups = os_calloc(2, sizeof(*pasn->pasn_groups));\n-\tif (!pasn->pasn_groups) {\n-\t\twpa_printf(MSG_DEBUG,\n-\t\t\t \"NAN: Pairing: Failed to allocate PASN groups\");\n-\t\treturn -1;\n-\t}\n-\n-\tpasn->pasn_groups[0] = pasn->group;\n-\n \tpt = sae_derive_pt(pasn->pasn_groups, (const u8 *)NAN_PASN_SSID,\n \t\t\t os_strlen(NAN_PASN_SSID), (const u8 *)passphrase,\n \t\t\t os_strlen(passphrase), NULL, 0);\n@@ -218,10 +209,8 @@ static int nan_pasn_verification_init(struct nan_data *nan_data,\n \tconst struct wpabuf *npk;\n \tint akmp;\n \tu8 npkid[NAN_NIRA_NONCE_LEN + NAN_NIRA_TAG_LEN];\n-\tstruct pasn_data *pasn;\n \n \tpairing_data = &peer->pairing;\n-\tpasn = pairing_data->pasn;\n \n \tif (!pairing_data->nonce_tag_valid) {\n \t\twpa_printf(MSG_DEBUG,\n@@ -240,16 +229,6 @@ static int nan_pasn_verification_init(struct nan_data *nan_data,\n \n \tpasn_set_akmp(pairing_data->pasn, akmp);\n \n-\tos_free(pasn->pasn_groups);\n-\tpasn->pasn_groups = os_calloc(2, sizeof(int));\n-\tif (!pasn->pasn_groups) {\n-\t\twpa_printf(MSG_DEBUG,\n-\t\t\t \"NAN: Pairing: Failed to allocate PASN groups\");\n-\t\treturn -1;\n-\t}\n-\n-\tpasn->pasn_groups[0] = pasn->group;\n-\n \tif (pairing_data->self_pairing_role == NAN_PAIRING_ROLE_INITIATOR)\n \t\tpasn_initiator_pmksa_cache_add(nan_data->initiator_pmksa,\n \t\t\t\t\t nan_data->cfg->nmi_addr,\n@@ -340,6 +319,16 @@ static int nan_pairing_pasn_initialize(struct nan_data *nan_data,\n \n \tpasn_enable_kdk_derivation(pasn);\n \n+\t/* Set allowed PASN groups. This is needed for all modes */\n+\tos_free(pasn->pasn_groups);\n+\tpasn->pasn_groups = os_calloc(2, sizeof(*pasn->pasn_groups));\n+\tif (!pasn->pasn_groups) {\n+\t\twpa_printf(MSG_DEBUG,\n+\t\t\t \"NAN: Pairing: Failed to allocate PASN groups\");\n+\t\tgoto fail;\n+\t}\n+\tpasn->pasn_groups[0] = pasn->group;\n+\n \tif (auth_mode == NAN_PASN_AUTH_MODE_SAE) {\n \t\tpasn_set_akmp(pasn, WPA_KEY_MGMT_SAE);\n \t\tif (!password) {\n@@ -356,15 +345,6 @@ static int nan_pairing_pasn_initialize(struct nan_data *nan_data,\n \t} else if (auth_mode == NAN_PASN_AUTH_MODE_PASN) {\n \t\tpasn_set_akmp(pasn, WPA_KEY_MGMT_PASN);\n \t\tpasn_set_noauth(pasn, true);\n-\n-\t\t/* Set allowed PASN groups for the responder to validate */\n-\t\tpasn->pasn_groups = os_calloc(2, sizeof(*pasn->pasn_groups));\n-\t\tif (!pasn->pasn_groups) {\n-\t\t\twpa_printf(MSG_DEBUG,\n-\t\t\t\t \"NAN: Pairing: Failed to allocate PASN groups\");\n-\t\t\tgoto fail;\n-\t\t}\n-\t\tpasn->pasn_groups[0] = pasn->group;\n \t} else if (auth_mode == NAN_PASN_AUTH_MODE_PMK) {\n \t\tif (nan_pasn_verification_init(nan_data, peer)) {\n \t\t\twpa_printf(MSG_DEBUG,\n", "prefixes": [ "78/92" ] }