Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2226304/?format=api
{ "id": 2226304, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2226304/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhubrmqub2.gcc.gcc-TEST.redi.31.1.3@forge-stage.sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.2/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<bmm.hhubrmqub2.gcc.gcc-TEST.redi.31.1.3@forge-stage.sourceware.org>", "list_archive_url": null, "date": "2026-04-22T10:44:18", "name": "[v1,03/16] libstdc++: Whitespace fixes in atomic wait/notify code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e102ba9e5e03ccaae2d84a9bd41aeefb0bd2581b", "submitter": { "id": 93210, "url": "http://patchwork.ozlabs.org/api/1.2/people/93210/?format=api", "name": "Jonathan Wakely via Sourceware Forge", "email": "forge-bot+redi@forge-stage.sourceware.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhubrmqub2.gcc.gcc-TEST.redi.31.1.3@forge-stage.sourceware.org/mbox/", "series": [ { "id": 500987, "url": "http://patchwork.ozlabs.org/api/1.2/series/500987/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=500987", "date": "2026-04-22T10:44:17", "name": "atomic wait/notify ABI stabilization", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500987/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226304/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226304/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org", "sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0xfv32v6z1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 21:23:19 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9B3424B9208A\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 11:23:17 +0000 (GMT)", "from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id CAD8B407C161\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 10:46:01 +0000 (GMT)", "from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 9E63E42BB1\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 10:46:01 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 9B3424B9208A", "OpenDKIM Filter v2.11.0 sourceware.org CAD8B407C161" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org CAD8B407C161", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org CAD8B407C161", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776854761; cv=none;\n b=xV7GkWhN3LX2cduNFJOAY6WtFO1ygWGjS0+gXz/JNhzj7Zwuf5K2EPcGQxcX96VfRf5hYo+wKLd0KJgCslpIrce7k74Za3hqXKnCyQj+gTpWpgK9qsgqFr6hde+37jTmvOSBQ+mYRLL4zpR2y3d/oE94agDHbbym9dy+x6MctBo=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776854761; c=relaxed/simple;\n bh=5Wk9zpT4Ecf13MtF/m5owgPw6vuXgwF/MFcjnj0cCxs=;\n h=From:Date:Subject:To:Message-ID;\n b=STsALsmkNtTCzXfIRRqoZGvfljaz+pSaQ4syW2166J/5GR9orImezY2f9/Z/1jtwk1alskfp8DgEk/mefPmYrmQGaI2rZTwSFiW/5qOPI+8B6cyLf833kA049cjBN9REjH+6nJfanDs+LIIC7tBlpoEIlZscxWEiBIGqvcT5pao=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "From": "Jonathan Wakely via Sourceware Forge\n <forge-bot+redi@forge-stage.sourceware.org>", "Date": "Wed, 22 Apr 2026 10:44:18 +0000", "Subject": "[PATCH v1 03/16] libstdc++: Whitespace fixes in atomic wait/notify\n code", "To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>", "Message-ID": "\n <bmm.hhubrmqub2.gcc.gcc-TEST.redi.31.1.3@forge-stage.sourceware.org>", "X-Mailer": "batrachomyomachia", "X-Pull-Request-Organization": "gcc", "X-Pull-Request-Repository": "gcc-TEST", "X-Pull-Request": "https://forge.sourceware.org/gcc/gcc-TEST/pulls/31", "References": "\n <bmm.hhubrmqub2.gcc.gcc-TEST.redi.31.1.0@forge-stage.sourceware.org>", "In-Reply-To": "\n <bmm.hhubrmqub2.gcc.gcc-TEST.redi.31.1.0@forge-stage.sourceware.org>", "X-Patch-URL": "\n https://forge.sourceware.org/redi/gcc/commit/f694be7b08c37b7e1a11109d142ce90acdb8f776", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>, redi@gcc.gnu.org", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Jonathan Wakely <jwakely@redhat.com>\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/atomic_timed_wait.h: Whitespace fixes.\n\t* include/bits/atomic_wait.h: Likewise.\n---\n libstdc++-v3/include/bits/atomic_timed_wait.h | 208 +++++++++---------\n libstdc++-v3/include/bits/atomic_wait.h | 8 +-\n 2 files changed, 105 insertions(+), 111 deletions(-)", "diff": "diff --git a/libstdc++-v3/include/bits/atomic_timed_wait.h b/libstdc++-v3/include/bits/atomic_timed_wait.h\nindex 4504b1b84bb8..e5a5f283bca0 100644\n--- a/libstdc++-v3/include/bits/atomic_timed_wait.h\n+++ b/libstdc++-v3/include/bits/atomic_timed_wait.h\n@@ -101,8 +101,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t if (errno != EINTR && errno != EAGAIN)\n \t __throw_system_error(errno);\n \t}\n-\treturn true;\n- }\n+ return true;\n+ }\n #else\n // define _GLIBCXX_HAVE_PLATFORM_TIMED_WAIT and implement __platform_wait_until()\n // if there is a more efficient primitive supported by the platform\n@@ -115,23 +115,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n __cond_wait_until(__condvar& __cv, mutex& __mx,\n \t\t const __wait_clock_t::time_point& __atime)\n {\n-\tauto __s = chrono::time_point_cast<chrono::seconds>(__atime);\n-\tauto __ns = chrono::duration_cast<chrono::nanoseconds>(__atime - __s);\n+ auto __s = chrono::time_point_cast<chrono::seconds>(__atime);\n+ auto __ns = chrono::duration_cast<chrono::nanoseconds>(__atime - __s);\n \n-\t__gthread_time_t __ts =\n-\t {\n-\t static_cast<std::time_t>(__s.time_since_epoch().count()),\n-\t static_cast<long>(__ns.count())\n-\t };\n+ __gthread_time_t __ts =\n+\t{\n+\t static_cast<std::time_t>(__s.time_since_epoch().count()),\n+\t static_cast<long>(__ns.count())\n+\t};\n \n #ifdef _GLIBCXX_USE_PTHREAD_COND_CLOCKWAIT\n-\tif constexpr (is_same_v<chrono::steady_clock, __wait_clock_t>)\n-\t __cv.wait_until(__mx, CLOCK_MONOTONIC, __ts);\n-\telse\n+ if constexpr (is_same_v<chrono::steady_clock, __wait_clock_t>)\n+\t__cv.wait_until(__mx, CLOCK_MONOTONIC, __ts);\n+ else\n #endif\n-\t __cv.wait_until(__mx, __ts);\n-\treturn __wait_clock_t::now() < __atime;\n- }\n+\t__cv.wait_until(__mx, __ts);\n+ return __wait_clock_t::now() < __atime;\n+ }\n #endif // _GLIBCXX_HAS_GTHREADS\n \n inline __wait_result_type\n@@ -146,34 +146,28 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n __platform_wait_t __val;\n auto __now = __wait_clock_t::now();\n for (; __now < __deadline; __now = __wait_clock_t::now())\n- {\n-\tauto __elapsed = __now - __t0;\n-#ifndef _GLIBCXX_NO_SLEEP\n-\tif (__elapsed > 128ms)\n-\t{\n-\t this_thread::sleep_for(64ms);\n-\t}\n-\telse if (__elapsed > 64us)\n \t{\n-\t this_thread::sleep_for(__elapsed / 2);\n-\t}\n-\telse\n+\t auto __elapsed = __now - __t0;\n+#ifndef _GLIBCXX_NO_SLEEP\n+\t if (__elapsed > 128ms)\n+\t this_thread::sleep_for(64ms);\n+\t else if (__elapsed > 64us)\n+\t this_thread::sleep_for(__elapsed / 2);\n+\t else\n #endif\n-\tif (__elapsed > 4us)\n-\t{\n-\t __thread_yield();\n-\t}\n-\telse\n-\t{\n-\t auto __res = __detail::__spin_impl(__addr, __a);\n-\t if (__res.first)\n-\t return __res;\n-\t}\n+\t if (__elapsed > 4us)\n+\t __thread_yield();\n+\t else\n+\t {\n+\t auto __res = __detail::__spin_impl(__addr, __a);\n+\t if (__res.first)\n+\t\treturn __res;\n+\t }\n \n-\t__atomic_load(__addr, &__val, __args._M_order);\n-\tif (__val != __args._M_old)\n-\t return make_pair(true, __val);\n- }\n+\t __atomic_load(__addr, &__val, __args._M_order);\n+\t if (__val != __args._M_old)\n+\t return make_pair(true, __val);\n+\t}\n return make_pair(false, __val);\n }\n \n@@ -212,14 +206,14 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t}\n \n if (!(__args & __wait_flags::__track_contention))\n- {\n-\t// caller does not externally track contention\n+\t{\n+\t // caller does not externally track contention\n #ifdef _GLIBCXX_HAVE_PLATFORM_TIMED_WAIT\n-\t__pool = (__pool == nullptr) ? &__waiter_pool_impl::_S_impl_for(__addr)\n-\t\t\t\t : __pool;\n+\t __pool = (__pool == nullptr) ? &__waiter_pool_impl::_S_impl_for(__addr)\n+\t\t\t\t : __pool;\n #endif\n-\t__pool->_M_enter_wait();\n- }\n+\t __pool->_M_enter_wait();\n+\t}\n \n __wait_result_type __res;\n #ifdef _GLIBCXX_HAVE_PLATFORM_TIMED_WAIT\n@@ -232,19 +226,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n __atomic_load(__wait_addr, &__val, __args._M_order);\n if (__val == __args._M_old)\n \t{\n-\t lock_guard<mutex> __l{ __pool->_M_mtx };\n-\t __atomic_load(__wait_addr, &__val, __args._M_order);\n-\t if (__val == __args._M_old &&\n-\t __cond_wait_until(__pool->_M_cv, __pool->_M_mtx, __atime))\n-\t __res = make_pair(true, __val);\n+\t lock_guard<mutex> __l{ __pool->_M_mtx };\n+\t __atomic_load(__wait_addr, &__val, __args._M_order);\n+\t if (__val == __args._M_old &&\n+\t __cond_wait_until(__pool->_M_cv, __pool->_M_mtx, __atime))\n+\t __res = make_pair(true, __val);\n \t}\n else\n \t__res = make_pair(false, __val);\n #endif\n \n if (!(__args & __wait_flags::__track_contention))\n-\t // caller does not externally track contention\n-\t __pool->_M_leave_wait();\n+\t// caller does not externally track contention\n+\t__pool->_M_leave_wait();\n return __res;\n }\n \n@@ -257,37 +251,37 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t return __detail::__wait_until_impl(__addr, __args, __atime);\n \telse\n \t {\n-\t auto __res = __detail::__wait_until_impl(__addr, __args,\n-\t\t\t\t\t __to_wait_clock(__atime));\n-\t if (!__res.first)\n-\t {\n-\t\t // We got a timeout when measured against __clock_t but\n-\t\t // we need to check against the caller-supplied clock\n-\t\t // to tell whether we should return a timeout.\n-\t\t if (_Clock::now() < __atime)\n-\t\t return make_pair(true, __res.second);\n-\t\t}\n-\t return __res;\n-\t }\n+\t auto __res = __detail::__wait_until_impl(__addr, __args,\n+\t\t\t\t\t\t __to_wait_clock(__atime));\n+\t if (!__res.first)\n+\t {\n+\t\t// We got a timeout when measured against __clock_t but\n+\t\t// we need to check against the caller-supplied clock\n+\t\t// to tell whether we should return a timeout.\n+\t\tif (_Clock::now() < __atime)\n+\t\t return make_pair(true, __res.second);\n+\t }\n+\t return __res;\n+\t }\n }\n \n template<typename _Rep, typename _Period>\n __wait_result_type\n __wait_for(const __platform_wait_t* __addr, const __wait_args_base* __a,\n \t\t const chrono::duration<_Rep, _Period>& __rtime) noexcept\n- {\n- __wait_args __args{ *__a };\n- if (!__rtime.count())\n-\t{\n-\t // no rtime supplied, just spin a bit\n-\t __args |= __wait_flags::__spin_only;\n-\t return __detail::__wait_impl(__addr, &__args);\n-\t}\n-\n- auto const __reltime = chrono::ceil<__wait_clock_t::duration>(__rtime);\n- auto const __atime = chrono::steady_clock::now() + __reltime;\n- return __detail::__wait_until(__addr, &__args, __atime);\n- }\n+ {\n+\t__wait_args __args{ *__a };\n+\tif (!__rtime.count())\n+\t {\n+\t // no rtime supplied, just spin a bit\n+\t __args |= __wait_flags::__spin_only;\n+\t return __detail::__wait_impl(__addr, &__args);\n+\t }\n+\n+\tauto const __reltime = chrono::ceil<__wait_clock_t::duration>(__rtime);\n+\tauto const __atime = chrono::steady_clock::now() + __reltime;\n+\treturn __detail::__wait_until(__addr, &__args, __atime);\n+ }\n } // namespace __detail\n \n // returns true if wait ended before timeout\n@@ -300,19 +294,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t\t\t\tconst chrono::time_point<_Clock, _Dur>& __atime,\n \t\t\t\tbool __bare_wait = false) noexcept\n {\n- const auto __wait_addr =\n-\t reinterpret_cast<const __detail::__platform_wait_t*>(__addr);\n- __detail::__wait_args __args{ __addr, __bare_wait };\n- _Tp __val = __vfn();\n- while (!__pred(__val))\n-\t {\n-\t auto __res = __detail::__wait_until(__wait_addr, &__args, __atime);\n-\t if (!__res.first)\n-\t // timed out\n-\t return __res.first; // C++26 will also return last observed __val\n-\t __val = __vfn();\n-\t }\n- return true; // C++26 will also return last observed __val\n+ const auto __wait_addr =\n+\treinterpret_cast<const __detail::__platform_wait_t*>(__addr);\n+ __detail::__wait_args __args{ __addr, __bare_wait };\n+ _Tp __val = __vfn();\n+ while (!__pred(__val))\n+\t{\n+\t auto __res = __detail::__wait_until(__wait_addr, &__args, __atime);\n+\t if (!__res.first)\n+\t // timed out\n+\t return __res.first; // C++26 will also return last observed __val\n+\t __val = __vfn();\n+\t}\n+ return true; // C++26 will also return last observed __val\n }\n \n template<typename _Clock, typename _Dur>\n@@ -335,21 +329,21 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t\t\t\t const chrono::time_point<_Clock, _Dur>& __atime,\n \t\t\t\t bool __bare_wait = false) noexcept\n {\n- auto __pfn = [&](const _Tp& __val)\n-\t { return !__detail::__atomic_compare(__old, __val); };\n- return __atomic_wait_address_until(__addr, __pfn, forward<_ValFn>(__vfn),\n-\t\t\t\t\t __atime, __bare_wait);\n+ auto __pfn = [&](const _Tp& __val)\n+\t { return !__detail::__atomic_compare(__old, __val); };\n+ return __atomic_wait_address_until(__addr, __pfn, forward<_ValFn>(__vfn),\n+\t\t\t\t\t __atime, __bare_wait);\n }\n \n template<typename _Tp,\n \t typename _Pred, typename _ValFn,\n \t typename _Rep, typename _Period>\n- bool\n- __atomic_wait_address_for(const _Tp* __addr, _Pred&& __pred,\n-\t\t\t _ValFn&& __vfn,\n-\t\t\t const chrono::duration<_Rep, _Period>& __rtime,\n-\t\t\t bool __bare_wait = false) noexcept\n- {\n+ bool\n+ __atomic_wait_address_for(const _Tp* __addr, _Pred&& __pred,\n+\t\t\t _ValFn&& __vfn,\n+\t\t\t const chrono::duration<_Rep, _Period>& __rtime,\n+\t\t\t bool __bare_wait = false) noexcept\n+ {\n const auto __wait_addr =\n \t reinterpret_cast<const __detail::__platform_wait_t*>(__addr);\n __detail::__wait_args __args{ __addr, __bare_wait };\n@@ -363,7 +357,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t __val = __vfn();\n \t}\n return true; // C++26 will also return last observed __val\n- }\n+ }\n \n template<typename _Rep, typename _Period>\n bool\n@@ -372,11 +366,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n \t\t\t\tint __order,\n \t\t\t\tconst chrono::time_point<_Rep, _Period>& __rtime,\n \t\t\t\tbool __bare_wait = false) noexcept\n- {\n- __detail::__wait_args __args{ __addr, __old, __order, __bare_wait };\n- auto __res = __detail::__wait_for(__addr, &__args, __rtime);\n- return __res.first; // C++26 will also return last observed __Val\n- }\n+ {\n+ __detail::__wait_args __args{ __addr, __old, __order, __bare_wait };\n+ auto __res = __detail::__wait_for(__addr, &__args, __rtime);\n+ return __res.first; // C++26 will also return last observed __Val\n+ }\n \n template<typename _Tp, typename _ValFn,\n \t typename _Rep, typename _Period>\ndiff --git a/libstdc++-v3/include/bits/atomic_wait.h b/libstdc++-v3/include/bits/atomic_wait.h\nindex cb246ed616d8..ebab4b099e66 100644\n--- a/libstdc++-v3/include/bits/atomic_wait.h\n+++ b/libstdc++-v3/include/bits/atomic_wait.h\n@@ -377,10 +377,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n __atomic_load(__wait_addr, &__val, __args._M_order);\n if (__val == __args._M_old)\n \t{\n-\t lock_guard<mutex> __l{ __pool->_M_mtx };\n-\t __atomic_load(__wait_addr, &__val, __args._M_order);\n-\t if (__val == __args._M_old)\n-\t\t__pool->_M_cv.wait(__pool->_M_mtx);\n+\t lock_guard<mutex> __l{ __pool->_M_mtx };\n+\t __atomic_load(__wait_addr, &__val, __args._M_order);\n+\t if (__val == __args._M_old)\n+\t __pool->_M_cv.wait(__pool->_M_mtx);\n \t}\n __res = make_pair(false, __val);\n #endif\n", "prefixes": [ "v1", "03/16" ] }