Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2226295/?format=api
{ "id": 2226295, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2226295/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhubwh7m90.gcc.gcc-TEST.pinskia.33.1.6@forge-stage.sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.2/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<bmm.hhubwh7m90.gcc.gcc-TEST.pinskia.33.1.6@forge-stage.sourceware.org>", "list_archive_url": null, "date": "2026-04-22T10:49:15", "name": "[v1,06/15] c: Fix pragma inside a pragma [PR97991}", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2ea7dae20d70367db1feb8f8eea00c2bdad986af", "submitter": { "id": 93219, "url": "http://patchwork.ozlabs.org/api/1.2/people/93219/?format=api", "name": "Andrew Pinski via Sourceware Forge", "email": "forge-bot+pinskia@forge-stage.sourceware.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhubwh7m90.gcc.gcc-TEST.pinskia.33.1.6@forge-stage.sourceware.org/mbox/", "series": [ { "id": 500990, "url": "http://patchwork.ozlabs.org/api/1.2/series/500990/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=500990", "date": "2026-04-22T10:49:12", "name": "copy-prop-arg", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500990/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226295/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org", "sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0xYB0MVkz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 21:18:22 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id D273B436592D\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 11:18:19 +0000 (GMT)", "from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 194864162844\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 10:50:34 +0000 (GMT)", "from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 9E8BE42BDB\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 10:50:31 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org D273B436592D", "OpenDKIM Filter v2.11.0 sourceware.org 194864162844" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 194864162844", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 194864162844", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776855034; cv=none;\n b=dmIJ1rjVFWUu05DLBvUs1PsUkRMp419vluFOLS16U/QaZ5iUABD6gej6mdZja1jtRzyCtPN4FVH/rq/IwbWWdiqncEWC11s8XJX0cO8PNVMJKyiQ3jJEeKcXaaYOUH+sWzNahRHnht9L2mEKmxEASQVhm0fKIQdeWMspweVUD8A=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776855034; c=relaxed/simple;\n bh=j9HNr5PLyveBiEZSMTN6Qb6YwBJh/3JumFYormlwKpU=;\n h=From:Date:Subject:To:Message-ID;\n b=vL3RJsz79Ze0TBAYrjTq9NhMwXdoAS2jfkkThDtBykCgk9KhpM+oG4uC3fWmv8m23VKHZqfSlCDP+uqCyG6FqoQCjzB8akQOq6FuJQNwJBSsLalr/Fnukpio+l6Nhjewq9n8npJz2lZbiTqGNE3Kwiq72l6YwVliDKbxvz5eYm8=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "From": "Andrew Pinski via Sourceware Forge\n <forge-bot+pinskia@forge-stage.sourceware.org>", "Date": "Wed, 22 Apr 2026 10:49:15 +0000", "Subject": "[PATCH v1 06/15] c: Fix pragma inside a pragma [PR97991}", "To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>", "Message-ID": "\n <bmm.hhubwh7m90.gcc.gcc-TEST.pinskia.33.1.6@forge-stage.sourceware.org>", "X-Mailer": "batrachomyomachia", "X-Pull-Request-Organization": "gcc", "X-Pull-Request-Repository": "gcc-TEST", "X-Pull-Request": "https://forge.sourceware.org/gcc/gcc-TEST/pulls/33", "References": "\n <bmm.hhubwh7m90.gcc.gcc-TEST.pinskia.33.1.0@forge-stage.sourceware.org>", "In-Reply-To": "\n <bmm.hhubwh7m90.gcc.gcc-TEST.pinskia.33.1.0@forge-stage.sourceware.org>", "X-Patch-URL": "\n https://forge.sourceware.org/pinskia/gcc-TEST/commit/9c2910508990bb7d12932ba866fa253e0009fe6c", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>,\n pinskia@gcc.gnu.org", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Andrew Pinski <quic_apinski@quicinc.com>\n\nAfter r0-72806-gbc4071dd66fd4d, c_parser_consume_token will\nassert if we get a pragma inside c_parser_consume_token but\npragma processing will call pragma_lex which then calls\nc_parser_consume_token. In the case of pragma with expansion\n(redefine_extname, message and sometimes pack [and some target\nspecific pragmas]) we get the expanded tokens that includes\nCPP_PRAGMA. We should just allow it instead of doing an assert.\nThis follows what the C++ front-end does even and we no longer\nhave an ICE.\n\nBootstrapped and tested on x86_64-linux-gnu.\n\n\tPR c/97991\n\ngcc/c/ChangeLog:\n\n\t* c-parser.cc (c_parser_consume_token): Allow\n\tCPP_PRAGMA if inside a pragma.\n\ngcc/testsuite/ChangeLog:\n\n\t* c-c++-common/cpp/pr97991-1.c: New test.\n\nSigned-off-by: Andrew Pinski <quic_apinski@quicinc.com>\n---\n gcc/c/c-parser.cc | 6 +++++-\n gcc/testsuite/c-c++-common/cpp/pr97991-1.c | 3 +++\n 2 files changed, 8 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/c-c++-common/cpp/pr97991-1.c", "diff": "diff --git a/gcc/c/c-parser.cc b/gcc/c/c-parser.cc\nindex 7672e06fdd0d..a1ad2bf41410 100644\n--- a/gcc/c/c-parser.cc\n+++ b/gcc/c/c-parser.cc\n@@ -929,7 +929,11 @@ c_parser_consume_token (c_parser *parser)\n gcc_assert (parser->tokens_avail >= 1);\n gcc_assert (parser->tokens[0].type != CPP_EOF);\n gcc_assert (!parser->in_pragma || parser->tokens[0].type != CPP_PRAGMA_EOL);\n- gcc_assert (parser->error || parser->tokens[0].type != CPP_PRAGMA);\n+ /* CPP_PRAGMA should not show up here except if there was an error or inside\n+ another pragma. */\n+ gcc_assert (parser->in_pragma\n+\t || parser->error\n+\t || parser->tokens[0].type != CPP_PRAGMA);\n parser->last_token_location = parser->tokens[0].location;\n if (parser->tokens != &parser->tokens_buf[0])\n parser->tokens++;\ndiff --git a/gcc/testsuite/c-c++-common/cpp/pr97991-1.c b/gcc/testsuite/c-c++-common/cpp/pr97991-1.c\nnew file mode 100644\nindex 000000000000..afdfd8a51b20\n--- /dev/null\n+++ b/gcc/testsuite/c-c++-common/cpp/pr97991-1.c\n@@ -0,0 +1,3 @@\n+/* { dg-do compile } */\n+/* Make sure malformed redefine_extname with a pragma inside does not cause an ICE. */\n+#pragma redefine_extname _Pragma (\"pack(bar)\") /* { dg-warning \"\" } */\n", "prefixes": [ "v1", "06/15" ] }