Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2225954/?format=api
{ "id": 2225954, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2225954/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260421210954.1170437-11-philippe.reynes@softathome.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260421210954.1170437-11-philippe.reynes@softathome.com>", "list_archive_url": null, "date": "2026-04-21T21:09:49", "name": "[v5,10/15] tools: mkimage: pre-load: add support of ecdsa", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1706361564525f94cec03af438aec42310106aed", "submitter": { "id": 74351, "url": "http://patchwork.ozlabs.org/api/1.2/people/74351/?format=api", "name": "Philippe Reynes", "email": "philippe.reynes@softathome.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260421210954.1170437-11-philippe.reynes@softathome.com/mbox/", "series": [ { "id": 500895, "url": "http://patchwork.ozlabs.org/api/1.2/series/500895/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=500895", "date": "2026-04-21T21:09:51", "name": "add software ecdsa support", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/500895/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225954/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225954/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=b7djlnJW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"b7djlnJW\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=philippe.reynes@softathome.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Zm32f1Cz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 07:11:31 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B2AB684329;\n\tTue, 21 Apr 2026 23:10:28 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id C8496842FD; Tue, 21 Apr 2026 23:10:15 +0200 (CEST)", "from PA5P264CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170100000.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E7BB2842B7\n for <u-boot@lists.denx.de>; Tue, 21 Apr 2026 23:10:02 +0200 (CEST)", "from MR1P264CA0140.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:51::6) by\n MR1PPF68BB94804.FRAP264.PROD.OUTLOOK.COM (2603:10a6:508:1::64f) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18; Tue, 21 Apr\n 2026 21:09:58 +0000", "from MR1PEPF00000D5A.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:501:51:cafe::b4) by MR1P264CA0140.outlook.office365.com\n (2603:10a6:501:51::6) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Tue,\n 21 Apr 2026 21:09:58 +0000", "from proxy.softathome.com (149.6.166.170) by\n MR1PEPF00000D5A.mail.protection.outlook.com (10.167.241.7) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.18\n via Frontend Transport; Tue, 21 Apr 2026 21:09:58 +0000", "from sah1lpt726.softathome.com (unknown [192.168.72.32])\n by proxy.softathome.com (Postfix) with ESMTPSA id BBB3220737;\n Tue, 21 Apr 2026 23:09:57 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=qEsiJ97S7ohq978I7dY0KC4pBlw9TXVhfPv9LzMJmszF7QyFXVMYth3XmHRje9N8xo8KRcM9FB0jD7NDUgbooHttbARQDTpkaiogk6S8nthDY41zb++eArgClVyv8QZO6FhqcjvxX644ZZpD/G78IS+a2WKwfBQqqU2P424qwQ67WwZVaYQp39jaVnU3pgQf+/TchZ/pcLce9KYNAHbNesacb/ThSOuzjmJBeR9N+b3eGpMNoV2B7bP66vHOVlFIQwGWCkcECKeK7FQ1r4bH9atHPVPa1U+RIZCv6gPH4PCvYofkwkEvK3+2+fBdGYYjq/31p5JCbEcqcpMugA8uOw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=cVcHIsk2xpc74VUcQdP1ry5OUI4HfVhpLzxchYhK2kc=;\n b=QmGKlOxNihinAcrEntGyzCNTH4jJKwN8wOlMTgU7MRIh5WKF9CqV3HJ2X/vystUey9scS6cBmJS+RZ4SLKAENZI2wuyriZ3Tq6DwWc8scKk9ngJJNynLYUCuE0Fl2bIoLucxx1fC+eZrNU9wZJ/7gUDZJwgBRKaRubjs+8zlvoN50SAHZ5BuM+HT7SKelYh+9YRQz6PvVPIqZ+o2xJCTIxwf6blK9KufghKMRsva1DLxjdWTfO4+K5vnsVf86DTKcITTYvkwRAhYsGW7zNiJ50XAmin2ZHEJwPAOz9o+HhoWAWf9hvYcGD7RQIUR/Gk5DZRs2+uGysBbYPAzEb8whw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=canonical.com smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=cVcHIsk2xpc74VUcQdP1ry5OUI4HfVhpLzxchYhK2kc=;\n b=b7djlnJWf2oPYHG0YmZwueq4QQ/m94pHwEl2+j2CcByB2ZULOLg51s49zLCZipaKnoDHouVIDJ25ME9Ip028yReOZ1vigaOF0OpBRGbiOlYT61qmlnLNHvCgli7stiE0NNjjfF1xiuRdSa4Svc+NzqwlSBaWCgMK/rMB3wSAuf9+WRfbtCiVj6EHK4ZaQ1Ep/0tJ0ZUNdUMACt8+l2MB1VvZwYwb+IUbw10FOxgIxZ9rYtbZ2cSAAjSQH8MRu8ZBtihtSEeyARfND8VmZMy8FNT48pe5F4lRy9clQ1/6tb14F+hqXrGMeyu24WRYx576WjtOFLWfGr8NnO/ox4bbAA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;", "Received-SPF": "Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C", "From": "Philippe Reynes <philippe.reynes@softathome.com>", "To": "marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com", "Cc": "u-boot@lists.denx.de, Philippe Reynes <philippe.reynes@softathome.com>,\n Simon Glass <sjg@chromium.org>", "Subject": "[PATCH v5 10/15] tools: mkimage: pre-load: add support of ecdsa", "Date": "Tue, 21 Apr 2026 23:09:49 +0200", "Message-ID": "<20260421210954.1170437-11-philippe.reynes@softathome.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260421210954.1170437-1-philippe.reynes@softathome.com>", "References": "<20260421210954.1170437-1-philippe.reynes@softathome.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MR1PEPF00000D5A:EE_|MR1PPF68BB94804:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "465d950b-6f32-475d-e126-08de9fea57fe", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|376014|36860700016|1800799024|82310400026|22082099003|18002099003|56012099003;", "X-Microsoft-Antispam-Message-Info": "\n MHM/fS6baCbw+AeBz5erZqBLVibL5fx2i5p0gXRLkw/lB1x3s6oNH5s3HI2WPNARHrT4qLw4u1gu/1ideBWIsOqMWthU8qJuDdNLSrzFVgEwkNoa85wDiK/8NDAcamTaRc1kk1o79ku3tFByraWRgfp6CeKAS/fBC1TGvNc3MerA2KskiL3zvVCN9xo820fxavFr4Dy3SBq/L86ngq9ubMVC/v1weSCb4YETTmmYuR5gdsKO0ber+bYdgjRXnFIScZlbNEntJ5p4UNKxRFhDUauNJB0hT0QZU8DavKrW2pzK5znrdAbdvjQBcE5VpMrmTmEgk3yWeiFlcbVku6sqbCsShBpa5U0wpPjVPhC1facjh4k+Gi8AoHk579eQKg7hdyVJ42dcNUID0qvUbVXgjU/KnY7yT8q9qNGP/ZJJ8Re/J5QYOT47OKa3KIohFgysduIqnGJmTE38ql4DLB+CxfGFs0yrX2kps9AFPHJq/cVOFW/6jNO0BBf/WGSdYAGc0aMpI1NIZC86lEXR6ReEmCxtyZToiPFQg1FFxbf38uxpb67msGfeE6zhku5EfG8JBWIhc5zrV7KB0N0iQIc3k1WGAnCPKKiK/ut+lmim8EP5ocmS0DE0TGqCMcVi0OCxn0g3XGXl/VeZnRRwujgYjDyUZEQqq5QhRKO/cJA7VrfMdJhXUyjCIcX6gTfp/IF5IlXXZHceRBA3iuZX+LMTIJxZ0zMQYrQpFD0F1rnIVBgCGVektFsm9MUaD/xMWAggf/zsvYgFggWhZNOJ9+08oA==", "X-Forefront-Antispam-Report": "CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n pswdPWH/DYHKQrXzRr6dTeNzH+7isxeat4IwCfoZ1yE/FcEPCT6Gts9tjxzU/+XuuUc+27tQVWDziTo0hXfC4Ug9VyASuT8rXKzycTZK8x6RLYTTflkLmd0c/bFp705XGjuu4TCRB9k8CCRO5li58BUAoP/mvGvUSOnx19ieaGsQXuHZP44Nm/xwO7dhPacLZjIdt3RojdSFwy2RwrEvNtqjZFi4UPDzX3GQfoMVHenkSkLEDY/vbav90Ovs3gte7GIHx549bR0nA/HKOGSlUQEE4+nxEot1WgkXRbs4dei8wsIgL5Ejcop3amS7IGM1e+IKRHf8i63amSey7pO5Qhp5pg7pJW22HRKRHzapsG5OWk54tNFWPAQkdxro8aoaeva+g+i+lIvYS9OWqhwzDX71YnrkorkOFbbRwvzmX+hPLHZSH59pgO98U5SRVj7P", "X-OriginatorOrg": "softathome.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Apr 2026 21:09:58.0010 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 465d950b-6f32-475d-e126-08de9fea57fe", "X-MS-Exchange-CrossTenant-Id": "aa10e044-e405-4c10-8353-36b4d0cce511", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]", "X-MS-Exchange-CrossTenant-AuthSource": "MR1PEPF00000D5A.FRAP264.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MR1PPF68BB94804", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Right now, mkimage can only create pre-load header\nusing rsa. We add the support of ecdsa.\n\nReviewed-by: Simon Glass <sjg@chromium.org>\nSigned-off-by: Philippe Reynes <philippe.reynes@softathome.com>\n---\nv3:\n- initial version\nv4:\n- use pre_load_noffset (do not compute it again)\n- release memory allocated with strdup\n- clean code\nv5:\n- check checksum and algo before using them\n\n lib/ecdsa/ecdsa-libcrypto.c | 29 +++++++++---\n tools/image-host.c | 92 ++++++++++++++++++++++++++++++++-----\n 2 files changed, 103 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/ecdsa/ecdsa-libcrypto.c b/lib/ecdsa/ecdsa-libcrypto.c\nindex 41590d22a51..0c7d1809a05 100644\n--- a/lib/ecdsa/ecdsa-libcrypto.c\n+++ b/lib/ecdsa/ecdsa-libcrypto.c\n@@ -505,14 +505,9 @@ int ecdsa_verify(struct image_sign_info *info,\n \treturn ret;\n }\n \n-static int do_add(struct signer *ctx, void *fdt, const char *key_node_name,\n-\t\t struct image_sign_info *info)\n+static int search_key_node(void *fdt, const char *key_node_name)\n {\n-\tint signature_node, key_node, ret, key_bits;\n-\tconst char *curve_name;\n-\tconst EC_GROUP *group;\n-\tconst EC_POINT *point;\n-\tBIGNUM *x, *y;\n+\tint signature_node, key_node;\n \n \tsignature_node = fdt_subnode_offset(fdt, 0, FIT_SIG_NODENAME);\n \tif (signature_node == -FDT_ERR_NOTFOUND) {\n@@ -547,6 +542,26 @@ static int do_add(struct signer *ctx, void *fdt, const char *key_node_name,\n \t\treturn key_node;\n \t}\n \n+\treturn key_node;\n+}\n+\n+static int do_add(struct signer *ctx, void *fdt, const char *key_node_name,\n+\t\t struct image_sign_info *info)\n+{\n+\tint key_node, ret, key_bits;\n+\tconst char *curve_name;\n+\tconst EC_GROUP *group;\n+\tconst EC_POINT *point;\n+\tBIGNUM *x, *y;\n+\n+\tif (info->required_keynode >= 0) {\n+\t\tkey_node = info->required_keynode;\n+\t} else {\n+\t\tkey_node = search_key_node(fdt, key_node_name);\n+\t\tif (key_node < 0)\n+\t\t\treturn key_node;\n+\t}\n+\n \tgroup = EC_KEY_get0_group(ctx->ecdsa_key);\n \tkey_bits = EC_GROUP_order_bits(group);\n \tcurve_name = OBJ_nid2sn(EC_GROUP_get_curve_name(group));\ndiff --git a/tools/image-host.c b/tools/image-host.c\nindex f5681d6c1f9..ae35a75d5a6 100644\n--- a/tools/image-host.c\n+++ b/tools/image-host.c\n@@ -13,6 +13,7 @@\n #include <fdt_region.h>\n #include <image.h>\n #include <version.h>\n+#include <u-boot/ecdsa.h>\n \n #if CONFIG_IS_ENABLED(FIT_SIGNATURE)\n #include <openssl/pem.h>\n@@ -1245,13 +1246,74 @@ err_cert:\n \treturn ret;\n }\n \n+static int fit_pre_load_data_key_rsa(const char *keydir, void *keydest,\n+\t\t\t\t int pre_load_noffset, const void *key_name)\n+{\n+\tunsigned char *pubkey = NULL;\n+\tint ret, pubkey_len;\n+\n+\t/* Read public key */\n+\tret = read_pub_key(keydir, key_name, &pubkey, &pubkey_len);\n+\tif (ret < 0)\n+\t\tgoto out;\n+\n+\t/* Add the public key to the device tree */\n+\tret = fdt_setprop(keydest, pre_load_noffset, \"public-key\",\n+\t\t\t pubkey, pubkey_len);\n+\tif (ret)\n+\t\tfprintf(stderr, \"Can't set public-key in node %s (ret = %d)\\n\",\n+\t\t\tIMAGE_PRE_LOAD_PATH, ret);\n+ out:\n+\treturn ret;\n+}\n+\n+static int fit_pre_load_data_key_ecdsa(const char *keydir, void *keydest,\n+\t\t\t\t int pre_load_noffset, const void *key_name,\n+\t\t\t\t const void *algo_name)\n+{\n+\tstruct image_sign_info info;\n+\tint node, ret = 0;\n+\n+\tmemset(&info, 0, sizeof(info));\n+\tinfo.keydir = keydir;\n+\tinfo.keyname = strdup(key_name);\n+\tinfo.name = strdup(algo_name);\n+\tinfo.checksum = image_get_checksum_algo(algo_name);\n+\tif (!info.checksum) {\n+\t\tfprintf(stderr, \"Can't find valid checksum from %s\\n\",\n+\t\t\t(char *)algo_name);\n+\t\tret = -EINVAL;\n+\t\tgoto out;\n+\t}\n+\tinfo.crypto = image_get_crypto_algo(algo_name);\n+\tif (!info.crypto) {\n+\t\tfprintf(stderr, \"Can't find valid crypto from %s\\n\",\n+\t\t\t(char *)algo_name);\n+\t\tret = -EINVAL;\n+\t\tgoto out;\n+\t}\n+\tinfo.required_keynode = pre_load_noffset;\n+\n+\tnode = ecdsa_add_verify_data(&info, keydest);\n+\tif (node < 0) {\n+\t\tfprintf(stderr, \"Can't add verify data: err = %d\\n\", node);\n+\t\tret = -EIO;\n+\t}\n+\n+ out:\n+\tfree((void *)info.keyname);\n+\tfree((void *)info.name);\n+\n+\treturn ret;\n+}\n+\n int fit_pre_load_data(const char *keydir, void *keydest, void *fit)\n {\n \tint pre_load_noffset;\n \tconst void *algo_name;\n \tconst void *key_name;\n-\tunsigned char *pubkey = NULL;\n-\tint ret, pubkey_len;\n+\tchar *name;\n+\tint ret;\n \n \tif (!keydir || !keydest || !fit)\n \t\treturn 0;\n@@ -1278,17 +1340,25 @@ int fit_pre_load_data(const char *keydir, void *keydest, void *fit)\n \t\tgoto out;\n \t}\n \n-\t/* Read public key */\n-\tret = read_pub_key(keydir, key_name, &pubkey, &pubkey_len);\n-\tif (ret < 0)\n+\t/* Is it a RSA or an ECDSA key */\n+\tname = strchr((const char *)algo_name, ',');\n+\tif (!name) {\n+\t\tfprintf(stderr, \"The name of the algo is invalid: %s\\n\",\n+\t\t\t(char *)algo_name);\n+\t\tret = -EINVAL;\n \t\tgoto out;\n+\t}\n+\tname += 1;\n \n-\t/* Add the public key to the device tree */\n-\tret = fdt_setprop(keydest, pre_load_noffset, \"public-key\",\n-\t\t\t pubkey, pubkey_len);\n-\tif (ret)\n-\t\tfprintf(stderr, \"Can't set public-key in node %s (ret = %d)\\n\",\n-\t\t\tIMAGE_PRE_LOAD_PATH, ret);\n+\tif (!strncmp(name, \"rsa\", 3)) {\n+\t\tret = fit_pre_load_data_key_rsa(keydir, keydest, pre_load_noffset, key_name);\n+\t} else if (!strncmp(name, \"ecdsa\", 5)) {\n+\t\tret = fit_pre_load_data_key_ecdsa(keydir, keydest, pre_load_noffset,\n+\t\t\t\t\t\t key_name, algo_name);\n+\t} else {\n+\t\tfprintf(stderr, \"The algo %s is not supported\\n\", (char *)algo_name);\n+\t\tret = -EINVAL;\n+\t}\n \n out:\n \treturn ret;\n", "prefixes": [ "v5", "10/15" ] }