Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2225572/?format=api
{ "id": 2225572, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2225572/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260421075439.16696-7-ravi@prevas.dk/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260421075439.16696-7-ravi@prevas.dk>", "list_archive_url": null, "date": "2026-04-21T07:54:36", "name": "[v2,6/9] lib/hashtable.c: use memdup_nul() in himport_r", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0369244c4d6eb3ae8bff69e562b46acf15ae4cce", "submitter": { "id": 89443, "url": "http://patchwork.ozlabs.org/api/1.2/people/89443/?format=api", "name": "Rasmus Villemoes", "email": "ravi@prevas.dk" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/1.2/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260421075439.16696-7-ravi@prevas.dk/mbox/", "series": [ { "id": 500753, "url": "http://patchwork.ozlabs.org/api/1.2/series/500753/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=500753", "date": "2026-04-21T07:54:32", "name": "add memdup_nul(), use it and memdup() in a few places", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500753/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225572/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256\n header.s=selector1 header.b=T+1D0lvz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.b=\"T+1D0lvz\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk", "phobos.denx.de;\n spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=prevas.dk;" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0F6D2d3Wz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 17:56:04 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6E24A84370;\n\tTue, 21 Apr 2026 09:55:24 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id BD83C84370; Tue, 21 Apr 2026 09:55:10 +0200 (CEST)", "from GVXPR05CU001.outbound.protection.outlook.com\n (mail-swedencentralazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c202::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4A8CA84348\n for <u-boot@lists.denx.de>; Tue, 21 Apr 2026 09:55:03 +0200 (CEST)", "from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:681::18)\n by DU0PR10MB5995.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3b1::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.32; Tue, 21 Apr\n 2026 07:54:59 +0000", "from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8]) by AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8%6]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 07:54:59 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=xpTBnZzyWGDIb43ma30e5pqSEkkb1u6okMz4IAre8yTlVltmf0QVdpSkiFAQihA2uPbYtEa7L41NYYLGaGI491KI2iKGf4AyXAMn5R5LlDk5hc/7dh6rqemjwDOiN7zZKZOM4KE9vjpT0X0dyI+SqJf6EaW9zMupMH7o87we2zu4sLbKj2g+u9PdJFT66IPsnwtTCCga9BeUxLT5cil3uHTdsDOxnP8gXbGX0Wx5ErAU5b2SRZ3APsMb7rtlAgLH1p4GJddcgHRvxUPAK987OKRDPI2AZylzQ0v6ZOQli/ErKBX/dnMcw3/YdIHppSHmQJKFBSklHXh57JuoShaCXQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=mBI/T/ztFiuTPKCZZc5567EwMful4IK7eZ58anuADD4=;\n b=VR1O1xssdRSE9w7PIgLWgtuadR9V1NYhF0v3Bf//91cSZ+46ySptbEubHi2jhtCU9TQps2HzEqZsL2RPyqaKRv4ecUAgOwdepK7RUQ0GTlmZC0fKLssECa5BHfu4IiNns81c5TriQP2V934bGhyVjsfzITLTn5TASU1CWPKDZzfaieAoiWYFVXXlkX39a3A79pK6nF66OVBOHsCFKPKpdNTyTxp0717tVDmylkWck38TBZMTELDZ6yyI8/2ACRqd22rgQeHTk+5L2b6hYNTaLZ3Jhky2FqSyADhuR1wQ9IxP9+ZQmV5tCvbK40icqfxLZ/uNMryaTRSa9nUdXNmH0g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk;\n dkim=pass header.d=prevas.dk; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=mBI/T/ztFiuTPKCZZc5567EwMful4IK7eZ58anuADD4=;\n b=T+1D0lvzYukcsbyRjPHnOvSoqNUmXvmOygEB4FNaTTOKvIeyLxwQ0lubyPz5Z4NAHBdFpKqInSMuI786O86ZkYw50Cy7Zn6huU9bh4ubO0xMzppF4uJ9YpUCERm2ZpswUhPiQ5ddZxMi3+H/EzGMkBEyP2MsxDUpFkUCd9/tFUg=", "From": "Rasmus Villemoes <ravi@prevas.dk>", "To": "u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Rasmus Villemoes <ravi@prevas.dk>", "Subject": "[PATCH v2 6/9] lib/hashtable.c: use memdup_nul() in himport_r", "Date": "Tue, 21 Apr 2026 09:54:36 +0200", "Message-ID": "<20260421075439.16696-7-ravi@prevas.dk>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260421075439.16696-1-ravi@prevas.dk>", "References": "<20260421075439.16696-1-ravi@prevas.dk>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "CPCP307CA0008.DNKP307.PROD.OUTLOOK.COM (2603:10a6:380::10)\n To AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:681::18)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS5PR10MB8243:EE_|DU0PR10MB5995:EE_", "X-MS-Office365-Filtering-Correlation-Id": "56e3783e-2304-49d5-19e2-08de9f7b494f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|52116014|376014|1800799024|366016|38350700014|22082099003|56012099003|18002099003;", "X-Microsoft-Antispam-Message-Info": "\n tgtlkyru9q1XKe8Z82PmQ3WFeZ5V2U8K5wP9v/ne1QeNrQWtevnl94PCprRBMQbJc1D7MU9fy2CYFHocmr7T0MOxbaQF/nT6eQBUTrUAk04eTKy31Qa1RgBE3bHWHeMnmPqOoz3L8ORGOFMqSBFjKm98NKpIHVpShJR2A6vx59sVz8LjaDs9PxON2DhP4z7eP8hBPDP04LuyMyLxzFaRSYJDSipQsSOyCIzerfj1uLU1qkbZGHVlFlHCqBLxkL/khm9RFxzZ5N3RcTknRDr/l+bMdrMFWYse2J6KUeAltWXXPoieta4twSJSgNCtR+AsKwILytr8U3V1TipLjt29f3dN8rrwJC0Mfs8og8PVGtLPPlH/Z9ryUOfP5dfr0qAgfEkeV1x9E6c7efda9m1DVWWQywti/FIM5XAti8mvsK3LQ6ONz7X/9147mUVSOJtA8BE9V4TN6A+O2gaX4lODJ4MlxnVJVGiCGCJIiJTis40HXfc4urQa2Xx5gwUjmbqhZHJC2ktoOq3NoHLyw7DY+T9hPY5VNQEIHyamivbZaurrD9BbRF5tFSUWCxAyodu0SAmBoD89VAL5/s3DZbzHVXqHy/n4rGo1POg8aKBcvtcQq0uhotT8UFDBR9VKuy0cEKkt3+meRyEMWQCAaBpYbOddold8oTLbeai8BUPb9XmSmyWFlSVAdVT01gZfkFaru30+TG60hSP4hgpPluf89D4DtsU9cv8vz6O4tLVU7/YRc5wMwcETANp2rcyDBGGbPtFDi2ueFq4F2UUBYo0crOAvGAQlf1xxkUqGdzxDqK8=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n G7mzG8o1PnLIMPZiwf/tl8HNj8F4MrtXmeSLhc1e/tvu7TNMr0ESYgz1jM9DhFLZTZLWn2v8S0H2U8A1y8VvL/JU+jthLyTQ/RfYvl5Ast4/ywfDvq9sidkIOu3Ws1KwyE+SDUX87km4rglncw3dhW7bkS2rJPHcxrotKCVtI/4cdU1fKCd5C3woVyT9ovAyCFnCK7G6TGtP1WKHBLDLY3RhB6itAmKsLpOceFwtXNmw9RF8VV01yqtrAJ1bPhSH4xEg3yGVMavFAHjyPUse/zASuFBhNUacopZkhxommM4evcuaZ/BItcOh0LQAX4cAdrJAom+alQn4c0wWE470E7ZyINt55FqYuiKCzW0gAPtDsdZRX3Kb77Vt+X3z3GUcYc0WBxGEV/sEDN+RN/zGABAcFVByU9gFhLZJ22H6givMfjaWKIavEjQWUoD8W3pNS3/dBSW1qGLpbmc4kfvH1SG9QAO6BjOzuQGMNt4yWulAndbh5x9T/fpetkz/1ZXz2Q1QS/YTxMJhbN43iBA/914L/v0WNhKIEKyNCGt/BS4yQTB7T8VQ2YRVjvl7KevEo28/m8IoNrtdWCQdbjsvPUmyYsVJFFO7Mi0VDcUTRgGtLU+fL4MNmOvMm/ffHN+/C5bPxEdG0FDp5rHcJalb8dOIyJyludoTFJjr97KjMgUe7dx34++e6NQTnThdNbhkJguTGK9S6e8cEhP/6sjpM3lXGJjIkBFXQ5qVdBSllAQbO2YBK06bKsg1VNhfYwFAtg02vwSE1y6zFIZxICUErr4pY90668a/zJs6FyGnBXi4im3yRtU+rvIKxRbINTTFCdZx+k1m7Z6qzPwea9+dU3tJQA7/5DOGfN9pkFQr1CrVlIjUADESJxSiJNErARJePCurJ3ea1At2DHcWHil2e2B6NPTs1Jymn1HcOgVHI2L+q4tjrsfcVeAYbEyudz5Ky5Mza6OHr1X2W/gWtzrWCC7i3GnRqx9LdNRYCqgy1crh0kaOhsYUsGQnDGxt1FesyEFpnrEUs8/nw6ZAUL+pvzZphT4OCz2kFm7EKL/R43J3cyOR0kgxmOWrwjGiFiRmqQnEGcVBjaglJJDNUgECKAvc75SUwI0ahnJP4CEUtcpoCT/ype4FSATpK+DpdziQ0vOOif5+S5RnK+rdohirp4EtGI0guW7vfdafdT60PG+Ow8Y8noVTqc2/KXV/tJ4ecrB7Jx1LtlClG8kBAXxzFrae3hjKD7iLZWROmBhpeW+ODuIe4r2taaUW412lM7RBQKR/XuIoU9AnaccIXsr/oEAS6ST273KXOnRa+GvM3e6uf3AfOWG77M/5o8iN/dtdcRNBEMNRDzw3Aab2do1ijgVY/jMUEM6biEdtxX+GG2imGhTThFXMOvvE/m46GkXVVa80c7gK5E6G1SNa52UY8KzJvJZcFhEe+r6MnRbcdSGM2skeN6dZF9zVa8zrtK8hLrxlrcXZ5izRlXbur3fUE7mbkkAkh49vBhSX5ZBGclslBI5xc1+vZB9SKHbAtA50H5vN+5EpRzlV264h6jVi/O5d0VPHkNjkxcVC0pMectez6dC37E21QJJa0TiJEDl906W/z11U0lu+YjGAPcs7TWZn9gRSwHkSkHC6B+ZimTqw01G8jOzpAssz3Oh/16uc7VcFcilYAM8m3B0uSV2GZP3OR/tIw5GTuH3QZMCcC89Q6HPudnAMw2AT3MDj1hlLc3WMluFCw6i510qIsyOD8PF6H29ex4GssAjBSxGQSRc=", "X-OriginatorOrg": "prevas.dk", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 56e3783e-2304-49d5-19e2-08de9f7b494f", "X-MS-Exchange-CrossTenant-AuthSource": "AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Apr 2026 07:54:59.3720 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "d350cf71-778d-4780-88f5-071a4cb1ed61", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n bG/JIPP54uybeSstkqWG5TMI1TY+bYeI7gfWK0+atLagFObfZdfftP6kYUTdnWnlR88nfGtwB3lwJzXDqZdeRrXVqRHoqgjGkgY3veURddQ=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU0PR10MB5995", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "We have memdup_nul() for exactly this pattern of duplicating a block\nof memory and ensuring there's a nul byte after the copy.\n\nReviewed-by: Simon Glass <sjg@chromium.org>\nSigned-off-by: Rasmus Villemoes <ravi@prevas.dk>\n---\n lib/hashtable.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/hashtable.c b/lib/hashtable.c\nindex 75c263b5053..f96a8e686f6 100644\n--- a/lib/hashtable.c\n+++ b/lib/hashtable.c\n@@ -821,13 +821,12 @@ int himport_r(struct hsearch_data *htab,\n \t}\n \n \t/* we allocate new space to make sure we can write to the array */\n-\tif ((data = malloc(size + 1)) == NULL) {\n-\t\tdebug(\"himport_r: can't malloc %lu bytes\\n\", (ulong)size + 1);\n+\tdata = memdup_nul(env, size);\n+\tif (data == NULL) {\n+\t\tdebug(\"himport_r: can't duplicate env block\\n\");\n \t\t__set_errno(ENOMEM);\n \t\treturn 0;\n \t}\n-\tmemcpy(data, env, size);\n-\tdata[size] = '\\0';\n \tdp = data;\n \n \t/* make a local copy of the list of variables */\n", "prefixes": [ "v2", "6/9" ] }