Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2225566/?format=api
{ "id": 2225566, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2225566/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260421075439.16696-3-ravi@prevas.dk/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260421075439.16696-3-ravi@prevas.dk>", "list_archive_url": null, "date": "2026-04-21T07:54:32", "name": "[v2,2/9] stdio: drop stdio_clone", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "71775cf55d8d80755cb2e0a736bce59d5c771b7f", "submitter": { "id": 89443, "url": "http://patchwork.ozlabs.org/api/1.2/people/89443/?format=api", "name": "Rasmus Villemoes", "email": "ravi@prevas.dk" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/1.2/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260421075439.16696-3-ravi@prevas.dk/mbox/", "series": [ { "id": 500753, "url": "http://patchwork.ozlabs.org/api/1.2/series/500753/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=500753", "date": "2026-04-21T07:54:32", "name": "add memdup_nul(), use it and memdup() in a few places", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500753/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225566/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225566/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256\n header.s=selector1 header.b=j4C4Jmq3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.b=\"j4C4Jmq3\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk", "phobos.denx.de;\n spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=prevas.dk;" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0F572dPsz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 17:55:07 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 601AA84324;\n\tTue, 21 Apr 2026 09:55:02 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id B6D6E84309; Tue, 21 Apr 2026 09:55:00 +0200 (CEST)", "from GVXPR05CU001.outbound.protection.outlook.com\n (mail-swedencentralazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c202::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 88F4C84258\n for <u-boot@lists.denx.de>; Tue, 21 Apr 2026 09:54:58 +0200 (CEST)", "from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:681::18)\n by GV2PR10MB6233.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:78::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.32; Tue, 21 Apr\n 2026 07:54:54 +0000", "from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8]) by AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8%6]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 07:54:54 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=BLLTDPGFGCR73dDteg2RzfX0jdQxmkonjxszx28cMz9xeRvIcKDnY0U8n8QE/s8gmKEeBcYBPTik9TzK3fAWoD4aqb8tY+wEOQ06oMk6A890qIQzh3b38zVyTKBqcMKXv5nJHXEDhCYjrIhqOPARPwDaf6j6ax3DVb09sDV1MFGxNgAjyCNM5Umv0o4ehRkICYBQuKE0sopSjYmiypflSZKzk3Sr5Qf9Z3kRN0vgH69ZFyQ6Ek4K4P4z6nuijjVRc+p2sJad/AomKEMED/+Q9By85jWM9Qk+/BDU9IzKQmF+2mQsIg0FKijkpDumfDyhYuNDpQucHBzsHSWF/2amtg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=cw1UB8jAZrUoY/P8fTibjTfGajPajqL9QXgoZakzsvI=;\n b=JvN1J5QKNl/iAy3O62DSctcJSCGWuOwuJ12t533GiBJo+9GTO3w7VhKLo03H9gcEXy2KxfVUHWHhGdRDM9qJ5uOAvrhM65700q9TqHkcUV3VAyNNaqHixKtk+1hx0XUV6ajHHhpm69HlUjpdTyYOJyJrJMbnEXIAP6uNLx2soghiE0BpMUleMXkBqgzQJyAGAPjFUoy745Na+6Ex1xIwB5yCC5NB2jiZX8hxlpX34sqTVZn1Yq7o/eMhAduMbltPYX2MV0riRodWh3Y3+iNg8W/3IgLEURPgc+tIHo1uxhYcGv/Lr0Mr+wIChL5wr0IUqoKP/9R7TvTDjr7SjzfZTA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk;\n dkim=pass header.d=prevas.dk; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=cw1UB8jAZrUoY/P8fTibjTfGajPajqL9QXgoZakzsvI=;\n b=j4C4Jmq3UW+LWCDOJegqDrtFNPXdrFLPG9mUfFjif7on2MC7j7PIhzrWAYdvQQx5WhWEtbRF0oq5Ku3nTKZZra8KXNu8xk165hfdbiI6WFQpEmj5K2FrsgkI34PdtCkv33tqCN3QIMvNV6TVdWPiPYJhUiWGqbcZEOuxb4GewhI=", "From": "Rasmus Villemoes <ravi@prevas.dk>", "To": "u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Rasmus Villemoes <ravi@prevas.dk>", "Subject": "[PATCH v2 2/9] stdio: drop stdio_clone", "Date": "Tue, 21 Apr 2026 09:54:32 +0200", "Message-ID": "<20260421075439.16696-3-ravi@prevas.dk>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260421075439.16696-1-ravi@prevas.dk>", "References": "<20260421075439.16696-1-ravi@prevas.dk>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "CPBP307CA0024.DNKP307.PROD.OUTLOOK.COM\n (2603:10a6:380:2::10) To AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:681::18)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS5PR10MB8243:EE_|GV2PR10MB6233:EE_", "X-MS-Office365-Filtering-Correlation-Id": "683e2bc2-edc6-4e9d-b315-08de9f7b460a", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|366016|52116014|376014|1800799024|38350700014|56012099003|18002099003|22082099003;", "X-Microsoft-Antispam-Message-Info": "\n 9WcK9RLLxILoyP2JH282mJvydCzf6B3KGLdNjt50PkgZn5o0vBkoqh/1swIAdKDqk6E2A/UF29+oZQvaapSLKhaZxXmsX6MeaKul9LcNCqbU6WTLPJg2nMwxvTLtbhSOjWP/H/pvZCII0ks9SlkMYlP8C07LQ2V4cC67NIGSlgfeaiyW2F1Es+yGZipPNKXQZgcCve82Fgqx0/wqV6FgBwCqT5qtJyQdydj3PqRBCjJc64+/q7CHvPhD9xKmHYyAY/Sp8gYGMZXKglVM1BFeLdntgLc+FByMnP347HRmOZq0htLr4fyiv6GWvTpWTcOtYSmu7kzZCij2F9kzrEX0rw+Rg4oZaChcqPEmiV/yJddWduUjJszoW42YKGwv0zADDNsdE4KxdBwN/28Vozm+DONqEFu2YLjc/iDlhuu7IhR6/8mlZai2M/670yakocMyf6SUL+KkruXpYVxfPqskXecUKfySAz3acNMWbFniP2ODMtkkGHHSVChAaHEoqBDOD1rXSRnG6yjTUcnX46nZaRYnKdXqzBW+RzznaoW9DvSLBoyd1ybMY6Y8kq2pC7s8TSJlzbLGjcS7p1Kq1VnqFkhsq5zb0dreS/gWOiCMVG1UhGjiHTuFZ3mgcEaad2dv2PoNrSSkcvR/Ri6CsEi54nfjaN5wYZiBYgakUfajTw8vc15oV0phTiaKNku/ch+5pafPQJ+leLPNadXjhxvso49vVoNLyxqEZNbFELYF8IVi1lwlimTM5n5uojf3LS018HOxQsH4WEgeUstvKCT7PbCDuieWmNi09LXrmARVi5U=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n +NSO/W4v6zbzZgXiaUNCDhv0+ztwq9mrmi8mqrEPoPVw0eXNpv+ZtVICPWoPG6JnfuyVRWNH4Dq/0Cg+mZYeCDTxL3yvb2hIYyTcIz6znmWBbIf5Mu27tlvZ0hB7ic2axSrWsv6oqS7wu5wcIquy+le0h6FezYc6g0aj3m3ueTxlfOK+bfxdyfYJy7veDkVZEksagWhwL113wjxitLaFIEN5cTu7Xk8rj0831oK2VHnSoTB5FYBA8Kb4JgRMsYMWjDRvYIz9o00Aae34UjWm/uoUHfzR3MWbesWSc1hv/DETZQ3py8mbHiG51VhXr+fd9ygG6SwAllK12ZFkz+aBAW+/MdHhQuxwzTcAuLLTJw54gnEbzMaJ7lpnYpw9Bt/EwBJl9OeS2WWxKHWrZbvEAgXzdftJ34SxiaH2uOxDNgcAlVVaKotZYDWA0p9DhHuWdmJV6/XRtyaNgGEsTCfFWXsHALdixA+ZuxJSuNzizDXiPxYiSJuFuR1oFD8cpNr43UgTnpz10rD21n62bF5+wDIr2oL6SGDFYBQKLAPdpryZ3SWojM/+jGSMDOH75HdzmAIh9DRLDM/rUOjUsOz5H+ypn6y8IEuiaf5C8vtEJbE6aAAeQmrxkUkDHYMDpj6hJl+iCHZBT4Z7t1Z9aAaNW/s9zJauKlk/nxZ8Cv+skA865P0iY1N0GeUFt1m5gizkikA2j3dmbNNCSl5XMMok/KqvnPmZq+GRizh37Nd1E25rhunYD3TWk+GWoSLDPXNrt/92ie2mmVAkOb95i+8GE4juM+D6PL4CxtaMzsTgzBDdx33awu57VpRMD3oodPRufqSRng22F9iQwueK43Hxopm5i/NUx9tNXYp6AG838qY9KAgAkp4WEYt8iiUuQ/nDs2dvaxjcGI8r5ez/8ctdUllQNeA/0BFUSiKg9GTnWnZLNAC77mZRnZ7gKnqA9KTvgkzM+ZsXhwebP2YtEIN+X7cPmFYIQqnuCnF2ds/EQ9Us2dupngh4Cw9nm8l8ekYcLgAPM4lyFJluFSqTGG+jGbkorZKVe2J9HX2GudDm9ft3Tq8Li5af2Ees21rrk7jKPE+KXn+VGVAomgkm3mSeDP63cPUhfsyjyl+lf3ArHIFpkNtXKizXlXkzRxAnk2iArRZCPSw8tHxR3fVTOBHBNUB6BHNW2UFWvSVoFUVJxpfRzZNxKhFD75bexeAfgFZPSWyj8d22bFt7ikMtq6ptfepTx4CROkIKMqHWCHLQ98I7pAp/4XMeSZa1A0tjYPp+5NBxd91j69rzLUJWzO126zmh1zx8kaPsc+IghHO6O1PbcsX3x2uWhFmoBZEDRyxvygW7GZOLbmWtjM9fWwXARRvxr1mL9xfrPsTyUC5kfY8Mxh7LZHzg+5ghnTHh+c1BUzwQnFLyYBxWNb9smuc1cxb8qqi+VR3M7AieiutI2wKFjNm8ga7UEMmqnbGWVSHMJMCKwGWkBQECETPKIC9GT0bJij6KD8PwDP/5HeSq9gsDmlw/3wyJr91G8RiBBDccCMgJy9QxIbD0GC449yNgx04FTb7Yd9i5nSnH9GBPIFWC9ylU0FV1/HMZQKtbHX1tegfJGXU5enbCz4UDrHlkvfGIWXHBiGOlO4BBoL27xVRbB35zdBuUUt7CyDtZrptuvxPyHQ4M2rjzJuqtqjPSM9vpxmA0BufPgCrWCarfoTI6wEjUxYg3JlGYX3QsKkLRXJRHFE48sAuItidh2nEDpGBNf7J/QLYGqBNaZ0IKi70=", "X-OriginatorOrg": "prevas.dk", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 683e2bc2-edc6-4e9d-b315-08de9f7b460a", "X-MS-Exchange-CrossTenant-AuthSource": "AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Apr 2026 07:54:53.9843 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "d350cf71-778d-4780-88f5-071a4cb1ed61", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n F8p5g0KorEYuwk6glBstjGMGATc8/9uyTrkZgaS8eWdQpQ6UwmrhKY1/ZAAjze8gvc/q2GnQKSR8BUVe8WYw2gCk+0bYPnsVtU2N/Btg0LY=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "GV2PR10MB6233", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The helper stdio_clone only has a single caller, so it certainly\ndoesn't need to be public. But in fact, it is merely an open-coded\nmemdup() - which for some reason uses calloc() even if the whole\nallocation is obviously immediately overwritten.\n\nDrop it and just use memdup() directly.\n\nReviewed-by: Simon Glass <sjg@chromium.org>\nSigned-off-by: Rasmus Villemoes <ravi@prevas.dk>\n---\n common/stdio.c | 18 +-----------------\n include/stdio_dev.h | 1 -\n 2 files changed, 1 insertion(+), 18 deletions(-)", "diff": "diff --git a/common/stdio.c b/common/stdio.c\nindex fc965944209..038e576147b 100644\n--- a/common/stdio.c\n+++ b/common/stdio.c\n@@ -217,27 +217,11 @@ struct stdio_dev *stdio_get_by_name(const char *name)\n \treturn NULL;\n }\n \n-struct stdio_dev *stdio_clone(struct stdio_dev *dev)\n-{\n-\tstruct stdio_dev *_dev;\n-\n-\tif (!dev)\n-\t\treturn NULL;\n-\n-\t_dev = calloc(1, sizeof(struct stdio_dev));\n-\tif (!_dev)\n-\t\treturn NULL;\n-\n-\tmemcpy(_dev, dev, sizeof(struct stdio_dev));\n-\n-\treturn _dev;\n-}\n-\n int stdio_register_dev(struct stdio_dev *dev, struct stdio_dev **devp)\n {\n \tstruct stdio_dev *_dev;\n \n-\t_dev = stdio_clone(dev);\n+\t_dev = memdup(dev, sizeof(*dev));\n \tif (!_dev)\n \t\treturn -ENODEV;\n \tlist_add_tail(&_dev->list, &devs.list);\ndiff --git a/include/stdio_dev.h b/include/stdio_dev.h\nindex f7f9c10199e..d93604331ff 100644\n--- a/include/stdio_dev.h\n+++ b/include/stdio_dev.h\n@@ -96,7 +96,6 @@ int stdio_add_devices(void);\n int stdio_deregister_dev(struct stdio_dev *dev, int force);\n struct list_head *stdio_get_list(void);\n struct stdio_dev *stdio_get_by_name(const char *name);\n-struct stdio_dev *stdio_clone(struct stdio_dev *dev);\n \n int drv_lcd_init(void);\n int drv_video_init(void);\n", "prefixes": [ "v2", "2/9" ] }