Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2225298/?format=api
{ "id": 2225298, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2225298/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-15-vsementsov@yandex-team.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260420200339.708640-15-vsementsov@yandex-team.ru>", "list_archive_url": null, "date": "2026-04-20T20:03:29", "name": "[v6,14/22] vhost: vhost_virtqueue_start(): drop extra local variables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "29bae15dbf90e9e4c839a60445eb899d8a134f65", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/1.2/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-15-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 500672, "url": "http://patchwork.ozlabs.org/api/1.2/series/500672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672", "date": "2026-04-20T20:03:18", "name": "vhost refactoring and fixes", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/500672/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225298/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225298/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=I0QT02KA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxKS6K5sz1yD4\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 06:04:44 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEur4-0001n1-2a; Mon, 20 Apr 2026 16:04:26 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqt-0001QR-6P\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:15 -0400", "from forwardcorp1d.mail.yandex.net ([178.154.239.200])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqr-0001zo-Od\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:14 -0400", "from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 7D7F580778;\n Mon, 20 Apr 2026 23:04:12 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-oFxuUmkY; Mon, 20 Apr 2026 23:04:11 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715451;\n bh=p7Mm9GudtPAeqe5zCfAh27owVpQGvscwVTdaF2yAkKc=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=I0QT02KASqb47D2QLz53aIRZLVwW1anG1pulBEEU3dvb6VTsSywKzY7QKtwSdLelk\n yS/id88O6ON6KZfZEBt+PsYbVd/fJSqfWIFr/Kdtn6wFLrfrjW9KN0M/u+ANy9lrD5\n FxGYHbGEcDFUTN1Co4qKZRj/KXjEN465bl1mE21E=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "mst@redhat.com", "Cc": "sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz <raphael.s.norwitz@gmail.com>", "Subject": "[PATCH v6 14/22] vhost: vhost_virtqueue_start(): drop extra local\n variables", "Date": "Mon, 20 Apr 2026 23:03:29 +0300", "Message-ID": "<20260420200339.708640-15-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260420200339.708640-1-vsementsov@yandex-team.ru>", "References": "<20260420200339.708640-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=178.154.239.200;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "One letter named variables doesn't really help to read the code,\nand they simply duplicate structure fields.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Raphael Norwitz <raphael.s.norwitz@gmail.com>\n---\n hw/virtio/vhost.c | 13 +++----------\n 1 file changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex d5bafbcc4b3..a3bf7e5a9b8 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1277,7 +1277,6 @@ int vhost_virtqueue_start(struct vhost_dev *dev,\n BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));\n VirtioBusState *vbus = VIRTIO_BUS(qbus);\n VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);\n- hwaddr l;\n int r;\n int vhost_vq_index = dev->vhost_ops->vhost_get_vq_index(dev, idx);\n struct vhost_vring_file file = {\n@@ -1302,23 +1301,17 @@ int vhost_virtqueue_start(struct vhost_dev *dev,\n /* Queue might not be ready for start */\n return 0;\n }\n-\n- l = vq->desc_size;\n- vq->desc = vhost_memory_map(dev, vq->desc_phys, l, false);\n+ vq->desc = vhost_memory_map(dev, vq->desc_phys, vq->desc_size, false);\n if (!vq->desc) {\n r = -ENOMEM;\n goto fail;\n }\n-\n- l = vq->avail_size;\n- vq->avail = vhost_memory_map(dev, vq->avail_phys, l, false);\n+ vq->avail = vhost_memory_map(dev, vq->avail_phys, vq->avail_size, false);\n if (!vq->avail) {\n r = -ENOMEM;\n goto fail;\n }\n-\n- l = vq->used_size;\n- vq->used = vhost_memory_map(dev, vq->used_phys, l, true);\n+ vq->used = vhost_memory_map(dev, vq->used_phys, vq->used_size, true);\n if (!vq->used) {\n r = -ENOMEM;\n goto fail;\n", "prefixes": [ "v6", "14/22" ] }