Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2224646/?format=api
{ "id": 2224646, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2224646/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260417173105.1648172-7-peter.maydell@linaro.org/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/1.2/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260417173105.1648172-7-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2026-04-17T17:30:54", "name": "[06/17] target/s390x: Make get_phys_page_debug handle non-page-aligned addrs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "de28768c57781409a5404facf7114b897ef49aea", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/1.2/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260417173105.1648172-7-peter.maydell@linaro.org/mbox/", "series": [ { "id": 500379, "url": "http://patchwork.ozlabs.org/api/1.2/series/500379/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=500379", "date": "2026-04-17T17:30:52", "name": "Handle sub-page granularity in cpu_memory_rw_debug()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500379/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224646/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224646/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ohf+deQW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy28T4Lbpz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 03:35:21 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1wDn34-0007M8-Tv; Fri, 17 Apr 2026 13:32:10 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wDn2P-0006km-78\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 13:31:35 -0400", "from mail-wr1-x433.google.com ([2a00:1450:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wDn2K-000257-QT\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 13:31:27 -0400", "by mail-wr1-x433.google.com with SMTP id\n ffacd0b85a97d-43d7a5e77b1so683883f8f.1\n for <qemu-ppc@nongnu.org>; Fri, 17 Apr 2026 10:31:22 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4ffa8sm5819650f8f.35.2026.04.17.10.31.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 10:31:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776447082; x=1777051882; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dnIJ3EmNqXbziGIQGEMV/q/0xOD9YQRq2D+dL5Z773s=;\n b=ohf+deQWd2ed5G8KdTvZpzMjE7hsOEPXk5Scs0bgj168ou2eVGmiG8HIp9R4zND4Gd\n EYpyM1alqL2K55Im4cfvC7togpJXZd/fvwJkmB4chFwwT1MZKF46Lr3jEFRW+OGml9Ou\n 2/XtYX2w3k6ce7euJvIY2AsOujLM/0t2v2dYnfWpkDdYiX/h5GtKfLaT1ktkxWU2t0/e\n k1exrbo+nV3AJsI+CB4orN/wi/lXzyWfUKgl5GI7J4J9SpmSLn7mQ5q3sN/oQGi3vBG4\n Y35qH/7XGNBun/1K9px8qcNG0gKF2N/fglSd0HPQU7/rPzHUSzbAjBEQ6wh52BsMb/ay\n VOvg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776447082; x=1777051882;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=dnIJ3EmNqXbziGIQGEMV/q/0xOD9YQRq2D+dL5Z773s=;\n b=XrCpK1PFg6LWnty2wpl4F4PhAeb4JL7VcNv0riws+zfhCaMlmvqxolEcpcNXqata20\n mly3kWSAGbWxfQOZ+86DcwKx6Pmq4IbirCywR74lpSILmF3HvqkXwVznle2h4cZwWY73\n fhJP5gdkbezJ2J9QRq1tNhXBsSs4l07hJrUZ7iiMT47FFRZ8UmqVVDWpYxyl95hhYrlC\n jEWlU5CIEKxQ809wDPPYuskdGBakmSQCDzL0KEJEZV8GPfDg/L/dk6g7yICX43Y61xuv\n I/8ywJaFzY4eoG55dq5HRT1EnnD5oqwUepNbtbW6uPhvktdaEH7v9kSvX67Qp2NvpuuT\n JQdA==", "X-Gm-Message-State": "AOJu0YzZOgvlh5WdphRuj/ZkIoxpB8GbX5pxyzH+rc/Ejg2VT97moYa5\n ++ChnbVUiEY0cqVOigz7/tJOy9fAzM1mGQWpYTIQejQkJoBzbF55QJbg0xfph0eMZ4w=", "X-Gm-Gg": "AeBDieu77n3lSW1m9em44xbzFZ12EP12Bi2d5mBiZ9opjOBfM92cObxXY6FdxqXEGOK\n spEdC7/OPvGTcsGAP3WLw2O7TPDPj/aekhNef6fpTYctHPPUvKbXap6qzQKC2wCQvuaE7xqKHH8\n Cd0RbuhxvYqsn3GoGqF9VrQToxDzCkCpzUsdKzHLscAKxEwS4pXcemidcB9882N3yH5xW6zQgCB\n KustlkQVw9R4xqAAFJltinltYHPiGOk+e7jXXDHXdE8YleRWv+g/ad19QIdHoZsRfMPNkfnND1G\n MpU9yAR5kiu8ssNV4AeqKymCgQ1orekTu/2Wa9lBkrV2JLwjq+Rise7j4d50n0K7i7EAVhCHfn6\n JteysKd31SBd6H2Y8PTEhkQOyj5N7ZhR5ZAshm67JD9F0p1mvKlZ4bdMnsKYnp9KgTRRIhrTWfF\n 9jL93qw/26UbkKjKdcO7AiMrSwasaV6Mt+hSp1SSSvMi0iIaUc0Jfk+ImkaUu2fi4davXQoPGsA\n Slzb2QFQKf3/Fi8zBdo7xaPI7lKMb0DrccDLfZBcQ==", "X-Received": "by 2002:a5d:6e66:0:b0:43d:7cc0:dac2 with SMTP id\n ffacd0b85a97d-43fe409de50mr4168195f8f.30.1776447081616;\n Fri, 17 Apr 2026 10:31:21 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Peter Xu <peterx@redhat.com>, \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Jiaxun Yang <jiaxun.yang@flygoat.com>, Nicholas Piggin <npiggin@gmail.com>,\n Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>,\n Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, Ilya Leoshkevich <iii@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Artyom Tarasenko <atar4qemu@gmail.com>", "Subject": "[PATCH 06/17] target/s390x: Make get_phys_page_debug handle\n non-page-aligned addrs", "Date": "Fri, 17 Apr 2026 18:30:54 +0100", "Message-ID": "<20260417173105.1648172-7-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260417173105.1648172-1-peter.maydell@linaro.org>", "References": "<20260417173105.1648172-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::433;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Currently our implementations of SysemuCPUOps::get_phys_page_debug\nand SysemuCPUOps::get_phys_page_attrs_debug are a mix of \"accepts a\nnon-page-aligned virtual address and returns the corresponding\nnon-page-aligned physical address\" and \"only returns a page-aligned\nphysical address\". This is awkward for callsites, which in practice\nall want the physical address for an arbitrary virtual address and\nhave to work around the possibility of getting a page-aligned\naddress, and it doesn't account for protection being possibly on a\nsub-page-sized granularity. We want to standardize on the\nimplementation having to handle non-page-aligned addresses.\n\ns390x already has an implementation of \"give me the actual physical\naddress, not rounded down\", in s390_get_phys_addr_debug(), so we can\nuse this for the SysemuCPUOps::get_phys_page_debug method, and merge\nthe s390_cpu_get_phys_page_debug() function into\ns390_get_phys_addr_debug() which is now its only caller.\n\nThis leaves the function implementing the method with a name\nthat doesn't match the method name, but we will fix that shortly\nby renaming the method to *_addr_* for all targets.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n target/s390x/cpu-system.c | 2 +-\n target/s390x/helper.c | 20 +++++---------------\n target/s390x/s390x-internal.h | 1 -\n 3 files changed, 6 insertions(+), 17 deletions(-)", "diff": "diff --git a/target/s390x/cpu-system.c b/target/s390x/cpu-system.c\nindex 881171d71a..c133b0c262 100644\n--- a/target/s390x/cpu-system.c\n+++ b/target/s390x/cpu-system.c\n@@ -176,7 +176,7 @@ void s390_cpu_finalize(Object *obj)\n \n static const struct SysemuCPUOps s390_sysemu_ops = {\n .has_work = s390_cpu_has_work,\n- .get_phys_page_debug = s390_cpu_get_phys_page_debug,\n+ .get_phys_page_debug = s390_cpu_get_phys_addr_debug,\n .get_crash_info = s390_cpu_get_crash_info,\n .write_elf64_note = s390_cpu_write_elf64_note,\n .legacy_vmsd = &vmstate_s390_cpu,\ndiff --git a/target/s390x/helper.c b/target/s390x/helper.c\nindex 667d4a0da7..1a2658eaf9 100644\n--- a/target/s390x/helper.c\n+++ b/target/s390x/helper.c\n@@ -39,7 +39,7 @@ void s390x_cpu_timer(void *opaque)\n cpu_inject_cpu_timer((S390CPU *) opaque);\n }\n \n-hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr vaddr)\n+hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr addr)\n {\n S390CPU *cpu = S390_CPU(cs);\n CPUS390XState *env = &cpu->env;\n@@ -47,10 +47,11 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr vaddr)\n int prot;\n uint64_t asc = env->psw.mask & PSW_MASK_ASC;\n uint64_t tec;\n+ vaddr page = addr & TARGET_PAGE_MASK;\n \n /* 31-Bit mode */\n if (!(env->psw.mask & PSW_MASK_64)) {\n- vaddr &= 0x7fffffff;\n+ page &= 0x7fffffff;\n }\n \n /* We want to read the code (e.g., see what we are single-stepping).*/\n@@ -62,24 +63,13 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr vaddr)\n * We want to read code even if IEP is active. Use MMU_DATA_LOAD instead\n * of MMU_INST_FETCH.\n */\n- if (mmu_translate(env, vaddr, MMU_DATA_LOAD, asc, &raddr, &prot, &tec)) {\n+ if (mmu_translate(env, page, MMU_DATA_LOAD, asc, &raddr, &prot, &tec)) {\n return -1;\n }\n+ raddr += (addr & ~TARGET_PAGE_MASK);\n return raddr;\n }\n \n-hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr v_addr)\n-{\n- hwaddr phys_addr;\n- vaddr page;\n-\n- page = v_addr & TARGET_PAGE_MASK;\n- phys_addr = cpu_get_phys_page_debug(cs, page);\n- phys_addr += (v_addr & ~TARGET_PAGE_MASK);\n-\n- return phys_addr;\n-}\n-\n static inline bool is_special_wait_psw(uint64_t psw_addr)\n {\n /* signal quiesce */\ndiff --git a/target/s390x/s390x-internal.h b/target/s390x/s390x-internal.h\nindex 40850bcdc4..e7e4f2b45d 100644\n--- a/target/s390x/s390x-internal.h\n+++ b/target/s390x/s390x-internal.h\n@@ -321,7 +321,6 @@ void do_restart_interrupt(CPUS390XState *env);\n void s390x_tod_timer(void *opaque);\n void s390x_cpu_timer(void *opaque);\n void s390_handle_wait(S390CPU *cpu);\n-hwaddr s390_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);\n hwaddr s390_cpu_get_phys_addr_debug(CPUState *cpu, vaddr addr);\n LowCore *cpu_map_lowcore(CPUS390XState *env);\n void cpu_unmap_lowcore(CPUS390XState *env, LowCore *lowcore);\n", "prefixes": [ "06/17" ] }