Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2224586/?format=api
{ "id": 2224586, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2224586/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417164328.1009132-8-alex.bennee@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260417164328.1009132-8-alex.bennee@linaro.org>", "list_archive_url": null, "date": "2026-04-17T16:43:27", "name": "[7/7] tests/tcg: add basic test for aarch64 wf[ie][t] insns", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c0cf16ea3173985d2c3c6f1525909155b3894dfc", "submitter": { "id": 39532, "url": "http://patchwork.ozlabs.org/api/1.2/people/39532/?format=api", "name": "Alex Bennée", "email": "alex.bennee@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417164328.1009132-8-alex.bennee@linaro.org/mbox/", "series": [ { "id": 500373, "url": "http://patchwork.ozlabs.org/api/1.2/series/500373/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500373", "date": "2026-04-17T16:43:20", "name": "tests/tcg: more capabilities for aarch64-softmmu tests", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500373/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224586/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224586/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Hr2HUZcx;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy1203stlz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 02:44:40 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDmIO-0003SA-Uy; Fri, 17 Apr 2026 12:43:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wDmI6-0003OP-LG\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 12:43:38 -0400", "from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wDmI4-0004tD-EV\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 12:43:38 -0400", "by mail-wr1-x42f.google.com with SMTP id\n ffacd0b85a97d-43fe608cb92so529484f8f.2\n for <qemu-devel@nongnu.org>; Fri, 17 Apr 2026 09:43:35 -0700 (PDT)", "from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a7b4sm5579073f8f.22.2026.04.17.09.43.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 09:43:32 -0700 (PDT)", "from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 25F2C5FA53;\n Fri, 17 Apr 2026 17:43:29 +0100 (BST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776444214; x=1777049014; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=liTcDcF3GIDEEzIN8ew1+DtNcgI89x7Dsh408ugPSo4=;\n b=Hr2HUZcxwZngdf2ghSBOHVI+OPF3EyO0j+b+I7GFvNfXvXc8bum5ACtth25+nxWWGK\n jOtD2r8gYIK2zi+hOmQmKTbpIA5Icx1zFLu4w1lXgooU/ySYuna9BNPlhED+kQy/ptHP\n GL3dZAagWcK1eBhWXVY1fn4N+QzGvqvE15Cfr4Ozb+KUk1F2peLuhmTs077M9fqLj+u7\n 8zv8hlD0u1cKe2GIZlDHvLFT9M/Qp5ErI6cGKJEdQI4RuDZlihVgdSoR7mN/nIzBITxt\n rRFujLZbtMbODXLE/NabvTzAIgQheoTN6lJMq3ZSFBl58yj1Pcbdoumc5hkvRoORVtQP\n x2OA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776444214; x=1777049014;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=liTcDcF3GIDEEzIN8ew1+DtNcgI89x7Dsh408ugPSo4=;\n b=NkFft7EoEfaaqxo+x+oMpd2h5PmrTRqHHplHVgy3djl7BOyo6m7RMgzElu91+fcu2T\n nCIUn32fhpozfPYFR5p/H/zBB5nBzSGnhFTHceV8N2dLFerXlb+VUF3exhfVHA28f81L\n O+YcjybJ8DvqMtK6Pep1NTGPjRiuNcG52oQU0zGXjqghpu7VhvwFSAPEJS0kM5WEs7QL\n N3G9DUZmKfcj02Q5wgoISi1qyL5+Ox9u6gdaKf8ae8waOeG9bj9FNI+g/tsq5wMvSDBp\n bGQqJj2F5SuhfGOpteOsp0KnAKx71949snAuejqhpkfD1gT6Mdgll2mLZb6yGBqAuMGl\n 3Rog==", "X-Gm-Message-State": "AOJu0Yy0s60MV972S9p4i8TcP1oTD125EVQMnBAh02b1LrSaSyGolmAt\n CXBc09leBpJUQhdYIoz6j1GIa7Xj0ZAHP22E8+tZAmeSokCdV823TrfyVUtBF5bcpCY=", "X-Gm-Gg": "AeBDieuqMY/KEFhUUXbGaaPVdNDdj94BwK83iM7dRWwWRWQDhF99uVeN2dE7ykp4EE8\n 0TY/YAThc3iyKm6dBWdon5QvkGWJGaNqL5fKXtVMd3Q99C0DB9O98n0WGabz7WprawUk5Bps89f\n q9xjO50l42WmcpJ4mBoVzg0Jj1dkk5ov2oeLtxSNLAihphb0gSpoBLbd2LlE6FkNFOGWbNHJWg+\n tIXRc+igRXsM0qU6xaRMpvakrkOvSQBwYaXrQBGhblqqMT7qzUfuxwr+RwgnGOk1HQTS5myarZv\n e2J8SaZZG5NeCrDQS7HCKibDtEl8vInHQtJwC5gGpDwxsT+6F6HeGnp2RTx38/q1pRgmZgutsDl\n XFYB3peW8teztiOCDW+dmtYUt3yON4wTS9W/cRL2y4baUzSpD8/hwQPN+KAS6rCUIpMyb2o6nWB\n wsnU0yoYsEEfJEuSbKWq/S+6qPBWsA+gHrBg==", "X-Received": "by 2002:a05:6000:2005:b0:43d:77a8:3ba7 with SMTP id\n ffacd0b85a97d-43fe3e12484mr5358574f8f.44.1776444214270;\n Fri, 17 Apr 2026 09:43:34 -0700 (PDT)", "From": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "Subject": "[PATCH 7/7] tests/tcg: add basic test for aarch64 wf[ie][t] insns", "Date": "Fri, 17 Apr 2026 17:43:27 +0100", "Message-ID": "<20260417164328.1009132-8-alex.bennee@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260417164328.1009132-1-alex.bennee@linaro.org>", "References": "<20260417164328.1009132-1-alex.bennee@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42f;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This is based on a generated test case which I've since refined and\ncleaned up.\n\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>\n---\n tests/tcg/aarch64/system/wfx.c | 143 ++++++++++++++++++++++\n tests/tcg/aarch64/Makefile.softmmu-target | 8 ++\n tests/tcg/aarch64/system/boot.S | 16 ++-\n 3 files changed, 164 insertions(+), 3 deletions(-)\n create mode 100644 tests/tcg/aarch64/system/wfx.c", "diff": "diff --git a/tests/tcg/aarch64/system/wfx.c b/tests/tcg/aarch64/system/wfx.c\nnew file mode 100644\nindex 00000000000..fa4c6761215\n--- /dev/null\n+++ b/tests/tcg/aarch64/system/wfx.c\n@@ -0,0 +1,143 @@\n+/*\n+ * WFX Instructions Test (WFI, WFE, WFIT, WFET)\n+ *\n+ * Copyright (c) 2026 Linaro Ltd\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include <stdint.h>\n+#include <stdbool.h>\n+#include <minilib.h>\n+#include \"sysregs.h\"\n+#include \"gicv3.h\"\n+\n+#define TIMEOUT 200000\n+\n+#define sev() asm volatile(\"sev\" : : : \"memory\")\n+#define sevl() asm volatile(\"sevl\" : : : \"memory\")\n+#define wfi() asm volatile(\"wfi\" : : : \"memory\")\n+#define wfe() asm volatile(\"wfe\" : : : \"memory\")\n+#define wfit(reg) asm volatile(\"wfit %0\" : : \"r\" (reg) : \"memory\")\n+#define wfet(reg) asm volatile(\"wfet %0\" : : \"r\" (reg) : \"memory\")\n+\n+#define enable_irq() asm volatile(\"msr daifclr, #2\" : : : \"memory\")\n+#define disable_irq() asm volatile(\"msr daifset, #2\" : : : \"memory\")\n+\n+static bool check_elapsed(uint64_t start, uint64_t threshold, const char *test, bool more)\n+{\n+ uint64_t end = read_sysreg(cntvct_el0);\n+ uint64_t elapsed = end - start;\n+ if (more ? elapsed < threshold : elapsed > threshold) {\n+ ml_printf(\"FAILED: %s %s (%ld ticks)\\n\", test,\n+ more ? \"woke too early\" : \"slept despite SEV\",\n+ elapsed);\n+ return false;\n+ }\n+ ml_printf(\"PASSED (%ld ticks)\\n\", elapsed);\n+ return true;\n+}\n+\n+int main(void)\n+{\n+ uint64_t start, timeout;\n+\n+ gicv3_init();\n+ gicv3_enable_irq(27); /* Virtual Timer PPI */\n+\n+ ml_printf(\"WFx[T] Tests\\n\");\n+\n+ /*\n+ * 1. Test WFI with timer interrupt\n+ *\n+ * We don't have a full interrupt handler, but WFI should wake up\n+ * when the interrupt is pending even if we have it masked at the CPU.\n+ * PSTATE.I is set by boot code.\n+ *\n+ * We unmask interrupts here to ensure the CPU can take the minimal\n+ * exception handler defined in boot.S.\n+ */\n+ ml_printf(\"Testing WFI...\");\n+\n+ start = read_sysreg(cntvct_el0);\n+ write_sysreg(TIMEOUT, cntv_tval_el0);\n+ write_sysreg(1, cntv_ctl_el0); /* Enable timer, no mask */\n+ isb();\n+\n+ enable_irq();\n+ wfi();\n+ disable_irq();\n+\n+ if (!check_elapsed(start, TIMEOUT, \"WFI\", true)) {\n+ return 1;\n+ }\n+\n+ /* Validate the timer fired and then disable for future tests */\n+ if (!read_sysreg(cntv_ctl_el0) & 0x4) {\n+ ml_printf(\"Time ISTATUS not set!\\n\");\n+ return 1;\n+ }\n+ write_sysreg(0, cntv_ctl_el0);\n+\n+ /*\n+ * 2. Test WFE and SEV[L]\n+ *\n+ * There are two SEV instructions, the normal one is a broadcast\n+ * from any PE on the system, the other is local only.\n+ * Functionally they have the same effect (setting the event\n+ * register) and should be immediately consumed by the WFE.\n+ *\n+ * As we want to detect an early exit the sense of the timeout\n+ * check is reversed.\n+ */\n+ ml_printf(\"Testing WFE/SEV...\");\n+ sev();\n+ start = read_sysreg(cntvct_el0);\n+ wfe();\n+ if (!check_elapsed(start, TIMEOUT, \"WFE\", false)) {\n+ return 1;\n+ }\n+\n+ ml_printf(\"Testing WFE/SEVL...\");\n+ sevl();\n+ start = read_sysreg(cntvct_el0);\n+ wfe();\n+ if (!check_elapsed(start, TIMEOUT, \"WFE\", false)) {\n+ return 1;\n+ }\n+\n+ /*\n+ * 3. Test WFIT\n+ *\n+ * With the timer now disabled and no other IRQ sources firing the\n+ * WFIT instruction should timeout. Although the architecture\n+ * permits this being treated as a NOP we have enabled it.\n+ */\n+ ml_printf(\"Testing WFIT...\");\n+ start = read_sysreg(cntvct_el0);\n+ timeout = start + TIMEOUT;\n+ wfit(timeout);\n+ if (!check_elapsed(start, TIMEOUT, \"WFIT\", true)) {\n+ return 1;\n+ }\n+\n+ /*\n+ * 4. Test WFET\n+ *\n+ * Much like WFIT there are no IRQs to wake us up. However the\n+ * event_register is a latch so we must first consume the event\n+ * register with a normal WFE before we do the timeout version.\n+ */\n+ ml_printf(\"Testing WFET...\");\n+ sev();\n+ wfe();\n+ start = read_sysreg(cntvct_el0);\n+ timeout = start + TIMEOUT;\n+ wfet(timeout);\n+ if (!check_elapsed(start, TIMEOUT, \"WFET\", true)) {\n+ return 1;\n+ }\n+\n+ ml_printf(\"ALL WFX TESTS PASSED\\n\");\n+ return 0;\n+}\ndiff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/Makefile.softmmu-target\nindex 543d638e819..6a1e867fba0 100644\n--- a/tests/tcg/aarch64/Makefile.softmmu-target\n+++ b/tests/tcg/aarch64/Makefile.softmmu-target\n@@ -108,6 +108,14 @@ endif\n \n gicv3.o: gicv3.c gicv3.h\n \t$(CC) $(CFLAGS) $(EXTRA_CFLAGS) -c $< -o $@\n+\n+wfx: CFLAGS += -march=armv8.7-a\n+wfx: LDFLAGS += gicv3.o\n+wfx: gicv3.o\n+\n+QEMU_GICV3_MACHINE=-M virt,gic-version=3 -cpu max -display none\n+run-wfx: QEMU_OPTS=$(QEMU_GICV3_MACHINE) $(QEMU_BASE_ARGS) -kernel\n+\n ifneq ($(CROSS_CC_HAS_ARMV8_MTE),)\n QEMU_MTE_ENABLED_MACHINE=-M virt,mte=on -cpu max -display none\n QEMU_OPTS_WITH_MTE_ON = $(QEMU_MTE_ENABLED_MACHINE) $(QEMU_BASE_ARGS) -kernel\ndiff --git a/tests/tcg/aarch64/system/boot.S b/tests/tcg/aarch64/system/boot.S\nindex bee8d9372e7..ba9000a749d 100644\n--- a/tests/tcg/aarch64/system/boot.S\n+++ b/tests/tcg/aarch64/system/boot.S\n@@ -35,7 +35,7 @@ vector_table:\n \n \t/* Current EL with SPx.\t */\n \tventry\tcurr_spx_sync\t\t/* Synchronous\t*/\n-\tventry\tcurr_spx_irq\t\t/* IRQ/vIRQ */\n+\tventry\tcurr_spx_irq\t\t/* Basic handler for IRQ/vIRQ */\n \tventry\tcurr_spx_fiq\t\t/* FIQ/vFIQ */\n \tventry\tcurr_spx_serror\t\t/* SError/VSError */\n \n@@ -54,13 +54,12 @@ vector_table:\n \t.text\n \t.align 4\n \n-\t/* Common vector handling for now */\n+\t/* Apart from curr_spx_irq we error out with an unexpected exception */\n curr_sp0_sync:\n curr_sp0_irq:\n curr_sp0_fiq:\n curr_sp0_serror:\n curr_spx_sync:\n-curr_spx_irq:\n curr_spx_fiq:\n curr_spx_serror:\n lower_a64_sync:\n@@ -275,6 +274,17 @@ _exit:\n \tsemihosting_call\n \t/* never returns */\n \n+\t/*\n+\t * IRQ handler\n+\t */\n+\t.global curr_spx_irq\n+curr_spx_irq:\n+\t/* Minimal IRQ handler: just mask the timer and return */\n+\tmrs\tx0, cntv_ctl_el0\n+\torr\tx0, x0, #2\t\t/* IMASK=1 */\n+\tmsr\tcntv_ctl_el0, x0\n+\teret\n+\n \t/*\n \t * Helper Functions\n \t*/\n", "prefixes": [ "7/7" ] }