Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2224400/?format=api
{ "id": 2224400, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2224400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-16-magnuskulke@linux.microsoft.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260417105618.3621-16-magnuskulke@linux.microsoft.com>", "list_archive_url": null, "date": "2026-04-17T10:55:59", "name": "[15/34] target/i386/mshv: remove redundant apic helpers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "52ca4d55c77f24aca7ee0117dfb7049746fd44b1", "submitter": { "id": 90753, "url": "http://patchwork.ozlabs.org/api/1.2/people/90753/?format=api", "name": "Magnus Kulke", "email": "magnuskulke@linux.microsoft.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-16-magnuskulke@linux.microsoft.com/mbox/", "series": [ { "id": 500310, "url": "http://patchwork.ozlabs.org/api/1.2/series/500310/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500310", "date": "2026-04-17T10:55:44", "name": "Add migration support to the MSHV accelerator", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500310/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224400/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=ZxqR/aTj;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxsMH2lXfz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 20:59:07 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDgtI-0001j1-Vk; Fri, 17 Apr 2026 06:57:41 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <magnuskulke@linux.microsoft.com>)\n id 1wDgtA-0001MC-5t\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:57:32 -0400", "from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <magnuskulke@linux.microsoft.com>) id 1wDgt8-0001bW-GP\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:57:31 -0400", "from DESKTOP-TUU1E5L.fritz.box (p5086d620.dip0.t-ipconnect.de\n [80.134.214.32])\n by linux.microsoft.com (Postfix) with ESMTPSA id 9A93520B7128;\n Fri, 17 Apr 2026 03:57:16 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 9A93520B7128", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1776423439;\n bh=4/dGjUSqCuffa4776aRoVC+jjvuxIlehRsFhT8amsVo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ZxqR/aTjwlgbpwdxaY5Nt0HyvpuzI3Z8Xqr9QpvFZ83qguRiiPmDWyjUfZTKdeM7+\n QyQS7f1lC/42te9qLjh9hEn5BhHh8lbsdoGPvdipzQPPiqXCaBmBNgNoLnwA3DAxSj\n ZhRt92S+VD8II9aB3vAFVkKYicWuZjxPNZq34aDI=", "From": "Magnus Kulke <magnuskulke@linux.microsoft.com>", "To": "qemu-devel@nongnu.org", "Cc": "kvm@vger.kernel.org, Magnus Kulke <magnuskulke@microsoft.com>,\n Wei Liu <liuwe@microsoft.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Magnus Kulke <magnuskulke@linux.microsoft.com>,\n Alex Williamson <alex@shazbot.org>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?q?aud=C3=A9?= <philmd@linaro.org>,\n Marcelo Tosatti <mtosatti@redhat.com>", "Subject": "[PATCH 15/34] target/i386/mshv: remove redundant apic helpers", "Date": "Fri, 17 Apr 2026 12:55:59 +0200", "Message-Id": "<20260417105618.3621-16-magnuskulke@linux.microsoft.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260417105618.3621-1-magnuskulke@linux.microsoft.com>", "References": "<20260417105618.3621-1-magnuskulke@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com", "X-Spam_score_int": "-42", "X-Spam_score": "-4.3", "X-Spam_bar": "----", "X-Spam_report": "(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This change remove the now redundant apic helpers in mshv-cpu.c\n\nSigned-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>\n---\n target/i386/mshv/mshv-cpu.c | 88 ++-----------------------------------\n 1 file changed, 3 insertions(+), 85 deletions(-)", "diff": "diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c\nindex 56656ac0b0..12343acb01 100644\n--- a/target/i386/mshv/mshv-cpu.c\n+++ b/target/i386/mshv/mshv-cpu.c\n@@ -919,101 +919,19 @@ static int set_xc_reg(const CPUState *cpu)\n return 0;\n }\n \n-static int get_vp_state(int cpu_fd, struct mshv_get_set_vp_state *state)\n-{\n- int ret;\n-\n- ret = ioctl(cpu_fd, MSHV_GET_VP_STATE, state);\n- if (ret < 0) {\n- error_report(\"failed to get partition state: %s\", strerror(errno));\n- return -1;\n- }\n-\n- return 0;\n-}\n-\n-static int get_lapic(const CPUState *cpu,\n- struct hv_local_interrupt_controller_state *state)\n-{\n- int ret;\n- size_t size = 4096;\n- /* buffer aligned to 4k, as *state requires that */\n- void *buffer = qemu_memalign(size, size);\n- struct mshv_get_set_vp_state mshv_state = { 0 };\n- int cpu_fd = mshv_vcpufd(cpu);\n-\n- mshv_state.buf_ptr = (uint64_t) buffer;\n- mshv_state.buf_sz = size;\n- mshv_state.type = MSHV_VP_STATE_LAPIC;\n-\n- ret = get_vp_state(cpu_fd, &mshv_state);\n- if (ret == 0) {\n- memcpy(state, buffer, sizeof(*state));\n- }\n- qemu_vfree(buffer);\n- if (ret < 0) {\n- error_report(\"failed to get lapic\");\n- return -1;\n- }\n-\n- return 0;\n-}\n-\n static uint32_t set_apic_delivery_mode(uint32_t reg, uint32_t mode)\n {\n return ((reg) & ~0x700) | ((mode) << 8);\n }\n \n-static int set_vp_state(int cpu_fd, const struct mshv_get_set_vp_state *state)\n-{\n- int ret;\n-\n- ret = ioctl(cpu_fd, MSHV_SET_VP_STATE, state);\n- if (ret < 0) {\n- error_report(\"failed to set partition state: %s\", strerror(errno));\n- return -1;\n- }\n-\n- return 0;\n-}\n-\n-static int set_lapic(const CPUState *cpu,\n- const struct hv_local_interrupt_controller_state *state)\n-{\n- int ret;\n- size_t size = 4096;\n- /* buffer aligned to 4k, as *state requires that */\n- void *buffer = qemu_memalign(size, size);\n- struct mshv_get_set_vp_state mshv_state = { 0 };\n- int cpu_fd = mshv_vcpufd(cpu);\n-\n- if (!state) {\n- error_report(\"lapic state is NULL\");\n- return -1;\n- }\n- memcpy(buffer, state, sizeof(*state));\n-\n- mshv_state.buf_ptr = (uint64_t) buffer;\n- mshv_state.buf_sz = size;\n- mshv_state.type = MSHV_VP_STATE_LAPIC;\n-\n- ret = set_vp_state(cpu_fd, &mshv_state);\n- qemu_vfree(buffer);\n- if (ret < 0) {\n- error_report(\"failed to set lapic: %s\", strerror(errno));\n- return -1;\n- }\n-\n- return 0;\n-}\n-\n static int init_lint(const CPUState *cpu)\n {\n int ret;\n uint32_t *lvt_lint0, *lvt_lint1;\n+ int cpu_fd = mshv_vcpufd(cpu);\n \n struct hv_local_interrupt_controller_state lapic_state = { 0 };\n- ret = get_lapic(cpu, &lapic_state);\n+ ret = mshv_get_lapic(cpu_fd, &lapic_state);\n if (ret < 0) {\n return ret;\n }\n@@ -1026,7 +944,7 @@ static int init_lint(const CPUState *cpu)\n \n /* TODO: should we skip setting lapic if the values are the same? */\n \n- return set_lapic(cpu, &lapic_state);\n+ return mshv_set_lapic(cpu_fd, &lapic_state);\n }\n \n int mshv_arch_store_vcpu_state(const CPUState *cpu)\n", "prefixes": [ "15/34" ] }