Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2223293/?format=api
{ "id": 2223293, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2223293/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-31-arthur.cohen@embecosm.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.2/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260414231905.191063-31-arthur.cohen@embecosm.com>", "list_archive_url": null, "date": "2026-04-14T23:18:52", "name": "[COMMITTED,31/43] gccrs: Fix ICE caused by TypeCheckBase::parse_repr_options", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eb6b27763cff04769ddf76b10d30747a2642f6ab", "submitter": { "id": 83476, "url": "http://patchwork.ozlabs.org/api/1.2/people/83476/?format=api", "name": "Arthur Cohen", "email": "arthur.cohen@embecosm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-31-arthur.cohen@embecosm.com/mbox/", "series": [ { "id": 499900, "url": "http://patchwork.ozlabs.org/api/1.2/series/499900/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=499900", "date": "2026-04-14T23:18:24", "name": "[COMMITTED,01/43] gccrs: testsuite:Add a testcase for setup_associated_types", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499900/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223293/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223293/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=gizifXQY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=gizifXQY", "sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com", "sourceware.org; spf=pass smtp.mailfrom=embecosm.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.67" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwL5747bTz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 09:26:35 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9AEFF4BA23EF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 23:26:33 +0000 (GMT)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n [209.85.128.67])\n by sourceware.org (Postfix) with ESMTPS id 0FBB14BA2E26\n for <gcc-patches@gcc.gnu.org>; Tue, 14 Apr 2026 23:14:58 +0000 (GMT)", "by mail-wm1-f67.google.com with SMTP id\n 5b1f17b1804b1-488b0046078so60531915e9.1\n for <gcc-patches@gcc.gnu.org>; Tue, 14 Apr 2026 16:14:57 -0700 (PDT)", "from platypus.localdomain (176-147-231-59.abo.bbox.fr.\n [176.147.231.59]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f1dd8806sm3325945e9.3.2026.04.14.16.14.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 16:14:55 -0700 (PDT)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 9AEFF4BA23EF", "OpenDKIM Filter v2.11.0 sourceware.org 0FBB14BA2E26" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 0FBB14BA2E26", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 0FBB14BA2E26", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776208498; cv=none;\n b=pEsspvK4LzvFYgKFXZWzoTk2bUYiZNa0EziVDHYzlDtMn4epSsQEK7UQ2zyzbm1GeUCWnDzpHAgCt00CZYCSjrH9dCIFDe0FNJ103e8i9Bv6cgtf5Td5vDon5+HXdpXpOWlyjiQc9sQjyyyOMNsb81uvqT3jxZASizN6uQwSNrE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776208498; c=relaxed/simple;\n bh=BS9KSaz+3Veg7EKPuai5ITGGSX9bjojbizEf5qEttl0=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=CTVft/K/DPXRloQsm77/En33lqZ4k3RBE0LTx+A6tj9mUr421M0WSwUkN/X/1RuwlVo3qVdaz5nurvFRljEYnLSpMkvsKMxm8N3fBalgnuhQZIS+X42Z4FK5La/l3rDuuwjN0dEDLfgXNl+JQr0sninuuZGpe8HudT30rK/gazM=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776208497; x=1776813297; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FMfnKxxlHtY6k1wMFRF9m06COPxU4tcHlFrRsHwwFcY=;\n b=gizifXQYCnVtFNaAQ0o6lPNNQS97oqogQQyAa6stz+8V6dZaJiHazLGQgU7+I1J6T/\n HU5q124lY4Rdk1zz5MBCJzvBS+lLRmHKuyxIl9fz9FpseU1hJ4a5csrnj6NjXY7aRIS2\n kEWYwz7oTNfKJCW+giNTq/qdTCzK5HJGo/yC1900aDPfRckl2+3GIMC+LMB9PIQJJYxO\n Z+135sptnFexZmSkOLjhm/5Qf7FPsdeI1uW/W+x18zSBKhFvPmBd0N/0ixfYlP56XEnw\n 4qizzjUWC6w2mAfRNINKZoCsR9faXEPWh+49LmpYkIALcJy7ssc039oIaBZ+H3tt4h4V\n I8lA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776208497; x=1776813297;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=FMfnKxxlHtY6k1wMFRF9m06COPxU4tcHlFrRsHwwFcY=;\n b=B4iQTMU2tx5YBGtkLNdpPWugEvzjZRuGMa9YJ7nAd/n3x6nuBYWXbGaw5cyeQubrPL\n GyqzQ5XpN64VFjfZ2Le+zQ17fzY5X7WX2nSNMOrpTlK7nJc3ECAbDecGD1MoKw3N2c2w\n bJF29tDbKzEIZBTtK8M43ZhCdkX+RyqlPAVQeygu9XtfiH0z5SfRFJ787urK8ejhyGKh\n JqU3JCiS8UCct/rb01RLlM4zBW685WeCRGTSZ+6MlBtP+th1FwLGn8B2d+cV0xyfq3/7\n DHC/tZuaiMMwjDOy3A7nomDj5b9NpqBpr736RVLm/zizTZ9BpF1d+bh2O+4MA4oq4cDc\n Zkhg==", "X-Gm-Message-State": "AOJu0YxgdiT+s/WkZLcm/9xDuhCo+1hTPJVJpnOyzNZVHKa6HuQ4N5LT\n 8lg5jh7wAXa0i+x2RAjXA9VlWhuaOMPoNjy41I0vV06wT+uHRSePjGC0dup+HI5CbkuXM0T/2Q7\n Ampqf0qMk", "X-Gm-Gg": "AeBDiev2NPCLwQ86wunMZpI282EHoYHee4cTFNHxW7uKq6M9gIMevH0hYeimToJoqHR\n oGjgsh4MqgxFJSagC7TbDsTivs3he/nnRl9bm3o8QpfG4rSOmtKZchRnZwAlrZV0v4NrKDGOmPh\n 4cdm3MxkB3xHHzFvsUiYqdRLj/8YKIAdEVuFOWRXpYM240Tggf0x4qQY6Dgr9bKy6HSaKuURYHF\n 0Cd6kl5drtkZVORE6ZZV0fmVnNshqY+bNp3NTacKXC6tT9Kr1iI40PZ1RP3h756n0pTFRCZ6Grs\n GbLA7xOUKsc2XVnKv3VwO/EhSZ91sEGrKrcT2yn90+uxIRUWpc5uzmc7jCa84G+sC4nktUGaBW7\n jZYkcyqxUqwZNZv+BAKGJRL2dsBVehv1l7NqnmeBFQAgT/Kp1IEoc2WkBHNIvHQyx+PQLvppnjI\n Vn0vVuxn0wF5P59Olg9CishQc/tOSRjmFPs2OsP8OewiK19XWxsTXaevDtLSP81hQZnw9/95yeo\n hle1Q==", "X-Received": "by 2002:a05:600c:474c:b0:487:219e:42d with SMTP id\n 5b1f17b1804b1-488d67e72b7mr242280215e9.11.1776208496697;\n Tue, 14 Apr 2026 16:14:56 -0700 (PDT)", "From": "arthur.cohen@embecosm.com", "To": "gcc-patches@gcc.gnu.org", "Cc": "gcc-rust@gcc.gnu.org,\n\tYap Zhi Heng <yapzhhg@gmail.com>", "Subject": "[COMMITTED 31/43] gccrs: Fix ICE caused by\n TypeCheckBase::parse_repr_options", "Date": "Wed, 15 Apr 2026 01:18:52 +0200", "Message-ID": "<20260414231905.191063-31-arthur.cohen@embecosm.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260414231905.191063-1-arthur.cohen@embecosm.com>", "References": "<20260414231905.191063-1-arthur.cohen@embecosm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Yap Zhi Heng <yapzhhg@gmail.com>\n\nFixes Rust-GCC/gccrs#3550. Previously parse_repr_options assumes that all attrs in its\nparams are token trees, but it is possible that already-parsed meta items can be passed\nas params as well due to expansion of cfg_attr.\n\ngcc/rust/ChangeLog:\n\n\t* typecheck/rust-hir-type-check-base.cc (TypeCheckBase::parse_repr_options):\n\tAllow parsing of AttrInputMetaItemContainer.\n\nSigned-off-by: Yap Zhi Heng <yapzhhg@gmail.com>\n---\n .../typecheck/rust-hir-type-check-base.cc | 21 +++++++++++++++----\n gcc/testsuite/rust/compile/issue-3550.rs | 7 +++++++\n 2 files changed, 24 insertions(+), 4 deletions(-)\n create mode 100644 gcc/testsuite/rust/compile/issue-3550.rs", "diff": "diff --git a/gcc/rust/typecheck/rust-hir-type-check-base.cc b/gcc/rust/typecheck/rust-hir-type-check-base.cc\nindex 835e8ca790c..6c3cb4054b1 100644\n--- a/gcc/rust/typecheck/rust-hir-type-check-base.cc\n+++ b/gcc/rust/typecheck/rust-hir-type-check-base.cc\n@@ -421,14 +421,27 @@ TypeCheckBase::parse_repr_options (const AST::AttrVec &attrs, location_t locus)\n \t const AST::AttrInput &input = attr.get_attr_input ();\n \t bool is_token_tree = input.get_attr_input_type ()\n \t\t\t == AST::AttrInput::AttrInputType::TOKEN_TREE;\n-\t if (!is_token_tree)\n+\t bool is_meta_item = input.get_attr_input_type ()\n+\t\t\t == AST::AttrInput::AttrInputType::META_ITEM;\n+\t if (!is_token_tree && !is_meta_item)\n \t {\n \t rust_error_at (attr.get_locus (), \"malformed %<repr%> attribute\");\n \t continue;\n \t }\n-\t const auto &option = static_cast<const AST::DelimTokenTree &> (input);\n-\t AST::AttrInputMetaItemContainer *meta_items\n-\t = option.parse_to_meta_item ();\n+\n+\t const AST::AttrInputMetaItemContainer *meta_items = nullptr;\n+\t if (is_token_tree)\n+\t {\n+\t const auto &option\n+\t\t= static_cast<const AST::DelimTokenTree &> (input);\n+\t meta_items = option.parse_to_meta_item ();\n+\t }\n+\t else\n+\t { // is_meta_item is true\n+\t const auto &option\n+\t\t= static_cast<const AST::AttrInputMetaItemContainer &> (input);\n+\t meta_items = new AST::AttrInputMetaItemContainer (option);\n+\t }\n \n \t if (meta_items == nullptr)\n \t {\ndiff --git a/gcc/testsuite/rust/compile/issue-3550.rs b/gcc/testsuite/rust/compile/issue-3550.rs\nnew file mode 100644\nindex 00000000000..50b8bbd4105\n--- /dev/null\n+++ b/gcc/testsuite/rust/compile/issue-3550.rs\n@@ -0,0 +1,7 @@\n+#![feature(no_core)]\n+#![no_core]\n+\n+#[cfg_attr(not(wrong = \"32\"), repr(i32))]\n+enum Eu64 {\n+ Au64 = 0,\n+}\n\\ No newline at end of file\n", "prefixes": [ "COMMITTED", "31/43" ] }