Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2222699/?format=api
{ "id": 2222699, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2222699/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260413131541.2091541-2-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.2/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260413131541.2091541-2-sjg@chromium.org>", "list_archive_url": null, "date": "2026-04-13T13:15:38", "name": "[v4,2/2] kbuild: Use if_changed for font and splash .incbin rules", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "76b379b5cb4575a6f6926f0c668c56bf3d992ce5", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/1.2/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/1.2/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260413131541.2091541-2-sjg@chromium.org/mbox/", "series": [ { "id": 499702, "url": "http://patchwork.ozlabs.org/api/1.2/series/499702/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=499702", "date": "2026-04-13T13:15:37", "name": "[v4,1/2] kbuild: Move U-Boot .incbin rules to Makefile.lib-u-boot", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/499702/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222699/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222699/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=KHmS4Vog;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"KHmS4Vog\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvSb80GKGz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 23:16:04 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 55E2884206;\n\tMon, 13 Apr 2026 15:15:55 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 0285F83DC9; Mon, 13 Apr 2026 15:15:53 +0200 (CEST)", "from mail-ot1-x335.google.com (mail-ot1-x335.google.com\n [IPv6:2607:f8b0:4864:20::335])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B194484199\n for <u-boot@lists.denx.de>; Mon, 13 Apr 2026 15:15:50 +0200 (CEST)", "by mail-ot1-x335.google.com with SMTP id\n 46e09a7af769-7d556c1a79eso6031451a34.3\n for <u-boot@lists.denx.de>; Mon, 13 Apr 2026 06:15:50 -0700 (PDT)", "from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-68bc7dfa196sm5958562eaf.2.2026.04.13.06.15.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 06:15:48 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776086149; x=1776690949; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pcwwnZArgauI9dwWQVxkj0FmN4DOivtVsgVpTwkIsfQ=;\n b=KHmS4Vogrz9xKcMdr2C9z1nC4hFgK17YTlGSm7HFJ62ueXvL5YOqYkMzWEY8+oCoPd\n lM4gLKuFS8V24kySpc7w7AuaKN480Xcv8G/GQrSOjm8eXgNFVieyM75Tn+iGaEo+llvA\n oajDS8D89JAIyVfvH42mpJ9BW7Gztu3TSPMGA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776086149; x=1776690949;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pcwwnZArgauI9dwWQVxkj0FmN4DOivtVsgVpTwkIsfQ=;\n b=l67pD/NeNVoJYcMDlNQwbE/52X7SyOhxcMoHB9MulGp4NPKv9f4R0Y8LS+cyOJMP2D\n 3Fqy36GOSjkQSzhmNYUPqFgEM00xhGLo+55m2FBIbl+ybpz0/mL/8vrOqXf0Gm64pSpw\n /dX0Wv73fiFxvHmvDrFV1oQaw0iSCyJEhQo4WxfZhobWyxPoENRnIPg0OnwRgMwvJCao\n 4Fp9bN9ZvzPXIVKxsGzQRWtuROxCkmODlBEeqff9YIligf0dsFqsqO4gxXK/xiheccRt\n zf8A52t4iMJowTc5aZ985McLQL5arJlAsy9FJfo5nYZwVaOMQScvx5zzqcDfFSAPpMqg\n t70g==", "X-Gm-Message-State": "AOJu0YyCifANtQ5/HLhoHixgFGCDMLRcA+gxfd5WDjZke9+5GXBjEXQK\n y88Wp5YNKt6CCeC1m43+51vAdAAOqucaah5HjZRF8cLlYIl0AZPlv1CQwPhYrXqyHn6ugPvQdt6\n z4wmmqQ==", "X-Gm-Gg": "AeBDieupIbts5Fi3drn8mItx9ERkhHdClcNFTQKGM7emqEC1a+zFKvtk+4CTY6I8G2c\n MsLN18HO7D6/FVRVXt0P95zqLD2ARTO1ECquGIO3msP39+y+/jx+FSsO8a1fNcGDfjUxH080w2a\n tpX52t3SmSANrkpxEr9FiQ4yJ60mCwXPv+Xw7VK68M1GpiqqZDvjIapLjKwGsep/lLY/etoAbxr\n PAX1P8AMwCUvHNuQaXEwdEE06otIusnE09ey3ooAahnpqwtIDN9t7lpQwwHyHLEhkrS2tJad2kw\n 1xZx6PKxzfN2fFVBhc7bifkwJ1lji5tLirUnMgZlmJhzS7sd6EA8hOxuZ3qq5P0eLlv1wiuLTO+\n k1nufbBqibuxVkVJyVwvgkGiMdG6CIjWDmDlGH5iQn0ajeeQhwxTlJu2az84ZYfITQUWJqd1XSV\n 1Bq3Z7oRczTowKqFVFpQ==", "X-Received": "by 2002:a05:6820:1351:b0:686:c7a9:d64c with SMTP id\n 006d021491bc7-68be84d179cmr6456648eaf.43.1776086148768;\n Mon, 13 Apr 2026 06:15:48 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Rasmus Villemoes <ravi@prevas.dk>, Simon Glass <sjg@chromium.org>,\n Anatolij Gustschin <ag.dev.uboot@gmail.com>,\n Dario Binacchi <dario.binacchi@amarulasolutions.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Ion Agorria <ion@agorria.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>,\n Sughosh Ganu <sughosh.ganu@arm.com>, Svyatoslav Ryhel <clamor95@gmail.com>,\n Tom Rini <trini@konsulko.com>", "Subject": "[PATCH v4 2/2] kbuild: Use if_changed for font and splash .incbin\n rules", "Date": "Mon, 13 Apr 2026 07:15:38 -0600", "Message-ID": "<20260413131541.2091541-2-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260413131541.2091541-1-sjg@chromium.org>", "References": "<20260413131541.2091541-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The generated .S files for fonts and splash screens use .incbin with the\nfull prerequisite path. When building with O= this bakes an absolute\npath into the .S file. If the build directory is later used on a\ndifferent machine (e.g. in a container), the assembler cannot find the\nsource file.\n\nFollow the existing DTB convention: rename the object targets to use\ncompound suffixes (.ttf.o, .bmp.o), switch the pattern rules from\ndirect $(call cmd,...) to FORCE + $(call if_changed,...), and register\nthe new suffixes with intermediate_targets so that kbuild loads their\n.cmd files. This lets if_changed detect when the recorded command\n(including source paths) has changed and regenerate the .S file\nautomatically.\n\nThe EFI rule is left unchanged since its prerequisite is a generated\nfile in the build directory, like the DTB and DTBO rules.\n\nThe intermediate_targets entries stay in scripts/Makefile.build rather\nthan moving to scripts/Makefile.lib-u-boot, because that file is\nincluded before intermediate_targets is defined and 'targets' is ':=',\nso a '$(call intermediate_targets, ...)' inside it would expand to\nempty and silently drop the entries. To keep the upstream block\nuntouched, the U-Boot additions go in a separate 'targets +=' block\nimmediately below.\n\nSuggested-by: Rasmus Villemoes <ravi@prevas.dk>\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\nChanges in v4:\n- Add a separate 'targets +=' block for .ttf.o/.bmp.o per Rasmus\n\nChanges in v3:\n- Use if_changed with compound suffixes (.ttf.o, .bmp.o)\n\nChanges in v2:\n- Move U-Boot .incbin rules to Makefile.lib-u-boot first (previous patch)\n- Drop the EFI .incbin change since .efi files are generated, not source\n- Use per-file AFLAGS instead of modifying a_flags in Makefile.lib\n\n drivers/video/Makefile | 2 +-\n drivers/video/fonts/Makefile | 10 +++++-----\n scripts/Makefile.build | 4 ++++\n scripts/Makefile.lib-u-boot | 8 ++++----\n 4 files changed, 14 insertions(+), 10 deletions(-)\n\n---\nbase-commit: e2fa3e570f83ab0f9ce667ddaec9dc738bcf05b9\nbranch: font-us4", "diff": "diff --git a/drivers/video/Makefile b/drivers/video/Makefile\nindex 984768ea156..dbc3018d716 100644\n--- a/drivers/video/Makefile\n+++ b/drivers/video/Makefile\n@@ -24,7 +24,7 @@ obj-$(CONFIG_$(PHASE_)PANEL) += panel-uclass.o\n obj-$(CONFIG_PANEL_HX8238D) += hx8238d.o\n obj-$(CONFIG_$(PHASE_)SIMPLE_PANEL) += simple_panel.o\n \n-obj-$(CONFIG_VIDEO_LOGO) += u_boot_logo.o\n+obj-$(CONFIG_VIDEO_LOGO) += u_boot_logo.bmp.o\n obj-$(CONFIG_$(PHASE_)BMP) += bmp.o\n \n endif\ndiff --git a/drivers/video/fonts/Makefile b/drivers/video/fonts/Makefile\nindex 1111f92a2c6..4d32fa43994 100644\n--- a/drivers/video/fonts/Makefile\n+++ b/drivers/video/fonts/Makefile\n@@ -3,8 +3,8 @@\n # (C) Copyright 2000-2007\n # Wolfgang Denk, DENX Software Engineering, wd@denx.de.\n \n-obj-$(CONFIG_CONSOLE_TRUETYPE_NIMBUS) += nimbus_sans_l_regular.o\n-obj-$(CONFIG_CONSOLE_TRUETYPE_ANKACODER) += ankacoder_c75_r.o\n-obj-$(CONFIG_CONSOLE_TRUETYPE_RUFSCRIPT) += rufscript010.o\n-obj-$(CONFIG_CONSOLE_TRUETYPE_CANTORAONE) += cantoraone_regular.o\n-obj-$(CONFIG_CONSOLE_TRUETYPE_DEJAVU) += dejavu_mono.o\n+obj-$(CONFIG_CONSOLE_TRUETYPE_NIMBUS) += nimbus_sans_l_regular.ttf.o\n+obj-$(CONFIG_CONSOLE_TRUETYPE_ANKACODER) += ankacoder_c75_r.ttf.o\n+obj-$(CONFIG_CONSOLE_TRUETYPE_RUFSCRIPT) += rufscript010.ttf.o\n+obj-$(CONFIG_CONSOLE_TRUETYPE_CANTORAONE) += cantoraone_regular.ttf.o\n+obj-$(CONFIG_CONSOLE_TRUETYPE_DEJAVU) += dejavu_mono.ttf.o\ndiff --git a/scripts/Makefile.build b/scripts/Makefile.build\nindex e625f99986e..73b6769ab90 100644\n--- a/scripts/Makefile.build\n+++ b/scripts/Makefile.build\n@@ -440,6 +440,10 @@ targets += $(call intermediate_targets, .asn1.o, .asn1.c .asn1.h) \\\n \t $(call intermediate_targets, .lex.o, .lex.c) \\\n \t $(call intermediate_targets, .tab.o, .tab.c .tab.h)\n \n+# Added for U-Boot\n+targets += $(call intermediate_targets, .ttf.o, .ttf.S) \\\n+\t $(call intermediate_targets, .bmp.o, .bmp.S)\n+\n # Build\n # ---------------------------------------------------------------------------\n \ndiff --git a/scripts/Makefile.lib-u-boot b/scripts/Makefile.lib-u-boot\nindex c55f8d8e0c3..4d60a8eee49 100644\n--- a/scripts/Makefile.lib-u-boot\n+++ b/scripts/Makefile.lib-u-boot\n@@ -20,8 +20,8 @@ cmd_S_ttf=\t\t\t\t\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n ) > $@\n \n-$(obj)/%.S: $(src)/%.ttf\n-\t$(call cmd,S_ttf)\n+$(obj)/%.ttf.S: $(src)/%.ttf FORCE\n+\t$(call if_changed,S_ttf)\n \n # Splash logos\n # ---------------------------------------------------------------------------\n@@ -40,8 +40,8 @@ cmd_S_splash=\t\t\t\t\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n ) > $@\n \n-$(obj)/%.S: $(src)/%.bmp\n-\t$(call cmd,S_splash)\n+$(obj)/%.bmp.S: $(src)/%.bmp FORCE\n+\t$(call if_changed,S_splash)\n \n # EFI applications\n # A Makefile target *.efi is built as EFI application.\n", "prefixes": [ "v4", "2/2" ] }