Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2222584/?format=api
{ "id": 2222584, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2222584/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413043247.3327855-1-keerthana.kalyanasundaram@broadcom.com/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.2/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260413043247.3327855-1-keerthana.kalyanasundaram@broadcom.com>", "list_archive_url": null, "date": "2026-04-13T04:32:47", "name": "[v5.15-v6.1] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "7ef48ef3f71c6c468e1023885ba16f37b8043fa1", "submitter": { "id": 92585, "url": "http://patchwork.ozlabs.org/api/1.2/people/92585/?format=api", "name": "Keerthana K", "email": "keerthana.kalyanasundaram@broadcom.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413043247.3327855-1-keerthana.kalyanasundaram@broadcom.com/mbox/", "series": [ { "id": 499644, "url": "http://patchwork.ozlabs.org/api/1.2/series/499644/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499644", "date": "2026-04-13T04:32:47", "name": "[v5.15-v6.1] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499644/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222584/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222584/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11838-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=google header.b=SO588cYn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11838-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"SO588cYn\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.98", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com", "smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvF8C13btz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 14:40:27 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D5206300F940\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 04:40:18 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BD69337C0E9;\n\tMon, 13 Apr 2026 04:40:17 +0000 (UTC)", "from mail-ot1-f98.google.com (mail-ot1-f98.google.com\n [209.85.210.98])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF7B38237C\n\tfor <netfilter-devel@vger.kernel.org>; Mon, 13 Apr 2026 04:40:15 +0000 (UTC)", "by mail-ot1-f98.google.com with SMTP id\n 46e09a7af769-7d7e878a7a9so530817a34.0\n for <netfilter-devel@vger.kernel.org>;\n Sun, 12 Apr 2026 21:40:15 -0700 (PDT)", "from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com\n (address-144-49-247-15.dlp.protect.broadcom.com. [144.49.247.15])\n by smtp-relay.gmail.com with ESMTPS id\n 586e51a60fabf-423ddd32ab3sm1299630fac.16.2026.04.12.21.40.13\n for <netfilter-devel@vger.kernel.org>\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Sun, 12 Apr 2026 21:40:14 -0700 (PDT)", "by mail-qv1-f70.google.com with SMTP id\n 6a1803df08f44-8a5bf7ee420so13279756d6.0\n for <netfilter-devel@vger.kernel.org>;\n Sun, 12 Apr 2026 21:40:12 -0700 (PDT)", "from keerthanak-ph5-dev.. ([192.19.161.250])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8aca5222c8esm38017646d6.28.2026.04.12.21.40.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 21:40:11 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776055217; cv=none;\n b=tHnZyzSAw7a+UfBp9d9ZXELyWjha8Ihf04fk4KRHyeT+IeRTEBT7R4uTEufTYUnlFc2FoeAW1953P3IQhKgw52GVMhtjBLn3OnkJsZPHZgVzo+gNft/XPM7InWM1wn/fTvMiRbmUjrx6/7h3Gfzt4RLhJi6SNdJ8rvdYi+iA8Zc=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776055217; c=relaxed/simple;\n\tbh=32i2CGMRFLkk71ry4kqEvU3i5K2ngl/kHrRJQNNg15s=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=ONPQsRTctWK07su7B7F33g4T1XzARwH95p5R/5sn6k+ZZs9kNHBWOK7fcgP/JxiReDbx7UtjzYIYjAVPm4Q8K777njD0jw/vZ8u6OI7xrV1MoOufu/C1Qt4IJx1LcmH+CEpxxnIAxAsKhbK04OXIAFKsIBtcsCMT29TXdy/7qYE=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=SO588cYn; arc=none smtp.client-ip=209.85.210.98", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776055215; x=1776660015;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=yEhC8dL15vha3u2nezC8YntUF4AHPl/GJlnlwSrjKaM=;\n b=K2I4cGP89ADy6N4uTrzHH/4crbIIMRV84yzVguwlGpoABWYj/s8AMxTQ9sVgFvSJwE\n exud/ug/rysz8AKedew9nmT6uNRqoX3ZR53voGQP+YGpihPsVOPf+g3jYoM4NYeckXzx\n TstxomL1k6PIOdYGZdFtgvHW85ih0WFWOA3ej6+aNDroVGAlgT5QMQVUsnJtTF2hppXT\n 8OxKGCye7pYmoge8zEYlQglPQoRUcjsOpNV2GJmDzBistCOmBRl2VQk3bpJnYuVK774+\n YV9FvyudFsj5IaN/HMwciWh2etpWAYZdgOY28UCbvadTPzfuw4OMfnXRI53BVBvCvuWV\n 2Xkg==", "X-Forwarded-Encrypted": [ "i=1;\n AJvYcCVS8AA0pPrWTIQfyKiLnKWOGTXV+GVINsodO5nPxLVCgYkakBhDm9urGFlpvkTxcImHb3I8TywinhpDIWYKar8=@vger.kernel.org", "i=1;\n AFNElJ+DYqMFnjGcj362jNN7mfx1aCAkSAePI+MTlxyvr0HOsWcn2cz1gPYKcdNVutfqwykcZMLWRo8OXxwz7RNIKUE=@vger.kernel.org" ], "X-Gm-Message-State": "AOJu0YwHgxEQ6nVwcCG11z5KYRPWqBh7vqzAEEsFElA4a82EInZ/VSHr\n\tkXgDYmzOObYc9JNoe+yise0NveH+uIqVpL/5BQdOyIdCNVHFVEgkma9QXZikCH5drD267Ud8PEW\n\tVNger8M27X7f327eJ+wVcKbAMxWC1KSVbQVwHT9PhF42h0R2e0488rwuL9anJkUYIjeWjAQeBIm\n\tacY/H+r2bi0pmgj8EMrM5Zwtj7ek36jRpENlfPMnsMD7K3dFX3GfACUQTcDonUhDGS9J3St4xe3\n\t7eDGyp82nbGaODqgnxdbWwuMY16gtFzBcEDEug5qbE=", "X-Gm-Gg": "AeBDieuP5adS47NHf/NmGvNoa7ypYgR7y32Aalpf+/pIYPWSU+5XkI1gUSdbBSx7t62\n\tgQC12IeQqP/NQMdOZygAKNc1Bj7XHRz2AIsNFFxC2/5QEWc0b5tYxgCb4H7u2vC/9ChwrULWl0E\n\t3ujuUr33DoomGA9Ru8564r8b57U6IMSYMpATbhyr+e2C7nsSgI6CPf7iVQx0vJPuZmHcHWgST+p\n\tq02S7zj/05LsFBWfRTt+01HFCUjQJ6RtWT/EkJWI/VnyjvIg5uaPegcUTkxY8OMnrcBzCnSwKp2\n\tsGLN05Ay/Yigfg1d1GrN5uH6ggG2GBN94fMA280ymJfxJ+eEoKs1phTcpJJse53R0M2E4O2Kq6x\n\t+t9cmrC7xwJBVZxLQ0P4pc1iNKxOgYeUsY5tDSK0eI5haA8mTuVouLLt3B/rlvfSSnCmccQLdSq\n\tcOD+jWSAV4pSi8lCYekdnTtDbx/U1F8eW0Yj4pUZGodfFI6+MVj0GPHny59ib/DV76atYX+uS8+\n\tA==", "X-Received": [ "by 2002:a05:6830:44a4:b0:7db:fe64:9464 with SMTP id\n 46e09a7af769-7dc27da28a5mr5825785a34.3.1776055214797;\n Sun, 12 Apr 2026 21:40:14 -0700 (PDT)", "by 2002:a05:6214:2424:b0:89c:5159:ea52 with SMTP id\n 6a1803df08f44-8ac8627aaacmr140468936d6.7.1776055212429;\n Sun, 12 Apr 2026 21:40:12 -0700 (PDT)", "by 2002:a05:6214:2424:b0:89c:5159:ea52 with SMTP id\n 6a1803df08f44-8ac8627aaacmr140468666d6.7.1776055211924;\n Sun, 12 Apr 2026 21:40:11 -0700 (PDT)" ], "X-Relaying-Domain": "broadcom.com", "X-CFilter-Loop": "Reflected", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1776055212; x=1776660012;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=yEhC8dL15vha3u2nezC8YntUF4AHPl/GJlnlwSrjKaM=;\n b=SO588cYnpMSCK8ejZkVQ8h2BFBcwM1VVp/9ajY/xxmPZ+Ir/4sPgpSVTN8K24cZSwf\n ZPcgEJZ8NBlyX2z9e6sYnGQ6Bu2poj9Pfuo6Rk4i2sdaDSXn+K/FK90LQq2bst/JlWR7\n sjFL0ZA9gV8Eb99crGO11wK0VmQVqPiuWlerQ=", "From": "Keerthana K <keerthana.kalyanasundaram@broadcom.com>", "To": "stable@vger.kernel.org,\n\tgregkh@linuxfoundation.org", "Cc": "pablo@netfilter.org,\n\tkadlec@netfilter.org,\n\tfw@strlen.de,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tajay.kaher@broadcom.com,\n\talexey.makhalov@broadcom.com,\n\tvamsi-krishna.brahmajosyula@broadcom.com,\n\tyin.ding@broadcom.com,\n\ttapas.kundu@broadcom.com,\n\tStefano Brivio <sbrivio@redhat.com>,\n\tMukul Sikka <mukul.sikka@broadcom.com>,\n\tBrennan Lamoreaux <brennan.lamoreaux@broadcom.com>,\n\tKeerthana K <keerthana.kalyanasundaram@broadcom.com>", "Subject": "[PATCH v5.15-v6.1] netfilter: nft_set_pipapo: do not rely on\n ZERO_SIZE_PTR", "Date": "Mon, 13 Apr 2026 04:32:47 +0000", "Message-ID": "<20260413043247.3327855-1-keerthana.kalyanasundaram@broadcom.com>", "X-Mailer": "git-send-email 2.43.7", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-DetectorID-Processed": "b00c1d49-9d2e-4205-b15f-d015386d3d5e" }, "content": "From: Florian Westphal <fw@strlen.de>\n\ncommit 07ace0bbe03b3d8e85869af1dec5e4087b1d57b8 upstream\n\npipapo relies on kmalloc(0) returning ZERO_SIZE_PTR (i.e., not NULL\nbut pointer is invalid).\n\nRework this to not call slab allocator when we'd request a 0-byte\nallocation.\n\nReviewed-by: Stefano Brivio <sbrivio@redhat.com>\nSigned-off-by: Florian Westphal <fw@strlen.de>\nSigned-off-by: Mukul Sikka <mukul.sikka@broadcom.com>\nSigned-off-by: Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>\n[Keerthana: In older stable branches (v6.6 and earlier), the allocation logic in\npipapo_clone() still relies on `src->rules` rather than `src->rules_alloc`\n(introduced in v6.9 via 9f439bd6ef4f). Consequently, the previously\nbackported INT_MAX clamping check uses `src->rules`. This patch correctly\nmoves that `src->rules > (INT_MAX / ...)` check inside the new\n`if (src->rules > 0)` block]\nSigned-off-by: Keerthana K <keerthana.kalyanasundaram@broadcom.com>\n---\n net/netfilter/nft_set_pipapo.c | 20 ++++++++++++++------\n 1 file changed, 14 insertions(+), 6 deletions(-)", "diff": "diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c\nindex 863162c82330..2072c89a467d 100644\n--- a/net/netfilter/nft_set_pipapo.c\n+++ b/net/netfilter/nft_set_pipapo.c\n@@ -525,6 +525,8 @@ static struct nft_pipapo_elem *pipapo_get(const struct net *net,\n \tint i;\n \n \tm = priv->clone;\n+\tif (m->bsize_max == 0)\n+\t\treturn ret;\n \n \tres_map = kmalloc_array(m->bsize_max, sizeof(*res_map), GFP_ATOMIC);\n \tif (!res_map) {\n@@ -1365,14 +1367,20 @@ static struct nft_pipapo_match *pipapo_clone(struct nft_pipapo_match *old)\n \t\t src->bsize * sizeof(*dst->lt) *\n \t\t src->groups * NFT_PIPAPO_BUCKETS(src->bb));\n \n-\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n-\t\t\tgoto out_mt;\n+\t\tif (src->rules > 0) {\n+\t\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n+\t\t\t\tgoto out_mt;\n+\n+\t\t\tdst->mt = kvmalloc_array(src->rules, sizeof(*src->mt),\n+\t\t\t\t\t\t GFP_KERNEL);\n+\t\t\tif (!dst->mt)\n+\t\t\t\tgoto out_mt;\n \n-\t\tdst->mt = kvmalloc(src->rules * sizeof(*src->mt), GFP_KERNEL_ACCOUNT);\n-\t\tif (!dst->mt)\n-\t\t\tgoto out_mt;\n+\t\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n+\t\t} else {\n+\t\t\tdst->mt = NULL;\n+\t\t}\n \n-\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n \t\tsrc++;\n \t\tdst++;\n \t}\n", "prefixes": [ "v5.15-v6.1" ] }