Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2222515/?format=api
{ "id": 2222515, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2222515/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412134016.1640882-1-vivien.leger@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260412134016.1640882-1-vivien.leger@gmail.com>", "list_archive_url": null, "date": "2026-04-12T13:40:16", "name": "hw/net/fsl_etsec: implement RCTRL[CFA] FCS stripping on receive", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a625a42428635bbc4b98f25b076b89cf2e3685e0", "submitter": { "id": 93121, "url": "http://patchwork.ozlabs.org/api/1.2/people/93121/?format=api", "name": "Vivien LEGER", "email": "vivien.leger@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412134016.1640882-1-vivien.leger@gmail.com/mbox/", "series": [ { "id": 499611, "url": "http://patchwork.ozlabs.org/api/1.2/series/499611/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499611", "date": "2026-04-12T13:40:16", "name": "hw/net/fsl_etsec: implement RCTRL[CFA] FCS stripping on receive", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499611/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222515/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222515/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=N3jWnB5u;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftt3G2ZVYz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 00:19:54 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBveW-0005Bm-Ll; Sun, 12 Apr 2026 10:19:08 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vivien.leger@gmail.com>)\n id 1wBv34-0007b6-Bf\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 09:40:26 -0400", "from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <vivien.leger@gmail.com>)\n id 1wBv31-00051W-Qt\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 09:40:26 -0400", "by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-43cfd1f9fd1so2260551f8f.3\n for <qemu-devel@nongnu.org>; Sun, 12 Apr 2026 06:40:23 -0700 (PDT)", "from vle-arch (88-184-113-142.subs.proxad.net. [88.184.113.142])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d6ffd3880sm8713324f8f.7.2026.04.12.06.40.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 06:40:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776001222; x=1776606022; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=ArzLsLDSjc83muoLDyS1M+CRJjI1FneSSOb42Mz0oPY=;\n b=N3jWnB5ux8pKIB21C7VnD/zN5WtnGisG2xBPXHgX0/ShW15fArJBlzoko+wwASQLQe\n +Zox5tpmJzsfLaNIg7yZOgmOgSbqdWkf6y5VWf/I5RY4f3oIWsRhS+FOt3YNIdxLHm0H\n mzGaRcwbCiZVSf95tdMGjzVgL24sWcxRRoeUYR0/1JyBZGgOd/4rcxNAowyPeFxUZ3HH\n VqYQxV3bFDE7MIAmNDJinhhe9qx5Q37jB8lLy/j7l7AztCFASCXESImK6B2+tc9dCTOP\n mwe6aJptGYqmL25KAAB05LPOq1PWbYszbTGjt+hsSChOrdnTu+208+pms5LZoCvi+7RQ\n Wejw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776001222; x=1776606022;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ArzLsLDSjc83muoLDyS1M+CRJjI1FneSSOb42Mz0oPY=;\n b=FnwdGQkDEXuMZcQeQ/4+X0yG4UUgJGq1OEkcasUCRXuAL5zrqzWmK7KJS2JQHH98bK\n KPlcss635pD3sLHTWAdhdpyTR048524ch3x7sNPpjQAF+QkrBvjWDIcaR3DBEnXEqD2X\n 5zGvep0DWo24WlUheOgOOfCxe9XJT6qjvsXQ64arzKUamKKYEhI2OIA+wl13Iq2qLxbL\n 8etWEJ7+F2zZ0O6fBpmLs+Ro5ron3bw160qmZMi67yC1bU5+BCQj9RmOwugtqczoFZ0s\n w5Vof8wCkj/QU4/JeG4cxXEffdMW08Y5QqsFwSQGGt4ZIGEKX37H3+zU+ttQ4WETCptI\n xrkg==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ8IvTCOfB3QVODlYTSMiEAIxOHGqu+v+p/ZVV70eGvR3T0N0xGshZ/L9CfiDPQgIeJJI598jiVgxU89@nongnu.org", "X-Gm-Message-State": "AOJu0YxDfYg5ky/RI8bERRbQy5c95qgzINIrhN41Wjn4i635XGGn7u7f\n I6C+YxkBPJncaRpKe3RUWS57bvSBCfEt2T++lqBqTx+QNQE7Ffy0ms6j", "X-Gm-Gg": "AeBDievbfikGItyqUX/K98LFxVCZRjLRQMGUAJDDthgtB2UpusL4pOxb2c43pCleS5M\n GhQqo5aqfVNyktbCe/v/OqZ2jww7HrdP6HoSKtcdqDf5GM53KAxl8AHUjenW/7eKGQIxZi1/Um4\n 7W0dO2/VhD062sXFrNGnZgDKdpQd36e8YM1asMAHrsSWw1v0HJ/FMTciipHaaGAOiMoFy3ZGJ3u\n RQvU/9yTHflTsQOcygMscEyxSwnb2qknLPXuX5NiqXjShF2g012nfjuO6xfFeuGs2C9Mu1KHs1u\n zRvFOROGvT5EXehl5A+CCnJ/BzuJQUfSfXywWAeHXykk+X5G3iJ4XYRn3IEuNb1LPlmTjxXwcTT\n cPADhvUd7AjsaiEfurkWzpg1ForK0Te2UWluPcR6cbLeqTIWIorLRg2hut4v4nyqkzjH8/orL06\n sRAIk4YRVHlbbNsil22mmFb0dtCHVcnpeHHJskYhSnw3Cdg3bOyOpTvE2k/8Jhi6IGwMUnihatv\n KMYrrVr21PLjVpAze6n0bOmVn1H+daBGxQLOAs=", "X-Received": "by 2002:a05:6000:2403:b0:43d:4b00:9ee7 with SMTP id\n ffacd0b85a97d-43d642d1b1cmr14406156f8f.33.1776001221475;\n Sun, 12 Apr 2026 06:40:21 -0700 (PDT)", "From": "Vivien LEGER <vivien.leger@gmail.com>", "To": "qemu-ppc@nongnu.org", "Cc": "shentey@gmail.com, qemu-devel@nongnu.org,\n Vivien LEGER <vivien.leger@gmail.com>", "Subject": "[PATCH] hw/net/fsl_etsec: implement RCTRL[CFA] FCS stripping on\n receive", "Date": "Sun, 12 Apr 2026 15:40:16 +0200", "Message-ID": "<20260412134016.1640882-1-vivien.leger@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::436;\n envelope-from=vivien.leger@gmail.com; helo=mail-wr1-x436.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-Mailman-Approved-At": "Sun, 12 Apr 2026 10:19:06 -0400", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The eTSEC hardware strips the 4-byte FCS from received frames by\ndefault (RCTRL[CFA]=0). When CFA=1, FCS is copied to the application\nbuffer and bd->length includes it.\n\nPreviously QEMU always included FCS in bd->length regardless of CFA,\ncausing guests using the default RCTRL to receive 4 extra bytes per\nframe, breaking protocols that validate frame length (e.g. ARP).\n\nFix by subtracting 4 from bd->length when RCTRL[CFA]=0 (default).\n\nSigned-off-by: Vivien LEGER <vivien.leger@gmail.com>\n---\n hw/net/fsl_etsec/registers.h | 1 +\n hw/net/fsl_etsec/rings.c | 10 ++++++++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/hw/net/fsl_etsec/registers.h b/hw/net/fsl_etsec/registers.h\nindex f085537ecd..1766e39a1a 100644\n--- a/hw/net/fsl_etsec/registers.h\n+++ b/hw/net/fsl_etsec/registers.h\n@@ -103,6 +103,7 @@ extern const eTSEC_Register_Definition eTSEC_registers_def[];\n #define RCTRL_PRSDEP_MASK (0x3)\n #define RCTRL_PRSDEP_OFFSET (6)\n #define RCTRL_RSF (1 << 2)\n+#define RCTRL_CFA (1 << 11) /* Copy FCS to application */\n \n /* Index of each register */\n \ndiff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c\nindex 22660c32b8..38e27ad6d8 100644\n--- a/hw/net/fsl_etsec/rings.c\n+++ b/hw/net/fsl_etsec/rings.c\n@@ -442,6 +442,16 @@ static void fill_rx_bd(eTSEC *etsec,\n cpu_physical_memory_write(bufptr, padd, rem);\n }\n }\n+\n+ /* Strip FCS unless RCTRL[CFA] requests copy to application.\n+ * Per FSL eTSEC architecture (RCTRL field descriptions):\n+ * CFA=0 (reset default): FCS is checked and discarded by hardware,\n+ * bd->length should not include the 4-byte FCS.\n+ * CFA=1: FCS is copied to the application buffer, bd->length includes FCS.\n+ */\n+ if (!(etsec->regs[RCTRL].value & RCTRL_CFA) && bd->length >= 4) {\n+ bd->length -= 4;\n+ }\n }\n \n static void rx_init_frame(eTSEC *etsec, const uint8_t *buf, size_t size)\n", "prefixes": [] }