Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2222361/?format=api
{ "id": 2222361, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2222361/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260411080148.471335-20-kwilczynski@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.2/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260411080148.471335-20-kwilczynski@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260411080148.471335-20-kwilczynski@kernel.org/", "date": "2026-04-11T08:01:43", "name": "[v4,19/24] PCI/sysfs: Remove pci_{create,remove}_sysfs_dev_files()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "617e5b66a541a60f27b2488ba210348b3d0124c4", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.2/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260411080148.471335-20-kwilczynski@kernel.org/mbox/", "series": [ { "id": 499538, "url": "http://patchwork.ozlabs.org/api/1.2/series/499538/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499538", "date": "2026-04-11T08:01:24", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/499538/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222361/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222361/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19639-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GyMNrqxf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19639-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GyMNrqxf;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft5mS5pkjz1yCx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 18:04:24 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4ft5kw06Vvz2yr4;\n\tSat, 11 Apr 2026 18:03:04 +1000 (AEST)", "from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4ft5kv165Pz2yk6\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sat, 11 Apr 2026 18:03:03 +1000 (AEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 4930F60141;\n\tSat, 11 Apr 2026 08:03:01 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 9EB7FC4CEF7;\n\tSat, 11 Apr 2026 08:02:57 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775894583;\n\tcv=none;\n b=jMGnuxmcBAIehYVucRJE+ocPtp4RX3ujDo8CjmQhEIiT8SS5uby3VSk35ARq1zHk9JR9zQ2bxGnzw97wsUhp/JFktf33KsTE+HLnjFilxxaiqr1WLinUD3Wg9qonfuzmgyVAzqmK/zbLpW6TTOcY9KNR8xUfsHQx3OlUO1n7WOUn3DzToCd4v/zzbM6VMj9vqzGleDnwHqCYCE0bpgtKKRnFUOn1mwxJKgwWwxn+BJpLqWhysYbFNLv5PTgjvmnxTz//Sc26ghpGhnxoYRLfbuQifnb/UbLc+MsgUsDJti8TzlZ1KOIhnUQlfvUk4eJHqELU38INyW5JyFgbKW8wag==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775894583; c=relaxed/relaxed;\n\tbh=AYfml6GaxXOr5nCMzF4T4gZwu0+WarQKjouLgSQZ5iU=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=omheySC9r5m9ggEhJC4iX6F8FZ9fqwkWuK9ZA7UDd4glDyPUDoOgwt1m3Ds89tN1h1w28gXM6spC3JWP57x60GsFrqIa9AkpD7Ci1zNOg8ZBkdNGTxRh0aA9M2cgeQOmiTAiL2IXwV3D5wrIrMDf+RSbuv+Hi7w5p6G5tI2lkqgVPL7T6MIl0BvL5P711SBqYGgsNIiD9QZcuEugQ2pZhHv/Qqz5Ko2oJmw0L3egR3ICU4ICzIZ6TIGx+8RfwgmnmEWdAxz088iv2qYpAO+Gr8RMlF24uHll/Kmrc3fdDQF/dqz7H08eMzc/gnQv+G1BAIczUB9oUPMBD0jF7LfHJw==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GyMNrqxf; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775894581;\n\tbh=weHFBz7i//6ML6QGLBL0RoSrKCxIntD99zUOmvv58+M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GyMNrqxfXGOJhCTa6jUSDY8IQyJRgq9ex3lecAtkTPxIJwcIIocjpDtodtPDcD2si\n\t OOZX4njQ0H6TdtuW3dC81m/XWlrCNKzkC7kH99RzNjZjTeND/OviHmM8uBXKW1UJ0Q\n\t ONImjaxUBjPnPSlx+x1BD8JMtqc+nDdy0D2IHexrgY3n1p2PzYQHWNqxVuOV5VTiKN\n\t xuEuyXNqGxsSfDfuAqrCWh+zyLjqqgJHOYA9knMgWCyVkzvYIqVCGxieiIvsqZg8zK\n\t j4pcQ5ZjwRI/r5Z3fJBaBGYPCqjvSNAQeZ7s1BsCaOho8y4VBXzptv5Z2PUDGlJa3u\n\t pftJLIje/tw/g==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v4 19/24] PCI/sysfs: Remove\n pci_{create,remove}_sysfs_dev_files()", "Date": "Sat, 11 Apr 2026 08:01:43 +0000", "Message-ID": "<20260411080148.471335-20-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260411080148.471335-1-kwilczynski@kernel.org>", "References": "<20260411080148.471335-1-kwilczynski@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Currently, pci_create_sysfs_dev_files() and pci_remove_sysfs_dev_files()\nare no-op stubs. With both the generic and Alpha resource files now\nhandled by static attribute groups, no platform needs dynamic per-device\nsysfs file creation.\n\nThus, remove both functions, their declarations, and the call sites in\npci_bus_add_device() and pci_stop_bus_device().\n\nRemove __weak pci_create_resource_files() and pci_remove_resource_files()\nstubs and their declarations in pci.h, as no architecture overrides them\nanymore.\n\nRemove the res_attr[] and res_attr_wc[] fields from struct pci_dev\nwhich were used to track dynamically allocated resource attributes.\n\nFinally, simplify pci_sysfs_init() to only handle legacy file creation\nunder HAVE_PCI_LEGACY, removing the per-device loop and the\nHAVE_PCI_SYSFS_INIT helper added earlier.\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/bus.c | 1 -\n drivers/pci/pci-sysfs.c | 52 ++---------------------------------------\n drivers/pci/pci.h | 4 ----\n drivers/pci/remove.c | 1 -\n include/linux/pci.h | 9 -------\n 5 files changed, 2 insertions(+), 65 deletions(-)", "diff": "diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c\nindex 6c1ad1f542d9..655ed53436d3 100644\n--- a/drivers/pci/bus.c\n+++ b/drivers/pci/bus.c\n@@ -354,7 +354,6 @@ void pci_bus_add_device(struct pci_dev *dev)\n \tpci_fixup_device(pci_fixup_final, dev);\n \tif (pci_is_bridge(dev))\n \t\tof_pci_make_dev_node(dev);\n-\tpci_create_sysfs_dev_files(dev);\n \tpci_proc_attach_device(dev);\n \tpci_bridge_d3_update(dev);\n \ndiff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex d22bc5c48bc0..3a7bbb00ca60 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -37,12 +37,7 @@\n #define ARCH_PCI_DEV_GROUPS\n #endif\n \n-#if defined(HAVE_PCI_LEGACY) || \\\n-\t!defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-#define HAVE_PCI_SYSFS_INIT\n-#endif\n-\n-#ifdef HAVE_PCI_SYSFS_INIT\n+#ifdef HAVE_PCI_LEGACY\n static int sysfs_initialized;\t/* = 0 */\n #endif\n \n@@ -1401,8 +1396,6 @@ static const struct attribute_group *pci_dev_resource_attr_groups[] = {\n };\n #else\n #define pci_dev_resource_attr_groups NULL\n-int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }\n-void __weak pci_remove_resource_files(struct pci_dev *dev) { }\n #endif\n \n /**\n@@ -1772,54 +1765,13 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.is_visible = resource_resize_attr_is_visible,\n };\n \n-#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n-void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n-#else\n-int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n-{\n-\tif (!sysfs_initialized)\n-\t\treturn -EACCES;\n-\n-\treturn pci_create_resource_files(pdev);\n-}\n-\n-/**\n- * pci_remove_sysfs_dev_files - cleanup PCI specific sysfs files\n- * @pdev: device whose entries we should free\n- *\n- * Cleanup when @pdev is removed from sysfs.\n- */\n-void pci_remove_sysfs_dev_files(struct pci_dev *pdev)\n-{\n-\tif (!sysfs_initialized)\n-\t\treturn;\n-\n-\tpci_remove_resource_files(pdev);\n-}\n-#endif\n-\n-#ifdef HAVE_PCI_SYSFS_INIT\n+#ifdef HAVE_PCI_LEGACY\n static int __init pci_sysfs_init(void)\n {\n-#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n \tstruct pci_bus *pbus = NULL;\n \n \tsysfs_initialized = 1;\n-#else\n-\tstruct pci_dev *pdev = NULL;\n-\tstruct pci_bus *pbus = NULL;\n-\tint retval;\n \n-\tsysfs_initialized = 1;\n-\tfor_each_pci_dev(pdev) {\n-\t\tretval = pci_create_sysfs_dev_files(pdev);\n-\t\tif (retval) {\n-\t\t\tpci_dev_put(pdev);\n-\t\t\treturn retval;\n-\t\t}\n-\t}\n-#endif\n \twhile ((pbus = pci_find_next_bus(pbus)))\n \t\tpci_create_legacy_files(pbus);\n \ndiff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex 13d998fbacce..1bf165595583 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -391,16 +391,12 @@ static inline int pci_no_d1d2(struct pci_dev *dev)\n }\n \n #ifdef CONFIG_SYSFS\n-int pci_create_sysfs_dev_files(struct pci_dev *pdev);\n-void pci_remove_sysfs_dev_files(struct pci_dev *pdev);\n extern const struct attribute_group *pci_dev_groups[];\n extern const struct attribute_group *pci_dev_attr_groups[];\n extern const struct attribute_group *pcibus_groups[];\n extern const struct attribute_group *pci_bus_groups[];\n extern const struct attribute_group pci_doe_sysfs_group;\n #else\n-static inline int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n-static inline void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n #define pci_dev_groups NULL\n #define pci_dev_attr_groups NULL\n #define pcibus_groups NULL\ndiff --git a/drivers/pci/remove.c b/drivers/pci/remove.c\nindex e9d519993853..6e796dbc5b29 100644\n--- a/drivers/pci/remove.c\n+++ b/drivers/pci/remove.c\n@@ -26,7 +26,6 @@ static void pci_stop_dev(struct pci_dev *dev)\n \n \tdevice_release_driver(&dev->dev);\n \tpci_proc_detach_device(dev);\n-\tpci_remove_sysfs_dev_files(dev);\n \tof_pci_remove_node(dev);\n }\n \ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 30aeb8e02b7b..f6f55005f82d 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -507,10 +507,6 @@ struct pci_dev {\n \tspinlock_t\tpcie_cap_lock;\t\t/* Protects RMW ops in capability accessors */\n \tu32\t\tsaved_config_space[16]; /* Config space saved at suspend time */\n \tstruct hlist_head saved_cap_space;\n-#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-\tstruct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */\n-\tstruct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs file for WC mapping of resources */\n-#endif\n \n #ifdef CONFIG_HOTPLUG_PCI_PCIE\n \tunsigned int\tbroken_cmd_compl:1;\t/* No compl for some cmds */\n@@ -2528,11 +2524,6 @@ int pcibios_alloc_irq(struct pci_dev *dev);\n void pcibios_free_irq(struct pci_dev *dev);\n resource_size_t pcibios_default_alignment(void);\n \n-#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n-extern int pci_create_resource_files(struct pci_dev *dev);\n-extern void pci_remove_resource_files(struct pci_dev *dev);\n-#endif\n-\n #if defined(CONFIG_PCI_MMCONFIG) || defined(CONFIG_ACPI_MCFG)\n void __init pci_mmcfg_early_init(void);\n void __init pci_mmcfg_late_init(void);\n", "prefixes": [ "v4", "19/24" ] }