Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2222343/?format=api
{ "id": 2222343, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2222343/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260411080148.471335-9-kwilczynski@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/1.2/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260411080148.471335-9-kwilczynski@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260411080148.471335-9-kwilczynski@kernel.org/", "date": "2026-04-11T08:01:32", "name": "[v4,08/24] PCI/sysfs: Convert __resource_resize_store() to use static attributes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8deebea4fdcac8a8210e6bec24c457e4a35da2e5", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.2/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260411080148.471335-9-kwilczynski@kernel.org/mbox/", "series": [ { "id": 499538, "url": "http://patchwork.ozlabs.org/api/1.2/series/499538/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499538", "date": "2026-04-11T08:01:24", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/499538/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222343/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222343/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19628-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=KzKF0gfZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19628-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=KzKF0gfZ;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft5kr6PbQz1yCx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 18:03:00 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4ft5k85yz9z2ynv;\n\tSat, 11 Apr 2026 18:02:24 +1000 (AEST)", "from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4ft5k76gQhz2ymg\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sat, 11 Apr 2026 18:02:23 +1000 (AEST)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id DC4B7600AE;\n\tSat, 11 Apr 2026 08:02:21 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 7D5B5C4CEF7;\n\tSat, 11 Apr 2026 08:02:18 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775894544;\n\tcv=none;\n b=KUJxsIHmPeY83+kTn+irs78RCC12a+GzfHr2NZ7lh0k2xvGOu7Fyu6cvbqj4g51yA2mKvIILLb0GmJYrSxB83uQSeN/gDaoELclq8F+9jF/ALPKEB5lxAY4QvwQhd/jpbFKkxguy8j9S1pka692GhPAE6/qgYyMICgmGnCcxOtWu58trWyiMpKY0PvFX9TGDDguZy3CiqwZd4qFIzBlj5jBJRXO4iBl4Y0X9lH6g1k2L2suS8erjWbAprPPZMr0N2X+hcupJUZV/Us6IBLnGftUsCXEjNjEp98cvxCTp0Mc3rFH6I9LwfznWRLBECq9a+UdNGU9A9IRD7Z9OnJxKjA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775894544; c=relaxed/relaxed;\n\tbh=hw5ggym5gsOgyXNq1pqVYyL3sTq1bxqihHcydzMkEzY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=TFF7O/hihG8b9sduL6LWmbGB8vpVBWCR9Rd1U1Kq3/s9+hbvLUdwTy8h4XtmPOwlmxgNReeyYf3HDp51rXDp/dABCa5dqd1FlI6uv0pNEHx2gedLdfVXnF9ah/v8ID9D8rhyayfzM9fJMtUAGhjZIZJN6ieqCJ/Pbrd9HMJR7iaDxxo83vPr7ZsMBQgtugQK4kQbb1hsJmHZxEPZZD8gZfrjdLfbyTZj/SlfRkkjtDUnIW/FdaZmk/9CTe9gyjqrnIX7bVYLKY6xLIVmCWEZbwbnOgwY6LunO3uFrwedv03UG/qZcgMZPpyYFYlmVQvNjSFl99IhLmOhraW9E31lQA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=KzKF0gfZ; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775894541;\n\tbh=UUdcfp1Jj+7X39UhUYZiEAGo8M2BFY1tXtTB8pe0jdU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KzKF0gfZsTJvOqnWuzxJdUYfZoqTbpWXMQrTizAIxQ/+UtJLTllDKMUPIcI3yM0DX\n\t Ca6CHETvribfiTZtj2sXAn2CwIyqhjDmkT98/5L3VIC8oVthBAtSESEIoSLuGk3TUC\n\t gkQDIy4Ss1TOVLbfhVsmrzGm0w08vKKoItkeqpC3WuY0aUyy0glfVX4+qDaO5PMYEI\n\t zzwNlnxl2Kynv01wi5wG9jkDVSeQMdW04eiHDQfbyztARqaEzHqKJHij2xJ6mhUTQb\n\t 9/deriR2IALMiqOspq55xqLH0viTdKjg0CSQx8ZZ2zTK0c9b+ExDHD5R5hWSsd4RSt\n\t QsgdytvWfOMbQ==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v4 08/24] PCI/sysfs: Convert __resource_resize_store() to use\n static attributes", "Date": "Sat, 11 Apr 2026 08:01:32 +0000", "Message-ID": "<20260411080148.471335-9-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260411080148.471335-1-kwilczynski@kernel.org>", "References": "<20260411080148.471335-1-kwilczynski@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Currently, __resource_resize_store() calls pci_remove_resource_files()\nand pci_create_resource_files() to tear down and recreate resource\nfiles after a BAR resize.\n\nReplace these with sysfs_remove_groups() before the resize and\nsysfs_create_groups() after, which re-evaluates visibility and\nruns the .bin_size callback for the static resource attribute\ngroups. Also, add a warning if pci_resize_resource() fails to\nexpose potential failures.\n\nFor architectures without HAVE_PCI_MMAP or ARCH_GENERIC_PCI_MMAP_RESOURCE,\ndefine pci_dev_resource_attr_groups as NULL so the resize path compiles\nunconditionally and sysfs_remove_groups() and sysfs_create_groups() become\nno-ops.\n\nWhile at it, rename the resource_resize_is_visible() to\nresource_resize_attr_is_visible() and the corresponding group variable\nto align with the naming convention used by the resource attribute\ngroups.\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/pci-sysfs.c | 25 ++++++++++++++++++-------\n 1 file changed, 18 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 2922905ff070..c0925bdc9ecd 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1386,6 +1386,14 @@ static const struct attribute_group pci_dev_resource_wc_attr_group = {\n \t.bin_size = pci_dev_resource_bin_size,\n };\n \n+static const struct attribute_group *pci_dev_resource_attr_groups[] = {\n+\t&pci_dev_resource_io_attr_group,\n+\t&pci_dev_resource_uc_attr_group,\n+\t&pci_dev_resource_wc_attr_group,\n+\tNULL,\n+};\n+#else\n+#define pci_dev_resource_attr_groups NULL\n #endif\n \n int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }\n@@ -1692,14 +1700,17 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tpci_write_config_word(pdev, PCI_COMMAND,\n \t\t\t cmd & ~PCI_COMMAND_MEMORY);\n \n-\tpci_remove_resource_files(pdev);\n+\tsysfs_remove_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups);\n \n \tret = pci_resize_resource(pdev, n, size, 0);\n+\tif (ret)\n+\t\tpci_warn(pdev, \"Failed to resize BAR %d: %pe\\n\",\n+\t\t\t n, ERR_PTR(ret));\n \n \tpci_assign_unassigned_bus_resources(bus);\n \n-\tif (pci_create_resource_files(pdev))\n-\t\tpci_warn(pdev, \"Failed to recreate resource files after BAR resizing\\n\");\n+\tif (sysfs_create_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups))\n+\t\tpci_warn(pdev, \"Failed to recreate resource groups after BAR resizing\\n\");\n \n \tpci_write_config_word(pdev, PCI_COMMAND, cmd);\n pm_put:\n@@ -1742,7 +1753,7 @@ static struct attribute *resource_resize_attrs[] = {\n \tNULL,\n };\n \n-static umode_t resource_resize_is_visible(struct kobject *kobj,\n+static umode_t resource_resize_attr_is_visible(struct kobject *kobj,\n \t\t\t\t\t struct attribute *a, int n)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n@@ -1750,9 +1761,9 @@ static umode_t resource_resize_is_visible(struct kobject *kobj,\n \treturn pci_rebar_get_current_size(pdev, n) < 0 ? 0 : a->mode;\n }\n \n-static const struct attribute_group pci_dev_resource_resize_group = {\n+static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n-\t.is_visible = resource_resize_is_visible,\n+\t.is_visible = resource_resize_attr_is_visible,\n };\n \n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n@@ -1873,6 +1884,7 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n #endif\n+\t&pci_dev_resource_resize_attr_group,\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n@@ -1884,7 +1896,6 @@ const struct attribute_group *pci_dev_groups[] = {\n #ifdef CONFIG_ACPI\n \t&pci_dev_acpi_attr_group,\n #endif\n-\t&pci_dev_resource_resize_group,\n \tARCH_PCI_DEV_GROUPS\n \tNULL,\n };\n", "prefixes": [ "v4", "08/24" ] }