Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2222251/?format=api
{ "id": 2222251, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2222251/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411022618.2136588-5-kshk@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.2/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260411022618.2136588-5-kshk@linux.ibm.com>", "list_archive_url": null, "date": "2026-04-11T02:26:07", "name": "[v2,04/15] s390x/pci: Move dm_mr from S390PCIIOMMU to S390PCIBusDevice", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "83fc5cb09afd969f7e878caed07350a890c6a7d2", "submitter": { "id": 90249, "url": "http://patchwork.ozlabs.org/api/1.2/people/90249/?format=api", "name": "Konstantin Shkolnyy", "email": "kshk@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411022618.2136588-5-kshk@linux.ibm.com/mbox/", "series": [ { "id": 499525, "url": "http://patchwork.ozlabs.org/api/1.2/series/499525/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499525", "date": "2026-04-11T02:26:13", "name": "s390x/pci: Implement migration for emulated devices", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499525/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222251/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222251/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=tiq9QjT6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsyJF3vjkz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 12:27:57 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBO3v-00026u-2G; Fri, 10 Apr 2026 22:27:07 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kshk@linux.ibm.com>)\n id 1wBO3r-00022Q-IL; Fri, 10 Apr 2026 22:27:03 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kshk@linux.ibm.com>)\n id 1wBO3o-0000Lr-Uc; Fri, 10 Apr 2026 22:27:03 -0400", "from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63B1WjHn2283816; Sat, 11 Apr 2026 02:26:56 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfcqer362-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2026 02:26:56 +0000 (GMT)", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63B00ubm026661;\n Sat, 11 Apr 2026 02:26:55 GMT", "from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dcmg8ayxe-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2026 02:26:55 +0000", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63B2QsBf32899810\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sat, 11 Apr 2026 02:26:54 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 14F695805A;\n Sat, 11 Apr 2026 02:26:54 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 7CF1058054;\n Sat, 11 Apr 2026 02:26:53 +0000 (GMT)", "from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.252.248])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Sat, 11 Apr 2026 02:26:53 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=iYqDdV/mpZmonzLAu\n Q89glCnUvTOWOki0Kn+55r82Bc=; b=tiq9QjT6GZhcp+zS5eCuOeSV8T+zQrBIC\n +bGVXfkpx4GmJIIl58UafjwMX+x82mfIP5ETtFtV9Deakjtt9i2eR8LohC9Ssahs\n jKAHFLmRBU2r2sEKCAWM0BMbp/lH84Yi1AM9TnIXn6ThZkHVVETT21DH4w78e4/1\n P1N7IzXkimFc8HOx1lizgEuwOT3rADjhd6lEeaSNMDmGpVSnP8q8Px1xqpKA+NtU\n 8ctMUZtRZGah3ghrYtrpO9y8Uu71p438BDOvpocpI+Jq77lV+9pWHuWWupscn2+m\n 5AGpbeWDyOsYExT9rOP54wYNtLs9VH7YsqDx+ogbqSL44GmT29mDQ==", "From": "Konstantin Shkolnyy <kshk@linux.ibm.com>", "To": "mjrosato@linux.ibm.com", "Cc": "alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy <kshk@linux.ibm.com>", "Subject": "[PATCH v2 04/15] s390x/pci: Move dm_mr from S390PCIIOMMU to\n S390PCIBusDevice", "Date": "Fri, 10 Apr 2026 21:26:07 -0500", "Message-Id": "<20260411022618.2136588-5-kshk@linux.ibm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260411022618.2136588-1-kshk@linux.ibm.com>", "References": "<20260411022618.2136588-1-kshk@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDExMDAxNiBTYWx0ZWRfX6XzzyL7PMoZ9\n DJqs9t4jscDgUVjRrWKjaUy1y6i7PsbvqK9T/NjBqcvyDj3rDFEsBoowQGl8kP6mJ7kgrbIdRyS\n HS6shmDTuZ/NYe8lup2Gk7pS/P+YqmbNCCsg7TIr89wE/FpZbB6ix5EY+3UV1sJ/DbPrUFLcbw7\n aZn362IBzen95NXIDCJHTnONIZf6WanCJDM4f4GFAW6C0sxZlC2lIG0CShYoTde6pGbvaqAdHsi\n 3crO4+d0WHzYZg21VXBxFOK82LHXKON06cg6aKp7v4PXmlcjnB9A7WP5ZqpW0H4vvwvCCJpxFvY\n MuWx9gCkZ7A4eSenGWqN313ju/fH+i9d7+5OCVf3NjCUc4CE9i/V6POCD6QGigkqDcE02BEnGEP\n v+OPDk9NporSafvt3+YMBFAvtPfj3oT59hDHdr7lfS3ov4YQMlf0QQoMHkiGWkdPDkZ+qhYWXTC\n zef3vUtfNWepe8Cf2LQ==", "X-Proofpoint-GUID": "tY2MnOyyhm4epRKCZ3Rh_rM2j_U3v0XW", "X-Proofpoint-ORIG-GUID": "tY2MnOyyhm4epRKCZ3Rh_rM2j_U3v0XW", "X-Authority-Analysis": "v=2.4 cv=YemNIQRf c=1 sm=1 tr=0 ts=69d9b170 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=jDWEBKAz6ZLYevfwb9sA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-10_07,2026-04-09_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015\n impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604110016", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=kshk@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This field is only used when S390PCIBusDevice exists, so it can be moved\nthere to simplify S390PCIIOMMU which purpose is just to store the \"root\"\nAddressSpace.\n\nSigned-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>\n---\n hw/s390x/s390-pci-bus.c | 21 +++++++++++----------\n hw/s390x/s390-pci-inst.c | 2 +-\n include/hw/s390x/s390-pci-bus.h | 4 ++--\n 3 files changed, 14 insertions(+), 13 deletions(-)", "diff": "diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex 99d503e85e..117fd8136e 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -604,7 +604,7 @@ static void s390_pci_ioat_replay(S390PCIBusDevice *pbdev)\n curr = iommu->pba;\n end = iommu->pal;\n \n- if (iommu->dm_mr) {\n+ if (pbdev->dm_mr) {\n /* If direct mapping is used, there are no guest tables to replay */\n return;\n }\n@@ -778,8 +778,9 @@ void s390_pci_iommu_enable(S390PCIBusDevice *pbdev)\n g_free(name);\n }\n \n-void s390_pci_iommu_direct_map_enable(S390PCIIOMMU *iommu)\n+void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev)\n {\n+ S390PCIIOMMU *iommu = pbdev->iommu;\n MachineState *ms = MACHINE(qdev_get_machine());\n S390CcwMachineState *s390ms = S390_CCW_MACHINE(ms);\n \n@@ -791,13 +792,13 @@ void s390_pci_iommu_direct_map_enable(S390PCIIOMMU *iommu)\n g_autofree char *name = g_strdup_printf(\"iommu-dm-s390-%04x\",\n iommu->pbdev->uid);\n \n- iommu->dm_mr = g_malloc0(sizeof(*iommu->dm_mr));\n- memory_region_init_alias(iommu->dm_mr, OBJECT(&iommu->mr), name,\n+ pbdev->dm_mr = g_malloc0(sizeof(*pbdev->dm_mr));\n+ memory_region_init_alias(pbdev->dm_mr, OBJECT(&iommu->mr), name,\n get_system_memory(), 0,\n s390_get_memory_limit(s390ms));\n iommu->enabled = true;\n memory_region_add_subregion(&iommu->mr, iommu->pbdev->zpci_fn.sdma,\n- iommu->dm_mr);\n+ pbdev->dm_mr);\n }\n \n void s390_pci_iommu_disable(S390PCIBusDevice *pbdev)\n@@ -805,11 +806,11 @@ void s390_pci_iommu_disable(S390PCIBusDevice *pbdev)\n S390PCIIOMMU *iommu = pbdev->iommu;\n iommu->enabled = false;\n g_hash_table_remove_all(iommu->iotlb);\n- if (iommu->dm_mr) {\n- memory_region_del_subregion(&iommu->mr, iommu->dm_mr);\n- object_unparent(OBJECT(iommu->dm_mr));\n- g_free(iommu->dm_mr);\n- iommu->dm_mr = NULL;\n+ if (pbdev->dm_mr) {\n+ memory_region_del_subregion(&iommu->mr, pbdev->dm_mr);\n+ object_unparent(OBJECT(pbdev->dm_mr));\n+ g_free(pbdev->dm_mr);\n+ pbdev->dm_mr = NULL;\n } else {\n memory_region_del_subregion(&iommu->mr,\n MEMORY_REGION(&pbdev->iommu_mr));\ndiff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex ed60e6100e..834a0aec95 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -1034,7 +1034,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n if (t) {\n s390_pci_iommu_enable(pbdev);\n } else {\n- s390_pci_iommu_direct_map_enable(iommu);\n+ s390_pci_iommu_direct_map_enable(pbdev);\n }\n \n return 0;\ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex a71f562dfc..f310672584 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -276,7 +276,6 @@ struct S390PCIIOMMU {\n S390PCIBusDevice *pbdev;\n AddressSpace as;\n MemoryRegion mr;\n- MemoryRegion *dm_mr;\n bool enabled;\n uint64_t g_iota;\n uint64_t pba;\n@@ -354,6 +353,7 @@ struct S390PCIBusDevice {\n AdapterRoutes routes;\n S390PCIIOMMU *iommu;\n IOMMUMemoryRegion iommu_mr;\n+ MemoryRegion *dm_mr;\n MemoryRegion msix_notify_mr;\n IndAddr *summary_ind;\n IndAddr *indicator;\n@@ -392,7 +392,7 @@ void s390_pci_sclp_configure(SCCB *sccb);\n void s390_pci_sclp_deconfigure(SCCB *sccb);\n bool s390_pci_is_translation_enabled(uint64_t g_iota);\n void s390_pci_iommu_enable(S390PCIBusDevice *pbdev);\n-void s390_pci_iommu_direct_map_enable(S390PCIIOMMU *iommu);\n+void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev);\n void s390_pci_iommu_disable(S390PCIBusDevice *pbdev);\n void s390_pci_generate_error_event(uint16_t pec, uint32_t fh, uint32_t fid,\n uint64_t faddr, uint32_t e);\n", "prefixes": [ "v2", "04/15" ] }