Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221878/?format=api
{ "id": 2221878, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221878/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.592237447@kernel.org/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/1.2/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260410120318.592237447@kernel.org>", "list_archive_url": null, "date": "2026-04-10T12:19:42", "name": "[15/38] ptp: ptp_vmclock: Replace get_cycles() usage", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0b0463d40f1539e1ad68c6da8ee1663879ac28ab", "submitter": { "id": 92397, "url": "http://patchwork.ozlabs.org/api/1.2/people/92397/?format=api", "name": "Thomas Gleixner", "email": "tglx@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.592237447@kernel.org/mbox/", "series": [ { "id": 499451, "url": "http://patchwork.ozlabs.org/api/1.2/series/499451/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=499451", "date": "2026-04-10T12:18:27", "name": "treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499451/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221878/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221878/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=RiuV=CJ=vger.kernel.org=linux-ext4+bounces-15750-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lx7PSe/P;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=riuv=cj=vger.kernel.org=linux-ext4+bounces-15750-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c15:e001:75::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lx7PSe/P;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15750-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"lx7PSe/P\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbqC2X5qz1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 22:35:03 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fsbqC246Wz4wJP\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 22:35:03 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fsbqC1yscz4wJS; Fri, 10 Apr 2026 22:35:03 +1000 (AEST)", "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fsbq81Hrmz4wJP\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Apr 2026 22:35:00 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 61BB43079F50\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Apr 2026 12:22:43 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D027D3C3444;\n\tFri, 10 Apr 2026 12:19:45 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 86DBD3C8731;\n\tFri, 10 Apr 2026 12:19:45 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 7F75AC2BC9E;\n\tFri, 10 Apr 2026 12:19:44 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775824503; cv=pass;\n\tb=Z7tWrdGfKJ/7i9H5ShHWS2Mh2Zzar+YVfBwnebtghi8fr66G86W8GYNKfV9WoJcOWe+4UrH1JjiHoqxDXadBi0rt4JXwSSv7TDSbuqox8vyhpPPusmO4DAOF9u6uZnp8bDARoBRsfCn/9GHdrBZSro3yPRgeV8q2jvMAmR3zJ56Fk5rU+2tqeBNhlT/Yign0rRiaoi9cggNiZB9GRFp8KvbWoI1NEwIrueYdK5Ix1bFYaGB9f93do7Xquc+/7oxHyUdZwXMuy0EpKFVEBG+nVSfDjkWqi5I9tWDIgpt+vf+Eh1L5A9B1RAaHtnw73fr4UNXkYmAY/wklMPBj07O3rQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775823585; cv=none;\n b=uDIIzPl6EkdrzAYSzLENkCYTsuG60ORaXJERlu2PfC7G0ivYQbrYCGMG0VEaeojnUO/mrZQnrjCZhiiGISh9/0LtebmMzKN2PU4rApAmNQaKgY50FHw3BgbaVTBs5yqBdUaCdk6a32IhLmcexUD8zz3/Ku3hCVM+SwDObMbU2Ew=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775824503; c=relaxed/relaxed;\n\tbh=xygFk++4Dzn0dankGqOQGxF6Nzu0dNNvlma/WvdOwrA=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=HMswMhSIBOCyGJk/66b3K4gfkfXv5FAR1l64u9g9FMsTgQZUivzsR92P74+29pbDx0FU/Gyq8Fi9YYrqXoJHK2sNpyCrerFsZrQud4WMyKt1cptKcPwyEJObKks2gU5L7DLWYD8pk2jRwEB8trekbG2Jjf/kZElpTrr2Q7BNznA1Zt5d8bPdNAYbXeN4RcJPA8NqBYcn4+6YZXPiuaaXDlv3EeYJ95aTLFys7q4G1L9GbFJhX27ntY4rJCBkQQQ+xo0ZR8SCMeAQuRNi46OLSQU2N3AlXQPzMO4A3bc266N/2hNJyjMH0I9UWr8MYvWc0LLYA4H2GiL73nqrjbcS/g==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775823585; c=relaxed/simple;\n\tbh=QeSclCuMiRAS5wk6lWoviUdmtawCgYPJK7955XSCrpk=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=XD9CRe/CrB1xSZMARoEF2zB19OwDGKRmcG+xcIIm3i5PksMiNFlffOU+8CRA8JOrWyJ7Xc+hCsD1LYtnM4K33gViWPZ65NExz+c08nGUSA8bh062gHltzvUT0bC1FUXruCHxWRazERHqUvkgwYLbP4p2IlZzdFc9NWyToXXJ/6w=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lx7PSe/P; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15750-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=lx7PSe/P; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823585;\n\tbh=QeSclCuMiRAS5wk6lWoviUdmtawCgYPJK7955XSCrpk=;\n\th=Date:From:To:Cc:Subject:References:From;\n\tb=lx7PSe/PjadVTpIMwJdhAJBLt/wkFkRfbRhizAqdCmT18BPcbSlnMFeRTECetW5Mz\n\t e18kIbNIOdNmzSRNcljN5MiUEDzdauvDtZpRrKPYAQq6HuU0ixY90WW/AT9/9BP1TE\n\t G0pmyVH8DHnvheD/Jtznb1TEyB0LG5ezsRLYR23JSrj8T1XCNh6BmAZvkaj4VTBCOk\n\t FjtLvndHPm1jEFcE8PqfK7D9YifyYmXQkYky/wPITICuSdRrICGnLkZ3jZxe25sBaP\n\t q8ggvP1HMAsaRRMlhxP+iwStOOzZHUsvv+/U0DMMTE0lc38vp99aMg2cqhdxuGrXAu\n\t mqm2UYpSfgZaw==", "Date": "Fri, 10 Apr 2026 14:19:42 +0200", "Message-ID": "<20260410120318.592237447@kernel.org>", "User-Agent": "quilt/0.68", "From": "Thomas Gleixner <tglx@kernel.org>", "To": "LKML <linux-kernel@vger.kernel.org>", "Cc": "David Woodhouse <dwmw2@infradead.org>,\n Arnd Bergmann <arnd@arndb.de>,\n x86@kernel.org,\n Lu Baolu <baolu.lu@linux.intel.com>,\n iommu@lists.linux.dev,\n Michael Grzeschik <m.grzeschik@pengutronix.de>,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu <herbert@gondor.apana.org.au>,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka <vbabka@kernel.org>,\n linux-mm@kvack.org,\n Bernie Thompson <bernie@plugable.com>,\n linux-fbdev@vger.kernel.org,\n \"Theodore Tso\" <tytso@mit.edu>,\n linux-ext4@vger.kernel.org,\n Andrew Morton <akpm@linux-foundation.org>,\n Uladzislau Rezki <urezki@gmail.com>,\n Marco Elver <elver@google.com>,\n Dmitry Vyukov <dvyukov@google.com>,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin <ryabinin.a.a@gmail.com>,\n Thomas Sailer <t.sailer@alumni.ethz.ch>,\n linux-hams@vger.kernel.org,\n \"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n linux-alpha@vger.kernel.org,\n Russell King <linux@armlinux.org.uk>,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas <catalin.marinas@arm.com>,\n Huacai Chen <chenhuacai@kernel.org>,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven <geert@linux-m68k.org>,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen <dinguyen@kernel.org>,\n Jonas Bonn <jonas@southpole.se>,\n linux-openrisc@vger.kernel.org,\n Helge Deller <deller@gmx.de>,\n linux-parisc@vger.kernel.org,\n Michael Ellerman <mpe@ellerman.id.au>,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley <pjw@kernel.org>,\n linux-riscv@lists.infradead.org,\n Heiko Carstens <hca@linux.ibm.com>,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" <davem@davemloft.net>,\n sparclinux@vger.kernel.org", "Subject": "[patch 15/38] ptp: ptp_vmclock: Replace get_cycles() usage", "References": "<20260410120044.031381086@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "get_cycles() is not really well defined and similar to other usaage of the\nunderlying hardware CPU counters the PTP vmclock should use an explicit\ninterface as well.\n\nImplement ptp_vmclock_read_cpu_counter() in arm64 and x86 and simplify the\nKconfig selection while at it.\n\nNo functional change.\n\nSigned-off-by: Thomas Gleixner <tglx@kernel.org>\nCc: David Woodhouse <dwmw2@infradead.org>\n---\n arch/arm64/Kconfig | 1 +\n arch/arm64/include/asm/ptp_vmclock.h | 12 ++++++++++++\n arch/x86/Kconfig | 1 +\n arch/x86/include/asm/ptp_vmclock.h | 12 ++++++++++++\n drivers/ptp/Kconfig | 6 ++++--\n drivers/ptp/ptp_vmclock.c | 6 ++++--\n 6 files changed, 34 insertions(+), 4 deletions(-)", "diff": "--- a/arch/arm64/Kconfig\n+++ b/arch/arm64/Kconfig\n@@ -112,6 +112,7 @@ config ARM64\n \tselect ARCH_SUPPORTS_SCHED_SMT\n \tselect ARCH_SUPPORTS_SCHED_CLUSTER\n \tselect ARCH_SUPPORTS_SCHED_MC\n+\tselect ARCH_SUPPORTS_PTP_VMCLOCK if ARCH_SUPPORTS_INT128\n \tselect ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH\n \tselect ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT\n \tselect ARCH_WANT_DEFAULT_BPF_JIT\n--- /dev/null\n+++ b/arch/arm64/include/asm/ptp_vmclock.h\n@@ -0,0 +1,12 @@\n+/* SPDX-License-Identifier: GPL-2.0-only */\n+#ifndef __ASM_PTP_VMCLOCK_H\n+#define __ASM_PTP_VMCLOCK_H\n+\n+#include <asm/arch_timer.h>\n+\n+static inline u64 ptp_vmclock_read_cpu_counter(void)\n+{\n+\treturn arch_timer_read_counter();\n+}\n+\n+#endif\n--- a/arch/x86/Kconfig\n+++ b/arch/x86/Kconfig\n@@ -135,6 +135,7 @@ config X86\n \tselect ARCH_SUPPORTS_RT\n \tselect ARCH_SUPPORTS_AUTOFDO_CLANG\n \tselect ARCH_SUPPORTS_PROPELLER_CLANG if X86_64\n+\tselect ARCH_SUPPORTS_PTP_VMCLOCK\tif X86_TSC\n \tselect ARCH_USE_BUILTIN_BSWAP\n \tselect ARCH_USE_CMPXCHG_LOCKREF\t\tif X86_CX8\n \tselect ARCH_USE_MEMTEST\n--- /dev/null\n+++ b/arch/x86/include/asm/ptp_vmclock.h\n@@ -0,0 +1,12 @@\n+/* SPDX-License-Identifier: GPL-2.0-only */\n+#ifndef __ASM_PTP_VMCLOCK_H\n+#define __ASM_PTP_VMCLOCK_H\n+\n+#include <asm/tsc.h>\n+\n+static inline u64 ptp_vmclock_read_cpu_counter(void)\n+{\n+\treturn cpu_feature_enabled(X86_FEATURE_TSC) ? rdtsc() : 0;\n+}\n+\n+#endif\n--- a/drivers/ptp/Kconfig\n+++ b/drivers/ptp/Kconfig\n@@ -131,10 +131,12 @@ config PTP_1588_CLOCK_KVM\n \t To compile this driver as a module, choose M here: the module\n \t will be called ptp_kvm.\n \n+config ARCH_SUPPORTS_PTP_VMCLOCK\n+\tbool\n+\n config PTP_1588_CLOCK_VMCLOCK\n \ttristate \"Virtual machine PTP clock\"\n-\tdepends on X86_TSC || ARM_ARCH_TIMER\n-\tdepends on PTP_1588_CLOCK && ARCH_SUPPORTS_INT128\n+\tdepends on PTP_1588_CLOCK && ARCH_SUPPORTS_PTP_VMCLOCK\n \tdefault PTP_1588_CLOCK_KVM\n \thelp\n \t This driver adds support for using a virtual precision clock\n--- a/drivers/ptp/ptp_vmclock.c\n+++ b/drivers/ptp/ptp_vmclock.c\n@@ -28,6 +28,8 @@\n \n #include <linux/ptp_clock_kernel.h>\n \n+#include <asm/ptp_vmclock.h>\n+\n #ifdef CONFIG_X86\n #include <asm/pvclock.h>\n #include <asm/kvmclock.h>\n@@ -144,11 +146,11 @@ static int vmclock_get_crosststamp(struc\n \t\t\tif (systime_snapshot.cs_id == st->cs_id) {\n \t\t\t\tcycle = systime_snapshot.cycles;\n \t\t\t} else {\n-\t\t\t\tcycle = get_cycles();\n+\t\t\t\tcycle = ptp_vmclock_read_cpu_counter();\n \t\t\t\tptp_read_system_postts(sts);\n \t\t\t}\n \t\t} else {\n-\t\t\tcycle = get_cycles();\n+\t\t\tcycle = ptp_vmclock_read_cpu_counter();\n \t\t}\n \n \t\tdelta = cycle - le64_to_cpu(st->clk->counter_value);\n", "prefixes": [ "15/38" ] }