Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/2221876/?format=api
{ "id": 2221876, "url": "http://patchwork.ozlabs.org/api/1.2/patches/2221876/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.997202495@kernel.org/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/1.2/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260410120318.997202495@kernel.org>", "list_archive_url": null, "date": "2026-04-10T12:20:11", "name": "[21/38] hamradio: baycom_epp: Remove BAYCOM_DEBUG", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "95c0538da412a69a6d904c50360b8c6254ff5f1c", "submitter": { "id": 92397, "url": "http://patchwork.ozlabs.org/api/1.2/people/92397/?format=api", "name": "Thomas Gleixner", "email": "tglx@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260410120318.997202495@kernel.org/mbox/", "series": [ { "id": 499451, "url": "http://patchwork.ozlabs.org/api/1.2/series/499451/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=499451", "date": "2026-04-10T12:18:27", "name": "treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499451/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221876/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=49je=CJ=vger.kernel.org=linux-ext4+bounces-15756-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=K9r3LlHr;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=49je=cj=vger.kernel.org=linux-ext4+bounces-15756-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.232.135.74 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=K9r3LlHr;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15756-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"K9r3LlHr\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbp622Scz1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 22:34:06 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fsbp61Ycfz4wJR\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 22:34:06 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4fsbp61Sc5z4wK5; Fri, 10 Apr 2026 22:34:06 +1000 (AEST)", "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fsbp24X0dz4wJR\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Apr 2026 22:34:02 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0964030B4FF5\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 10 Apr 2026 12:25:12 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 279A63DA7E9;\n\tFri, 10 Apr 2026 12:20:15 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C698E3CBE65;\n\tFri, 10 Apr 2026 12:20:14 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 8C840C2BCB0;\n\tFri, 10 Apr 2026 12:20:13 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1775824446; cv=pass;\n\tb=YPosulNBzHc1DfjQvcXTcgkrmGI3XhT1xqUSfKJws8ftleXOCzaF8q3Vi426EW8XI9fmidFPzoOFFqPFY/h5Yf8pw86GdTIKKeCfODan6gOCxpiNH5BQ0LxayF93yT941T+z51jC8fPUcC7WAOBjqRVzRE1ZzNscVgELZDMFIXmBVx6+9JBti61BoysRk9DG4PNzCAaaCph34DjwdO8JnBuE4j6Rh2vhLlC/OOo5AfSNOPrE7kuvf33+ZC4B7m5I8LuqQ9AUG6ZlUsBbXjIfI/0ft6/zGvr4rWqC2I+icCzeeCB2j4Ih0Vfu0HJaaV2nF8qgjewBF88xObm2CNTDLw==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775823614; cv=none;\n b=t4K9uvE2lenawvNQFIvyFrdwoqhWlX9npbKVfQ7CnttX0eZYkSa/IFEvD+SbWBbgDcqLoAzUP2A1RnC6+DDEQgcgpzy1lWVVByUhevTYL9bZHz+mksvDQFis1TxnyrWpvFtW7Eh8KM2keghzBraEw0O3JAvbrKX9Cq3SDuGCHPY=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1775824446; c=relaxed/relaxed;\n\tbh=uc43GoCkDGKCftnS7MZ3OA0khnbsdPYb8yxntAbHoVw=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=Ukb1PBs05FnAs/O/czVBwAd5eNE/4UqSFA8ORLpUMijMFtMK5U34fSu6AWj445o8Pb0Zy/GF7vVHTMIbcNRL4P56TNTghsOV9SJ+VkmpFCHRAuqxwuxoEA7lHQi8XxLLTks8W6YK3BSjf+MY8EpyJ+0U8x7NsFSbmY281eQNpQIT3Ie28H24gvKN8SOsSfA7EUqRJbkN0RLgFy2gSE9bRjZkehaY4TX7GY6bfY2Mw384ZgBPyHyLm1r7hHii5khp009L0x09wg1UjnUibUjhzakdN1JMz67I6Zb3YtJ7H9IHg1LMsHYUUb1Jym/BjaaJxVeZ2Sn6KPeogsBal/O/3g==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775823614; c=relaxed/simple;\n\tbh=fBmKDE903B55aOazdk1fgTYrHTdJzb3m7rYXj49+TyY=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=lN4YwviANod8j/9WlTq1QNr84ZfIuxr2+KdFyq7P8l1IEJXBri/FuOl+oIqBzobyi57ZByif+l0ikZlii7y3jyKPscDNlIdgw7OHLEtI+q47LljBNPhA0Jlh3GPNRh+2k5OYIzZgLYMLR54UXuSxwiW6HRLHEBQC28jpw+Ev/TA=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=K9r3LlHr; dkim-atps=neutral;\n spf=pass (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15756-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=K9r3LlHr; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823614;\n\tbh=fBmKDE903B55aOazdk1fgTYrHTdJzb3m7rYXj49+TyY=;\n\th=Date:From:To:Cc:Subject:References:From;\n\tb=K9r3LlHrTcCOkcDztBL2sK/tQ+yi3dZzcdFnxujOK2CvaNmPXdlKrSDZTOaDJVW4S\n\t 4mOX2OGTBKQ54SjOZcfKwdFhqUqz7KSUNqnVJajtIbXp/GGLFwlU7bEb8zVF3NgHwH\n\t 1PaUWksbUVEp48mOHI3J4/UWYuvo5lLJzmYA1j3FTzptfyaQ68k1o579nPzwBiXUsC\n\t 3DfIec/NNOEw9ut9tg7BENSlBdgvHCyF+4+WEDfTHmiMcBanB5cN+csJSB4d+fA+Ka\n\t C4Vf48Goy0kDdmbaemETnL+HfFRh1XMMUZS6QyYOK2+NJ2yf87fs8P9lxl4UXibsda\n\t 2J390A/pMX1Ag==", "Date": "Fri, 10 Apr 2026 14:20:11 +0200", "Message-ID": "<20260410120318.997202495@kernel.org>", "User-Agent": "quilt/0.68", "From": "Thomas Gleixner <tglx@kernel.org>", "To": "LKML <linux-kernel@vger.kernel.org>", "Cc": "Thomas Sailer <t.sailer@alumni.ethz.ch>,\n linux-hams@vger.kernel.org,\n Arnd Bergmann <arnd@arndb.de>,\n x86@kernel.org,\n Lu Baolu <baolu.lu@linux.intel.com>,\n iommu@lists.linux.dev,\n Michael Grzeschik <m.grzeschik@pengutronix.de>,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu <herbert@gondor.apana.org.au>,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka <vbabka@kernel.org>,\n linux-mm@kvack.org,\n David Woodhouse <dwmw2@infradead.org>,\n Bernie Thompson <bernie@plugable.com>,\n linux-fbdev@vger.kernel.org,\n \"Theodore Tso\" <tytso@mit.edu>,\n linux-ext4@vger.kernel.org,\n Andrew Morton <akpm@linux-foundation.org>,\n Uladzislau Rezki <urezki@gmail.com>,\n Marco Elver <elver@google.com>,\n Dmitry Vyukov <dvyukov@google.com>,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin <ryabinin.a.a@gmail.com>,\n \"Jason A. Donenfeld\" <Jason@zx2c4.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n linux-alpha@vger.kernel.org,\n Russell King <linux@armlinux.org.uk>,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas <catalin.marinas@arm.com>,\n Huacai Chen <chenhuacai@kernel.org>,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven <geert@linux-m68k.org>,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen <dinguyen@kernel.org>,\n Jonas Bonn <jonas@southpole.se>,\n linux-openrisc@vger.kernel.org,\n Helge Deller <deller@gmx.de>,\n linux-parisc@vger.kernel.org,\n Michael Ellerman <mpe@ellerman.id.au>,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley <pjw@kernel.org>,\n linux-riscv@lists.infradead.org,\n Heiko Carstens <hca@linux.ibm.com>,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" <davem@davemloft.net>,\n sparclinux@vger.kernel.org", "Subject": "[patch 21/38] hamradio: baycom_epp: Remove BAYCOM_DEBUG", "References": "<20260410120044.031381086@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "The whole code guarded by BAYCOM_DEBUG is only writing debug values into a\ndatastructure, but there is no way to ever access them.\n\nRemove the pointless ballast.\n\nThis is part of a larger effort to remove get_cycles() usage from\nnon-architecture code.\n\nSigned-off-by: Thomas Gleixner <tglx@kernel.org>\nCc: Thomas Sailer <t.sailer@alumni.ethz.ch>\nCc: linux-hams@vger.kernel.org\n---\n drivers/net/hamradio/baycom_epp.c | 51 --------------------------------------\n 1 file changed, 51 deletions(-)", "diff": "--- a/drivers/net/hamradio/baycom_epp.c\n+++ b/drivers/net/hamradio/baycom_epp.c\n@@ -44,7 +44,6 @@\n \n /* --------------------------------------------------------------------- */\n \n-#define BAYCOM_DEBUG\n #define BAYCOM_MAGIC 19730510\n \n /* --------------------------------------------------------------------- */\n@@ -191,18 +190,6 @@ struct baycom_state {\n \n \tunsigned int ptt_keyed;\n \tstruct sk_buff *skb; /* next transmit packet */\n-\n-#ifdef BAYCOM_DEBUG\n-\tstruct debug_vals {\n-\t\tunsigned long last_jiffies;\n-\t\tunsigned cur_intcnt;\n-\t\tunsigned last_intcnt;\n-\t\tint cur_pllcorr;\n-\t\tint last_pllcorr;\n-\t\tunsigned int mod_cycles;\n-\t\tunsigned int demod_cycles;\n-\t} debug_vals;\n-#endif /* BAYCOM_DEBUG */\n };\n \n /* --------------------------------------------------------------------- */\n@@ -259,26 +246,6 @@ static inline int calc_crc_ccitt(const u\n \n #define tenms_to_flags(bc,tenms) ((tenms * bc->bitrate) / 800)\n \n-/* --------------------------------------------------------------------- */\n-\n-static inline void baycom_int_freq(struct baycom_state *bc)\n-{\n-#ifdef BAYCOM_DEBUG\n-\tunsigned long cur_jiffies = jiffies;\n-\t/*\n-\t * measure the interrupt frequency\n-\t */\n-\tbc->debug_vals.cur_intcnt++;\n-\tif (time_after_eq(cur_jiffies, bc->debug_vals.last_jiffies + HZ)) {\n-\t\tbc->debug_vals.last_jiffies = cur_jiffies;\n-\t\tbc->debug_vals.last_intcnt = bc->debug_vals.cur_intcnt;\n-\t\tbc->debug_vals.cur_intcnt = 0;\n-\t\tbc->debug_vals.last_pllcorr = bc->debug_vals.cur_pllcorr;\n-\t\tbc->debug_vals.cur_pllcorr = 0;\n-\t}\n-#endif /* BAYCOM_DEBUG */\n-}\n-\n /* ---------------------------------------------------------------------- */\n /*\n * eppconfig_path should be setable via /proc/sys.\n@@ -621,13 +588,6 @@ static int receive(struct net_device *de\n \treturn ret;\n }\n \n-/* --------------------------------------------------------------------- */\n-\n-#define GETTICK(x)\t\t\t\t\t\t\\\n-({\t\t\t\t\t\t\t\t\\\n-\tx = (unsigned int)get_cycles();\t\t\t\t\\\n-})\n-\n static void epp_bh(struct work_struct *work)\n {\n \tstruct net_device *dev;\n@@ -635,21 +595,17 @@ static void epp_bh(struct work_struct *w\n \tstruct parport *pp;\n \tunsigned char stat;\n \tunsigned char tmp[2];\n-\tunsigned int time1 = 0, time2 = 0, time3 = 0;\n \tint cnt, cnt2;\n \n \tbc = container_of(work, struct baycom_state, run_work.work);\n \tdev = bc->dev;\n \tif (!bc->work_running)\n \t\treturn;\n-\tbaycom_int_freq(bc);\n \tpp = bc->pdev->port;\n \t/* update status */\n \tif (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)\n \t\tgoto epptimeout;\n \tbc->stat = stat;\n-\tbc->debug_vals.last_pllcorr = stat;\n-\tGETTICK(time1);\n \tif (bc->modem == EPP_FPGAEXTSTATUS) {\n \t\t/* get input count */\n \t\ttmp[0] = EPP_TX_FIFO_ENABLE|EPP_RX_FIFO_ENABLE|EPP_MODEM_ENABLE|1;\n@@ -673,7 +629,6 @@ static void epp_bh(struct work_struct *w\n \t\t\tgoto epptimeout;\n \t\tif (transmit(bc, cnt2, stat))\n \t\t\tgoto epptimeout;\n-\t\tGETTICK(time2);\n \t\tif (receive(dev, cnt))\n \t\t\tgoto epptimeout;\n \t\tif (pp->ops->epp_read_addr(pp, &stat, 1, 0) != 1)\n@@ -700,7 +655,6 @@ static void epp_bh(struct work_struct *w\n \t\t}\n \t\tif (transmit(bc, cnt, stat))\n \t\t\tgoto epptimeout;\n-\t\tGETTICK(time2);\n \t\t/* do receiver */\n \t\twhile ((stat & (EPP_NRAEF|EPP_NRHF)) != EPP_NRHF) {\n \t\t\tswitch (stat & (EPP_NRAEF|EPP_NRHF)) {\n@@ -734,11 +688,6 @@ static void epp_bh(struct work_struct *w\n \t\t\t\tgoto epptimeout;\n \t\t}\n \t}\n-\tGETTICK(time3);\n-#ifdef BAYCOM_DEBUG\n-\tbc->debug_vals.mod_cycles = time2 - time1;\n-\tbc->debug_vals.demod_cycles = time3 - time2;\n-#endif /* BAYCOM_DEBUG */\n \tschedule_delayed_work(&bc->run_work, 1);\n \tif (!bc->skb)\n \t\tnetif_wake_queue(dev);\n", "prefixes": [ "21/38" ] }